Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
2 years agorequalify tesh
Augustin Degomme [Tue, 5 Feb 2019 15:16:11 +0000 (16:16 +0100)]
requalify tesh

2 years agoremove some codacy warnings
Augustin Degomme [Tue, 5 Feb 2019 15:10:11 +0000 (16:10 +0100)]
remove some codacy warnings

2 years agoWith Icc, change bogus error into warning.
Arnaud Giersch [Tue, 5 Feb 2019 14:28:52 +0000 (15:28 +0100)]
With Icc, change bogus error into warning.

src/xbt/mallocator.c(49): error #2330: argument of type "atomic_flag *" is incompatible with parameter of type "volatile void *" (dropping qualifiers)
     atomic_flag_clear(&m->lock);
     ^

2 years agoPlug memory leak.
Arnaud Giersch [Tue, 5 Feb 2019 13:09:11 +0000 (14:09 +0100)]
Plug memory leak.

2 years agoProvide our own main() for unit-tests.
Arnaud Giersch [Tue, 5 Feb 2019 13:01:13 +0000 (14:01 +0100)]
Provide our own main() for unit-tests.

The goal is to be able to use the --log=... command line parameters.

2 years agoUse C++11 std::atomic instead of gcc builtins.
Arnaud Giersch [Wed, 7 Mar 2018 17:51:09 +0000 (18:51 +0100)]
Use C++11 std::atomic instead of gcc builtins.

NOTE: wrong type for futex operations (rude cast).

2 years agoUse C11 atomic_flag instead of gcc builtins.
Arnaud Giersch [Tue, 5 Feb 2019 11:05:51 +0000 (12:05 +0100)]
Use C11 atomic_flag instead of gcc builtins.

2 years agoUpdate .mailmap.
Arnaud Giersch [Tue, 5 Feb 2019 11:03:30 +0000 (12:03 +0100)]
Update .mailmap.

2 years agoCosmetics.
Arnaud Giersch [Tue, 5 Feb 2019 10:21:35 +0000 (11:21 +0100)]
Cosmetics.

Undefined macros expand to zero anyway, and it avoids a cppcheck issue.

2 years agoReduce scope for variable 'rank'.
Arnaud Giersch [Tue, 5 Feb 2019 10:11:34 +0000 (11:11 +0100)]
Reduce scope for variable 'rank'.

2 years agoCosmetic rewrite to please cppcheck.
Arnaud Giersch [Tue, 5 Feb 2019 10:10:45 +0000 (11:10 +0100)]
Cosmetic rewrite to please cppcheck.

Fix: Condition 'slow_copy' is always true.

2 years agoReset pointer to make it clear for cppcheck that it's not freed twice.
Arnaud Giersch [Tue, 5 Feb 2019 09:47:52 +0000 (10:47 +0100)]
Reset pointer to make it clear for cppcheck that it's not freed twice.

2 years agoInitialized all struct members.
Arnaud Giersch [Tue, 5 Feb 2019 09:41:19 +0000 (10:41 +0100)]
Initialized all struct members.

Currently not tested, but should fix smpi_shared_free().

2 years agoCosmetic rewrite to please cppcheck.
Arnaud Giersch [Tue, 5 Feb 2019 09:36:53 +0000 (10:36 +0100)]
Cosmetic rewrite to please cppcheck.

Fix: Variable 'rem_size' is assigned a value that is never used.

2 years ago[SMPI] Fix iprobe bound
Christian Heinrich [Tue, 5 Feb 2019 09:09:29 +0000 (10:09 +0100)]
[SMPI] Fix iprobe bound

While looping over iprobes, not the whole CPU can be used.

2 years agoMerge branch 'master' of https://framagit.org/simgrid/simgrid
Frederic Suter [Mon, 4 Feb 2019 10:42:02 +0000 (11:42 +0100)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid

2 years ago[codacy/cppcheck] A few more issues.
Arnaud Giersch [Mon, 4 Feb 2019 10:01:22 +0000 (11:01 +0100)]
[codacy/cppcheck] A few more issues.

2 years ago[codacy/cppcheck] A few more issues.
Arnaud Giersch [Mon, 4 Feb 2019 10:01:22 +0000 (11:01 +0100)]
[codacy/cppcheck] A few more issues.

2 years agoMerge remote-tracking branch 'origin/master'
Arnaud Giersch [Mon, 4 Feb 2019 09:58:41 +0000 (10:58 +0100)]
Merge remote-tracking branch 'origin/master'

2 years agofix clang builds
Frederic Suter [Mon, 4 Feb 2019 09:54:32 +0000 (10:54 +0100)]
fix clang builds

2 years agoMerge remote-tracking branch 'origin/master'
Arnaud Giersch [Mon, 4 Feb 2019 09:45:21 +0000 (10:45 +0100)]
Merge remote-tracking branch 'origin/master'

2 years ago[codacy/cppcheck] Potential memory leak.
Arnaud Giersch [Mon, 4 Feb 2019 09:42:31 +0000 (10:42 +0100)]
[codacy/cppcheck] Potential memory leak.

2 years agothink about users
Frederic Suter [Mon, 4 Feb 2019 09:40:30 +0000 (10:40 +0100)]
think about users

2 years ago[codacy/cppcheck] Fix: Variable is reassigned a value before the old one has been...
Arnaud Giersch [Mon, 4 Feb 2019 09:29:01 +0000 (10:29 +0100)]
[codacy/cppcheck] Fix: Variable is reassigned a value before the old one has been used.

2 years ago[codacy/cppcheck] Reduce scope for variables.
Arnaud Giersch [Mon, 4 Feb 2019 09:24:31 +0000 (10:24 +0100)]
[codacy/cppcheck] Reduce scope for variables.

2 years ago[codacy] minor issues in shell scripts.
Arnaud Giersch [Mon, 4 Feb 2019 09:24:15 +0000 (10:24 +0100)]
[codacy] minor issues in shell scripts.

2 years agocodacy.yml: complete and sort exclusion list.
Arnaud Giersch [Mon, 4 Feb 2019 07:57:28 +0000 (08:57 +0100)]
codacy.yml: complete and sort exclusion list.

Alsot exclude python scripts for sphinx in docs/ subdirectory.

2 years ago[codacy] Add quotes around exclude paths in .codacy.yml.
Arnaud Giersch [Sun, 3 Feb 2019 20:00:26 +0000 (21:00 +0100)]
[codacy] Add quotes around exclude paths in .codacy.yml.

2 years agoset_kill_time is a method of ActorImpl
Frederic Suter [Sun, 3 Feb 2019 19:25:08 +0000 (20:25 +0100)]
set_kill_time is a method of ActorImpl

2 years agoEngine is in charge of platform creation, not SIMIX anymore
Frederic Suter [Sun, 3 Feb 2019 18:51:40 +0000 (19:51 +0100)]
Engine is in charge of platform creation, not SIMIX anymore

2 years agomove code to the right place
Frederic Suter [Sun, 3 Feb 2019 17:11:54 +0000 (18:11 +0100)]
move code to the right place

2 years agofurther cleaning in simcalls
Frederic Suter [Sun, 3 Feb 2019 17:08:36 +0000 (18:08 +0100)]
further cleaning in simcalls

2 years agoMerge branch 'master' of https://framagit.org/simgrid/simgrid
Frederic Suter [Sun, 3 Feb 2019 16:22:53 +0000 (17:22 +0100)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid

2 years agomodern simcall for set_category
Frederic Suter [Sun, 3 Feb 2019 16:22:30 +0000 (17:22 +0100)]
modern simcall for set_category

2 years agoallow all activities to set their tracing category
Frederic Suter [Sun, 3 Feb 2019 15:42:01 +0000 (16:42 +0100)]
allow all activities to set their tracing category

2 years agomodernize a few simcall_execution_* calls
Frederic Suter [Sun, 3 Feb 2019 14:18:50 +0000 (15:18 +0100)]
modernize a few simcall_execution_* calls

2 years agosanitize the OOP of kernel::profile
Martin Quinson [Sun, 3 Feb 2019 14:57:04 +0000 (15:57 +0100)]
sanitize the OOP of kernel::profile

* Add a Profile::next() returning the next event of the list.
  This opens the way to future profile kinds, based on statistical
  generator instead of explicit lists.
  Earlier, FES was advancing the internal pointer of the Profile.

* Change FutureEvtSet::add_trace(Profile, Resource) into Profile::schedule(FutureEvtSet, Resource).
  This way, Profile knows about its FES and there is no need for a
  global (also making testing easier), and FES does not have to mess
  with the internals of Profile.

2 years agoFix (old) clang builds
Martin Quinson [Sun, 3 Feb 2019 11:23:17 +0000 (12:23 +0100)]
Fix (old) clang builds

2 years agoFix lua build
Martin Quinson [Sun, 3 Feb 2019 10:48:00 +0000 (11:48 +0100)]
Fix lua build

2 years agosonar: simplify this code
Martin Quinson [Sat, 2 Feb 2019 22:58:14 +0000 (23:58 +0100)]
sonar: simplify this code

2 years agosonar: Replace this if-then-else statement by a single statement
Martin Quinson [Sat, 2 Feb 2019 21:44:10 +0000 (22:44 +0100)]
sonar: Replace this if-then-else statement by a single statement

2 years agoprofile: cosmetics: inline a function and rename a variable
Martin Quinson [Sat, 2 Feb 2019 17:13:16 +0000 (18:13 +0100)]
profile: cosmetics: inline a function and rename a variable

2 years agos:k:profile: turn two functions into static methods
Martin Quinson [Sat, 2 Feb 2019 16:59:51 +0000 (17:59 +0100)]
s:k:profile: turn two functions into static methods

2 years agoalign file position to the C++ namespaces
Martin Quinson [Sat, 2 Feb 2019 08:02:49 +0000 (09:02 +0100)]
align file position to the C++ namespaces

2 years agoproperly split init/start for Exec activities
Frederic Suter [Sat, 2 Feb 2019 10:17:15 +0000 (11:17 +0100)]
properly split init/start for Exec activities

2 years agoMerge branch 'master' of https://framagit.org/simgrid/simgrid
Frederic Suter [Sat, 2 Feb 2019 08:45:46 +0000 (09:45 +0100)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid

2 years agomake sure to define _FILE_OFFSET_BITS as early as possible
Martin Quinson [Fri, 1 Feb 2019 22:56:17 +0000 (23:56 +0100)]
make sure to define _FILE_OFFSET_BITS as early as possible

It won't be effective if defined after the system headers are loaded.

2 years agoPlease codacy, forget about Catch2
Martin Quinson [Fri, 1 Feb 2019 21:29:06 +0000 (22:29 +0100)]
Please codacy, forget about Catch2

2 years agodoc: reword to remove crufts of the old cunit
Martin Quinson [Fri, 1 Feb 2019 21:28:16 +0000 (22:28 +0100)]
doc: reword to remove crufts of the old cunit

2 years agotidy some #includes in MC
Martin Quinson [Fri, 1 Feb 2019 20:54:07 +0000 (21:54 +0100)]
tidy some #includes in MC

2 years agoPlease Sonar.
Arnaud Giersch [Fri, 1 Feb 2019 20:52:53 +0000 (21:52 +0100)]
Please Sonar.

2 years agoRemove last references to testall.
Arnaud Giersch [Fri, 1 Feb 2019 20:40:35 +0000 (21:40 +0100)]
Remove last references to testall.

2 years agofactor surf_action_ in ActivityImpl
Frederic Suter [Fri, 1 Feb 2019 19:42:25 +0000 (20:42 +0100)]
factor surf_action_ in ActivityImpl

2 years agouniform naming across activities
Frederic Suter [Fri, 1 Feb 2019 16:30:31 +0000 (17:30 +0100)]
uniform naming across activities

2 years agocosmetics
Frederic Suter [Fri, 1 Feb 2019 16:30:02 +0000 (17:30 +0100)]
cosmetics

2 years ago[sonar] Split declarations, unshadow variables.
Arnaud Giersch [Fri, 1 Feb 2019 14:43:25 +0000 (15:43 +0100)]
[sonar] Split declarations, unshadow variables.

2 years agoRIP cunit.
Arnaud Giersch [Fri, 1 Feb 2019 14:03:47 +0000 (15:03 +0100)]
RIP cunit.

2 years agoConvert the unit tests of xbt::config to Catch2.
Arnaud Giersch [Fri, 1 Feb 2019 13:58:38 +0000 (14:58 +0100)]
Convert the unit tests of xbt::config to Catch2.

2 years agoConvert the unit tests of xbt::str to Catch2.
Arnaud Giersch [Thu, 31 Jan 2019 22:18:06 +0000 (23:18 +0100)]
Convert the unit tests of xbt::str to Catch2.

2 years agoConvert the unit tests of xbt::dict to Catch2.
Arnaud Giersch [Thu, 31 Jan 2019 20:25:26 +0000 (21:25 +0100)]
Convert the unit tests of xbt::dict to Catch2.

2 years agoReduce number of #include.
Arnaud Giersch [Thu, 31 Jan 2019 15:32:57 +0000 (16:32 +0100)]
Reduce number of #include.

2 years agoCheck for emptyness, and populate dynar before testing xbt_dynar_foreach_ptr.
Arnaud Giersch [Thu, 31 Jan 2019 15:16:37 +0000 (16:16 +0100)]
Check for emptyness, and populate dynar before testing xbt_dynar_foreach_ptr.

2 years agoproperly split init and start for IO activities
Frederic Suter [Fri, 1 Feb 2019 12:07:18 +0000 (13:07 +0100)]
properly split init and start for IO activities

2 years agoIgnore Catch2 in sonar
Martin Quinson [Thu, 31 Jan 2019 20:35:01 +0000 (21:35 +0100)]
Ignore Catch2 in sonar

2 years agoRevert "Try to improve coverage reports for MC tests."
Arnaud Giersch [Thu, 31 Jan 2019 14:29:41 +0000 (15:29 +0100)]
Revert "Try to improve coverage reports for MC tests."

This reverts commit db3df03114cb65a9c27c2c1dfd6faf964b571254.

The following tests are broken (timeout): mc-bugged1-liveness-visited-ucontext,
mc-bugged1-liveness-visited-ucontext-sparse and mc-umpire-comm-dup-no-free2.

To reproduce, it seems that compile_optimizations should be disabled.

2 years agofix makedist
Martin Quinson [Thu, 31 Jan 2019 09:08:33 +0000 (10:08 +0100)]
fix makedist

2 years agoConvert the unit tests of xbt::dynar to Catch2
Martin Quinson [Thu, 31 Jan 2019 08:52:56 +0000 (09:52 +0100)]
Convert the unit tests of xbt::dynar to Catch2

2 years agocosmetics
Martin Quinson [Thu, 31 Jan 2019 08:52:05 +0000 (09:52 +0100)]
cosmetics

2 years agoTry to improve coverage reports for MC tests.
Arnaud Giersch [Wed, 30 Jan 2019 22:36:47 +0000 (23:36 +0100)]
Try to improve coverage reports for MC tests.

2 years agoDefine coverage_checkpoint().
Arnaud Giersch [Wed, 30 Jan 2019 22:36:05 +0000 (23:36 +0100)]
Define coverage_checkpoint().

It's defined as an alias for __gcov_flush() when coverage is enabled, or a
no-op otherwise.

2 years agoDefine COVERAGE for C++ too.
Arnaud Giersch [Wed, 30 Jan 2019 20:41:07 +0000 (21:41 +0100)]
Define COVERAGE for C++ too.

2 years agoRemove unused static functions.
Arnaud Giersch [Wed, 30 Jan 2019 09:14:20 +0000 (10:14 +0100)]
Remove unused static functions.

2 years agoRefactorize and speedup a unit test
Martin Quinson [Thu, 31 Jan 2019 08:03:35 +0000 (09:03 +0100)]
Refactorize and speedup a unit test

I don't think there is a real need to test each region size from 1 to
256. Testing on [1;32[ should give a sufficient coverage, I think.

2 years agoRemove the now useless unit_test_framework
Martin Quinson [Thu, 31 Jan 2019 07:45:29 +0000 (08:45 +0100)]
Remove the now useless unit_test_framework

2 years agoconvert the two other boost::unit_test suites to Catch2
Martin Quinson [Thu, 31 Jan 2019 07:42:53 +0000 (08:42 +0100)]
convert the two other boost::unit_test suites to Catch2

2 years agoConvert a first unit test to Catch
Martin Quinson [Thu, 31 Jan 2019 00:06:47 +0000 (01:06 +0100)]
Convert a first unit test to Catch

2 years agoAdd the Catch header
Martin Quinson [Wed, 30 Jan 2019 23:39:49 +0000 (00:39 +0100)]
Add the Catch header

This is a header-only library for unit-testing. Including the header
in our project is the recommended way of using it. No need to test for
its presence, then.

Boost::unit_test_framework shall soon vanish from our tree. Testing
for its presence is too bothersome, and Catch seems easier to use
anyway.

2 years agosonar: kill unused imports in java
Martin Quinson [Wed, 30 Jan 2019 07:06:52 +0000 (08:06 +0100)]
sonar: kill unused imports in java

2 years agouncomment forgotten line, includes smpi_helper in C++ codes as well
Augustin Degomme [Wed, 30 Jan 2019 14:03:37 +0000 (15:03 +0100)]
uncomment forgotten line, includes smpi_helper in C++ codes as well

2 years agoavoid sending misleading log message
Augustin Degomme [Tue, 29 Jan 2019 14:34:37 +0000 (15:34 +0100)]
avoid sending misleading log message

2 years agoOur cmake files are so fragile, fix last changes.
Arnaud Giersch [Wed, 30 Jan 2019 07:21:20 +0000 (08:21 +0100)]
Our cmake files are so fragile, fix last changes.

2 years ago[jenkins] Temporary disable LTO on NixOS/gcc 7.4.0/ld 2.30.
Arnaud Giersch [Tue, 29 Jan 2019 22:01:25 +0000 (23:01 +0100)]
[jenkins] Temporary disable LTO on NixOS/gcc 7.4.0/ld 2.30.

2 years agoOptimize MC builds a bit further.
Arnaud Giersch [Tue, 29 Jan 2019 21:33:01 +0000 (22:33 +0100)]
Optimize MC builds a bit further.

2 years agoContextUnix belongs to Simix.
Arnaud Giersch [Tue, 29 Jan 2019 21:27:04 +0000 (22:27 +0100)]
ContextUnix belongs to Simix.

2 years agoInclude cmake/Flags.cmake after DefinePackages.
Arnaud Giersch [Tue, 29 Jan 2019 21:00:18 +0000 (22:00 +0100)]
Include cmake/Flags.cmake after DefinePackages.

The former uses variables defined in the latter (e.g. MC_SRC).

2 years agoImprove coverage, even with high log threshold.
Arnaud Giersch [Tue, 29 Jan 2019 15:31:30 +0000 (16:31 +0100)]
Improve coverage, even with high log threshold.

2 years agoKill dead code in kademlia examples.
Arnaud Giersch [Tue, 29 Jan 2019 12:34:27 +0000 (13:34 +0100)]
Kill dead code in kademlia examples.

2 years ago[java] Delete broken test.
Arnaud Giersch [Tue, 29 Jan 2019 12:13:23 +0000 (13:13 +0100)]
[java] Delete broken test.

2 years ago[java] Catch StopRequest during VM migration.
Arnaud Giersch [Tue, 29 Jan 2019 10:49:24 +0000 (11:49 +0100)]
[java] Catch StopRequest during VM migration.

2 years ago[sonar] Inform that some properties are overridden by Jenkins.
Arnaud Giersch [Tue, 29 Jan 2019 12:51:54 +0000 (13:51 +0100)]
[sonar] Inform that some properties are overridden by Jenkins.

2 years ago[sonar] Only exclude from coverage a subset of python files.
Arnaud Giersch [Tue, 29 Jan 2019 09:58:05 +0000 (10:58 +0100)]
[sonar] Only exclude from coverage a subset of python files.

2 years agoEnable running parmap_bench for coverage.
Arnaud Giersch [Tue, 29 Jan 2019 09:33:15 +0000 (10:33 +0100)]
Enable running parmap_bench for coverage.

2 years agoparmap_bench: make timeout a runtime parameter.
Arnaud Giersch [Tue, 29 Jan 2019 09:25:21 +0000 (10:25 +0100)]
parmap_bench: make timeout a runtime parameter.

2 years agoKill dead code.
Arnaud Giersch [Tue, 29 Jan 2019 09:11:38 +0000 (10:11 +0100)]
Kill dead code.

This test for mallocators has never been used.

2 years agoProcess.java: reduce the debugging scaffolding now that it works
Martin Quinson [Tue, 29 Jan 2019 08:26:24 +0000 (09:26 +0100)]
Process.java: reduce the debugging scaffolding now that it works

2 years agothis file should not be executable
Martin Quinson [Mon, 28 Jan 2019 14:55:32 +0000 (15:55 +0100)]
this file should not be executable

2 years agoOnly unregister the kill timer once, in maestro context
Martin Quinson [Mon, 28 Jan 2019 08:16:17 +0000 (09:16 +0100)]
Only unregister the kill timer once, in maestro context

2 years agoRemove workaround for g++ 4.8.
Arnaud Giersch [Sun, 27 Jan 2019 21:24:40 +0000 (22:24 +0100)]
Remove workaround for g++ 4.8.

g++ 5.0 or higher is advertised in the doc.

2 years agoImplement xbt::Result with boost::variant.
Arnaud Giersch [Sun, 27 Jan 2019 20:07:06 +0000 (21:07 +0100)]
Implement xbt::Result with  boost::variant.

std::variant is today not an option because it's C++17.

2 years agoFix memleak.
Arnaud Giersch [Sun, 27 Jan 2019 17:33:57 +0000 (18:33 +0100)]
Fix memleak.

The comment seems to be invalidated by commit 4f2d08b0ae4625d32890dc4613e1d842ad0f7b77
"Sanitize the API of this_actor::parallel_execute()"