Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
Convert the unit tests of xbt::str to Catch2.
authorArnaud Giersch <arnaud.giersch@univ-fcomte.fr>
Thu, 31 Jan 2019 22:18:06 +0000 (23:18 +0100)
committerArnaud Giersch <arnaud.giersch@univ-fcomte.fr>
Fri, 1 Feb 2019 13:30:44 +0000 (14:30 +0100)
src/xbt/xbt_str.cpp
src/xbt/xbt_str_test.cpp [new file with mode: 0644]
tools/cmake/Tests.cmake
tools/cmake/UnitTesting.cmake

index ac97bee..0d784a1 100644 (file)
@@ -260,85 +260,3 @@ double xbt_str_parse_double(const char* str, const char* error_msg)
 
   return res;
 }
-
-#ifdef SIMGRID_TEST
-#include "simgrid/Exception.hpp"
-#include "xbt/str.h"
-
-XBT_TEST_SUITE("xbt_str", "String Handling");
-
-#define mytest(name, input, expected)                                                                                  \
-  xbt_test_add(name);                                                                                                  \
-  a = static_cast<char**>(xbt_dynar_to_array(xbt_str_split_quoted(input)));                                            \
-  s = xbt_str_join_array(a, "XXX");                                                                                    \
-  xbt_test_assert(not strcmp(s, expected), "Input (%s) leads to (%s) instead of (%s)", input, s, expected);            \
-  xbt_free(s);                                                                                                         \
-  for (int i = 0; a[i] != nullptr; i++)                                                                                \
-    xbt_free(a[i]);                                                                                                    \
-  xbt_free(a);
-XBT_TEST_UNIT("xbt_str_split_quoted", test_split_quoted, "Test the function xbt_str_split_quoted")
-{
-  char** a;
-  char *s;
-
-  mytest("Empty", "", "");
-  mytest("Basic test", "toto tutu", "totoXXXtutu");
-  mytest("Useless backslashes", "\\t\\o\\t\\o \\t\\u\\t\\u", "totoXXXtutu");
-  mytest("Protected space", "toto\\ tutu", "toto tutu");
-  mytest("Several spaces", "toto   tutu", "totoXXXtutu");
-  mytest("LTriming", "  toto tatu", "totoXXXtatu");
-  mytest("Triming", "  toto   tutu  ", "totoXXXtutu");
-  mytest("Single quotes", "'toto tutu' tata", "toto tutuXXXtata");
-  mytest("Double quotes", "\"toto tutu\" tata", "toto tutuXXXtata");
-  mytest("Mixed quotes", "\"toto' 'tutu\" tata", "toto' 'tutuXXXtata");
-  mytest("Backslashed quotes", "\\'toto tutu\\' tata", "'totoXXXtutu'XXXtata");
-  mytest("Backslashed quotes + quotes", "'toto \\'tutu' tata", "toto 'tutuXXXtata");
-}
-
-#define test_parse_error(function, name, variable, str)                 \
-  do {                                                                  \
-    xbt_test_add(name);                                                 \
-    try {                                                               \
-      variable = function(str, "Parse error");                          \
-      xbt_test_fail("The test '%s' did not detect the problem",name );  \
-    } catch(xbt_ex& e) {                                                \
-      if (e.category != arg_error) {                                    \
-        xbt_test_exception(e);                                          \
-      }                                                                 \
-    }                                                                   \
-  } while (0)
-#define test_parse_ok(function, name, variable, str, value)             \
-  do {                                                                  \
-    xbt_test_add(name);                                                 \
-    try {                                                               \
-      variable = function(str, "Parse error");                          \
-    } catch(xbt_ex& e) {                                                \
-      xbt_test_exception(e);                                            \
-    }                                                                   \
-    xbt_test_assert(variable == value, "Fail to parse '%s'", str);      \
-  } while (0)
-
-XBT_TEST_UNIT("xbt_str_parse", test_parse, "Test the parsing functions")
-{
-  int rint = -9999;
-  test_parse_ok(xbt_str_parse_int, "Parse int", rint, "42", 42);
-  test_parse_ok(xbt_str_parse_int, "Parse 0 as an int", rint, "0", 0);
-  test_parse_ok(xbt_str_parse_int, "Parse -1 as an int", rint, "-1", -1);
-
-  test_parse_error(xbt_str_parse_int, "Parse int + noise", rint, "342 cruft");
-  test_parse_error(xbt_str_parse_int, "Parse nullptr as an int", rint, nullptr);
-  test_parse_error(xbt_str_parse_int, "Parse '' as an int", rint, "");
-  test_parse_error(xbt_str_parse_int, "Parse cruft as an int", rint, "cruft");
-
-  double rdouble = -9999;
-  test_parse_ok(xbt_str_parse_double, "Parse 42 as a double", rdouble, "42", 42);
-  test_parse_ok(xbt_str_parse_double, "Parse 42.5 as a double", rdouble, "42.5", 42.5);
-  test_parse_ok(xbt_str_parse_double, "Parse 0 as a double", rdouble, "0", 0);
-  test_parse_ok(xbt_str_parse_double, "Parse -1 as a double", rdouble, "-1", -1);
-
-  test_parse_error(xbt_str_parse_double, "Parse double + noise", rdouble, "342 cruft");
-  test_parse_error(xbt_str_parse_double, "Parse nullptr as a double", rdouble, nullptr);
-  test_parse_error(xbt_str_parse_double, "Parse '' as a double", rdouble, "");
-  test_parse_error(xbt_str_parse_double, "Parse cruft as a double", rdouble, "cruft");
-}
-#endif                          /* SIMGRID_TEST */
diff --git a/src/xbt/xbt_str_test.cpp b/src/xbt/xbt_str_test.cpp
new file mode 100644 (file)
index 0000000..d6eee1e
--- /dev/null
@@ -0,0 +1,84 @@
+/* xbt_str.cpp - various helping functions to deal with strings             */
+
+/* Copyright (c) 2007-2019. The SimGrid Team. All rights reserved.          */
+
+/* This program is free software; you can redistribute it and/or modify it
+ * under the terms of the license (GNU LGPL) which comes with this package. */
+
+#include "xbt/str.h"
+
+#include "simgrid/Exception.hpp"
+
+#include "catch.hpp"
+
+#define mytest(name, input, expected)                                                                                  \
+  INFO(name);                                                                                                          \
+  a = static_cast<char**>(xbt_dynar_to_array(xbt_str_split_quoted(input)));                                            \
+  s = xbt_str_join_array(a, "XXX");                                                                                    \
+  REQUIRE(not strcmp(s, expected));                                                                                    \
+  xbt_free(s);                                                                                                         \
+  for (int i = 0; a[i] != nullptr; i++)                                                                                \
+    xbt_free(a[i]);                                                                                                    \
+  xbt_free(a);
+
+#define test_parse_error(function, name, variable, str)                                                                \
+  do {                                                                                                                 \
+    INFO(name);                                                                                                        \
+    REQUIRE_THROWS_MATCHES(variable = function(str, "Parse error"), xbt_ex,                                            \
+                           Catch::Matchers::Predicate<xbt_ex>([](xbt_ex const& e) { return e.category == arg_error; }, \
+                                                              "category arg_error"));                                  \
+  } while (0)
+
+#define test_parse_ok(function, name, variable, str, value)                                                            \
+  do {                                                                                                                 \
+    INFO(name);                                                                                                        \
+    REQUIRE_NOTHROW(variable = function(str, "Parse error"));                                                          \
+    REQUIRE(variable == value); /* Fail to parse str */                                                                \
+  } while (0)
+
+TEST_CASE("xbt::str: String Handling", "xbt_str")
+{
+
+  SECTION("Test the function xbt_str_split_quoted")
+  {
+    char** a;
+    char* s;
+
+    mytest("Empty", "", "");
+    mytest("Basic test", "toto tutu", "totoXXXtutu");
+    mytest("Useless backslashes", "\\t\\o\\t\\o \\t\\u\\t\\u", "totoXXXtutu");
+    mytest("Protected space", "toto\\ tutu", "toto tutu");
+    mytest("Several spaces", "toto   tutu", "totoXXXtutu");
+    mytest("LTriming", "  toto tatu", "totoXXXtatu");
+    mytest("Triming", "  toto   tutu  ", "totoXXXtutu");
+    mytest("Single quotes", "'toto tutu' tata", "toto tutuXXXtata");
+    mytest("Double quotes", "\"toto tutu\" tata", "toto tutuXXXtata");
+    mytest("Mixed quotes", "\"toto' 'tutu\" tata", "toto' 'tutuXXXtata");
+    mytest("Backslashed quotes", "\\'toto tutu\\' tata", "'totoXXXtutu'XXXtata");
+    mytest("Backslashed quotes + quotes", "'toto \\'tutu' tata", "toto 'tutuXXXtata");
+  }
+
+  SECTION("Test the parsing functions")
+  {
+    int rint = -9999;
+    test_parse_ok(xbt_str_parse_int, "Parse int", rint, "42", 42);
+    test_parse_ok(xbt_str_parse_int, "Parse 0 as an int", rint, "0", 0);
+    test_parse_ok(xbt_str_parse_int, "Parse -1 as an int", rint, "-1", -1);
+
+    test_parse_error(xbt_str_parse_int, "Parse int + noise", rint, "342 cruft");
+    test_parse_error(xbt_str_parse_int, "Parse nullptr as an int", rint, nullptr);
+    test_parse_error(xbt_str_parse_int, "Parse '' as an int", rint, "");
+    test_parse_error(xbt_str_parse_int, "Parse cruft as an int", rint, "cruft");
+
+    double rdouble = -9999;
+    test_parse_ok(xbt_str_parse_double, "Parse 42 as a double", rdouble, "42", 42);
+    test_parse_ok(xbt_str_parse_double, "Parse 42.5 as a double", rdouble, "42.5", 42.5);
+    test_parse_ok(xbt_str_parse_double, "Parse 0 as a double", rdouble, "0", 0);
+    test_parse_ok(xbt_str_parse_double, "Parse -1 as a double", rdouble, "-1", -1);
+
+    test_parse_error(xbt_str_parse_double, "Parse double + noise", rdouble, "342 cruft");
+    test_parse_error(xbt_str_parse_double, "Parse nullptr as a double", rdouble, nullptr);
+    test_parse_error(xbt_str_parse_double, "Parse '' as a double", rdouble, "");
+    test_parse_error(xbt_str_parse_double, "Parse cruft as a double", rdouble, "cruft");
+  }
+}
index 9122e24..02da373 100644 (file)
@@ -125,7 +125,8 @@ ADD_TEST(testall                                 ${CMAKE_BINARY_DIR}/testall)
 # New tests should use the Catch Framework
 set(UNIT_TESTS  src/surf/trace_mgr_test.cpp
                 src/xbt/dict_test.cpp
-                src/xbt/dynar_test.cpp)
+                src/xbt/dynar_test.cpp
+                src/xbt/xbt_str_test.cpp)
 if (SIMGRID_HAVE_MC)
   set(UNIT_TESTS ${UNIT_TESTS} src/mc/sosp/mc_snapshot_test.cpp src/mc/sosp/PageStore_test.cpp)
 else()
index 85e80f5..1ac344d 100644 (file)
@@ -6,7 +6,6 @@
 
 set(FILES_CONTAINING_UNITTESTS
   src/xbt/cunit.cpp
-  src/xbt/xbt_str.cpp
   src/xbt/config.cpp
 )