Arnaud Giersch [Mon, 14 Nov 2011 14:37:41 +0000 (15:37 +0100)]
Use xbt_XXX_is_empty() instead of testing xbt_XXX_length() against 0.
Where XXX is 'dict' or 'dynar'.
(was a request from emptty)
Arnaud Giersch [Mon, 14 Nov 2011 11:01:11 +0000 (12:01 +0100)]
Rewrite xbt libs, using xbt dicts.
And remove lots of code duplication.
Also remove unused functions.
Arnaud Giersch [Mon, 14 Nov 2011 10:23:25 +0000 (11:23 +0100)]
Use xbt_lib_length instead of xbt_lib_size.
Arnaud Giersch [Mon, 14 Nov 2011 10:21:06 +0000 (11:21 +0100)]
Use defined interface for accessing to lib properties.
Arnaud Giersch [Mon, 14 Nov 2011 12:04:16 +0000 (13:04 +0100)]
Remove usage of xbt_dict_size().
xbt_dict_size() can now be safely removed.
Arnaud Giersch [Mon, 14 Nov 2011 12:10:51 +0000 (13:10 +0100)]
Remove trailing spaces in ChangeLog.
Laurent Bobelin [Sat, 12 Nov 2011 09:02:21 +0000 (10:02 +0100)]
Added the new logo to the unstable doc, so that Lucas and Fred can show a webpage and at least one doc with the same logo at SC
Martin Quinson [Fri, 11 Nov 2011 08:37:49 +0000 (09:37 +0100)]
kill another "method" away from the "singleton" global_routing
OO coding in C is something, but applying the worst possible OO design
to C is ... inventive
Martin Quinson [Fri, 11 Nov 2011 02:36:28 +0000 (03:36 +0100)]
cosmetics and improve doc
Martin Quinson [Fri, 11 Nov 2011 02:31:05 +0000 (03:31 +0100)]
kill a file that were begging for it
Martin Quinson [Fri, 11 Nov 2011 02:18:51 +0000 (03:18 +0100)]
cosmetics
Martin Quinson [Fri, 11 Nov 2011 02:17:41 +0000 (03:17 +0100)]
move the callbacks to the cluster creation from surfxml_parse to sg_platf
Martin Quinson [Fri, 11 Nov 2011 02:05:27 +0000 (03:05 +0100)]
I've found the name of the next release
Martin Quinson [Fri, 11 Nov 2011 01:47:04 +0000 (02:47 +0100)]
move some XML specific code from surf_routing.c to surfxml_parse.c
Martin Quinson [Fri, 11 Nov 2011 01:37:58 +0000 (02:37 +0100)]
Improve a bit the documentation of hte xbt_queues, and ensure that they are displayed on the web site
Arnaud Giersch [Thu, 10 Nov 2011 22:53:50 +0000 (23:53 +0100)]
Remove two more declaration of phantom functions.
Arnaud Giersch [Thu, 10 Nov 2011 22:36:16 +0000 (23:36 +0100)]
Simply say fun_ptr(...) instead of (*fun_ptr)(...).
Another possible cleanup in the same spirit is to remove the
ampersand when taking the address of a function.
This is left as an exercise for the reader.
Martin Quinson [Thu, 10 Nov 2011 22:07:03 +0000 (23:07 +0100)]
some more cleanups for tomorrow marked as FIXME for now -- good night
Martin Quinson [Thu, 10 Nov 2011 22:03:25 +0000 (23:03 +0100)]
various psychorigid cleanups -- routing_parse_cluster() is now readable
Martin Quinson [Thu, 10 Nov 2011 21:52:03 +0000 (22:52 +0100)]
that's a quite complicated no-op :)
Martin Quinson [Thu, 10 Nov 2011 21:40:23 +0000 (22:40 +0100)]
Merge branch 'parser'
Martin Quinson [Thu, 10 Nov 2011 21:38:52 +0000 (22:38 +0100)]
do not search the cluster backbones again and again, store them in the right location
On the poor tests I've done, it seems to give a non negligible
improvement on the goal example. Maybe 5-10%, but it's hard to say
right now.
Martin Quinson [Thu, 10 Nov 2011 21:23:25 +0000 (22:23 +0100)]
you have to plug the memleaks from time to time
Martin Quinson [Thu, 10 Nov 2011 21:03:36 +0000 (22:03 +0100)]
populate the routing_none_finalize to make sure that we always call these functions
Martin Quinson [Thu, 10 Nov 2011 20:54:20 +0000 (21:54 +0100)]
cosmetics: variable&fields renaming
Martin Quinson [Thu, 10 Nov 2011 20:39:19 +0000 (21:39 +0100)]
Use the none routing as an ancestor to the generic one, which is ancestor to most of the others. First step to further factorization
Martin Quinson [Thu, 10 Nov 2011 20:30:43 +0000 (21:30 +0100)]
cosmetics, nothing serious
Christophe Thiéry [Thu, 10 Nov 2011 17:46:50 +0000 (18:46 +0100)]
New Lua example: Chord (work in progress)
Martin Quinson [Thu, 10 Nov 2011 17:42:59 +0000 (18:42 +0100)]
sanitize get_network_element_type()
It were declared as a field of global_routing, and of each and every
routing model. That's a bit much for a simple little function.
Martin Quinson [Thu, 10 Nov 2011 17:07:38 +0000 (18:07 +0100)]
kill unused global_routing->get_latency()
Martin Quinson [Thu, 10 Nov 2011 17:05:39 +0000 (18:05 +0100)]
Kill global_routing->get_route_or_null
It was used at only one location, so I setup a TRY/CATCH in there
instead
Martin Quinson [Thu, 10 Nov 2011 16:57:02 +0000 (17:57 +0100)]
That pointer to function was never given anything but one value
The global_routing value seem to be used to group functions together,
but the fields cannot be given another value.
Of course, I'm gonna kill em all.
Martin Quinson [Thu, 10 Nov 2011 16:47:24 +0000 (17:47 +0100)]
factorize the routing_exit functionality, and ensure that no model can forget to call it
Martin Quinson [Thu, 10 Nov 2011 16:37:30 +0000 (17:37 +0100)]
kill small crufts here and there
Martin Quinson [Thu, 10 Nov 2011 16:33:46 +0000 (17:33 +0100)]
kill further globals
Martin Quinson [Thu, 10 Nov 2011 16:20:36 +0000 (17:20 +0100)]
saner pattern use in the trace files
I guess that previously, the patterns were replaced for the first
host, and then reused as is for the next ones. So the traces specified
for the first host were used for any ones.
Martin Quinson [Thu, 10 Nov 2011 16:20:04 +0000 (17:20 +0100)]
fix the constness of xbt_strbuff_new_from(), it's too dangerous with previous prototype
Martin Quinson [Thu, 10 Nov 2011 16:07:48 +0000 (17:07 +0100)]
various cleanups
amongst other, kill yet another global
Martin Quinson [Thu, 10 Nov 2011 15:56:00 +0000 (16:56 +0100)]
ahah. Mort de rire. :-/
Martin Quinson [Thu, 10 Nov 2011 15:54:43 +0000 (16:54 +0100)]
various cleanups and clarifications
Martin Quinson [Thu, 10 Nov 2011 15:51:03 +0000 (16:51 +0100)]
rename routing_component to as, since that's just an AS at the end of the day
Navarrop [Thu, 10 Nov 2011 16:39:07 +0000 (17:39 +0100)]
Remove section about java.
Navarrop [Thu, 10 Nov 2011 16:14:03 +0000 (17:14 +0100)]
Make a sync in a different directory.
Christophe Thiéry [Thu, 10 Nov 2011 15:47:20 +0000 (16:47 +0100)]
Lua masterslave: simplify the code and improve the output
Christophe Thiéry [Thu, 10 Nov 2011 15:45:04 +0000 (16:45 +0100)]
Lua: set a task metatable that allows OO-style syntax
You can now write my_task:send(mailbox), which is just syntaxic sugar
for simgrid.task.send(my_task, mailbox).
Christophe Thiéry [Thu, 10 Nov 2011 14:54:02 +0000 (15:54 +0100)]
Lua: garbage collect the simgrid module (remove simgrid.clean())
Christophe Thiéry [Thu, 10 Nov 2011 13:13:31 +0000 (14:13 +0100)]
Don't protect access to the metatable from Lua.
Lua code can never change the metatable of a userdata anyway
(setmetatable is possible only for a table).
getmetatable is now allowed for tasks and hosts: it's harmless and lets
people extend them.
Christophe Thiéry [Thu, 10 Nov 2011 13:06:13 +0000 (14:06 +0100)]
Clean MSG source file names
Martin Quinson [Thu, 10 Nov 2011 15:20:02 +0000 (16:20 +0100)]
inline static functions declared only once, and that were not really improving my execution flow understanding
Martin Quinson [Thu, 10 Nov 2011 15:19:26 +0000 (16:19 +0100)]
kill unused static functions
Martin Quinson [Thu, 10 Nov 2011 15:13:07 +0000 (16:13 +0100)]
that function is so stupid that it is never called. Let's remove it
Martin Quinson [Thu, 10 Nov 2011 15:08:23 +0000 (16:08 +0100)]
kill a type that were exactly the same than another
Martin Quinson [Thu, 10 Nov 2011 14:45:12 +0000 (15:45 +0100)]
sanitize type naming between surf models and routing models
Martin Quinson [Thu, 10 Nov 2011 14:44:10 +0000 (15:44 +0100)]
use an explicit type name for pointer on fct
Martin Quinson [Thu, 10 Nov 2011 14:37:23 +0000 (15:37 +0100)]
tiny partial reindent
Martin Quinson [Thu, 10 Nov 2011 14:33:54 +0000 (15:33 +0100)]
Move the SURF model initialization from routing_parse to sg_platf
It's cleaner when the router is just another bunch of callbacks, with
no central point. But it's a bit harder because the sg_platf callbacks
are also used during the parsing of deploy.xml
Martin Quinson [Thu, 10 Nov 2011 13:29:48 +0000 (14:29 +0100)]
kill unused callbacks in the routing models
they were (probably) intended to allow the rmodels to add new
callbacks over the elements, but since I cannot remove callbacks in
the new mecanism, and since it wasn't used, I don't see the point.
Martin Quinson [Thu, 10 Nov 2011 13:21:35 +0000 (14:21 +0100)]
Rename sg_platf_new_AS_{open,close} to {begin,end} since you cannot reopen them to add stuff afterward (and other similar call renaming)
Arnaud Giersch [Thu, 10 Nov 2011 14:47:20 +0000 (15:47 +0100)]
Remove declaration for inexistent functions.
Arnaud Giersch [Thu, 10 Nov 2011 14:46:28 +0000 (15:46 +0100)]
These functions are declared static, define them static too.
Martin Quinson [Thu, 10 Nov 2011 11:12:44 +0000 (12:12 +0100)]
Rename some routing logic fields to make them more explicit (hopefully)
Martin Quinson [Thu, 10 Nov 2011 11:03:16 +0000 (12:03 +0100)]
kill asserts which error message is as instructive as the segfault that it hides
Martin Quinson [Thu, 10 Nov 2011 10:58:31 +0000 (11:58 +0100)]
cluster routing is simpler than you thought
Martin Quinson [Thu, 10 Nov 2011 10:57:22 +0000 (11:57 +0100)]
kill unused function
Martin Quinson [Thu, 10 Nov 2011 10:54:02 +0000 (11:54 +0100)]
add a constructor to the generic parsing logic, and use it to factorize code
Martin Quinson [Thu, 10 Nov 2011 10:38:09 +0000 (11:38 +0100)]
Start fixing the OO organization of the routing
the generic routing is intended to be the ancestor of every other
routing logic, so move it into its own file (without any other change
for now)
Martin Quinson [Thu, 10 Nov 2011 10:21:29 +0000 (11:21 +0100)]
hide an ugly function used only locally
and also mark at its second location that its usage shouldn't be
dupplicated.
Martin Quinson [Thu, 10 Nov 2011 10:18:17 +0000 (11:18 +0100)]
what is that pimple, for god's sake??
Martin Quinson [Thu, 10 Nov 2011 10:02:14 +0000 (11:02 +0100)]
kill an unused structure + reindent and cosmetics
Martin Quinson [Thu, 10 Nov 2011 08:43:24 +0000 (09:43 +0100)]
further improve that damn message (fct called from two user visible functions -> don't name them)
Martin Quinson [Thu, 10 Nov 2011 07:47:54 +0000 (08:47 +0100)]
fix a typo spotted by Henri
Martin Quinson [Thu, 10 Nov 2011 00:25:45 +0000 (01:25 +0100)]
some users prefer this name, so provide it for symmetry with send and irecv
Arnaud Giersch [Wed, 9 Nov 2011 21:16:32 +0000 (22:16 +0100)]
Don't define routing_component_t twice.
Christophe Thiéry [Wed, 9 Nov 2011 20:41:07 +0000 (21:41 +0100)]
Yet another clobbered variable warning
Christophe Thiéry [Wed, 9 Nov 2011 20:10:17 +0000 (21:10 +0100)]
Clean the code and comments of registering C functions to Lua
Christophe Thiéry [Wed, 9 Nov 2011 19:22:53 +0000 (20:22 +0100)]
These function don't return anything
Christophe Thiéry [Wed, 9 Nov 2011 19:22:14 +0000 (20:22 +0100)]
Move this debugging function to lua_utils.c
Christophe Thiéry [Wed, 9 Nov 2011 19:19:08 +0000 (20:19 +0100)]
The argument is a userdata, not a Lua task
Christophe Thiéry [Wed, 9 Nov 2011 19:15:42 +0000 (20:15 +0100)]
Lua: merge simgrid.task.recv and simgrid.task.recv_with_timeout
The timeout is now an optional argument of simgrid.task.recv.
Christophe Thiéry [Wed, 9 Nov 2011 19:10:53 +0000 (20:10 +0100)]
Document C functions that Lua calls
Christophe Thiéry [Wed, 9 Nov 2011 18:02:00 +0000 (19:02 +0100)]
When a C function is called by Lua, get the args with positive indices
A negative index is unsafe since the caller may provide more arguments
than needed.
Christophe Thiéry [Wed, 9 Nov 2011 17:57:57 +0000 (18:57 +0100)]
Nice joke.
Christophe Thiéry [Wed, 9 Nov 2011 17:53:45 +0000 (18:53 +0100)]
Make the Lua API respect coherent naming conventions
Christophe Thiéry [Wed, 9 Nov 2011 17:42:34 +0000 (18:42 +0100)]
Rename functions in simgrid_lua.c
Martin Quinson [Wed, 9 Nov 2011 17:08:21 +0000 (18:08 +0100)]
Remove a useless xbt_assert from the critical path
The error message was not more informative than a segfault will be,
and user behavior cannot produce this (I think)
Martin Quinson [Wed, 9 Nov 2011 17:06:57 +0000 (18:06 +0100)]
use a sane way to declare postparse callbacks, now that this way exists
Martin Quinson [Wed, 9 Nov 2011 16:45:06 +0000 (17:45 +0100)]
partially reindent that file
Martin Quinson [Wed, 9 Nov 2011 16:32:36 +0000 (17:32 +0100)]
Remove the complexity needed to save a global that is never used
this is the field "model" in the surf_model_description structure. The
actual model is always saved elsewhere (like in the global
surf_workstation_model and friends).
If one day we want to have multi-model simulations, we'll need to
partially revert this change, but I guess that this day seaching the
right model linearly by name, as it was made possible with the
existing setup, will not be the way to go.
Martin Quinson [Wed, 9 Nov 2011 15:50:42 +0000 (16:50 +0100)]
I don't see the point of declaring and calling empty functions
*_load *_unload callbacks of the routing logics seem unused.
We could maybe kill them?
Martin Quinson [Wed, 9 Nov 2011 15:30:19 +0000 (16:30 +0100)]
oups, that comment were in french
Martin Quinson [Wed, 9 Nov 2011 15:19:22 +0000 (16:19 +0100)]
nobody use these structures, so I won't try to understand their purpose
Arnaud Giersch [Wed, 20 Jul 2011 15:02:15 +0000 (17:02 +0200)]
Reorganize mallocator.c, and add the possibility to disable mallocators.
Memory leaks are sometimes hard to track when mallocators are in use.
Set MALLOCATOR_IS_WANTED to 0 to disable them during your debugging session.
The code for mallocator_new and mallocator_get is also made a bit cleaner.
Arnaud Giersch [Fri, 28 Jan 2011 15:27:37 +0000 (16:27 +0100)]
Kill "if" before free, and useless cast of free argument.
free(NULL) is a no-op, there is no need to test the given pointer
before call.
The same argument stands for xbt_free, xbt_dict_free, xbt_dynar_free,
and xbt_strbuff_free.
Arnaud Giersch [Tue, 13 Sep 2011 08:20:32 +0000 (10:20 +0200)]
Replace, when possible, calls to bprintf() by calls to xbt_strdup().
Navarrop [Wed, 9 Nov 2011 12:48:06 +0000 (13:48 +0100)]
For radical it is "," and not ";"
Lucas Schnorr [Wed, 9 Nov 2011 12:28:41 +0000 (13:28 +0100)]
improve documentation of MSG_task_dsend function
Christophe Thiéry [Wed, 9 Nov 2011 11:20:26 +0000 (12:20 +0100)]
Also remove the comm from processes when SIMIX_post_comm is not called
Christophe Thiéry [Wed, 9 Nov 2011 10:46:02 +0000 (11:46 +0100)]
Fix possible crashes and leaks with dsends during processes cleanup
Arnaud Giersch [Tue, 8 Nov 2011 14:44:38 +0000 (15:44 +0100)]
Destroy sg_platf_link_cb_list on sg_platf_exit().
Arnaud Giersch [Mon, 7 Nov 2011 22:21:33 +0000 (23:21 +0100)]
Don't duplicate strings uselessly, and avoid memory leaks.