Arnaud Giersch [Mon, 11 Feb 2019 19:49:09 +0000 (20:49 +0100)]
Avoid unnecessary copy of parameters for parallel_execute.
Arnaud Giersch [Mon, 11 Feb 2019 19:45:12 +0000 (20:45 +0100)]
Get rid of temporary vector of strings.
Save the unnecessary cost of its construction.
Arnaud Giersch [Mon, 11 Feb 2019 19:40:35 +0000 (20:40 +0100)]
Deprecate the is_off() methods.
They are simply the negation of is_on() and, when the two forms are defined,
we may wonder if there is some kind of intermediate state neither on(), nor
off().
Arnaud Giersch [Tue, 12 Feb 2019 12:57:20 +0000 (13:57 +0100)]
[tesh] Split setenv parameter on first '=' only.
Frederic Suter [Tue, 12 Feb 2019 15:56:09 +0000 (16:56 +0100)]
keep a return value for MSG_process_sleep
handle the exception in msg_legacy.cpp
Frederic Suter [Tue, 12 Feb 2019 14:50:54 +0000 (15:50 +0100)]
fix build
Frederic Suter [Tue, 12 Feb 2019 14:19:04 +0000 (15:19 +0100)]
a bug notified on July 28, 2014 is finally solved \o/
a true c++ exception is now raised if an actor is killed because its
host was turned off. It can be catched in the Java binding and set the
right MSG error status to MSG_HOST_FAILURE.
MSG_process_sleep can thus be marked as legacy and replaced by
s4u_actor_sleep_for
Frederic Suter [Tue, 12 Feb 2019 13:07:48 +0000 (14:07 +0100)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid
Frederic Suter [Tue, 12 Feb 2019 13:05:09 +0000 (14:05 +0100)]
cosmetics
Frederic Suter [Tue, 12 Feb 2019 13:02:26 +0000 (14:02 +0100)]
SIMIX_process_killall becomes ActorImp::kill_all
Frederic Suter [Tue, 12 Feb 2019 12:49:38 +0000 (13:49 +0100)]
SIMIX_process_kill becomes ActorImpl::kill
Frederic Suter [Tue, 12 Feb 2019 10:05:29 +0000 (11:05 +0100)]
start to differentiate kill from exit in ActorImpl
Arnaud Giersch [Mon, 11 Feb 2019 22:11:40 +0000 (23:11 +0100)]
Add suppressions for Asan when run on jenkins.
Ideally, ASAN_OPTIONS should be set by ctest but I didn't find how.
Arnaud Giersch [Mon, 11 Feb 2019 15:07:12 +0000 (16:07 +0100)]
No need to answer to simcall when host is off.
These changes should fix tests platform-failures where some processes were
duplicated in process_to_run[], leading to runtime errors with boost and raw
contexts.
The error could be seen with a "xbt_assert(next_context != this);" just before
"this->swap_into(next_context);" in SwappedContext::suspend().
Arnaud Giersch [Mon, 11 Feb 2019 15:05:06 +0000 (16:05 +0100)]
Don't set field twice.
Arnaud Giersch [Mon, 11 Feb 2019 13:21:17 +0000 (14:21 +0100)]
Enrich debugging messages.
Arnaud Giersch [Mon, 11 Feb 2019 13:16:17 +0000 (14:16 +0100)]
Rename file for the sake of consistency.
Arnaud Giersch [Mon, 11 Feb 2019 13:08:00 +0000 (14:08 +0100)]
Deprecate an unused function.
Frederic Suter [Mon, 11 Feb 2019 10:55:45 +0000 (11:55 +0100)]
please sonar with a few smells
Arnaud Giersch [Sun, 10 Feb 2019 13:55:31 +0000 (14:55 +0100)]
Typo.
Martin Quinson [Sat, 9 Feb 2019 22:10:42 +0000 (23:10 +0100)]
finish the rename of availability_file into speed_file
Martin Quinson [Sat, 9 Feb 2019 21:57:13 +0000 (22:57 +0100)]
remove a useless example profile
Martin Quinson [Sat, 9 Feb 2019 16:52:32 +0000 (17:52 +0100)]
mv examples/platforms/two_hosts_platform_with_availability.xml examples/platforms/two_hosts_profiles.xml
Martin Quinson [Sat, 9 Feb 2019 16:44:08 +0000 (17:44 +0100)]
In <host> and <peer>, availability_file is now speed_file
Martin Quinson [Sat, 9 Feb 2019 16:36:37 +0000 (17:36 +0100)]
regenerate with Flex 2.6.4
Arnaud Giersch [Sat, 9 Feb 2019 14:39:44 +0000 (15:39 +0100)]
Tests {msg,s4u}-platform-failures seem to work as expected with threads and ucontexts.
Arnaud Giersch [Sat, 9 Feb 2019 14:39:44 +0000 (15:39 +0100)]
Update tesh files for {msg,s4u}-platform-failures.
Arnaud Giersch [Sat, 9 Feb 2019 14:39:44 +0000 (15:39 +0100)]
File has been renamed.
Arnaud Giersch [Sat, 9 Feb 2019 14:39:44 +0000 (15:39 +0100)]
Cosmetics.
Arnaud Giersch [Sat, 9 Feb 2019 14:39:44 +0000 (15:39 +0100)]
Add const attribute.
Arnaud Giersch [Sat, 9 Feb 2019 14:39:44 +0000 (15:39 +0100)]
Using cancel() seems to be the right way to do.
Frederic Suter [Fri, 8 Feb 2019 14:46:29 +0000 (15:46 +0100)]
cosmetics
Frederic Suter [Fri, 8 Feb 2019 13:41:37 +0000 (14:41 +0100)]
handle SleepImpl more like other activities
Frederic Suter [Fri, 8 Feb 2019 12:07:35 +0000 (13:07 +0100)]
better chaining
Frederic Suter [Fri, 8 Feb 2019 11:55:52 +0000 (12:55 +0100)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid
Frederic Suter [Fri, 8 Feb 2019 11:55:25 +0000 (12:55 +0100)]
namespace and method chaining for Io activities
Martin Quinson [Fri, 8 Feb 2019 11:17:05 +0000 (12:17 +0100)]
mv examples/platforms/trace examples/platforms/profiles
Frederic Suter [Fri, 8 Feb 2019 11:33:51 +0000 (12:33 +0100)]
allow and use method chaining for ExecImpl
Martin Quinson [Fri, 8 Feb 2019 11:11:33 +0000 (12:11 +0100)]
improve the doc of this example
Martin Quinson [Fri, 8 Feb 2019 10:55:17 +0000 (11:55 +0100)]
add an example of speed profile in the platform
Frederic Suter [Fri, 8 Feb 2019 11:09:52 +0000 (12:09 +0100)]
use namespaces for sake of readability
Frederic Suter [Fri, 8 Feb 2019 11:01:01 +0000 (12:01 +0100)]
replace SIMIX_execution_start by modern simcall
Martin Quinson [Fri, 8 Feb 2019 10:50:53 +0000 (11:50 +0100)]
fix misleading doc!
Martin Quinson [Fri, 8 Feb 2019 10:49:45 +0000 (11:49 +0100)]
new functions: Link::is_{on,off}()
Frederic Suter [Fri, 8 Feb 2019 10:02:26 +0000 (11:02 +0100)]
change_host -> set_host
Martin Quinson [Fri, 8 Feb 2019 09:33:29 +0000 (10:33 +0100)]
allow to set a profile to links and hosts from S4U
Arnaud Giersch [Wed, 6 Feb 2019 22:13:25 +0000 (23:13 +0100)]
Fix generation of graphical-toc.svg.
Attribute target="_top" was duplicated on line 6120.
Arnaud Giersch [Wed, 6 Feb 2019 17:12:29 +0000 (18:12 +0100)]
Update some URLs to simgrid.org.
Arnaud Giersch [Wed, 6 Feb 2019 17:01:48 +0000 (18:01 +0100)]
Fix URL for simgrid.dtd.
Arnaud Giersch [Wed, 6 Feb 2019 16:06:23 +0000 (17:06 +0100)]
Fix null pointer dereference spotted by scan-build.
Arnaud Giersch [Wed, 6 Feb 2019 13:53:51 +0000 (14:53 +0100)]
Assert that there is no memory leak (help scan-build).
Arnaud Giersch [Wed, 6 Feb 2019 13:53:19 +0000 (14:53 +0100)]
Rewrite smpi_copy_file() again.
Slightly improve commit
b618980c2b58d7347c8f9444dc63bbb3ae082e18.
Arnaud Giersch [Wed, 6 Feb 2019 08:56:44 +0000 (09:56 +0100)]
[codacy/cppcheck] Comment dead code (is_homogeneous is always true).
Frederic Suter [Wed, 6 Feb 2019 14:21:14 +0000 (15:21 +0100)]
factor suspend/resume across Activities
+ specific Activity can override (CommImpl and SynchroRaw do that)
+ current comments are pretty confusing
+ signals are now in ActivityImpl
Frederic Suter [Tue, 5 Feb 2019 21:03:17 +0000 (22:03 +0100)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid
Augustin Degomme [Tue, 5 Feb 2019 15:16:11 +0000 (16:16 +0100)]
requalify tesh
Augustin Degomme [Tue, 5 Feb 2019 15:10:11 +0000 (16:10 +0100)]
remove some codacy warnings
Arnaud Giersch [Tue, 5 Feb 2019 14:28:52 +0000 (15:28 +0100)]
With Icc, change bogus error into warning.
src/xbt/mallocator.c(49): error #2330: argument of type "atomic_flag *" is incompatible with parameter of type "volatile void *" (dropping qualifiers)
atomic_flag_clear(&m->lock);
^
Arnaud Giersch [Tue, 5 Feb 2019 13:09:11 +0000 (14:09 +0100)]
Plug memory leak.
Arnaud Giersch [Tue, 5 Feb 2019 13:01:13 +0000 (14:01 +0100)]
Provide our own main() for unit-tests.
The goal is to be able to use the --log=... command line parameters.
Arnaud Giersch [Wed, 7 Mar 2018 17:51:09 +0000 (18:51 +0100)]
Use C++11 std::atomic instead of gcc builtins.
NOTE: wrong type for futex operations (rude cast).
Arnaud Giersch [Tue, 5 Feb 2019 11:05:51 +0000 (12:05 +0100)]
Use C11 atomic_flag instead of gcc builtins.
Arnaud Giersch [Tue, 5 Feb 2019 11:03:30 +0000 (12:03 +0100)]
Update .mailmap.
Arnaud Giersch [Tue, 5 Feb 2019 10:21:35 +0000 (11:21 +0100)]
Cosmetics.
Undefined macros expand to zero anyway, and it avoids a cppcheck issue.
Arnaud Giersch [Tue, 5 Feb 2019 10:11:34 +0000 (11:11 +0100)]
Reduce scope for variable 'rank'.
Arnaud Giersch [Tue, 5 Feb 2019 10:10:45 +0000 (11:10 +0100)]
Cosmetic rewrite to please cppcheck.
Fix: Condition 'slow_copy' is always true.
Arnaud Giersch [Tue, 5 Feb 2019 09:47:52 +0000 (10:47 +0100)]
Reset pointer to make it clear for cppcheck that it's not freed twice.
Arnaud Giersch [Tue, 5 Feb 2019 09:41:19 +0000 (10:41 +0100)]
Initialized all struct members.
Currently not tested, but should fix smpi_shared_free().
Arnaud Giersch [Tue, 5 Feb 2019 09:36:53 +0000 (10:36 +0100)]
Cosmetic rewrite to please cppcheck.
Fix: Variable 'rem_size' is assigned a value that is never used.
Christian Heinrich [Tue, 5 Feb 2019 09:09:29 +0000 (10:09 +0100)]
[SMPI] Fix iprobe bound
While looping over iprobes, not the whole CPU can be used.
Frederic Suter [Mon, 4 Feb 2019 11:32:44 +0000 (12:32 +0100)]
SIMIX_process_change_host becomes ActorImpl::change_host
Frederic Suter [Mon, 4 Feb 2019 10:42:02 +0000 (11:42 +0100)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid
Arnaud Giersch [Mon, 4 Feb 2019 10:01:22 +0000 (11:01 +0100)]
[codacy/cppcheck] A few more issues.
Arnaud Giersch [Mon, 4 Feb 2019 10:01:22 +0000 (11:01 +0100)]
[codacy/cppcheck] A few more issues.
Arnaud Giersch [Mon, 4 Feb 2019 09:58:41 +0000 (10:58 +0100)]
Merge remote-tracking branch 'origin/master'
Frederic Suter [Mon, 4 Feb 2019 09:54:32 +0000 (10:54 +0100)]
fix clang builds
Arnaud Giersch [Mon, 4 Feb 2019 09:45:21 +0000 (10:45 +0100)]
Merge remote-tracking branch 'origin/master'
Arnaud Giersch [Mon, 4 Feb 2019 09:42:31 +0000 (10:42 +0100)]
[codacy/cppcheck] Potential memory leak.
Frederic Suter [Mon, 4 Feb 2019 09:40:30 +0000 (10:40 +0100)]
think about users
Arnaud Giersch [Mon, 4 Feb 2019 09:29:01 +0000 (10:29 +0100)]
[codacy/cppcheck] Fix: Variable is reassigned a value before the old one has been used.
Arnaud Giersch [Mon, 4 Feb 2019 09:24:31 +0000 (10:24 +0100)]
[codacy/cppcheck] Reduce scope for variables.
Arnaud Giersch [Mon, 4 Feb 2019 09:24:15 +0000 (10:24 +0100)]
[codacy] minor issues in shell scripts.
Arnaud Giersch [Mon, 4 Feb 2019 07:57:28 +0000 (08:57 +0100)]
codacy.yml: complete and sort exclusion list.
Alsot exclude python scripts for sphinx in docs/ subdirectory.
Arnaud Giersch [Sun, 3 Feb 2019 20:00:26 +0000 (21:00 +0100)]
[codacy] Add quotes around exclude paths in .codacy.yml.
Frederic Suter [Sun, 3 Feb 2019 19:25:08 +0000 (20:25 +0100)]
set_kill_time is a method of ActorImpl
Frederic Suter [Sun, 3 Feb 2019 18:51:40 +0000 (19:51 +0100)]
Engine is in charge of platform creation, not SIMIX anymore
Frederic Suter [Sun, 3 Feb 2019 17:11:54 +0000 (18:11 +0100)]
move code to the right place
Frederic Suter [Sun, 3 Feb 2019 17:08:36 +0000 (18:08 +0100)]
further cleaning in simcalls
Frederic Suter [Sun, 3 Feb 2019 16:22:53 +0000 (17:22 +0100)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid
Frederic Suter [Sun, 3 Feb 2019 16:22:30 +0000 (17:22 +0100)]
modern simcall for set_category
Frederic Suter [Sun, 3 Feb 2019 15:42:01 +0000 (16:42 +0100)]
allow all activities to set their tracing category
Frederic Suter [Sun, 3 Feb 2019 14:18:50 +0000 (15:18 +0100)]
modernize a few simcall_execution_* calls
Martin Quinson [Sun, 3 Feb 2019 14:57:04 +0000 (15:57 +0100)]
sanitize the OOP of kernel::profile
* Add a Profile::next() returning the next event of the list.
This opens the way to future profile kinds, based on statistical
generator instead of explicit lists.
Earlier, FES was advancing the internal pointer of the Profile.
* Change FutureEvtSet::add_trace(Profile, Resource) into Profile::schedule(FutureEvtSet, Resource).
This way, Profile knows about its FES and there is no need for a
global (also making testing easier), and FES does not have to mess
with the internals of Profile.
Martin Quinson [Sun, 3 Feb 2019 11:23:17 +0000 (12:23 +0100)]
Fix (old) clang builds
Martin Quinson [Sun, 3 Feb 2019 10:48:00 +0000 (11:48 +0100)]
Fix lua build
Martin Quinson [Sat, 2 Feb 2019 22:58:14 +0000 (23:58 +0100)]
sonar: simplify this code
Martin Quinson [Sat, 2 Feb 2019 21:44:10 +0000 (22:44 +0100)]
sonar: Replace this if-then-else statement by a single statement
Martin Quinson [Sat, 2 Feb 2019 17:13:16 +0000 (18:13 +0100)]
profile: cosmetics: inline a function and rename a variable
Martin Quinson [Sat, 2 Feb 2019 16:59:51 +0000 (17:59 +0100)]
s:k:profile: turn two functions into static methods
Martin Quinson [Sat, 2 Feb 2019 08:02:49 +0000 (09:02 +0100)]
align file position to the C++ namespaces