Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
Get rid of temporary vector of strings.
authorArnaud Giersch <arnaud.giersch@univ-fcomte.fr>
Mon, 11 Feb 2019 19:45:12 +0000 (20:45 +0100)
committerArnaud Giersch <arnaud.giersch@univ-fcomte.fr>
Tue, 12 Feb 2019 16:30:02 +0000 (17:30 +0100)
Save the unnecessary cost of its construction.

src/surf/sg_platf.cpp

index bc82d2d..a3b956a 100644 (file)
@@ -111,31 +111,31 @@ simgrid::kernel::routing::NetPoint* sg_platf_new_router(std::string name, const
   return netpoint;
 }
 
-void sg_platf_new_link(simgrid::kernel::routing::LinkCreationArgs* link)
+static void sg_platf_new_link(simgrid::kernel::routing::LinkCreationArgs* link, const std::string& link_name)
 {
-  std::vector<std::string> names;
+  simgrid::kernel::resource::LinkImpl* l =
+      surf_network_model->create_link(link_name, link->bandwidth, link->latency, link->policy);
 
-  if (link->policy == simgrid::s4u::Link::SharingPolicy::SPLITDUPLEX) {
-    names.push_back(link->id+ "_UP");
-    names.push_back(link->id+ "_DOWN");
-  } else {
-    names.push_back(link->id);
+  if (link->properties) {
+    for (auto const& elm : *link->properties)
+      l->set_property(elm.first, elm.second);
   }
-  for (auto const& link_name : names) {
-    simgrid::kernel::resource::LinkImpl* l =
-        surf_network_model->create_link(link_name, link->bandwidth, link->latency, link->policy);
 
-    if (link->properties) {
-      for (auto const& elm : *link->properties)
-        l->set_property(elm.first, elm.second);
-    }
+  if (link->latency_trace)
+    l->set_latency_profile(link->latency_trace);
+  if (link->bandwidth_trace)
+    l->set_bandwidth_profile(link->bandwidth_trace);
+  if (link->state_trace)
+    l->set_state_profile(link->state_trace);
+}
 
-    if (link->latency_trace)
-      l->set_latency_profile(link->latency_trace);
-    if (link->bandwidth_trace)
-      l->set_bandwidth_profile(link->bandwidth_trace);
-    if (link->state_trace)
-      l->set_state_profile(link->state_trace);
+void sg_platf_new_link(simgrid::kernel::routing::LinkCreationArgs* link)
+{
+  if (link->policy == simgrid::s4u::Link::SharingPolicy::SPLITDUPLEX) {
+    sg_platf_new_link(link, link->id + "_UP");
+    sg_platf_new_link(link, link->id + "_DOWN");
+  } else {
+    sg_platf_new_link(link, link->id);
   }
   delete link->properties;
 }