Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
7 months agoSlight simplification.
Arnaud Giersch [Sat, 20 Apr 2019 20:21:32 +0000 (22:21 +0200)]
Slight simplification.

7 months agoUse what was previously added, and fix broken tests
degomme [Tue, 23 Apr 2019 13:38:32 +0000 (15:38 +0200)]
Use what was previously added, and fix broken tests

7 months agoIf size read is 0 (eof), don't initiate faulty comm which will crash.
degomme [Tue, 23 Apr 2019 12:50:37 +0000 (14:50 +0200)]
If size read is 0 (eof), don't initiate faulty comm which will crash.

7 months agostorage : Allow to write inside a file without reducing its final size (for parallel IO)
degomme [Tue, 23 Apr 2019 12:49:51 +0000 (14:49 +0200)]
storage : Allow to write inside a file without reducing its final size (for parallel IO)

7 months agoMPI_File_get_size, MPI_File_get_amode, MPI_File_get_group, MPI_File_sync
degomme [Tue, 23 Apr 2019 12:48:50 +0000 (14:48 +0200)]
MPI_File_get_size, MPI_File_get_amode, MPI_File_get_group, MPI_File_sync

7 months agoComplete --help-logs.
Arnaud Giersch [Fri, 19 Apr 2019 20:34:54 +0000 (22:34 +0200)]
Complete --help-logs.

7 months agoNew log appenders stdout and stderr. Use stdout for xbt_help.
Arnaud Giersch [Fri, 19 Apr 2019 20:18:09 +0000 (22:18 +0200)]
New log appenders stdout and stderr. Use stdout for xbt_help.

7 months agotry to address comment made in FG#8
Frederic Suter [Fri, 19 Apr 2019 17:23:10 +0000 (19:23 +0200)]
try to address comment made in FG#8

7 months agoSet cfg=smpi/simulate-computation:no.
Arnaud Giersch [Fri, 19 Apr 2019 15:51:27 +0000 (17:51 +0200)]
Set cfg=smpi/simulate-computation:no.

7 months agoFix default MPI_Barrier.
Arnaud Giersch [Fri, 19 Apr 2019 13:40:05 +0000 (15:40 +0200)]
Fix default MPI_Barrier.

Mpich3 test comm_group_rand was sometimes failing.

7 months agoRevise to fool cppcheck.
Arnaud Giersch [Fri, 19 Apr 2019 12:19:12 +0000 (14:19 +0200)]
Revise to fool cppcheck.

7 months agofix test binary path
Frederic Suter [Fri, 19 Apr 2019 13:01:37 +0000 (15:01 +0200)]
fix test binary path

7 months agofixed issue
Frederic Suter [Fri, 19 Apr 2019 11:43:00 +0000 (13:43 +0200)]
fixed issue

7 months agoAdd a test for callback disconnection
Frederic Suter [Fri, 19 Apr 2019 11:38:01 +0000 (13:38 +0200)]
Add a test for callback disconnection

7 months agoAllow for callback disconnection
Frederic Suter [Fri, 19 Apr 2019 11:35:00 +0000 (13:35 +0200)]
Allow for callback disconnection

xbt::signal::connect now returns an unsigned int id and callbacks are
stored in a map <id, callback>.
a new xbt::signal::disconnect(unsigned int id) method has been added.

7 months agoFix build errors with gcc 5.4.0.
Arnaud Giersch [Fri, 19 Apr 2019 11:20:29 +0000 (13:20 +0200)]
Fix build errors with gcc 5.4.0.

7 months agoUse default destructor for resource::Model.
Arnaud Giersch [Fri, 19 Apr 2019 09:18:43 +0000 (11:18 +0200)]
Use default destructor for resource::Model.

7 months agoRemove empty functions
Arnaud Giersch [Fri, 19 Apr 2019 08:32:29 +0000 (10:32 +0200)]
Remove empty functions

7 months agoUse std::unique_ptr to manage memory.
Arnaud Giersch [Fri, 19 Apr 2019 08:08:05 +0000 (10:08 +0200)]
Use std::unique_ptr to manage memory.

7 months agoleaks --
degomme [Fri, 19 Apr 2019 09:10:35 +0000 (11:10 +0200)]
leaks --

7 months agofix issue seen on 34f5b82ed231ecce .
degomme [Fri, 19 Apr 2019 08:41:02 +0000 (10:41 +0200)]
fix issue seen on 34f5b82ed231ecce .
We were writing inside an existing file, reducing its size for the fs.
And then used_size was becoming <0, which for an unsigned is quite large.
This seems to point to another issue in storage, as used_size might not be initialized properly

7 months agofix io-shared (remove spurious ordered_read) and do write then read.
degomme [Fri, 19 Apr 2019 08:32:24 +0000 (10:32 +0200)]
fix io-shared (remove spurious ordered_read) and do write then read.

7 months agocheck for readonly flag before writing to a file.
degomme [Fri, 19 Apr 2019 07:59:52 +0000 (09:59 +0200)]
check for readonly flag before writing to a file.

7 months ago[sonar] kill commented code
Martin Quinson [Fri, 19 Apr 2019 09:29:14 +0000 (11:29 +0200)]
[sonar] kill commented code

7 months ago[sonar] define each identifiers on its line
Martin Quinson [Fri, 19 Apr 2019 09:23:08 +0000 (11:23 +0200)]
[sonar] define each identifiers on its line

7 months agonope sonar, that's not commented code
Martin Quinson [Fri, 19 Apr 2019 09:18:51 +0000 (11:18 +0200)]
nope sonar, that's not commented code

7 months agoplease sonar
Martin Quinson [Fri, 19 Apr 2019 08:41:01 +0000 (10:41 +0200)]
please sonar

7 months agodoc: 2 more internal references
Martin Quinson [Wed, 17 Apr 2019 15:00:26 +0000 (17:00 +0200)]
doc: 2 more internal references

7 months agofix GH#133
Frederic Suter [Fri, 19 Apr 2019 08:35:14 +0000 (10:35 +0200)]
fix GH#133
When a host is turned off, also shutwdown and turn off the VMs hosted
by this host. This is a rather crude patch that implies to browse the
whole list of existing VMs. A better solution requires a bit more work
and time

7 months agoplease sonar
Augustin Degomme [Thu, 18 Apr 2019 22:06:03 +0000 (00:06 +0200)]
please sonar

7 months agoUse std::vector instead of plain arrays in smpi_topo.
Arnaud Giersch [Thu, 18 Apr 2019 20:35:24 +0000 (22:35 +0200)]
Use std::vector instead of plain arrays in smpi_topo.

7 months agoRemove a level of indirection in sd::Global.
Arnaud Giersch [Thu, 18 Apr 2019 16:34:58 +0000 (18:34 +0200)]
Remove a level of indirection in sd::Global.

7 months agoTidy up mc/mc_unw a little.
Arnaud Giersch [Thu, 18 Apr 2019 16:22:17 +0000 (18:22 +0200)]
Tidy up mc/mc_unw a little.

7 months agoRemove custom destructors for instr/paje.
Arnaud Giersch [Thu, 18 Apr 2019 15:28:53 +0000 (17:28 +0200)]
Remove custom destructors for instr/paje.

7 months agoRemove a level of indirection, and custom destructors for instr/jedule.
Arnaud Giersch [Thu, 18 Apr 2019 13:41:45 +0000 (15:41 +0200)]
Remove a level of indirection, and custom destructors for instr/jedule.

7 months agoRemove custom destructors for s4u_Filesystem.
Arnaud Giersch [Thu, 18 Apr 2019 12:51:02 +0000 (14:51 +0200)]
Remove custom destructors for s4u_Filesystem.

7 months agoRestore warning for unit-less values.
Arnaud Giersch [Thu, 18 Apr 2019 12:16:17 +0000 (14:16 +0200)]
Restore warning for unit-less values.

7 months ago32 bits insists of having some timestamps off by 1us ... Hide them.
Augustin Degomme [Thu, 18 Apr 2019 20:24:17 +0000 (22:24 +0200)]
32 bits insists of having some timestamps off by 1us ... Hide them.
And fix my windows line endings mess.

7 months agobe cleaner with memory
Augustin Degomme [Thu, 18 Apr 2019 19:47:41 +0000 (21:47 +0200)]
be cleaner with memory

7 months agofix out of source builds
Augustin Degomme [Thu, 18 Apr 2019 18:40:29 +0000 (20:40 +0200)]
fix out of source builds

7 months agoplease clang
Augustin Degomme [Thu, 18 Apr 2019 18:37:29 +0000 (20:37 +0200)]
please clang

7 months agoMerge branch 'file' into 'master'
Augustin Degomme [Thu, 18 Apr 2019 18:19:09 +0000 (20:19 +0200)]
Merge branch 'file' into 'master'

MPI IO

See merge request simgrid/simgrid!6

7 months agotry to get rid of some variability
Augustin Degomme [Thu, 18 Apr 2019 17:19:22 +0000 (19:19 +0200)]
try to get rid of some variability

7 months agoadd hostfile as well for tests
Augustin Degomme [Thu, 18 Apr 2019 16:41:56 +0000 (18:41 +0200)]
add hostfile as well for tests

7 months agoChange how we lock things up ...
Augustin Degomme [Thu, 18 Apr 2019 15:54:40 +0000 (17:54 +0200)]
Change how we lock things up ...
MPI RMA seemed a god idea, but it just did not work.

7 months agoAdd some tests for io.
Augustin Degomme [Thu, 18 Apr 2019 11:40:58 +0000 (13:40 +0200)]
Add some tests for io.

7 months agoComment out a buggy line... Can't put a finger on what goes wrong here, but values...
Augustin Degomme [Thu, 18 Apr 2019 11:40:22 +0000 (13:40 +0200)]
Comment out a buggy line... Can't put a finger on what goes wrong here, but values seem insane and break all tests
TODO : investigate

7 months agocleanups debug messages for read_all write_all
Augustin Degomme [Thu, 18 Apr 2019 11:39:20 +0000 (13:39 +0200)]
cleanups debug messages for read_all write_all

7 months agocleanups
Augustin Degomme [Thu, 18 Apr 2019 11:37:43 +0000 (13:37 +0200)]
cleanups

7 months agoRevert "Inline Context::self()."
Arnaud Giersch [Thu, 18 Apr 2019 11:30:28 +0000 (13:30 +0200)]
Revert "Inline Context::self()."

This reverts commit 92061e0bc62b9a2ef3bdc041e5e9fe716ada1120.

It's failing on appveyor (mingw64) with:
C:\mingw-w64\x86_64-7.2.0-posix-seh-rt_v5-rev1\mingw64\bin\g++.exe    -g3 -O3 -funroll-loops -fno-strict-aliasing  -finline-functions  -fdebug-prefix-map=C:/projects/simgrid=. -static-libgcc -static-libstdc++ -Wl,--add-stdcall-alias -m64  -shared -o lib\libsimgrid-java.dll -Wl,--out-implib,lib\libsimgrid-java.dll.a -Wl,--major-image-version,3,--minor-image-version,22 -Wl,--whole-archive CMakeFiles\simgrid-java.dir/objects.a -Wl,--no-whole-archive @CMakeFiles\simgrid-java.dir\linklibs.rsp
CMakeFiles\simgrid-java.dir/objects.a(jmsg.cpp.obj):././src/bindings/java/jmsg.cpp:342: undefined reference to `__imp__ZTHN7simgrid6kernel7context7Context8current_E'
CMakeFiles\simgrid-java.dir/objects.a(jmsg.cpp.obj):././src/bindings/java/jmsg.cpp:342: undefined reference to `__imp__ZTHN7simgrid6kernel7context7Context8current_E'
CMakeFiles\simgrid-java.dir/objects.a(jmsg.cpp.obj):././src/bindings/java/jmsg.cpp:342: undefined reference to `__imp__ZTHN7simgrid6kernel7context7Context8current_E'
CMakeFiles\simgrid-java.dir/objects.a(JavaContext.cpp.obj):././src/bindings/java/JavaContext.cpp:81: undefined reference to `__imp__ZTHN7simgrid6kernel7context7Context8current_E'
collect2.exe: error: ld returned 1 exit status

7 months ago[sonar] Remove the use of "sprintf".
Arnaud Giersch [Thu, 18 Apr 2019 11:28:39 +0000 (13:28 +0200)]
[sonar] Remove the use of "sprintf".

7 months agoDefine PropertyHolder::set_properties.
Arnaud Giersch [Thu, 18 Apr 2019 09:45:34 +0000 (11:45 +0200)]
Define PropertyHolder::set_properties.

It allows to have a single simcall when setting many properties.

7 months agoConstify get_properties() and and remove simcalls.
Arnaud Giersch [Wed, 17 Apr 2019 21:21:48 +0000 (23:21 +0200)]
Constify get_properties() and and remove simcalls.

7 months agochange verbosity of some messages, to ease testing
Augustin Degomme [Wed, 17 Apr 2019 21:35:19 +0000 (23:35 +0200)]
change verbosity of some messages, to ease testing

7 months agocomments about implem
Augustin Degomme [Wed, 17 Apr 2019 21:34:16 +0000 (23:34 +0200)]
comments about implem

7 months ago[sonar] Remove custom destructors for surf/PropertyHolder.
Arnaud Giersch [Wed, 17 Apr 2019 21:05:36 +0000 (23:05 +0200)]
[sonar] Remove custom destructors for surf/PropertyHolder.

7 months agomove everything to the implemented zone.
Augustin Degomme [Wed, 17 Apr 2019 20:54:22 +0000 (22:54 +0200)]
move everything to the implemented zone.

7 months ago[sonar] Remove custom destructors for CpuTiProfile.
Arnaud Giersch [Wed, 17 Apr 2019 20:45:12 +0000 (22:45 +0200)]
[sonar] Remove custom destructors for CpuTiProfile.

7 months agoMPI_File_read_shared, MPI_File_write_shared, MPI_File_read_ordered, MPI_File_write_or...
Augustin Degomme [Wed, 17 Apr 2019 20:38:04 +0000 (22:38 +0200)]
MPI_File_read_shared, MPI_File_write_shared, MPI_File_read_ordered, MPI_File_write_ordered, MPI_File_seek_shared, MPI_File_get_position_shared

7 months agoUse std algorithm for binary search.
Arnaud Giersch [Wed, 17 Apr 2019 20:37:11 +0000 (22:37 +0200)]
Use std algorithm for binary search.

7 months agoMPI_File_set_info, MPI_File_get_info, MPI_File_get_position
Augustin Degomme [Wed, 17 Apr 2019 20:37:04 +0000 (22:37 +0200)]
MPI_File_set_info, MPI_File_get_info, MPI_File_get_position

7 months agoUseless smart pointer.
Arnaud Giersch [Wed, 17 Apr 2019 19:43:04 +0000 (21:43 +0200)]
Useless smart pointer.

7 months agoCosmetics.
Arnaud Giersch [Wed, 17 Apr 2019 19:31:37 +0000 (21:31 +0200)]
Cosmetics.

7 months agoTypo.
Arnaud Giersch [Wed, 17 Apr 2019 19:16:06 +0000 (21:16 +0200)]
Typo.

7 months agoUse the good interface.
Arnaud Giersch [Wed, 17 Apr 2019 19:13:32 +0000 (21:13 +0200)]
Use the good interface.

7 months agoSmart pointer is not necessary for Actor::self.
Arnaud Giersch [Wed, 17 Apr 2019 19:13:16 +0000 (21:13 +0200)]
Smart pointer is not necessary for Actor::self.

7 months agoInline Context::self().
Arnaud Giersch [Wed, 17 Apr 2019 19:03:36 +0000 (21:03 +0200)]
Inline Context::self().

7 months agoUniformize get_impl(): const attribute, and return raw pointer.
Arnaud Giersch [Wed, 17 Apr 2019 18:46:11 +0000 (20:46 +0200)]
Uniformize get_impl(): const attribute, and return raw pointer.

7 months agoMethods of simix::Global have direct access to their members.
Arnaud Giersch [Wed, 17 Apr 2019 10:55:08 +0000 (12:55 +0200)]
Methods of simix::Global have direct access to their members.

7 months ago[sonar] clean_action() called from destructor should not be overridable.
Arnaud Giersch [Wed, 10 Apr 2019 08:54:51 +0000 (10:54 +0200)]
[sonar] clean_action() called from destructor should not be overridable.

7 months agoRead_all, Write_all, Read_at_all, Write_at_all
Augustin Degomme [Wed, 17 Apr 2019 11:49:06 +0000 (13:49 +0200)]
Read_all, Write_all, Read_at_all, Write_at_all
Imperfect algorithm, needs to be tested

7 months agoRead_at, Write, Write_at
Augustin Degomme [Wed, 17 Apr 2019 11:46:28 +0000 (13:46 +0200)]
Read_at, Write, Write_at

7 months agoTest using macros for arguments checking, saves some duplicated lines.
Augustin Degomme [Wed, 17 Apr 2019 11:44:47 +0000 (13:44 +0200)]
Test using macros for arguments checking, saves some duplicated lines.

7 months agoDon't make exception on timeout.
Arnaud Giersch [Tue, 16 Apr 2019 12:08:42 +0000 (14:08 +0200)]
Don't make exception on timeout.

It breaks for example xbt_cond_timedwait which is expected to report timeout by
a regular return.

7 months agoDelete unused private function.
Arnaud Giersch [Mon, 15 Apr 2019 12:52:26 +0000 (14:52 +0200)]
Delete unused private function.

7 months ago[sonar] Remove custom destructors for routing/DragonflyZone.
Arnaud Giersch [Mon, 15 Apr 2019 12:32:52 +0000 (14:32 +0200)]
[sonar] Remove custom destructors for routing/DragonflyZone.

7 months ago[sonar] Remove custom destructors for surf/network_ib.
Arnaud Giersch [Mon, 15 Apr 2019 12:09:37 +0000 (14:09 +0200)]
[sonar] Remove custom destructors for surf/network_ib.

7 months ago[sonar] Remove custom destructors for xbt_replay.
Arnaud Giersch [Mon, 15 Apr 2019 10:01:10 +0000 (12:01 +0200)]
[sonar] Remove custom destructors for xbt_replay.

7 months ago[sonar] Remove custom destructors for examples/s4u/.
Arnaud Giersch [Mon, 15 Apr 2019 09:01:36 +0000 (11:01 +0200)]
[sonar] Remove custom destructors for examples/s4u/.

7 months agoread, seek + init
degomme [Mon, 15 Apr 2019 14:02:38 +0000 (16:02 +0200)]
read, seek + init
TODO: properly init plugin, only when needed.

8 months agoDon't explode here, as flatifier may try exactly to do this.
degomme [Mon, 15 Apr 2019 10:44:47 +0000 (12:44 +0200)]
Don't explode here, as flatifier may try exactly to do this.

8 months agofrench comment --
degomme [Mon, 15 Apr 2019 09:51:06 +0000 (11:51 +0200)]
french comment --

8 months agoAllow units in smpi factors.
degomme [Mon, 15 Apr 2019 09:12:48 +0000 (11:12 +0200)]
Allow units in smpi factors.
To make it optional (as parse_factor is used for actual factors and not only seconds on some occasions), remove the warning in surf if a unit-less value is used.

8 months agoAvoid returning uninitialized bytes in fortran processor names.
degomme [Wed, 10 Apr 2019 09:25:33 +0000 (11:25 +0200)]
Avoid returning uninitialized bytes in fortran processor names.

8 months agoSkeleton for MPI_IO
Augustin Degomme [Sun, 14 Apr 2019 23:53:02 +0000 (01:53 +0200)]
Skeleton for MPI_IO

8 months agoFix 32 bits build
Augustin Degomme [Sun, 14 Apr 2019 18:09:32 +0000 (20:09 +0200)]
Fix 32 bits build

8 months agoRevert "Reactivate an umpire test, once disabled in 56fefe1bf81ca."
Augustin Degomme [Sun, 14 Apr 2019 17:49:20 +0000 (19:49 +0200)]
Revert "Reactivate an umpire test, once disabled in 56fefe1bf81ca."

This reverts commit 1797da7d294b83c915fe49dad633855985eccb64.

8 months agodon't compile non working and non compiling test
Augustin Degomme [Sun, 14 Apr 2019 17:10:06 +0000 (19:10 +0200)]
don't compile non working and non compiling test

8 months agoPretend we support MPI 3.1.
Augustin Degomme [Sun, 14 Apr 2019 16:15:26 +0000 (18:15 +0200)]
Pretend we support MPI 3.1.
We don't support all of it, obviously, but what we have may be enough for some codes.

8 months agocomment tests we don't support in MPI3, and fix a few we support
Augustin Degomme [Sun, 14 Apr 2019 16:12:56 +0000 (18:12 +0200)]
comment tests we don't support in MPI3, and fix a few we support

8 months agoMPI_Count can be used in ops too.
Augustin Degomme [Sun, 14 Apr 2019 16:11:22 +0000 (18:11 +0200)]
MPI_Count can be used in ops too.

8 months agoMPI_INFO_ENV ... Still does nothing for now
Augustin Degomme [Sun, 14 Apr 2019 14:46:37 +0000 (16:46 +0200)]
MPI_INFO_ENV ... Still does nothing for now

8 months agoReactivate an umpire test, once disabled in 56fefe1bf81ca.
Augustin Degomme [Sun, 14 Apr 2019 14:09:43 +0000 (16:09 +0200)]
Reactivate an umpire test, once disabled in 56fefe1bf81ca.

8 months agoMPI_Comm_get_info, MPI_Comm_set_info
Augustin Degomme [Sun, 14 Apr 2019 14:08:37 +0000 (16:08 +0200)]
MPI_Comm_get_info, MPI_Comm_set_info

8 months agoSupport MPI3 datatype MPI_Count
Augustin Degomme [Sun, 14 Apr 2019 14:07:55 +0000 (16:07 +0200)]
Support MPI3 datatype MPI_Count

8 months agoplease sonar: replace void* by unsigned char* for raw buffer
Frederic Suter [Sat, 13 Apr 2019 15:50:40 +0000 (17:50 +0200)]
please sonar: replace void* by unsigned char* for raw buffer

8 months agoplease sonar
Frederic Suter [Sat, 13 Apr 2019 15:20:39 +0000 (17:20 +0200)]
please sonar

8 months agoyet another attempt to handle MPI special values in fortran
Augustin Degomme [Sat, 13 Apr 2019 10:57:10 +0000 (12:57 +0200)]
yet another attempt to handle MPI special values in fortran
Without dereferencing potentially unassigned variables.
Old way with a struct and common block does not work with dlopen provatization somehow.

8 months agomove CPU models to kernel::resource too
Frederic Suter [Fri, 12 Apr 2019 12:34:36 +0000 (14:34 +0200)]
move CPU models to kernel::resource too

8 months agocosmetic cleanups in network models
Frederic Suter [Fri, 12 Apr 2019 11:26:51 +0000 (13:26 +0200)]
cosmetic cleanups in network models