sonar prefers dupplicated code to missing breaks

And clangs agrees on this one.

diff --git a/src/surf/xml/surfxml_sax_cb.cpp b/src/surf/xml/surfxml_sax_cb.cpp
index 1652090..83073b4 100644 (file)
--- a/src/surf/xml/surfxml_sax_cb.cpp
+++ b/src/surf/xml/surfxml_sax_cb.cpp
@@ -504,7 +504,8 @@ void ETag_surfxml_cluster(){
     break;
   case A_surfxml_cluster_sharing___policy_FULLDUPLEX:
     XBT_WARN("FULLDUPLEX is now deprecated. Please update your platform file to use SPLITDUPLEX instead.");
     break;
   case A_surfxml_cluster_sharing___policy_FULLDUPLEX:
     XBT_WARN("FULLDUPLEX is now deprecated. Please update your platform file to use SPLITDUPLEX instead.");

-    /* no break: that's a fallback */
+    cluster.sharing_policy = SURF_LINK_SPLITDUPLEX;
+    break;

   case A_surfxml_cluster_sharing___policy_SPLITDUPLEX:
     cluster.sharing_policy = SURF_LINK_SPLITDUPLEX;
     break;
   case A_surfxml_cluster_sharing___policy_SPLITDUPLEX:
     cluster.sharing_policy = SURF_LINK_SPLITDUPLEX;
     break;


@@ -596,7 +597,8 @@ void ETag_surfxml_link(){
      break;
   case A_surfxml_link_sharing___policy_FULLDUPLEX:
     XBT_WARN("FULLDUPLEX is now deprecated. Please update your platform file to use SPLITDUPLEX instead.");
      break;
   case A_surfxml_link_sharing___policy_FULLDUPLEX:
     XBT_WARN("FULLDUPLEX is now deprecated. Please update your platform file to use SPLITDUPLEX instead.");

-    /* no break: that's a fallback */
+    link.policy = SURF_LINK_SPLITDUPLEX;
+    break;

   case A_surfxml_cluster_sharing___policy_SPLITDUPLEX:
     link.policy = SURF_LINK_SPLITDUPLEX;
     break;
   case A_surfxml_cluster_sharing___policy_SPLITDUPLEX:
     link.policy = SURF_LINK_SPLITDUPLEX;
     break;