Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
4 years agosonar prefers dupplicated code to missing breaks
Martin Quinson [Sun, 18 Feb 2018 14:53:04 +0000 (15:53 +0100)]
sonar prefers dupplicated code to missing breaks

And clangs agrees on this one.

4 years agofinish the s/FULLDUPLEX/SPLITDUPLEX/
Martin Quinson [Sun, 18 Feb 2018 12:07:34 +0000 (13:07 +0100)]
finish the s/FULLDUPLEX/SPLITDUPLEX/

4 years agos/FULLDUPLEX/SPLITDUPLEX/ in the documentation
Martin Quinson [Sun, 18 Feb 2018 10:51:40 +0000 (11:51 +0100)]
s/FULLDUPLEX/SPLITDUPLEX/ in the documentation

4 years agohte doc should not speak of AS anymore
Martin Quinson [Fri, 16 Feb 2018 23:27:06 +0000 (00:27 +0100)]
hte doc should not speak of AS anymore

4 years agos/fullduplex/splitduplex/ in platform parsing (backward compatible, with a warning)
Martin Quinson [Fri, 16 Feb 2018 22:52:47 +0000 (23:52 +0100)]
s/fullduplex/splitduplex/ in platform parsing (backward compatible, with a warning)

4 years agouse SPLITDUPLEX internally instead of FULLDUPLEX
Martin Quinson [Fri, 16 Feb 2018 20:50:47 +0000 (21:50 +0100)]
use SPLITDUPLEX internally instead of FULLDUPLEX

We will s/FULLDUPLEX/SPLITDUPLEX/ everywhere in SimGrid. Rational:

That sharing mode is modeled by spliting every link between two links:
one uplink used when traversing the link in a direction, and the
downlink when we traverse the same link in the other direction.

With SHARED links, the bandwidth is shared between all flows without
taking the flow direction into account.

So, SPLITDUPLEX is the way we model fullduplex links, but at the end,
each of the SimGrid link in a SPLITDUPLEX (either the up or down link)
can be used in one direction only. That's the right model, but using
FULLDUPLEX for the situation where you have 2 links was rather
disturbing.

And yes, users will soon notice, when they will try to use network
energy models.

4 years agoRevert "switch default smpi privatization to mmap, as tsan is now allergic to RTLD_DE...
Augustin Degomme [Fri, 16 Feb 2018 23:12:49 +0000 (00:12 +0100)]
Revert "switch default smpi privatization to mmap, as tsan is now allergic to RTLD_DEEPBIND"

This reverts commit c42ed4092ce78e88b5de1a4623c19d3d9d912d3d.

4 years agosonar: don't mask fields with parameters in Java
Martin Quinson [Fri, 16 Feb 2018 12:56:29 +0000 (13:56 +0100)]
sonar: don't mask fields with parameters in Java

4 years agosonar: dont escape LF in string literals
Martin Quinson [Fri, 16 Feb 2018 12:36:51 +0000 (13:36 +0100)]
sonar: dont escape LF in string literals

4 years agosonar: don't use auto for pointers, but auto*
Martin Quinson [Fri, 16 Feb 2018 12:33:44 +0000 (13:33 +0100)]
sonar: don't use auto for pointers, but auto*

4 years agodon't use deepbind in cases it's not needed (I think)
degomme [Fri, 16 Feb 2018 10:00:00 +0000 (11:00 +0100)]
don't use deepbind in cases it's not needed (I think)

4 years agoswitch default smpi privatization to mmap, as tsan is now allergic to RTLD_DEEPBIND
degomme [Fri, 16 Feb 2018 09:01:47 +0000 (10:01 +0100)]
switch default smpi privatization to mmap, as tsan is now allergic to RTLD_DEEPBIND
This should not work for the -dlopen tests, but it should be better

4 years agowoops, bash typo
Martin Quinson [Fri, 16 Feb 2018 06:57:23 +0000 (07:57 +0100)]
woops, bash typo

And cleanup before installation

4 years agoplease MC builds, don't install your stuff
Martin Quinson [Wed, 14 Feb 2018 22:48:07 +0000 (23:48 +0100)]
please MC builds, don't install your stuff

4 years agotry to reduce the amount of warnings in StarPU compilation
Martin Quinson [Wed, 14 Feb 2018 19:23:01 +0000 (20:23 +0100)]
try to reduce the amount of warnings in StarPU compilation

4 years ago[DVFS] Clean up the mess I made before; move to unique_ptr
Christian Heinrich [Wed, 14 Feb 2018 10:35:08 +0000 (11:35 +0100)]
[DVFS] Clean up the mess I made before; move to unique_ptr

4 years ago[DVFS] Move plugin::HostDvfs to plugin::dvfs::HostDvfs
Christian Heinrich [Tue, 13 Feb 2018 16:30:59 +0000 (17:30 +0100)]
[DVFS] Move plugin::HostDvfs to plugin::dvfs::HostDvfs

4 years ago[DVFS] Make debug statement more verbose
Christian Heinrich [Tue, 13 Feb 2018 16:30:28 +0000 (17:30 +0100)]
[DVFS] Make debug statement more verbose

4 years ago[DVFS] Added 'override' specifier
Christian Heinrich [Tue, 13 Feb 2018 16:29:51 +0000 (17:29 +0100)]
[DVFS] Added 'override' specifier

4 years ago[KERNEL] Simple spelling fix
Christian Heinrich [Mon, 12 Feb 2018 16:31:40 +0000 (17:31 +0100)]
[KERNEL] Simple spelling fix

4 years ago[PLUGIN] Remove local variable and comment in host_load.cpp
Christian Heinrich [Thu, 8 Feb 2018 10:07:30 +0000 (11:07 +0100)]
[PLUGIN] Remove local variable and comment in host_load.cpp

4 years ago[DVFS] Cosmetics as proposed by clang-format
Christian Heinrich [Wed, 7 Feb 2018 13:18:07 +0000 (14:18 +0100)]
[DVFS] Cosmetics as proposed by clang-format

4 years ago[DVFS] Make governors individually configurable for each host
Christian Heinrich [Wed, 7 Feb 2018 13:16:10 +0000 (14:16 +0100)]
[DVFS] Make governors individually configurable for each host

Add this to your host tag:
  - <prop id=plugin/dvfs/governor value=performance />

Valid values as of now are: performance, powersave, ondemand, conservative
It doesn't matter if you use uppercase or lowercase.

For the sampling rate, use this:

  - <prop id=plugin/dvfs/sampling_rate value=2 />

This will run the update() method of the specified governor every 2 seconds
on that host.

These properties can also be used within the <config> tag to configure
these values globally. Using them within the <host> will overwrite this
global configuration

4 years ago[DVFS] Add/change debug statements for dvfs governors
Christian Heinrich [Wed, 7 Feb 2018 13:07:01 +0000 (14:07 +0100)]
[DVFS] Add/change debug statements for dvfs governors

4 years ago[DVFS] Use local variable for pstate computation
Christian Heinrich [Wed, 7 Feb 2018 13:07:37 +0000 (14:07 +0100)]
[DVFS] Use local variable for pstate computation

4 years ago[DVFS] Fix load calculation for Dvfs governors
Christian Heinrich [Wed, 7 Feb 2018 12:54:21 +0000 (13:54 +0100)]
[DVFS] Fix load calculation for Dvfs governors

The HostLoad plugin computes the load as <cores used>/<cores total>.
This means that governors sometimes decide to slow down even though
one or several cores were used because too many cores were unused.

4 years ago[ENERGY] The energy now depends on the HostLoad plugin.
Christian Heinrich [Tue, 6 Feb 2018 15:50:52 +0000 (16:50 +0100)]
[ENERGY] The energy now depends on the HostLoad plugin.

When a pstate is changed, the energy plugin will update a timestamp for that
host even if that host is never used; this means that we cannot rely on this
to determine if a host has been idle or not. The HostLoad plugin allows
us to do that.

This commit also updates several tesh files as some hosts were reported
as active in the past although they have not computed anything. These
hosts were hence idle and should be reported as such; a machine that
only boots or shuts down is in this case also regarded as unused.

4 years ago[HostLoad] Load is currently 0 because of integer division. Fix that.
Christian Heinrich [Wed, 7 Feb 2018 13:22:20 +0000 (14:22 +0100)]
[HostLoad] Load is currently 0 because of integer division. Fix that.

4 years ago[HostLoad] Ignore VM's ...
Christian Heinrich [Tue, 13 Feb 2018 18:50:11 +0000 (19:50 +0100)]
[HostLoad] Ignore VM's ...

4 years ago[SURF] Move Action::suspended_ to new enum class SuspendedStates
Christian Heinrich [Tue, 13 Feb 2018 16:41:52 +0000 (17:41 +0100)]
[SURF] Move Action::suspended_ to new enum class SuspendedStates

4 years agojenkins: install everything after testing
Martin Quinson [Mon, 12 Feb 2018 16:44:26 +0000 (17:44 +0100)]
jenkins: install everything after testing

4 years agocosmetics
Martin Quinson [Thu, 8 Feb 2018 22:04:15 +0000 (23:04 +0100)]
cosmetics

4 years agorename two files in examples
degomme [Tue, 13 Feb 2018 14:24:34 +0000 (15:24 +0100)]
rename two files in examples
Other files have the same name elsewhere, and this confuses coverage tool in sonar

4 years agoFix MC builds.
Arnaud Giersch [Tue, 13 Feb 2018 10:28:00 +0000 (11:28 +0100)]
Fix MC builds.

4 years agoKill unused function simgrid::xbt::three_way_partition().
Arnaud Giersch [Tue, 13 Feb 2018 09:51:10 +0000 (10:51 +0100)]
Kill unused function simgrid::xbt::three_way_partition().

4 years agoKill unused private function mmalloc_get_increment().
Arnaud Giersch [Tue, 13 Feb 2018 09:45:33 +0000 (10:45 +0100)]
Kill unused private function mmalloc_get_increment().

4 years agoKill unused private function MC_dwarf_at_linkage_name().
Arnaud Giersch [Tue, 13 Feb 2018 09:38:46 +0000 (10:38 +0100)]
Kill unused private function MC_dwarf_at_linkage_name().

4 years agoKill unused private function MC_compare_frame_index_items().
Arnaud Giersch [Tue, 13 Feb 2018 09:34:53 +0000 (10:34 +0100)]
Kill unused private function MC_compare_frame_index_items().

4 years agoKill unused function surf_parse_warn().
Arnaud Giersch [Mon, 12 Feb 2018 23:10:21 +0000 (00:10 +0100)]
Kill unused function surf_parse_warn().

4 years agoKill useless include files.
Arnaud Giersch [Mon, 12 Feb 2018 22:49:29 +0000 (23:49 +0100)]
Kill useless include files.

4 years agoKill unused function instr_platform_traced().
Arnaud Giersch [Mon, 12 Feb 2018 22:39:46 +0000 (23:39 +0100)]
Kill unused function instr_platform_traced().

4 years agoKill unused function get_java_VM().
Arnaud Giersch [Mon, 12 Feb 2018 22:36:06 +0000 (23:36 +0100)]
Kill unused function get_java_VM().

4 years agoKill unused function TRACE_surf_action().
Arnaud Giersch [Mon, 12 Feb 2018 22:27:04 +0000 (23:27 +0100)]
Kill unused function TRACE_surf_action().

4 years agoKill unused private variable surf_action_state_names[].
Arnaud Giersch [Mon, 12 Feb 2018 22:01:33 +0000 (23:01 +0100)]
Kill unused private variable surf_action_state_names[].

4 years agoFunction smpi_process_papi_counters() was renamed (untested).
Arnaud Giersch [Mon, 12 Feb 2018 21:55:23 +0000 (22:55 +0100)]
Function smpi_process_papi_counters() was renamed (untested).

4 years agoKill unused private functions instr_{pause,resume}_tracing().
Arnaud Giersch [Mon, 12 Feb 2018 21:44:59 +0000 (22:44 +0100)]
Kill unused private functions instr_{pause,resume}_tracing().

4 years agoFIXME: TRACE_smpi_sleeping_init() is never called.
Arnaud Giersch [Mon, 12 Feb 2018 21:39:49 +0000 (22:39 +0100)]
FIXME: TRACE_smpi_sleeping_init() is never called.

4 years agoRemove unused run-time parameter "tracing/onelink-only".
Arnaud Giersch [Mon, 12 Feb 2018 21:33:23 +0000 (22:33 +0100)]
Remove unused run-time parameter "tracing/onelink-only".

4 years agoKill unused private function SIMIX_process_get_by_name().
Arnaud Giersch [Mon, 12 Feb 2018 21:18:05 +0000 (22:18 +0100)]
Kill unused private function SIMIX_process_get_by_name().

4 years agoKill unused private function SIMIX_process_exception_terminate().
Arnaud Giersch [Mon, 12 Feb 2018 21:14:35 +0000 (22:14 +0100)]
Kill unused private function SIMIX_process_exception_terminate().

4 years agoKill function declarations without definitions.
Arnaud Giersch [Mon, 12 Feb 2018 21:12:23 +0000 (22:12 +0100)]
Kill function declarations without definitions.

4 years agoKill unused private function MC_snapshot_memcmp().
Arnaud Giersch [Mon, 12 Feb 2018 21:08:11 +0000 (22:08 +0100)]
Kill unused private function MC_snapshot_memcmp().

4 years agoHostAction was killed a long time ago.
Arnaud Giersch [Mon, 12 Feb 2018 21:03:20 +0000 (22:03 +0100)]
HostAction was killed a long time ago.

4 years agomore C++ around ns3
Martin Quinson [Thu, 8 Feb 2018 21:55:46 +0000 (22:55 +0100)]
more C++ around ns3

4 years agocallbacks are actually meant for external users to use
Martin Quinson [Wed, 7 Feb 2018 16:24:29 +0000 (17:24 +0100)]
callbacks are actually meant for external users to use

4 years agoMerge branch 'master' of scm.gforge.inria.fr:/gitroot/simgrid/simgrid
Martin Quinson [Wed, 7 Feb 2018 10:24:51 +0000 (11:24 +0100)]
Merge branch 'master' of scm.gforge.inria.fr:/gitroot/simgrid/simgrid

4 years agoAdd virtual destructor.
Arnaud Giersch [Wed, 7 Feb 2018 10:12:27 +0000 (11:12 +0100)]
Add virtual destructor.

4 years agoRemove semicolon (No, Sonar, it's not commented code).
Arnaud Giersch [Wed, 7 Feb 2018 10:09:41 +0000 (11:09 +0100)]
Remove semicolon (No, Sonar, it's not commented code).

4 years agoEXIT_SUCCESS/EXIT_FAILURE are standard C defined in stdlib.h.
Arnaud Giersch [Wed, 7 Feb 2018 09:39:29 +0000 (10:39 +0100)]
EXIT_SUCCESS/EXIT_FAILURE are standard C defined in stdlib.h.

4 years agoPlease scan-build.
Arnaud Giersch [Tue, 6 Feb 2018 15:59:56 +0000 (16:59 +0100)]
Please scan-build.

4 years agoInform scan-build that (bucket_id + i) cannot wrap around.
Arnaud Giersch [Tue, 6 Feb 2018 15:51:33 +0000 (16:51 +0100)]
Inform scan-build that (bucket_id + i) cannot wrap around.

4 years agoRemove unused variable.
Arnaud Giersch [Tue, 6 Feb 2018 15:06:25 +0000 (16:06 +0100)]
Remove unused variable.

4 years ago[doc] fix link to Sonar dashboard
Millian Poquet [Tue, 6 Feb 2018 10:34:47 +0000 (11:34 +0100)]
[doc] fix link to Sonar dashboard

4 years agosonar don't like to have commented code, so hide it a bit
Martin Quinson [Tue, 6 Feb 2018 09:15:47 +0000 (10:15 +0100)]
sonar don't like to have commented code, so hide it a bit

4 years agoFix distcheck.
Arnaud Giersch [Mon, 5 Feb 2018 21:00:35 +0000 (22:00 +0100)]
Fix distcheck.

4 years agoUpdate ChangeLog.
Arnaud Giersch [Mon, 5 Feb 2018 17:51:32 +0000 (18:51 +0100)]
Update ChangeLog.

4 years agoRemove now unused smpi::Process::return_value.
Arnaud Giersch [Mon, 5 Feb 2018 17:35:29 +0000 (18:35 +0100)]
Remove now unused smpi::Process::return_value.

4 years agoUse explicit extern "C" in cpp file.
Arnaud Giersch [Mon, 5 Feb 2018 20:34:10 +0000 (21:34 +0100)]
Use explicit extern "C" in cpp file.

4 years agoMake constructors explicit.
Arnaud Giersch [Mon, 5 Feb 2018 20:30:23 +0000 (21:30 +0100)]
Make constructors explicit.

4 years agoParameter is not used.
Arnaud Giersch [Mon, 5 Feb 2018 17:32:57 +0000 (18:32 +0100)]
Parameter is not used.

4 years agoFix build with MC (simgrid::xbt::string).
Arnaud Giersch [Mon, 5 Feb 2018 17:31:26 +0000 (18:31 +0100)]
Fix build with MC (simgrid::xbt::string).

4 years agofix build of dvfs plugin with warning enabled
Martin Quinson [Mon, 5 Feb 2018 20:36:13 +0000 (21:36 +0100)]
fix build of dvfs plugin with warning enabled

4 years agoRescue cleanups lost with commit 8914cdf67bb2cdd7b64e6eeef5b06c29b24c3c96.
Arnaud Giersch [Mon, 5 Feb 2018 16:06:25 +0000 (17:06 +0100)]
Rescue cleanups lost with commit 8914cdf67bb2cdd7b64e6eeef5b06c29b24c3c96.

4 years ago[DVFS] Cosmetics / indent as suggested by clang-format
Christian Heinrich [Mon, 5 Feb 2018 13:54:58 +0000 (14:54 +0100)]
[DVFS] Cosmetics / indent as suggested by clang-format

4 years ago[DVFS] Remove MSG from DVFS plugin and make it more flexible
Christian Heinrich [Mon, 5 Feb 2018 13:53:47 +0000 (14:53 +0100)]
[DVFS] Remove MSG from DVFS plugin and make it more flexible

The option plugin/dvfs/governor is now available and can be set on a per-host basis

4 years ago[DVFS] Rephrase debug statements
Christian Heinrich [Mon, 5 Feb 2018 13:51:49 +0000 (14:51 +0100)]
[DVFS] Rephrase debug statements

4 years ago[PLUGINS] Initial commit for the Dvfs plugin (frequency governors)
Christian Heinrich [Sun, 28 Jan 2018 15:10:21 +0000 (16:10 +0100)]
[PLUGINS] Initial commit for the Dvfs plugin (frequency governors)

4 years ago[SMPI] Fix issues with daemons by using isDaemon()
Christian Heinrich [Sun, 28 Jan 2018 15:12:11 +0000 (16:12 +0100)]
[SMPI] Fix issues with daemons by using isDaemon()

4 years ago[S4U API] Expose the isDaemon() function to the API
Christian Heinrich [Sun, 28 Jan 2018 15:11:45 +0000 (16:11 +0100)]
[S4U API] Expose the isDaemon() function to the API

4 years ago[SMPI] Clarify in debug message that SMPI processes are meant, not SIMIX.
Christian Heinrich [Sun, 28 Jan 2018 15:12:52 +0000 (16:12 +0100)]
[SMPI] Clarify in debug message that SMPI processes are meant, not SIMIX.

4 years ago[CHANGELOG] Added brief description on the privatization changes
Christian Heinrich [Thu, 25 Jan 2018 19:32:03 +0000 (20:32 +0100)]
[CHANGELOG] Added brief description on the privatization changes

4 years agoCosmetics: get rid of stringstream.
Arnaud Giersch [Thu, 25 Jan 2018 11:31:43 +0000 (12:31 +0100)]
Cosmetics: get rid of stringstream.

4 years agoFix comment.
Arnaud Giersch [Wed, 24 Jan 2018 20:45:19 +0000 (21:45 +0100)]
Fix comment.

4 years agoDisable unused copy constructors (and please cppcheck).
Arnaud Giersch [Thu, 18 Jan 2018 09:21:13 +0000 (10:21 +0100)]
Disable unused copy constructors (and please cppcheck).

4 years agoCorrectly get the exit status for smpi processes.
Arnaud Giersch [Mon, 5 Feb 2018 15:34:41 +0000 (16:34 +0100)]
Correctly get the exit status for smpi processes.

4 years agoSearch in map only once.
Arnaud Giersch [Mon, 5 Feb 2018 15:34:23 +0000 (16:34 +0100)]
Search in map only once.

4 years agoKill dead code.
Arnaud Giersch [Mon, 5 Feb 2018 15:18:08 +0000 (16:18 +0100)]
Kill dead code.

process_data is empty a this point.

4 years agoRevert "Revert "actually fix the memleak around smpi's process_data" and "try to...
Arnaud Giersch [Mon, 5 Feb 2018 15:15:21 +0000 (16:15 +0100)]
Revert "Revert "actually fix the memleak around smpi's process_data" and "try to plug a memleak""

This reverts commit c7c5def2870e604025be03b866967c0c5e293afe.

4 years agoRevert "Finally fix memleak."
Arnaud Giersch [Mon, 5 Feb 2018 15:15:19 +0000 (16:15 +0100)]
Revert "Finally fix memleak."

This reverts commit aad6442f8fd7d7610f49271010cb8a650f4772de.

4 years agoFinally fix memleak.
Arnaud Giersch [Sun, 4 Feb 2018 21:26:36 +0000 (22:26 +0100)]
Finally fix memleak.

4 years agoRevert "actually fix the memleak around smpi's process_data" and "try to plug a memleak"
Arnaud Giersch [Sun, 4 Feb 2018 14:50:54 +0000 (15:50 +0100)]
Revert "actually fix the memleak around smpi's process_data" and "try to plug a memleak"

This reverts commit 3c40b1bfc4f4925fa401d3b5d0c74a4b4824b3d5
and commit d53a2108a1ea38b2f952abb48c39730ccc91c2a8.

4 years agoinline a oneliner
Martin Quinson [Sat, 3 Feb 2018 21:36:23 +0000 (22:36 +0100)]
inline a oneliner

4 years agoplug another memleak
Martin Quinson [Sat, 3 Feb 2018 21:36:10 +0000 (22:36 +0100)]
plug another memleak

4 years agoactually fix the memleak around smpi's process_data
Martin Quinson [Sat, 3 Feb 2018 21:26:25 +0000 (22:26 +0100)]
actually fix the memleak around smpi's process_data

- Call Actor::onDestruction from the right location
- Have SMPI only destroy the process data of its own processes (not of MSG ones)
- Make sure that the process created with MSG_process_attach() have
  the right refcount since we now use a smart pointer on it: we don't
  want it to get freed too early.

4 years agoobey our coding style
Martin Quinson [Sat, 3 Feb 2018 21:25:37 +0000 (22:25 +0100)]
obey our coding style

4 years agotry to plug a memleak
Martin Quinson [Fri, 2 Feb 2018 21:52:51 +0000 (22:52 +0100)]
try to plug a memleak

4 years agoPick the best available clang-format version
Martin Quinson [Thu, 1 Feb 2018 22:02:18 +0000 (23:02 +0100)]
Pick the best available clang-format version

and also, update copyright info

4 years ago[misc, doc] clang-format pre-commit hook cleanup
Millian Poquet [Thu, 1 Feb 2018 17:02:52 +0000 (18:02 +0100)]
[misc, doc] clang-format pre-commit hook cleanup

The previous script only worked on (old) debian.
This version should work with:
- more versions of clang-format
- more distribs (tested on arch)

Furthermore, I did some cleanup on the script and its doc

4 years ago[#!] #! ./tesh -> #!/usr/bin/env tesh
Millian Poquet [Thu, 1 Feb 2018 12:48:56 +0000 (13:48 +0100)]
[#!] #! ./tesh -> #!/usr/bin/env tesh

find . \
    -type f \
    -not -iwholename '*.git*' \
    -exec sed -i -e 'sW#!\s*\./teshW#!/usr/bin/env teshWg' {} \;

4 years ago[#!] #! tesh -> #!/usr/bin/env tesh
Millian Poquet [Thu, 1 Feb 2018 12:45:27 +0000 (13:45 +0100)]
[#!] #! tesh -> #!/usr/bin/env tesh

find . \
    -type f \
    -not -iwholename '*.git*' \
    -exec sed -i -e 'sW#!\s*teshW#!/usr/bin/env teshWg' {} \;