From: Martin Quinson <martin.quinson@loria.fr>
Date: Sun, 18 Feb 2018 14:53:04 +0000 (+0100)
Subject: sonar prefers dupplicated code to missing breaks
X-Git-Tag: v3.19~189
X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/commitdiff_plain/cc05a6b37aefdf463cac0fe88a8c8cb1d7d72eda?ds=sidebyside

sonar prefers dupplicated code to missing breaks

And clangs agrees on this one.
---

diff --git a/src/surf/xml/surfxml_sax_cb.cpp b/src/surf/xml/surfxml_sax_cb.cpp
index 16520908f3..83073b4f0f 100644
--- a/src/surf/xml/surfxml_sax_cb.cpp
+++ b/src/surf/xml/surfxml_sax_cb.cpp
@@ -504,7 +504,8 @@ void ETag_surfxml_cluster(){
     break;
   case A_surfxml_cluster_sharing___policy_FULLDUPLEX:
     XBT_WARN("FULLDUPLEX is now deprecated. Please update your platform file to use SPLITDUPLEX instead.");
-    /* no break: that's a fallback */
+    cluster.sharing_policy = SURF_LINK_SPLITDUPLEX;
+    break;
   case A_surfxml_cluster_sharing___policy_SPLITDUPLEX:
     cluster.sharing_policy = SURF_LINK_SPLITDUPLEX;
     break;
@@ -596,7 +597,8 @@ void ETag_surfxml_link(){
      break;
   case A_surfxml_link_sharing___policy_FULLDUPLEX:
     XBT_WARN("FULLDUPLEX is now deprecated. Please update your platform file to use SPLITDUPLEX instead.");
-    /* no break: that's a fallback */
+    link.policy = SURF_LINK_SPLITDUPLEX;
+    break;
   case A_surfxml_cluster_sharing___policy_SPLITDUPLEX:
     link.policy = SURF_LINK_SPLITDUPLEX;
     break;