From cc05a6b37aefdf463cac0fe88a8c8cb1d7d72eda Mon Sep 17 00:00:00 2001 From: Martin Quinson Date: Sun, 18 Feb 2018 15:53:04 +0100 Subject: [PATCH] sonar prefers dupplicated code to missing breaks And clangs agrees on this one. --- src/surf/xml/surfxml_sax_cb.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/surf/xml/surfxml_sax_cb.cpp b/src/surf/xml/surfxml_sax_cb.cpp index 16520908f3..83073b4f0f 100644 --- a/src/surf/xml/surfxml_sax_cb.cpp +++ b/src/surf/xml/surfxml_sax_cb.cpp @@ -504,7 +504,8 @@ void ETag_surfxml_cluster(){ break; case A_surfxml_cluster_sharing___policy_FULLDUPLEX: XBT_WARN("FULLDUPLEX is now deprecated. Please update your platform file to use SPLITDUPLEX instead."); - /* no break: that's a fallback */ + cluster.sharing_policy = SURF_LINK_SPLITDUPLEX; + break; case A_surfxml_cluster_sharing___policy_SPLITDUPLEX: cluster.sharing_policy = SURF_LINK_SPLITDUPLEX; break; @@ -596,7 +597,8 @@ void ETag_surfxml_link(){ break; case A_surfxml_link_sharing___policy_FULLDUPLEX: XBT_WARN("FULLDUPLEX is now deprecated. Please update your platform file to use SPLITDUPLEX instead."); - /* no break: that's a fallback */ + link.policy = SURF_LINK_SPLITDUPLEX; + break; case A_surfxml_cluster_sharing___policy_SPLITDUPLEX: link.policy = SURF_LINK_SPLITDUPLEX; break; -- 2.20.1