Christian Heinrich [Fri, 3 Nov 2017 13:18:39 +0000 (14:18 +0100)]
[SMPI] Elaborated on comment
Christian Heinrich [Thu, 2 Nov 2017 10:16:34 +0000 (11:16 +0100)]
[SMPI] Move all 3 MPI_Comm getters together
Christian Heinrich [Tue, 31 Oct 2017 14:13:52 +0000 (15:13 +0100)]
[SMPI] Fixed style
Frederic Suter [Fri, 3 Nov 2017 09:50:20 +0000 (10:50 +0100)]
more protected->private fields
Arnaud Giersch [Thu, 2 Nov 2017 17:24:46 +0000 (18:24 +0100)]
Hopefully resolve ambiguity on osx too.
Arnaud Giersch [Thu, 2 Nov 2017 17:02:42 +0000 (18:02 +0100)]
Some compilers need an explicit constructor.
Arnaud Giersch [Thu, 2 Nov 2017 16:13:06 +0000 (17:13 +0100)]
Use a map and generator to handle units.
Arnaud Giersch [Thu, 2 Nov 2017 15:57:32 +0000 (16:57 +0100)]
Sonar: make return type of lambdas implicit.
Arnaud Giersch [Wed, 1 Nov 2017 16:15:29 +0000 (17:15 +0100)]
Sonar smells of the day.
Arnaud Giersch [Wed, 1 Nov 2017 16:09:04 +0000 (17:09 +0100)]
Remove old commented declaration.
Arnaud Giersch [Wed, 1 Nov 2017 15:31:57 +0000 (16:31 +0100)]
Remove empty destructor.
Frederic Suter [Thu, 2 Nov 2017 14:13:27 +0000 (15:13 +0100)]
prevent infinite recursion with clang
Frederic Suter [Thu, 2 Nov 2017 11:21:20 +0000 (12:21 +0100)]
use (existing) accessors to make protected fields private
Frederic Suter [Thu, 2 Nov 2017 09:53:38 +0000 (10:53 +0100)]
simplify link events and rename getRootContainer to getRoot
Arnaud Giersch [Wed, 1 Nov 2017 14:26:25 +0000 (15:26 +0100)]
Fix memory leaks.
Arnaud Giersch [Wed, 1 Nov 2017 14:13:39 +0000 (15:13 +0100)]
Use a vector for index_to_rank_map_ too.
Arnaud Giersch [Wed, 1 Nov 2017 13:18:22 +0000 (14:18 +0100)]
Make field private.
Arnaud Giersch [Wed, 1 Nov 2017 09:14:09 +0000 (10:14 +0100)]
Use explicit atomic operations.
Arnaud Giersch [Wed, 1 Nov 2017 09:02:01 +0000 (10:02 +0100)]
Remove unused typedef.
Arnaud Giersch [Wed, 1 Nov 2017 08:50:26 +0000 (09:50 +0100)]
Remove unused parameter.
Arnaud Giersch [Wed, 1 Nov 2017 08:48:02 +0000 (09:48 +0100)]
Sonar: extract assignment from expression.
Arnaud Giersch [Wed, 1 Nov 2017 08:27:18 +0000 (09:27 +0100)]
Remove useless typedefs.
Arnaud Giersch [Wed, 1 Nov 2017 08:26:50 +0000 (09:26 +0100)]
Remove redundant conditional.
Arnaud Giersch [Tue, 31 Oct 2017 22:28:14 +0000 (23:28 +0100)]
Replace legacy __sync* builtins by __atomic*.
Arnaud Giersch [Tue, 31 Oct 2017 21:58:37 +0000 (22:58 +0100)]
Reduce code duplication (untested).
Arnaud Giersch [Tue, 31 Oct 2017 21:13:36 +0000 (22:13 +0100)]
Factorize code.
Arnaud Giersch [Tue, 31 Oct 2017 17:23:39 +0000 (18:23 +0100)]
Use a static map for dwarf attr and tag names.
Arnaud Giersch [Tue, 31 Oct 2017 15:26:18 +0000 (16:26 +0100)]
Don't let field unitialized.
Arnaud Giersch [Tue, 31 Oct 2017 14:47:12 +0000 (15:47 +0100)]
Compute size * size once, and please scan-build.
Arnaud Giersch [Tue, 31 Oct 2017 14:36:07 +0000 (15:36 +0100)]
Make loop easier to follow for scan-build.
Arnaud Giersch [Mon, 30 Oct 2017 22:28:18 +0000 (23:28 +0100)]
Fill empty if statement.
Arnaud Giersch [Mon, 30 Oct 2017 22:25:34 +0000 (23:25 +0100)]
Don't return when debug is enabled.
Frederic Suter [Tue, 31 Oct 2017 08:30:37 +0000 (09:30 +0100)]
please sonar + cosmetics
Frederic Suter [Mon, 30 Oct 2017 21:16:53 +0000 (22:16 +0100)]
cosmetics
Frederic Suter [Mon, 30 Oct 2017 21:16:31 +0000 (22:16 +0100)]
fix invalid read
Frederic Suter [Mon, 30 Oct 2017 20:28:39 +0000 (21:28 +0100)]
enough playing with instr for now ...
Arnaud Giersch [Mon, 30 Oct 2017 14:55:45 +0000 (15:55 +0100)]
Please scan-build.
Arnaud Giersch [Mon, 30 Oct 2017 11:13:56 +0000 (12:13 +0100)]
Be safe in case of spurious wakeup of xbt_os_cond_wait.
Arnaud Giersch [Mon, 30 Oct 2017 10:18:32 +0000 (11:18 +0100)]
Typos.
Arnaud Giersch [Mon, 30 Oct 2017 08:34:47 +0000 (09:34 +0100)]
Declare parameters as const, and make comment match the code.
Arnaud Giersch [Mon, 30 Oct 2017 07:41:57 +0000 (08:41 +0100)]
Remove useless allocations.
Frederic Suter [Mon, 30 Oct 2017 14:35:58 +0000 (15:35 +0100)]
Merge branch 'master' of git+ssh://scm.gforge.inria.fr//gitroot/simgrid/simgrid
Frederic Suter [Mon, 30 Oct 2017 14:35:47 +0000 (15:35 +0100)]
a few more simplifications
Frederic Suter [Mon, 30 Oct 2017 14:01:40 +0000 (15:01 +0100)]
stringify
Frederic Suter [Mon, 30 Oct 2017 13:46:17 +0000 (14:46 +0100)]
simplify the way states are used in high-level instr modules
Christian Heinrich [Thu, 26 Oct 2017 15:24:02 +0000 (17:24 +0200)]
[SMPI] Moved variable declaration.
It's now close to where it's used and not 100 lines above
that place.
Christian Heinrich [Tue, 24 Oct 2017 09:29:47 +0000 (11:29 +0200)]
[SMPI] Move a map in smpi::Group from array to std::vector
See the source code comment why I'm not using std::map.
Christian Heinrich [Mon, 23 Oct 2017 11:21:59 +0000 (13:21 +0200)]
[SMPI] Move variable declaration into for-loop
Christian Heinrich [Mon, 23 Oct 2017 08:37:14 +0000 (10:37 +0200)]
[SMPI] Added a comment explaining why we subtract 1
Christian Heinrich [Mon, 23 Oct 2017 08:31:04 +0000 (10:31 +0200)]
[SMPI] Renamed global memory init function
This function is not used to initialize the
segments any longer but to merely back up the
segment.
Christian Heinrich [Wed, 18 Oct 2017 14:39:59 +0000 (16:39 +0200)]
[SMPI] This fixes the indentation in smpi_memory.cpp
I didn't commit that in the previous commit because it was distracting from
the really important changes.
Christian Heinrich [Wed, 18 Oct 2017 14:38:25 +0000 (16:38 +0200)]
[SMPI] Allow privatization in a more generic way
1. We now use a std::set instead of a static array
2. simgrid::smpi::Process::Init() now initializes the global data segment
by using a (clean) copy of the data segment that we backuped at startup.
(This is done by calling smpi_init_global_memory_segment_process(), a function
that contains mostly code that was looped-over before.)
Christian Heinrich [Wed, 18 Oct 2017 14:14:29 +0000 (16:14 +0200)]
[SMPI] Added explanation of what smpi_data_exe_size==0 means
Christian Heinrich [Wed, 18 Oct 2017 13:03:09 +0000 (15:03 +0200)]
[SMPI] Added privatized_region_ property to simgrid::smpi::Process
This property is not used at this time but will be
once the privatization overhaul is completed.
For the record: This property will hold the pointer
to the memory address of the global-variables segment of
that specific process.
Christian Heinrich [Tue, 17 Oct 2017 15:42:42 +0000 (17:42 +0200)]
[SMPI] Moved local address to for-initializer
Christian Heinrich [Tue, 10 Oct 2017 12:11:12 +0000 (14:11 +0200)]
[SMPI] Removed declaration of smpi_privatization_regions from smpi_bench.cpp
Added it to smpi_memory.cpp for the sake of compiling.
It will be changed in the next few commits.
Christian Heinrich [Tue, 10 Oct 2017 09:23:40 +0000 (11:23 +0200)]
[SMPI] Privatization changes, step 1
This commit introduces a new variable that retains the whole initial
data segment during the execution of the program. We need this
as we will soon allow new processes to be added dynamically and we
can hence no longer assume that we can initialize all processes at the
beginning of the execution.
Christian Heinrich [Mon, 30 Oct 2017 09:21:13 +0000 (10:21 +0100)]
[KERNEL] Replaced literal strings with variable.
This error message was hardcoded several times. Replaced
it with a const message.
Christian Heinrich [Mon, 30 Oct 2017 09:20:15 +0000 (10:20 +0100)]
[KERNEL] Fixed comment on FatTree parameters.
This was pointed out by Ahmed Hamdy Mohamed Eleliemy
on the SimGrid User List.
Frederic Suter [Mon, 30 Oct 2017 11:00:46 +0000 (12:00 +0100)]
twitching and tweaking
Frederic Suter [Mon, 30 Oct 2017 09:54:59 +0000 (10:54 +0100)]
Continue to reorganize instr
Arnaud Giersch [Sun, 29 Oct 2017 22:27:32 +0000 (23:27 +0100)]
Use C++ atomic instead of compiler builtins.
Arnaud Giersch [Sun, 29 Oct 2017 22:07:16 +0000 (23:07 +0100)]
Parmap: add missing atomic load/store, and convert legacy builtins.
Arnaud Giersch [Sun, 29 Oct 2017 21:09:43 +0000 (22:09 +0100)]
Enable SIMIX parallel mode for parmap_{bench,text}.
Arnaud Giersch [Sat, 28 Oct 2017 20:46:33 +0000 (22:46 +0200)]
Use "using" to import method from base class.
Arnaud Giersch [Sat, 28 Oct 2017 16:39:31 +0000 (18:39 +0200)]
Sonar: remove unused private fields.
Arnaud Giersch [Sat, 28 Oct 2017 16:19:14 +0000 (18:19 +0200)]
Sonar: remove nested blocks.
Arnaud Giersch [Sat, 28 Oct 2017 16:14:49 +0000 (18:14 +0200)]
Sonar: fill empty "catch".
Arnaud Giersch [Sat, 28 Oct 2017 16:05:34 +0000 (18:05 +0200)]
Sonar: use public inheritance.
Arnaud Giersch [Sat, 28 Oct 2017 16:04:18 +0000 (18:04 +0200)]
Sonar: replace "switch" statement by an "if".
Arnaud Giersch [Sat, 28 Oct 2017 16:01:52 +0000 (18:01 +0200)]
Sonar: use lowercase for field names.
Arnaud Giersch [Sat, 28 Oct 2017 15:54:19 +0000 (17:54 +0200)]
Sonar: move extern "C" declarations out of namespaces.
Arnaud Giersch [Sat, 28 Oct 2017 15:49:33 +0000 (17:49 +0200)]
Sonar: remove redundant jumps.
Arnaud Giersch [Sat, 28 Oct 2017 13:32:25 +0000 (15:32 +0200)]
Kill another unused function: xbt_str_join.
Arnaud Giersch [Sat, 28 Oct 2017 13:01:19 +0000 (15:01 +0200)]
No need to duplicate string.
Arnaud Giersch [Sat, 28 Oct 2017 12:49:14 +0000 (14:49 +0200)]
Rewrite without using c++11 regex which are not functional in gcc-4.8.
Arnaud Giersch [Sat, 28 Oct 2017 08:43:06 +0000 (10:43 +0200)]
Try to fix regexes with older gcc.
See https://stackoverflow.com/questions/
8060025/is-this-c11-regex-error-me-or-the-compiler.
Arnaud Giersch [Sat, 28 Oct 2017 07:44:17 +0000 (09:44 +0200)]
Use c++ regex and string.
Arnaud Giersch [Fri, 27 Oct 2017 21:44:52 +0000 (23:44 +0200)]
Use new/delete.
Arnaud Giersch [Fri, 27 Oct 2017 20:56:24 +0000 (22:56 +0200)]
Workaround shellcheck warning about $'s inside single quotes.
Arnaud Giersch [Fri, 27 Oct 2017 20:37:12 +0000 (22:37 +0200)]
Don't redefine builtin 'format'.
Arnaud Giersch [Fri, 27 Oct 2017 20:12:28 +0000 (22:12 +0200)]
Catch specific exceptions in python scripts.
Arnaud Giersch [Fri, 27 Oct 2017 19:58:49 +0000 (21:58 +0200)]
Don't redefine builtin 'exit'.
Frederic Suter [Sat, 28 Oct 2017 07:30:15 +0000 (09:30 +0200)]
try to please sanitizers
Frederic Suter [Fri, 27 Oct 2017 19:03:58 +0000 (21:03 +0200)]
rework Variable related events
Frederic Suter [Fri, 27 Oct 2017 16:10:20 +0000 (18:10 +0200)]
rework State related events
Arnaud Giersch [Fri, 27 Oct 2017 13:26:36 +0000 (15:26 +0200)]
Save a couple of strdup/free.
Arnaud Giersch [Fri, 27 Oct 2017 13:25:50 +0000 (15:25 +0200)]
Use c++ string to parse config parameters.
Arnaud Giersch [Fri, 27 Oct 2017 10:42:50 +0000 (12:42 +0200)]
Use c++ string.
Arnaud Giersch [Thu, 26 Oct 2017 22:59:28 +0000 (00:59 +0200)]
Define common output stream.
Sonar, happy whith that?
Frederic Suter [Fri, 27 Oct 2017 10:49:42 +0000 (12:49 +0200)]
try to silence CI on maverick
Frederic Suter [Fri, 27 Oct 2017 10:02:15 +0000 (12:02 +0200)]
remove useless casts
Frederic Suter [Fri, 27 Oct 2017 10:01:55 +0000 (12:01 +0200)]
stringify
Frederic Suter [Fri, 27 Oct 2017 08:21:40 +0000 (10:21 +0200)]
split instr_private in several header files
Frederic Suter [Fri, 27 Oct 2017 07:46:38 +0000 (09:46 +0200)]
fix leak
Arnaud Giersch [Thu, 26 Oct 2017 22:15:47 +0000 (00:15 +0200)]
Really remove unused function.
Arnaud Giersch [Thu, 26 Oct 2017 21:09:45 +0000 (23:09 +0200)]
cunit: use string and iostream.
Arnaud Giersch [Thu, 26 Oct 2017 20:24:20 +0000 (22:24 +0200)]
cunit: C++-ify s_xbt_test_suite.
Also remove the last dynar from this module.
Arnaud Giersch [Thu, 26 Oct 2017 20:04:59 +0000 (22:04 +0200)]
cunit: C++-ify s_xbt_test_unit.
Arnaud Giersch [Thu, 26 Oct 2017 19:49:23 +0000 (21:49 +0200)]
cunit: C++-ify s_xbt_test_test.