Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
19 months agotry to address comment made in FG#8
Frederic Suter [Fri, 19 Apr 2019 17:23:10 +0000 (19:23 +0200)]
try to address comment made in FG#8

19 months agoSet cfg=smpi/simulate-computation:no.
Arnaud Giersch [Fri, 19 Apr 2019 15:51:27 +0000 (17:51 +0200)]
Set cfg=smpi/simulate-computation:no.

19 months agoFix default MPI_Barrier.
Arnaud Giersch [Fri, 19 Apr 2019 13:40:05 +0000 (15:40 +0200)]
Fix default MPI_Barrier.

Mpich3 test comm_group_rand was sometimes failing.

19 months agoRevise to fool cppcheck.
Arnaud Giersch [Fri, 19 Apr 2019 12:19:12 +0000 (14:19 +0200)]
Revise to fool cppcheck.

19 months agofix test binary path
Frederic Suter [Fri, 19 Apr 2019 13:01:37 +0000 (15:01 +0200)]
fix test binary path

19 months agofixed issue
Frederic Suter [Fri, 19 Apr 2019 11:43:00 +0000 (13:43 +0200)]
fixed issue

19 months agoAdd a test for callback disconnection
Frederic Suter [Fri, 19 Apr 2019 11:38:01 +0000 (13:38 +0200)]
Add a test for callback disconnection

19 months agoAllow for callback disconnection
Frederic Suter [Fri, 19 Apr 2019 11:35:00 +0000 (13:35 +0200)]
Allow for callback disconnection

xbt::signal::connect now returns an unsigned int id and callbacks are
stored in a map <id, callback>.
a new xbt::signal::disconnect(unsigned int id) method has been added.

19 months agoFix build errors with gcc 5.4.0.
Arnaud Giersch [Fri, 19 Apr 2019 11:20:29 +0000 (13:20 +0200)]
Fix build errors with gcc 5.4.0.

19 months agoUse default destructor for resource::Model.
Arnaud Giersch [Fri, 19 Apr 2019 09:18:43 +0000 (11:18 +0200)]
Use default destructor for resource::Model.

19 months agoRemove empty functions
Arnaud Giersch [Fri, 19 Apr 2019 08:32:29 +0000 (10:32 +0200)]
Remove empty functions

19 months agoUse std::unique_ptr to manage memory.
Arnaud Giersch [Fri, 19 Apr 2019 08:08:05 +0000 (10:08 +0200)]
Use std::unique_ptr to manage memory.

19 months agoleaks --
degomme [Fri, 19 Apr 2019 09:10:35 +0000 (11:10 +0200)]
leaks --

19 months agofix issue seen on 34f5b82ed231ecce .
degomme [Fri, 19 Apr 2019 08:41:02 +0000 (10:41 +0200)]
fix issue seen on 34f5b82ed231ecce .
We were writing inside an existing file, reducing its size for the fs.
And then used_size was becoming <0, which for an unsigned is quite large.
This seems to point to another issue in storage, as used_size might not be initialized properly

19 months agofix io-shared (remove spurious ordered_read) and do write then read.
degomme [Fri, 19 Apr 2019 08:32:24 +0000 (10:32 +0200)]
fix io-shared (remove spurious ordered_read) and do write then read.

19 months agocheck for readonly flag before writing to a file.
degomme [Fri, 19 Apr 2019 07:59:52 +0000 (09:59 +0200)]
check for readonly flag before writing to a file.

19 months ago[sonar] kill commented code
Martin Quinson [Fri, 19 Apr 2019 09:29:14 +0000 (11:29 +0200)]
[sonar] kill commented code

19 months ago[sonar] define each identifiers on its line
Martin Quinson [Fri, 19 Apr 2019 09:23:08 +0000 (11:23 +0200)]
[sonar] define each identifiers on its line

19 months agonope sonar, that's not commented code
Martin Quinson [Fri, 19 Apr 2019 09:18:51 +0000 (11:18 +0200)]
nope sonar, that's not commented code

19 months agoplease sonar
Martin Quinson [Fri, 19 Apr 2019 08:41:01 +0000 (10:41 +0200)]
please sonar

19 months agodoc: 2 more internal references
Martin Quinson [Wed, 17 Apr 2019 15:00:26 +0000 (17:00 +0200)]
doc: 2 more internal references

19 months agofix GH#133
Frederic Suter [Fri, 19 Apr 2019 08:35:14 +0000 (10:35 +0200)]
fix GH#133
When a host is turned off, also shutwdown and turn off the VMs hosted
by this host. This is a rather crude patch that implies to browse the
whole list of existing VMs. A better solution requires a bit more work
and time

19 months agoplease sonar
Augustin Degomme [Thu, 18 Apr 2019 22:06:03 +0000 (00:06 +0200)]
please sonar

19 months agoUse std::vector instead of plain arrays in smpi_topo.
Arnaud Giersch [Thu, 18 Apr 2019 20:35:24 +0000 (22:35 +0200)]
Use std::vector instead of plain arrays in smpi_topo.

19 months agoRemove a level of indirection in sd::Global.
Arnaud Giersch [Thu, 18 Apr 2019 16:34:58 +0000 (18:34 +0200)]
Remove a level of indirection in sd::Global.

19 months agoTidy up mc/mc_unw a little.
Arnaud Giersch [Thu, 18 Apr 2019 16:22:17 +0000 (18:22 +0200)]
Tidy up mc/mc_unw a little.

19 months agoRemove custom destructors for instr/paje.
Arnaud Giersch [Thu, 18 Apr 2019 15:28:53 +0000 (17:28 +0200)]
Remove custom destructors for instr/paje.

19 months agoRemove a level of indirection, and custom destructors for instr/jedule.
Arnaud Giersch [Thu, 18 Apr 2019 13:41:45 +0000 (15:41 +0200)]
Remove a level of indirection, and custom destructors for instr/jedule.

19 months agoRemove custom destructors for s4u_Filesystem.
Arnaud Giersch [Thu, 18 Apr 2019 12:51:02 +0000 (14:51 +0200)]
Remove custom destructors for s4u_Filesystem.

19 months agoRestore warning for unit-less values.
Arnaud Giersch [Thu, 18 Apr 2019 12:16:17 +0000 (14:16 +0200)]
Restore warning for unit-less values.

19 months ago32 bits insists of having some timestamps off by 1us ... Hide them.
Augustin Degomme [Thu, 18 Apr 2019 20:24:17 +0000 (22:24 +0200)]
32 bits insists of having some timestamps off by 1us ... Hide them.
And fix my windows line endings mess.

19 months agobe cleaner with memory
Augustin Degomme [Thu, 18 Apr 2019 19:47:41 +0000 (21:47 +0200)]
be cleaner with memory

19 months agofix out of source builds
Augustin Degomme [Thu, 18 Apr 2019 18:40:29 +0000 (20:40 +0200)]
fix out of source builds

19 months agoplease clang
Augustin Degomme [Thu, 18 Apr 2019 18:37:29 +0000 (20:37 +0200)]
please clang

19 months agoMerge branch 'file' into 'master'
Augustin Degomme [Thu, 18 Apr 2019 18:19:09 +0000 (20:19 +0200)]
Merge branch 'file' into 'master'

MPI IO

See merge request simgrid/simgrid!6

19 months agotry to get rid of some variability
Augustin Degomme [Thu, 18 Apr 2019 17:19:22 +0000 (19:19 +0200)]
try to get rid of some variability

19 months agoadd hostfile as well for tests
Augustin Degomme [Thu, 18 Apr 2019 16:41:56 +0000 (18:41 +0200)]
add hostfile as well for tests

19 months agoChange how we lock things up ...
Augustin Degomme [Thu, 18 Apr 2019 15:54:40 +0000 (17:54 +0200)]
Change how we lock things up ...
MPI RMA seemed a god idea, but it just did not work.

19 months agoAdd some tests for io.
Augustin Degomme [Thu, 18 Apr 2019 11:40:58 +0000 (13:40 +0200)]
Add some tests for io.

19 months agoComment out a buggy line... Can't put a finger on what goes wrong here, but values...
Augustin Degomme [Thu, 18 Apr 2019 11:40:22 +0000 (13:40 +0200)]
Comment out a buggy line... Can't put a finger on what goes wrong here, but values seem insane and break all tests
TODO : investigate

19 months agocleanups debug messages for read_all write_all
Augustin Degomme [Thu, 18 Apr 2019 11:39:20 +0000 (13:39 +0200)]
cleanups debug messages for read_all write_all

19 months agocleanups
Augustin Degomme [Thu, 18 Apr 2019 11:37:43 +0000 (13:37 +0200)]
cleanups

19 months agoRevert "Inline Context::self()."
Arnaud Giersch [Thu, 18 Apr 2019 11:30:28 +0000 (13:30 +0200)]
Revert "Inline Context::self()."

This reverts commit 92061e0bc62b9a2ef3bdc041e5e9fe716ada1120.

It's failing on appveyor (mingw64) with:
C:\mingw-w64\x86_64-7.2.0-posix-seh-rt_v5-rev1\mingw64\bin\g++.exe    -g3 -O3 -funroll-loops -fno-strict-aliasing  -finline-functions  -fdebug-prefix-map=C:/projects/simgrid=. -static-libgcc -static-libstdc++ -Wl,--add-stdcall-alias -m64  -shared -o lib\libsimgrid-java.dll -Wl,--out-implib,lib\libsimgrid-java.dll.a -Wl,--major-image-version,3,--minor-image-version,22 -Wl,--whole-archive CMakeFiles\simgrid-java.dir/objects.a -Wl,--no-whole-archive @CMakeFiles\simgrid-java.dir\linklibs.rsp
CMakeFiles\simgrid-java.dir/objects.a(jmsg.cpp.obj):././src/bindings/java/jmsg.cpp:342: undefined reference to `__imp__ZTHN7simgrid6kernel7context7Context8current_E'
CMakeFiles\simgrid-java.dir/objects.a(jmsg.cpp.obj):././src/bindings/java/jmsg.cpp:342: undefined reference to `__imp__ZTHN7simgrid6kernel7context7Context8current_E'
CMakeFiles\simgrid-java.dir/objects.a(jmsg.cpp.obj):././src/bindings/java/jmsg.cpp:342: undefined reference to `__imp__ZTHN7simgrid6kernel7context7Context8current_E'
CMakeFiles\simgrid-java.dir/objects.a(JavaContext.cpp.obj):././src/bindings/java/JavaContext.cpp:81: undefined reference to `__imp__ZTHN7simgrid6kernel7context7Context8current_E'
collect2.exe: error: ld returned 1 exit status

19 months ago[sonar] Remove the use of "sprintf".
Arnaud Giersch [Thu, 18 Apr 2019 11:28:39 +0000 (13:28 +0200)]
[sonar] Remove the use of "sprintf".

19 months agoDefine PropertyHolder::set_properties.
Arnaud Giersch [Thu, 18 Apr 2019 09:45:34 +0000 (11:45 +0200)]
Define PropertyHolder::set_properties.

It allows to have a single simcall when setting many properties.

19 months agoConstify get_properties() and and remove simcalls.
Arnaud Giersch [Wed, 17 Apr 2019 21:21:48 +0000 (23:21 +0200)]
Constify get_properties() and and remove simcalls.

19 months agochange verbosity of some messages, to ease testing
Augustin Degomme [Wed, 17 Apr 2019 21:35:19 +0000 (23:35 +0200)]
change verbosity of some messages, to ease testing

19 months agocomments about implem
Augustin Degomme [Wed, 17 Apr 2019 21:34:16 +0000 (23:34 +0200)]
comments about implem

19 months ago[sonar] Remove custom destructors for surf/PropertyHolder.
Arnaud Giersch [Wed, 17 Apr 2019 21:05:36 +0000 (23:05 +0200)]
[sonar] Remove custom destructors for surf/PropertyHolder.

19 months agomove everything to the implemented zone.
Augustin Degomme [Wed, 17 Apr 2019 20:54:22 +0000 (22:54 +0200)]
move everything to the implemented zone.

19 months ago[sonar] Remove custom destructors for CpuTiProfile.
Arnaud Giersch [Wed, 17 Apr 2019 20:45:12 +0000 (22:45 +0200)]
[sonar] Remove custom destructors for CpuTiProfile.

19 months agoMPI_File_read_shared, MPI_File_write_shared, MPI_File_read_ordered, MPI_File_write_or...
Augustin Degomme [Wed, 17 Apr 2019 20:38:04 +0000 (22:38 +0200)]
MPI_File_read_shared, MPI_File_write_shared, MPI_File_read_ordered, MPI_File_write_ordered, MPI_File_seek_shared, MPI_File_get_position_shared

19 months agoUse std algorithm for binary search.
Arnaud Giersch [Wed, 17 Apr 2019 20:37:11 +0000 (22:37 +0200)]
Use std algorithm for binary search.

19 months agoMPI_File_set_info, MPI_File_get_info, MPI_File_get_position
Augustin Degomme [Wed, 17 Apr 2019 20:37:04 +0000 (22:37 +0200)]
MPI_File_set_info, MPI_File_get_info, MPI_File_get_position

19 months agoUseless smart pointer.
Arnaud Giersch [Wed, 17 Apr 2019 19:43:04 +0000 (21:43 +0200)]
Useless smart pointer.

19 months agoCosmetics.
Arnaud Giersch [Wed, 17 Apr 2019 19:31:37 +0000 (21:31 +0200)]
Cosmetics.

19 months agoTypo.
Arnaud Giersch [Wed, 17 Apr 2019 19:16:06 +0000 (21:16 +0200)]
Typo.

19 months agoUse the good interface.
Arnaud Giersch [Wed, 17 Apr 2019 19:13:32 +0000 (21:13 +0200)]
Use the good interface.

19 months agoSmart pointer is not necessary for Actor::self.
Arnaud Giersch [Wed, 17 Apr 2019 19:13:16 +0000 (21:13 +0200)]
Smart pointer is not necessary for Actor::self.

19 months agoInline Context::self().
Arnaud Giersch [Wed, 17 Apr 2019 19:03:36 +0000 (21:03 +0200)]
Inline Context::self().

19 months agoUniformize get_impl(): const attribute, and return raw pointer.
Arnaud Giersch [Wed, 17 Apr 2019 18:46:11 +0000 (20:46 +0200)]
Uniformize get_impl(): const attribute, and return raw pointer.

19 months agoMethods of simix::Global have direct access to their members.
Arnaud Giersch [Wed, 17 Apr 2019 10:55:08 +0000 (12:55 +0200)]
Methods of simix::Global have direct access to their members.

19 months ago[sonar] clean_action() called from destructor should not be overridable.
Arnaud Giersch [Wed, 10 Apr 2019 08:54:51 +0000 (10:54 +0200)]
[sonar] clean_action() called from destructor should not be overridable.

19 months agoRead_all, Write_all, Read_at_all, Write_at_all
Augustin Degomme [Wed, 17 Apr 2019 11:49:06 +0000 (13:49 +0200)]
Read_all, Write_all, Read_at_all, Write_at_all
Imperfect algorithm, needs to be tested

19 months agoRead_at, Write, Write_at
Augustin Degomme [Wed, 17 Apr 2019 11:46:28 +0000 (13:46 +0200)]
Read_at, Write, Write_at

19 months agoTest using macros for arguments checking, saves some duplicated lines.
Augustin Degomme [Wed, 17 Apr 2019 11:44:47 +0000 (13:44 +0200)]
Test using macros for arguments checking, saves some duplicated lines.

19 months agoDon't make exception on timeout.
Arnaud Giersch [Tue, 16 Apr 2019 12:08:42 +0000 (14:08 +0200)]
Don't make exception on timeout.

It breaks for example xbt_cond_timedwait which is expected to report timeout by
a regular return.

19 months agoDelete unused private function.
Arnaud Giersch [Mon, 15 Apr 2019 12:52:26 +0000 (14:52 +0200)]
Delete unused private function.

19 months ago[sonar] Remove custom destructors for routing/DragonflyZone.
Arnaud Giersch [Mon, 15 Apr 2019 12:32:52 +0000 (14:32 +0200)]
[sonar] Remove custom destructors for routing/DragonflyZone.

19 months ago[sonar] Remove custom destructors for surf/network_ib.
Arnaud Giersch [Mon, 15 Apr 2019 12:09:37 +0000 (14:09 +0200)]
[sonar] Remove custom destructors for surf/network_ib.

19 months ago[sonar] Remove custom destructors for xbt_replay.
Arnaud Giersch [Mon, 15 Apr 2019 10:01:10 +0000 (12:01 +0200)]
[sonar] Remove custom destructors for xbt_replay.

19 months ago[sonar] Remove custom destructors for examples/s4u/.
Arnaud Giersch [Mon, 15 Apr 2019 09:01:36 +0000 (11:01 +0200)]
[sonar] Remove custom destructors for examples/s4u/.

19 months agoread, seek + init
degomme [Mon, 15 Apr 2019 14:02:38 +0000 (16:02 +0200)]
read, seek + init
TODO: properly init plugin, only when needed.

19 months agoDon't explode here, as flatifier may try exactly to do this.
degomme [Mon, 15 Apr 2019 10:44:47 +0000 (12:44 +0200)]
Don't explode here, as flatifier may try exactly to do this.

19 months agofrench comment --
degomme [Mon, 15 Apr 2019 09:51:06 +0000 (11:51 +0200)]
french comment --

19 months agoAllow units in smpi factors.
degomme [Mon, 15 Apr 2019 09:12:48 +0000 (11:12 +0200)]
Allow units in smpi factors.
To make it optional (as parse_factor is used for actual factors and not only seconds on some occasions), remove the warning in surf if a unit-less value is used.

19 months agoAvoid returning uninitialized bytes in fortran processor names.
degomme [Wed, 10 Apr 2019 09:25:33 +0000 (11:25 +0200)]
Avoid returning uninitialized bytes in fortran processor names.

19 months agoSkeleton for MPI_IO
Augustin Degomme [Sun, 14 Apr 2019 23:53:02 +0000 (01:53 +0200)]
Skeleton for MPI_IO

19 months agoFix 32 bits build
Augustin Degomme [Sun, 14 Apr 2019 18:09:32 +0000 (20:09 +0200)]
Fix 32 bits build

19 months agoRevert "Reactivate an umpire test, once disabled in 56fefe1bf81ca."
Augustin Degomme [Sun, 14 Apr 2019 17:49:20 +0000 (19:49 +0200)]
Revert "Reactivate an umpire test, once disabled in 56fefe1bf81ca."

This reverts commit 1797da7d294b83c915fe49dad633855985eccb64.

19 months agodon't compile non working and non compiling test
Augustin Degomme [Sun, 14 Apr 2019 17:10:06 +0000 (19:10 +0200)]
don't compile non working and non compiling test

19 months agoPretend we support MPI 3.1.
Augustin Degomme [Sun, 14 Apr 2019 16:15:26 +0000 (18:15 +0200)]
Pretend we support MPI 3.1.
We don't support all of it, obviously, but what we have may be enough for some codes.

19 months agocomment tests we don't support in MPI3, and fix a few we support
Augustin Degomme [Sun, 14 Apr 2019 16:12:56 +0000 (18:12 +0200)]
comment tests we don't support in MPI3, and fix a few we support

19 months agoMPI_Count can be used in ops too.
Augustin Degomme [Sun, 14 Apr 2019 16:11:22 +0000 (18:11 +0200)]
MPI_Count can be used in ops too.

19 months agoMPI_INFO_ENV ... Still does nothing for now
Augustin Degomme [Sun, 14 Apr 2019 14:46:37 +0000 (16:46 +0200)]
MPI_INFO_ENV ... Still does nothing for now

19 months agoReactivate an umpire test, once disabled in 56fefe1bf81ca.
Augustin Degomme [Sun, 14 Apr 2019 14:09:43 +0000 (16:09 +0200)]
Reactivate an umpire test, once disabled in 56fefe1bf81ca.

19 months agoMPI_Comm_get_info, MPI_Comm_set_info
Augustin Degomme [Sun, 14 Apr 2019 14:08:37 +0000 (16:08 +0200)]
MPI_Comm_get_info, MPI_Comm_set_info

19 months agoSupport MPI3 datatype MPI_Count
Augustin Degomme [Sun, 14 Apr 2019 14:07:55 +0000 (16:07 +0200)]
Support MPI3 datatype MPI_Count

19 months agoplease sonar: replace void* by unsigned char* for raw buffer
Frederic Suter [Sat, 13 Apr 2019 15:50:40 +0000 (17:50 +0200)]
please sonar: replace void* by unsigned char* for raw buffer

19 months agoplease sonar
Frederic Suter [Sat, 13 Apr 2019 15:20:39 +0000 (17:20 +0200)]
please sonar

19 months agoyet another attempt to handle MPI special values in fortran
Augustin Degomme [Sat, 13 Apr 2019 10:57:10 +0000 (12:57 +0200)]
yet another attempt to handle MPI special values in fortran
Without dereferencing potentially unassigned variables.
Old way with a struct and common block does not work with dlopen provatization somehow.

19 months agomove CPU models to kernel::resource too
Frederic Suter [Fri, 12 Apr 2019 12:34:36 +0000 (14:34 +0200)]
move CPU models to kernel::resource too

19 months agocosmetic cleanups in network models
Frederic Suter [Fri, 12 Apr 2019 11:26:51 +0000 (13:26 +0200)]
cosmetic cleanups in network models

19 months agoMerge branch 'master' of https://framagit.org/simgrid/simgrid
Frederic Suter [Fri, 12 Apr 2019 11:01:51 +0000 (13:01 +0200)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid

19 months agochanging namespace for cpu_interface
Frederic Suter [Fri, 12 Apr 2019 11:01:15 +0000 (13:01 +0200)]
changing namespace for cpu_interface

19 months agocosmetics
Frederic Suter [Fri, 12 Apr 2019 09:29:43 +0000 (11:29 +0200)]
cosmetics

19 months agoFix hash update.
Arnaud Giersch [Fri, 12 Apr 2019 09:13:51 +0000 (11:13 +0200)]
Fix hash update.

19 months agostringify
Frederic Suter [Fri, 12 Apr 2019 09:08:31 +0000 (11:08 +0200)]
stringify

19 months agoWith a std::map, entries are already sorted by their keys.
Arnaud Giersch [Thu, 11 Apr 2019 20:08:26 +0000 (22:08 +0200)]
With a std::map, entries are already sorted by their keys.

19 months agoRemove unnecessary "else"s.
Arnaud Giersch [Tue, 9 Apr 2019 08:27:12 +0000 (10:27 +0200)]
Remove unnecessary "else"s.

Also reduce Sonar's cognitive complexity.