Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
3 years agoMisc issues in shell scripts (codefator.io).
Arnaud Giersch [Sun, 31 May 2020 21:06:15 +0000 (23:06 +0200)]
Misc issues in shell scripts (codefator.io).

3 years agoFix potential memory leaks.
Arnaud Giersch [Sun, 31 May 2020 13:37:29 +0000 (15:37 +0200)]
Fix potential memory leaks.

3 years agowifi: make room for the ns3-wifi binding
Martin Quinson [Fri, 29 May 2020 14:37:38 +0000 (16:37 +0200)]
wifi: make room for the ns3-wifi binding

3 years agosmpi topo : a topo can be shared between some comm (duplicates), but there was no...
Augustin Degomme [Thu, 28 May 2020 15:30:51 +0000 (17:30 +0200)]
smpi topo : a topo can be shared between some comm (duplicates), but there was no refcounting.
Try to switch to a shared_ptr to avoid segfaults or leaks...

3 years agothat's not a double
Augustin Degomme [Thu, 28 May 2020 15:29:14 +0000 (17:29 +0200)]
that's not a double

3 years agofortran : protect in case some calls return success, but with a null request.
Augustin Degomme [Wed, 27 May 2020 16:24:06 +0000 (18:24 +0200)]
fortran : protect in case some calls return success, but with a null request.
This can be caused by sending messages to unreachable processes.

3 years agoattempt to please fortran on ci
Augustin Degomme [Wed, 27 May 2020 13:42:57 +0000 (15:42 +0200)]
attempt to please fortran on ci

3 years agoTrigger a warning when abort is called and a process exits.
Augustin Degomme [Wed, 27 May 2020 12:58:51 +0000 (14:58 +0200)]
Trigger a warning when abort is called and a process exits.
Does not hurt and can help understand why there is a deadlock in simgrid, when the app forgets to print an error message.

3 years agodist
Augustin Degomme [Wed, 27 May 2020 12:55:48 +0000 (14:55 +0200)]
dist

3 years agoMPI IO : "support" for ./ in filename
Augustin Degomme [Wed, 27 May 2020 12:55:33 +0000 (14:55 +0200)]
MPI IO : "support" for ./ in filename

3 years agoMPI IO: now with more fortran bindings
Augustin Degomme [Wed, 27 May 2020 12:54:46 +0000 (14:54 +0200)]
MPI IO: now with more fortran bindings

3 years agofortran support for MPI_UB and MPI_LB
Augustin Degomme [Wed, 27 May 2020 12:53:22 +0000 (14:53 +0200)]
fortran support for MPI_UB and MPI_LB

3 years agofortran : allow use of C names for types
Augustin Degomme [Wed, 27 May 2020 12:53:05 +0000 (14:53 +0200)]
fortran : allow use of C names for types

3 years agoRemove redundant blank lines (codefactor).
Arnaud Giersch [Wed, 27 May 2020 08:10:46 +0000 (10:10 +0200)]
Remove redundant blank lines (codefactor).

3 years agoMake smpif90 support SMPI_NO_UNDEFINED_CHECK too.
Arnaud Giersch [Wed, 27 May 2020 08:07:06 +0000 (10:07 +0200)]
Make smpif90 support SMPI_NO_UNDEFINED_CHECK too.

3 years agoSMPI : Allow to deactivate link-time definitions check with an environment var
Augustin Degomme [Tue, 26 May 2020 21:04:14 +0000 (23:04 +0200)]
SMPI : Allow to deactivate link-time definitions check with an environment var
This is breaking compilation when the code has shared libraries itself (CLAMR).
Not sure if we should keep all this, actually ...

3 years agoDon't use XBT_LOG macros within a function (thanks lgtm for noticing)
Martin Quinson [Sun, 24 May 2020 22:13:41 +0000 (00:13 +0200)]
Don't use XBT_LOG macros within a function (thanks lgtm for noticing)

3 years agolgtm: Add some missing header guards
Martin Quinson [Sun, 24 May 2020 22:08:32 +0000 (00:08 +0200)]
lgtm: Add some missing header guards

3 years agoBetter explanations for the parameters of the decay model
Martin Quinson [Wed, 20 May 2020 10:01:12 +0000 (12:01 +0200)]
Better explanations for the parameters of the decay model

3 years agoMC: inline a function
Martin Quinson [Thu, 14 May 2020 22:16:34 +0000 (00:16 +0200)]
MC: inline a function

3 years agobump osx version on travis
Augustin Degomme [Fri, 15 May 2020 00:12:48 +0000 (02:12 +0200)]
bump osx version on travis

3 years agofix ns3 builds
Martin Quinson [Thu, 14 May 2020 21:30:35 +0000 (23:30 +0200)]
fix ns3 builds

3 years agoremove an extraneous ';' that fools codacy
Martin Quinson [Thu, 14 May 2020 20:56:19 +0000 (22:56 +0200)]
remove an extraneous ';' that fools codacy

3 years agoMissing const marker
Martin Quinson [Thu, 14 May 2020 20:31:26 +0000 (22:31 +0200)]
Missing const marker

3 years agoSave the src_wifi_link and dst_wifi_link in a subclass of NetCm02Action
Martin Quinson [Thu, 14 May 2020 19:04:15 +0000 (21:04 +0200)]
Save the src_wifi_link and dst_wifi_link in a subclass of NetCm02Action

This way, interested parties won't have to recompute that information
and possibly miscompute it.

3 years agofix how wifi's host_rate is used in communicate()
Martin Quinson [Thu, 14 May 2020 18:17:31 +0000 (20:17 +0200)]
fix how wifi's host_rate is used in communicate()

- Enforce that we use the first provided link for the src host,
  and the last one for the dst host
- Assert that the provided links are actually associated to by the right host
- Fix the test that was missing an association

3 years agofix save src/dst
Martin Quinson [Thu, 14 May 2020 18:16:13 +0000 (20:16 +0200)]
fix save src/dst

3 years agoremove the src and dst from the Link::on_communicate callback since it's now in the...
Martin Quinson [Thu, 14 May 2020 16:29:42 +0000 (18:29 +0200)]
remove the src and dst from the Link::on_communicate callback since it's now in the action

3 years agosave the source and destination hosts in the NetworkAction
Martin Quinson [Thu, 14 May 2020 16:23:02 +0000 (18:23 +0200)]
save the source and destination hosts in the NetworkAction

3 years agostick to our coding standards: getters should have get_ in their name
Martin Quinson [Thu, 14 May 2020 16:01:34 +0000 (18:01 +0200)]
stick to our coding standards: getters should have get_ in their name

3 years agothird time's the charm. It was already done properly for smpicc, so just port it...
Augustin Degomme [Wed, 13 May 2020 12:44:02 +0000 (14:44 +0200)]
third time's the charm. It was already done properly for smpicc, so just port it to smpicxx

3 years agodisable on osx as -z is not supported there
Augustin Degomme [Wed, 13 May 2020 12:11:37 +0000 (14:11 +0200)]
disable on osx as -z is not supported there

3 years agoadd definitions check to link phase in SMPI (gh #342).. let's see how many ci workers...
Augustin Degomme [Wed, 13 May 2020 11:15:24 +0000 (13:15 +0200)]
add definitions check to link phase in SMPI (gh #342).. let's see how many ci workers complain

3 years agosonar: also ignore S5271 for the examples in C++
Martin Quinson [Sun, 10 May 2020 20:17:19 +0000 (22:17 +0200)]
sonar: also ignore S5271 for the examples in C++

Plus fix some other warnings reported by sonar.

3 years agoPlease the checkers (sonar, codacy)
Martin Quinson [Sun, 10 May 2020 13:02:46 +0000 (15:02 +0200)]
Please the checkers (sonar, codacy)

- reduce the scope of a variable
- Mark a constructor as explicit
- Blindly obey the given hints about javascript that I don't really master

3 years agodo not downcast activities to the wrong type just to get their name
Martin Quinson [Sun, 10 May 2020 12:41:20 +0000 (14:41 +0200)]
do not downcast activities to the wrong type just to get their name

- I use a protected method to keep my data private. Doing otherwise
  would trigger sonar to complain.
- The code is not particularly clear this way, but I fail to see how
  to do otherwise: I don't want the getter to become a virtual method.
- This was reported by UndefSan now that we have a test that deadlocks.

3 years agoBetter fix for FG#50
Martin Quinson [Sun, 10 May 2020 11:47:44 +0000 (13:47 +0200)]
Better fix for FG#50

- The previous solution was not allowing the suspended actor to be resumed properly
- Instead of going for a complex story where we create an activity on
  which to suspend the actor, simply unschedule it on suspend(), and
  explicitely reschedule it on resume()
- This is much easier since we don't have to save and restore the
  simcall of the suspended actor, even if the price to pay is the
  explicit simix_global->actors_to_run.push_back(this); in resume()
  of which I'm not a big fan.

Fixes https://framagit.org/simgrid/simgrid/-/issues/50

3 years agoplease codacy by not setting a variable we won't use
Martin Quinson [Sun, 10 May 2020 10:28:26 +0000 (12:28 +0200)]
please codacy by not setting a variable we won't use

3 years agosonar: ignore more useless warnings in the examples
Martin Quinson [Sun, 10 May 2020 10:09:42 +0000 (12:09 +0200)]
sonar: ignore more useless warnings in the examples

3 years agoFix MC on FreeBSD
Martin Quinson [Sun, 10 May 2020 09:22:18 +0000 (11:22 +0200)]
Fix MC on FreeBSD

3 years agoFix pip builds
Martin Quinson [Sun, 10 May 2020 08:55:18 +0000 (10:55 +0200)]
Fix pip builds

3 years agostick to our coding standards: fields must have a trailing _
Martin Quinson [Sun, 10 May 2020 08:31:26 +0000 (10:31 +0200)]
stick to our coding standards: fields must have a trailing _

3 years agosonar: ignore more crufty warnings about the examples
Martin Quinson [Sun, 10 May 2020 08:10:59 +0000 (10:10 +0200)]
sonar: ignore more crufty warnings about the examples

3 years agoThe examples must be readable. I'll shut off sonar on these issues
Martin Quinson [Sun, 10 May 2020 08:02:03 +0000 (10:02 +0200)]
The examples must be readable. I'll shut off sonar on these issues

3 years agoMC: obey to the rule of 5 to please sonar
Martin Quinson [Sun, 10 May 2020 07:58:45 +0000 (09:58 +0200)]
MC: obey to the rule of 5 to please sonar

3 years agoFix MC+SMPI builds
Martin Quinson [Sun, 10 May 2020 07:52:22 +0000 (09:52 +0200)]
Fix MC+SMPI builds

3 years agoEnsure that suspending an actor running later in the current scheduling round actuall...
Martin Quinson [Sat, 9 May 2020 23:56:20 +0000 (01:56 +0200)]
Ensure that suspending an actor running later in the current scheduling round actually works

Fixes https://framagit.org/simgrid/simgrid/-/issues/50

3 years agocosmetics
Martin Quinson [Sat, 9 May 2020 23:26:00 +0000 (01:26 +0200)]
cosmetics

3 years agoMC: Further renamings
Martin Quinson [Thu, 7 May 2020 17:41:21 +0000 (19:41 +0200)]
MC: Further renamings

3 years agotry to print pointer correctly on sunos as well
Augustin Degomme [Thu, 7 May 2020 08:54:10 +0000 (10:54 +0200)]
try to print pointer correctly on sunos as well

3 years agodoc: add units for message sizes, and try to make smpi/buffering more understandable
Augustin Degomme [Thu, 7 May 2020 07:20:43 +0000 (09:20 +0200)]
doc: add units for message sizes, and try to make smpi/buffering more understandable

3 years agoMC: actually remove the comm channel from RemoteClientMemory
Martin Quinson [Wed, 6 May 2020 23:38:58 +0000 (01:38 +0200)]
MC: actually remove the comm channel from RemoteClientMemory

It is now in remote::CheckerSide. This makes it symmetric with remote::ClientSide

There is still a lot to do to clean things up:
- the actual communication Checker->App is spread all over the place
- the ModelChecker singleton dupplicates the function of the mc::Session
- plus the other ugly things that I fail to see right now given the ambiant mess

3 years agoMC: rename remote/RemoteClient -> remote/RemoteClientMemory and remove networking...
Martin Quinson [Wed, 6 May 2020 23:21:19 +0000 (01:21 +0200)]
MC: rename remote/RemoteClient -> remote/RemoteClientMemory and remove networking from its responsability

3 years agoMC: move a function around + cosmetics
Martin Quinson [Wed, 6 May 2020 23:13:40 +0000 (01:13 +0200)]
MC: move a function around + cosmetics

3 years agoMC: inline a trivial function
Martin Quinson [Wed, 6 May 2020 22:59:21 +0000 (00:59 +0200)]
MC: inline a trivial function

3 years agoMC: rename remote/EventLoop into remote/CheckerSide
Martin Quinson [Wed, 6 May 2020 22:53:05 +0000 (00:53 +0200)]
MC: rename remote/EventLoop into remote/CheckerSide

3 years agoMC: rename remote/Client into remote/AppSide
Martin Quinson [Wed, 6 May 2020 22:46:50 +0000 (00:46 +0200)]
MC: rename remote/Client into remote/AppSide

3 years agoThe return type of the sg_actor_on_exit() callbacks is now 'void'
Martin Quinson [Wed, 6 May 2020 21:43:05 +0000 (23:43 +0200)]
The return type of the sg_actor_on_exit() callbacks is now 'void'

3 years agoactor-exiting: Align the C test with the C++ one
Martin Quinson [Wed, 6 May 2020 21:24:19 +0000 (23:24 +0200)]
actor-exiting: Align the C test with the C++ one

3 years agothe on_exit() of each actor is also executed when the simulation deadlocks
Martin Quinson [Wed, 6 May 2020 20:27:27 +0000 (22:27 +0200)]
the on_exit() of each actor is also executed when the simulation deadlocks

3 years agoExtra header needed by FreeBSD to know SIGCHILD
Martin Quinson [Wed, 6 May 2020 15:39:11 +0000 (17:39 +0200)]
Extra header needed by FreeBSD to know SIGCHILD

3 years agosplit a piece of src/mc/ModelChecker.cpp into src/mc/remote/EventLoop.cpp
Martin Quinson [Wed, 6 May 2020 14:49:06 +0000 (16:49 +0200)]
split a piece of src/mc/ModelChecker.cpp into src/mc/remote/EventLoop.cpp

3 years agoMC: tiny code simplifications
Martin Quinson [Wed, 6 May 2020 01:19:03 +0000 (03:19 +0200)]
MC: tiny code simplifications

3 years agofurther simplify the MC initialization
Martin Quinson [Tue, 5 May 2020 22:22:17 +0000 (00:22 +0200)]
further simplify the MC initialization

3 years agosimplify the MC initialization by using only one env variable
Martin Quinson [Tue, 5 May 2020 22:13:03 +0000 (00:13 +0200)]
simplify the MC initialization by using only one env variable

3 years agoRemove a useless call in MC initialization
Martin Quinson [Tue, 5 May 2020 21:53:15 +0000 (23:53 +0200)]
Remove a useless call in MC initialization

That's a very long time that we don't have two heap regions anymore.

3 years agoFix doc markup to not break the build process
Martin Quinson [Fri, 1 May 2020 13:01:55 +0000 (15:01 +0200)]
Fix doc markup to not break the build process

3 years agomake sure that the doc build failures get detected
Martin Quinson [Fri, 1 May 2020 13:01:05 +0000 (15:01 +0200)]
make sure that the doc build failures get detected

3 years agoUse const reference for std::string parameters.
Arnaud Giersch [Thu, 30 Apr 2020 09:28:58 +0000 (11:28 +0200)]
Use const reference for std::string parameters.

3 years agoAlso check that the i/o operation didn't fail.
Arnaud Giersch [Wed, 29 Apr 2020 12:18:54 +0000 (14:18 +0200)]
Also check that the i/o operation didn't fail.

3 years agoUpdate ChangeLog.
Arnaud Giersch [Wed, 29 Apr 2020 11:56:48 +0000 (13:56 +0200)]
Update ChangeLog.

4 years agoMerge branch 'random_readwritestate' into 'master'
Yann Duplouy [Mon, 27 Apr 2020 17:09:07 +0000 (19:09 +0200)]
Merge branch 'random_readwritestate' into 'master'

[xbt/random] Read/Write the state of the RNG

See merge request simgrid/simgrid!36

4 years agorevalidate tesh files
Frederic Suter [Mon, 27 Apr 2020 17:07:40 +0000 (19:07 +0200)]
revalidate tesh files

4 years agouse signals for smpi tracing of execs
Frederic Suter [Mon, 27 Apr 2020 11:28:14 +0000 (13:28 +0200)]
use signals for smpi tracing of execs

4 years agorefactoring SMPI trace initialization
Frederic Suter [Mon, 27 Apr 2020 10:14:25 +0000 (12:14 +0200)]
refactoring SMPI trace initialization

4 years agoTests whether the file could be opened and removes the temporary file at the end
Yann Duplouy [Mon, 27 Apr 2020 08:02:12 +0000 (10:02 +0200)]
Tests whether the file could be opened and removes the temporary file at the end

4 years agoNow returns true if the file could be opened
Yann Duplouy [Mon, 27 Apr 2020 08:01:40 +0000 (10:01 +0200)]
Now returns true if the file could be opened

4 years agoTries to handle IO errors
Yann Duplouy [Mon, 27 Apr 2020 07:53:58 +0000 (09:53 +0200)]
Tries to handle IO errors

4 years agoremove redundant Link Type
Frederic Suter [Tue, 21 Apr 2020 14:19:40 +0000 (16:19 +0200)]
remove redundant Link Type

4 years agonamespacing cosmetics
Frederic Suter [Tue, 21 Apr 2020 12:42:58 +0000 (14:42 +0200)]
namespacing cosmetics

4 years agomore lambdas
Frederic Suter [Tue, 21 Apr 2020 12:30:30 +0000 (14:30 +0200)]
more lambdas

4 years agoKill obsolete option --cfg=contexts/parallel-threshold.
Arnaud Giersch [Fri, 24 Apr 2020 22:14:01 +0000 (00:14 +0200)]
Kill obsolete option --cfg=contexts/parallel-threshold.

The associated code was removed 4 years ago by commit
9ed461c11fd10eeea596831f2791e359c05d26bf "kill more old cruft: adaptative threshold".

4 years agoUpdate .mailmap.
Arnaud Giersch [Fri, 24 Apr 2020 12:30:58 +0000 (14:30 +0200)]
Update .mailmap.

4 years agoMerged FG!35.
Arnaud Giersch [Fri, 24 Apr 2020 12:02:37 +0000 (14:02 +0200)]
Merged FG!35.

4 years agoMerge branch 'doc' into 'master'
Arnaud Giersch [Fri, 24 Apr 2020 12:02:20 +0000 (14:02 +0200)]
Merge branch 'doc' into 'master'

Add a modeling hint for parallel links in doc

See merge request simgrid/simgrid!35

4 years agoMerged GH!339.
Arnaud Giersch [Fri, 24 Apr 2020 08:29:37 +0000 (10:29 +0200)]
Merged GH!339.

4 years agoAdded Mailbox::set_receiver to python binding
Sylvain Lefebvre [Thu, 23 Apr 2020 03:16:02 +0000 (12:16 +0900)]
Added Mailbox::set_receiver to python binding

4 years agoAdd a modeling hint for parallel links in doc
Julien EMMANUEL [Wed, 4 Mar 2020 09:39:07 +0000 (10:39 +0100)]
Add a modeling hint for parallel links in doc

Explain how to model several parallel links between two routers
(usually useful when modeling fat-tree platforms for example)

4 years agoadd the capacicity to modify links' latency and bandwidth
Frederic Suter [Tue, 21 Apr 2020 11:40:42 +0000 (13:40 +0200)]
add the capacicity to modify links' latency and bandwidth

4 years agoplease sonar
Frederic Suter [Fri, 17 Apr 2020 11:15:46 +0000 (13:15 +0200)]
please sonar

4 years agoTypo fix
Henri Casanova [Mon, 20 Apr 2020 21:43:45 +0000 (11:43 -1000)]
Typo fix

4 years agoUnit test to check if the RNG state is written and read correctly
Yann Duplouy [Wed, 15 Apr 2020 10:15:50 +0000 (12:15 +0200)]
Unit test to check if the RNG state is written and read correctly

4 years agoIt is now possible to read/write the RNG state in a file.
Yann Duplouy [Wed, 15 Apr 2020 09:56:15 +0000 (11:56 +0200)]
It is now possible to read/write the RNG state in a file.

4 years agouse signals on PajeEvent creation/destruction
Frederic Suter [Mon, 6 Apr 2020 10:59:11 +0000 (12:59 +0200)]
use signals on PajeEvent creation/destruction

4 years agostill fighting against this code
Frederic Suter [Sun, 5 Apr 2020 16:15:44 +0000 (18:15 +0200)]
still fighting against this code

4 years agouseless morning cleanups
Frederic Suter [Sun, 5 Apr 2020 09:12:59 +0000 (11:12 +0200)]
useless morning cleanups

4 years agofix that example
Martin Quinson [Thu, 2 Apr 2020 15:02:32 +0000 (17:02 +0200)]
fix that example

4 years agoset_maestro example: improve comments
Martin Quinson [Thu, 2 Apr 2020 13:41:29 +0000 (15:41 +0200)]
set_maestro example: improve comments

4 years agocmake: code simplification (hope it does not break)
Martin Quinson [Thu, 2 Apr 2020 13:41:02 +0000 (15:41 +0200)]
cmake: code simplification (hope it does not break)

4 years agofix distcheck
Frederic Suter [Thu, 2 Apr 2020 13:30:30 +0000 (15:30 +0200)]
fix distcheck