Use const reference for std::string parameters.

diff --git a/include/xbt/random.hpp b/include/xbt/random.hpp
index 81572c7..d4c612f 100644 (file)
--- a/include/xbt/random.hpp
+++ b/include/xbt/random.hpp
@@ -40,12 +40,12 @@ public:
   /**
    * @brief Read the state of the Mersenne-Twister RNG from a file
    */
-  bool read_state(std::string filename);
+  bool read_state(const std::string& filename);
 
   /**
    * @brief Write the state of the Mersenne-Twister RNG to a file
    */
-  bool write_state(std::string filename);
+  bool write_state(const std::string& filename);
 
   /**
    * @brief Draws an integer number uniformly in range [min, max] (min and max included)
@@ -127,12 +127,12 @@ void set_mersenne_seed(int);
 /**
  * @brief Read the state of the Mersenne-Twister RNG from a file.
  */
-bool read_mersenne_state(std::string filename);
+bool read_mersenne_state(const std::string& filename);
 
 /**
  * @brief Write the state of the Mersenne-Twister RNG to a file.
  */
-bool write_mersenne_state(std::string filename);
+bool write_mersenne_state(const std::string& filename);
 
 /**
  * @brief Draws an integer number uniformly in range [min, max] (min and max included)

diff --git a/src/instr/instr_smpi.hpp b/src/instr/instr_smpi.hpp
index 1a9ecf9..aac3353 100644 (file)
--- a/src/instr/instr_smpi.hpp
+++ b/src/instr/instr_smpi.hpp
@@ -20,7 +20,7 @@ XBT_PRIVATE void TRACE_smpi_comm_in(int rank, const char* operation, simgrid::in
 XBT_PRIVATE void TRACE_smpi_comm_out(int rank);
 XBT_PRIVATE void TRACE_smpi_send(int rank, int src, int dst, int tag, int size);
 XBT_PRIVATE void TRACE_smpi_recv(int src, int dst, int tag);
-XBT_PRIVATE void TRACE_smpi_init(int rank, std::string calling_func);
+XBT_PRIVATE void TRACE_smpi_init(int rank, const std::string& calling_func);
 
 /* SMPI + LB (load balancer) */
 XBT_PRIVATE void TRACE_smpi_process_change_host(int rank, const_sg_host_t new_host);

diff --git a/src/smpi/internals/instr_smpi.cpp b/src/smpi/internals/instr_smpi.cpp
index 5dba5c2..1cadb65 100644 (file)
--- a/src/smpi/internals/instr_smpi.cpp
+++ b/src/smpi/internals/instr_smpi.cpp
@@ -146,7 +146,7 @@ void TRACE_smpi_setup_container(int rank, const_sg_host_t host)
   father->create_child(std::string("rank-") + std::to_string(rank), "MPI"); // This container is of type MPI
 }
 
-void TRACE_smpi_init(int rank, std::string calling_func)
+void TRACE_smpi_init(int rank, const std::string& calling_func)
 {
   if (not TRACE_smpi_is_enabled())
     return;

diff --git a/src/xbt/random.cpp b/src/xbt/random.cpp
index 5621f5a..8439dea 100644 (file)
--- a/src/xbt/random.cpp
+++ b/src/xbt/random.cpp
@@ -19,7 +19,7 @@ namespace simgrid {
 namespace xbt {
 namespace random {
 
-bool Random::read_state(std::string filename)
+bool Random::read_state(const std::string& filename)
 {
   std::ifstream file(filename);
   file >> mt19937_gen;
@@ -29,7 +29,7 @@ bool Random::read_state(std::string filename)
   return not file.fail();
 }
 
-bool Random::write_state(std::string filename)
+bool Random::write_state(const std::string& filename)
 {
   std::ofstream file(filename);
   file << mt19937_gen;
@@ -119,12 +119,12 @@ void set_mersenne_seed(int seed)
   default_random->set_seed(seed);
 }
 
-bool read_mersenne_state(std::string filename)
+bool read_mersenne_state(const std::string& filename)
 {
   return default_random->read_state(filename);
 }
 
-bool write_mersenne_state(std::string filename)
+bool write_mersenne_state(const std::string& filename)
 {
   return default_random->write_state(filename);
 }