Frederic Suter [Tue, 10 Oct 2017 06:26:53 +0000 (08:26 +0200)]
please sonar
these are not TODOs anymore
the unused data is a good catch though
Frederic Suter [Tue, 10 Oct 2017 06:11:14 +0000 (08:11 +0200)]
Merge branch 'master' of git+ssh://scm.gforge.inria.fr//gitroot/simgrid/simgrid
Arnaud Giersch [Mon, 9 Oct 2017 13:44:43 +0000 (15:44 +0200)]
Rename file .cc -> .cpp.
Arnaud Giersch [Mon, 9 Oct 2017 10:04:24 +0000 (12:04 +0200)]
Protect C++ code when building in C mode.
Arnaud Giersch [Sat, 7 Oct 2017 12:21:32 +0000 (14:21 +0200)]
Change some struct to class.
Arnaud Giersch [Fri, 6 Oct 2017 21:30:50 +0000 (23:30 +0200)]
Reduce number of Sonar smells in Java examples.
Arnaud Giersch [Fri, 6 Oct 2017 21:14:30 +0000 (23:14 +0200)]
Use Msg logger in Java examples.
Frederic Suter [Mon, 9 Oct 2017 15:25:46 +0000 (17:25 +0200)]
sloppy replacement of dict by map and char* by string
some tesh files have to be revalidated as the order in which the
destruction of containers is logged has changed.
Frederic Suter [Mon, 9 Oct 2017 13:51:07 +0000 (15:51 +0200)]
dict->map
Frederic Suter [Mon, 9 Oct 2017 13:30:28 +0000 (15:30 +0200)]
a dict whose values are "1" (as char* of course) to say a element is
in is a std::set
Frederic Suter [Mon, 9 Oct 2017 07:11:33 +0000 (09:11 +0200)]
fix a tiny todo
Frederic Suter [Mon, 9 Oct 2017 06:54:54 +0000 (08:54 +0200)]
stringify a bit
Frederic Suter [Mon, 9 Oct 2017 06:39:09 +0000 (08:39 +0200)]
use initialisation lists (and std::string)
Martin Quinson [Sun, 8 Oct 2017 21:14:15 +0000 (23:14 +0200)]
update the doc on how to release
Martin Quinson [Sun, 8 Oct 2017 21:14:03 +0000 (23:14 +0200)]
start the dev of the next version
Martin Quinson [Sun, 8 Oct 2017 16:44:53 +0000 (18:44 +0200)]
Release v3.17
Martin Quinson [Sun, 8 Oct 2017 16:48:20 +0000 (18:48 +0200)]
improve doc of how to release
Martin Quinson [Sun, 8 Oct 2017 16:47:14 +0000 (18:47 +0200)]
Integrate a Debian patch (armel portability)
Martin Quinson [Sun, 8 Oct 2017 16:44:31 +0000 (18:44 +0200)]
codacy
Martin Quinson [Fri, 6 Oct 2017 05:47:30 +0000 (07:47 +0200)]
prepare the files for the next release
Martin Quinson [Fri, 6 Oct 2017 05:44:09 +0000 (07:44 +0200)]
we will get ride of <include> very soon
Arnaud Giersch [Thu, 5 Oct 2017 21:02:09 +0000 (23:02 +0200)]
Cover the Full network/optim.
Arnaud Giersch [Thu, 5 Oct 2017 20:52:17 +0000 (22:52 +0200)]
Cover the Reno2 network model.
Arnaud Giersch [Thu, 5 Oct 2017 20:37:31 +0000 (22:37 +0200)]
Set routing="None" for constant network model.
Arnaud Giersch [Thu, 5 Oct 2017 20:30:21 +0000 (22:30 +0200)]
Kill dead code: it's already split between CpuAction and NetworkCm02Action.
Arnaud Giersch [Thu, 5 Oct 2017 19:48:33 +0000 (21:48 +0200)]
Fix invalid free when SIMIX_global_init() exits early.
Martin Quinson [Thu, 5 Oct 2017 20:20:30 +0000 (22:20 +0200)]
add a test to cover the Constant-time network model
Arnaud Giersch [Thu, 5 Oct 2017 11:36:23 +0000 (13:36 +0200)]
Add tests for xbt/log and fix some memory leaks.
Arnaud Giersch [Thu, 5 Oct 2017 07:55:48 +0000 (09:55 +0200)]
Factorize code.
Arnaud Giersch [Thu, 5 Oct 2017 06:53:09 +0000 (08:53 +0200)]
Another try to silence sonar on commented lines of code.
Arnaud Giersch [Thu, 5 Oct 2017 06:48:49 +0000 (08:48 +0200)]
Remove a few more commented lines of code.
Arnaud Giersch [Wed, 4 Oct 2017 21:43:39 +0000 (23:43 +0200)]
Reduce scope for variable.
Martin Quinson [Thu, 5 Oct 2017 06:21:33 +0000 (08:21 +0200)]
this variable is accessed concurrently (thanks TSan)
Arnaud Giersch [Wed, 4 Oct 2017 21:15:15 +0000 (23:15 +0200)]
Reduce cognitive complexity (sonar).
Arnaud Giersch [Wed, 4 Oct 2017 20:56:01 +0000 (22:56 +0200)]
Avoid implicit bool to int conversion.
Arnaud Giersch [Wed, 4 Oct 2017 20:26:21 +0000 (22:26 +0200)]
Remove side effects from right hand operands of && or ||.
Arnaud Giersch [Wed, 4 Oct 2017 20:07:32 +0000 (22:07 +0200)]
Add a dummy action in empty catch block (sonar).
Arnaud Giersch [Wed, 4 Oct 2017 20:06:12 +0000 (22:06 +0200)]
Reduce code duplication.
Arnaud Giersch [Wed, 4 Oct 2017 16:43:57 +0000 (18:43 +0200)]
Remove lines of commented code spotted by sonar.
Martin Quinson [Wed, 4 Oct 2017 20:04:29 +0000 (22:04 +0200)]
cosmetics in field names (and fix MC builds)
Martin Quinson [Wed, 4 Oct 2017 19:40:54 +0000 (21:40 +0200)]
sonar cleanups
Martin Quinson [Wed, 4 Oct 2017 19:02:39 +0000 (21:02 +0200)]
Deprecate an obscure part of the XML format
Martin Quinson [Wed, 4 Oct 2017 18:57:14 +0000 (20:57 +0200)]
sonar: also exclude java tests from coverage
Arnaud Giersch [Wed, 4 Oct 2017 14:45:38 +0000 (16:45 +0200)]
Cannot have comm == MPI_COMM_NULL here.
Arnaud Giersch [Wed, 4 Oct 2017 13:55:58 +0000 (15:55 +0200)]
Delete obsolete hack.
Arnaud Giersch [Wed, 4 Oct 2017 13:38:29 +0000 (15:38 +0200)]
Remove unused functions from xbt_os_thread.
Functions: xbt_os_thread_cancel(), xbt_os_thread_detach(), _os_thread_ex_terminate().
Arnaud Giersch [Wed, 4 Oct 2017 10:18:16 +0000 (12:18 +0200)]
Removed unused functions from xbt_str.
Functions: xbt_str_split_str(), xbt_str_subst(), xbt_str_ltrim(),
xbt_str_rtrim(), xbt_str_trim().
Arnaud Giersch [Wed, 4 Oct 2017 13:40:59 +0000 (15:40 +0200)]
Delete trailing spaces.
Arnaud Giersch [Wed, 4 Oct 2017 09:24:06 +0000 (11:24 +0200)]
A call to bprintf is enough here.
Arnaud Giersch [Tue, 3 Oct 2017 20:39:07 +0000 (22:39 +0200)]
Use std::replace instead of xbt_str_subst in C++ files.
Arnaud Giersch [Tue, 3 Oct 2017 19:43:05 +0000 (21:43 +0200)]
Remove useless includes for xbt/str.h.
Martin Quinson [Wed, 4 Oct 2017 13:22:22 +0000 (15:22 +0200)]
Merge branch 'master' of github.com:simgrid/simgrid
Martin Quinson [Wed, 4 Oct 2017 13:17:02 +0000 (15:17 +0200)]
codacy
Martin Quinson [Wed, 4 Oct 2017 13:17:02 +0000 (15:17 +0200)]
codacy
Christian Heinrich [Tue, 3 Oct 2017 16:19:32 +0000 (18:19 +0200)]
[SMPI] Renamed smpi_*_data_exe as a first step for overhaul of the privatization
We will introduce a smpi_data_exe_copy variable soon and
we want more uniform names; having the (size|copy|start) at the end makes it much
simpler for us to grep for these variables.
Martin Quinson [Tue, 3 Oct 2017 10:51:19 +0000 (12:51 +0200)]
enable MPICH3 tests on travis to get the associated coverage on sonar
Martin Quinson [Mon, 2 Oct 2017 23:01:44 +0000 (01:01 +0200)]
fix teshfile according to my recent cosmetics
Martin Quinson [Mon, 2 Oct 2017 22:55:48 +0000 (00:55 +0200)]
sonar: fix a syntax error in the file
Martin Quinson [Mon, 2 Oct 2017 22:43:12 +0000 (00:43 +0200)]
ignore the newly created binary
Martin Quinson [Mon, 2 Oct 2017 22:27:13 +0000 (00:27 +0200)]
further reduce the differences between the s4u-async examples
Martin Quinson [Mon, 2 Oct 2017 22:05:38 +0000 (00:05 +0200)]
various cosmetics in the s4u-async-wait example
Martin Quinson [Mon, 2 Oct 2017 21:28:11 +0000 (23:28 +0200)]
cosmetics and doc
Martin Quinson [Mon, 2 Oct 2017 21:21:40 +0000 (23:21 +0200)]
simplification, and don't miss any such file
Martin Quinson [Sun, 1 Oct 2017 21:57:10 +0000 (23:57 +0200)]
update changelog
Martin Quinson [Mon, 2 Oct 2017 19:49:53 +0000 (21:49 +0200)]
Merge pull request #224 from Takishipp/async-wait
Add s4u-async-wait to the examples of s4u
Zitagcc [Mon, 2 Oct 2017 16:02:10 +0000 (18:02 +0200)]
Merge branch 'master' into async-wait
Takishipp [Mon, 2 Oct 2017 16:02:57 +0000 (18:02 +0200)]
s4u-async-wait is complete
Arnaud Giersch [Sun, 1 Oct 2017 20:32:48 +0000 (22:32 +0200)]
Reintroduce lines removed at commit
5bc3597e1513c7b94497ae0ea819e5fa2e28058a.
Only put them in SIMIX_clean instead of SIMIX_process_killall.
I don't really understand when/why they are useful, but the call to
SIMIX_process_empty_trash() fixes a leak seen with teshsuite/mc/random-bug.
Arnaud Giersch [Sun, 1 Oct 2017 20:00:26 +0000 (22:00 +0200)]
Cosmetics.
Martin Quinson [Sat, 30 Sep 2017 22:24:43 +0000 (00:24 +0200)]
improve changelog for the upcoming release
Martin Quinson [Sat, 30 Sep 2017 22:24:24 +0000 (00:24 +0200)]
sonar: try to exclude java from coverage
Martin Quinson [Sat, 30 Sep 2017 21:31:58 +0000 (23:31 +0200)]
document a class
Martin Quinson [Sat, 30 Sep 2017 21:22:08 +0000 (23:22 +0200)]
shutdown all hosted VMs when an host is turned off
Martin Quinson [Sat, 30 Sep 2017 21:20:12 +0000 (23:20 +0200)]
sonar: don't check for memleaks, you suck at it
Martin Quinson [Sat, 30 Sep 2017 20:35:54 +0000 (22:35 +0200)]
add some bits of the commit log into the code comments
Arnaud Giersch [Sat, 30 Sep 2017 19:46:54 +0000 (21:46 +0200)]
Complete s4u-actor-kill to include a test for Actor::killAll().
Arnaud Giersch [Sat, 30 Sep 2017 19:40:08 +0000 (21:40 +0200)]
Fix process_killall. Closes #186.
This was never tested, or it was a long time ago.
Arnaud Giersch [Fri, 29 Sep 2017 21:00:56 +0000 (23:00 +0200)]
Simply finish the surf sleep action on process join.
It is much more simpler, and permits to kill the processes involved in join.
Fixes github bug #225.
Arnaud Giersch [Fri, 29 Sep 2017 20:39:56 +0000 (22:39 +0200)]
Revert "Derive custom exception from std::exception."
This reverts commit
7198a3162eaae82fa2ec5c612d5ae22e243055d7.
Make it impossible for user code to catch a StopRequest with a
try {} catch (std::exception).
Sonar will be whining but I don't care.
Arnaud Giersch [Fri, 29 Sep 2017 20:23:01 +0000 (22:23 +0200)]
Action::finish() is never used without setState().
Add the new state as a parameter for finish().
Arnaud Giersch [Fri, 29 Sep 2017 20:08:20 +0000 (22:08 +0200)]
Remove function from list before use.
Arnaud Giersch [Thu, 28 Sep 2017 20:23:53 +0000 (22:23 +0200)]
Remove old commented code.
Arnaud Giersch [Thu, 28 Sep 2017 14:21:44 +0000 (16:21 +0200)]
Boost contexts: inform ASan about context switches.
Arnaud Giersch [Thu, 28 Sep 2017 13:53:22 +0000 (15:53 +0200)]
Check if ASan is enabled from CMake, and define variables.
HAVE_SANITIZE_ADDRESS if AddressSanitizer is enabled
HAVE_SANITIZE_ADDRESS_FIBER_SUPPORT if current ASan version includes Fiber annotation interface
Update smpi_memory.cpp in consequence.
Arnaud Giersch [Wed, 27 Sep 2017 21:31:25 +0000 (23:31 +0200)]
Align top of stacks to a multiple of 16.
It's needed for Asan not to whine.
Martin Quinson [Thu, 28 Sep 2017 05:58:08 +0000 (07:58 +0200)]
fix build on weird clangs
Martin Quinson [Thu, 21 Sep 2017 23:08:47 +0000 (01:08 +0200)]
instr: prefer std::str to char*
Arnaud Giersch [Wed, 27 Sep 2017 09:41:54 +0000 (11:41 +0200)]
Add explicit keyword, and remove default value for parameter.
Arnaud Giersch [Wed, 27 Sep 2017 09:23:55 +0000 (11:23 +0200)]
Delete unused copy constructor.
Arnaud Giersch [Wed, 27 Sep 2017 08:44:39 +0000 (10:44 +0200)]
Update ChangeLog.
Close #120, #222.
Arnaud Giersch [Wed, 27 Sep 2017 08:16:00 +0000 (10:16 +0200)]
Test comm before cancelation, and kill last leak in this test! \o/
Arnaud Giersch [Tue, 26 Sep 2017 13:16:53 +0000 (15:16 +0200)]
Delete timer on removal.
Arnaud Giersch [Tue, 26 Sep 2017 13:14:56 +0000 (15:14 +0200)]
Change xbt_heap_rm_elm to return the removed element, or NULL.
Arnaud Giersch [Tue, 26 Sep 2017 11:35:09 +0000 (13:35 +0200)]
s4u-dht-chord: cancel pending comm.
The timings are slightly changed (tesh updated).
Arnaud Giersch [Tue, 26 Sep 2017 11:32:19 +0000 (13:32 +0200)]
s4u-dht-chord: free detached comms.
Arnaud Giersch [Tue, 26 Sep 2017 09:38:02 +0000 (11:38 +0200)]
Allow to specify a cleanup handler for detached comms.
Arnaud Giersch [Tue, 26 Sep 2017 09:27:34 +0000 (11:27 +0200)]
Implement basic backtrace cut for --cfg=exception/cutpath.
This option became a no-op when the exceptions were ported to C++.
Arnaud Giersch [Mon, 25 Sep 2017 20:23:10 +0000 (22:23 +0200)]
Fix most of the remaining leaks in msg-host_on_off_processes.
Only Test 6 remains unfixed, because it would change the test output.
See FIXME comment at line 179.
Arnaud Giersch [Mon, 25 Sep 2017 09:03:29 +0000 (11:03 +0200)]
Disable broken test.
It gives a yellow bullet on Jenkins, and doesn't bring anything.
More precisely, the test aborts early because MPI_Type_extent doesn't give
the expected result (Unexpected extent for small struct). The result of
the test was however never verified, since the test is only used by the
model checker.
On the FreeBSD node (clang/libc++), something is broken with exception
handling and the model checker hangs indefinitely at context's ::stop(),
when a StopRequest exception is launched.
The test can be reactivated either when MPI_Type_extent is fixed, or an
update corrects the problems on FreeBSD.
Arnaud Giersch [Fri, 22 Sep 2017 22:21:41 +0000 (00:21 +0200)]
More cleanup in contexts' stop().
Call Context::stop() at upper level: save an exception, and hopefully fix
MC tests on FreeBSD, even if I don't really understand what's going wrong.