Martin Quinson [Thu, 14 May 2020 18:17:31 +0000 (20:17 +0200)]
fix how wifi's host_rate is used in communicate()
- Enforce that we use the first provided link for the src host,
and the last one for the dst host
- Assert that the provided links are actually associated to by the right host
- Fix the test that was missing an association
Martin Quinson [Thu, 14 May 2020 18:16:13 +0000 (20:16 +0200)]
fix save src/dst
Martin Quinson [Thu, 14 May 2020 16:29:42 +0000 (18:29 +0200)]
remove the src and dst from the Link::on_communicate callback since it's now in the action
Martin Quinson [Thu, 14 May 2020 16:23:02 +0000 (18:23 +0200)]
save the source and destination hosts in the NetworkAction
Martin Quinson [Thu, 14 May 2020 16:01:34 +0000 (18:01 +0200)]
stick to our coding standards: getters should have get_ in their name
Augustin Degomme [Wed, 13 May 2020 12:44:02 +0000 (14:44 +0200)]
third time's the charm. It was already done properly for smpicc, so just port it to smpicxx
Augustin Degomme [Wed, 13 May 2020 12:11:37 +0000 (14:11 +0200)]
disable on osx as -z is not supported there
Augustin Degomme [Wed, 13 May 2020 11:15:24 +0000 (13:15 +0200)]
add definitions check to link phase in SMPI (gh #342).. let's see how many ci workers complain
Martin Quinson [Sun, 10 May 2020 20:17:19 +0000 (22:17 +0200)]
sonar: also ignore S5271 for the examples in C++
Plus fix some other warnings reported by sonar.
Martin Quinson [Sun, 10 May 2020 13:02:46 +0000 (15:02 +0200)]
Please the checkers (sonar, codacy)
- reduce the scope of a variable
- Mark a constructor as explicit
- Blindly obey the given hints about javascript that I don't really master
Martin Quinson [Sun, 10 May 2020 12:41:20 +0000 (14:41 +0200)]
do not downcast activities to the wrong type just to get their name
- I use a protected method to keep my data private. Doing otherwise
would trigger sonar to complain.
- The code is not particularly clear this way, but I fail to see how
to do otherwise: I don't want the getter to become a virtual method.
- This was reported by UndefSan now that we have a test that deadlocks.
Martin Quinson [Sun, 10 May 2020 11:47:44 +0000 (13:47 +0200)]
Better fix for FG#50
- The previous solution was not allowing the suspended actor to be resumed properly
- Instead of going for a complex story where we create an activity on
which to suspend the actor, simply unschedule it on suspend(), and
explicitely reschedule it on resume()
- This is much easier since we don't have to save and restore the
simcall of the suspended actor, even if the price to pay is the
explicit simix_global->actors_to_run.push_back(this); in resume()
of which I'm not a big fan.
Fixes https://framagit.org/simgrid/simgrid/-/issues/50
Martin Quinson [Sun, 10 May 2020 10:28:26 +0000 (12:28 +0200)]
please codacy by not setting a variable we won't use
Martin Quinson [Sun, 10 May 2020 10:09:42 +0000 (12:09 +0200)]
sonar: ignore more useless warnings in the examples
Martin Quinson [Sun, 10 May 2020 09:22:18 +0000 (11:22 +0200)]
Fix MC on FreeBSD
Martin Quinson [Sun, 10 May 2020 08:55:18 +0000 (10:55 +0200)]
Fix pip builds
Martin Quinson [Sun, 10 May 2020 08:31:26 +0000 (10:31 +0200)]
stick to our coding standards: fields must have a trailing _
Martin Quinson [Sun, 10 May 2020 08:10:59 +0000 (10:10 +0200)]
sonar: ignore more crufty warnings about the examples
Martin Quinson [Sun, 10 May 2020 08:02:03 +0000 (10:02 +0200)]
The examples must be readable. I'll shut off sonar on these issues
Martin Quinson [Sun, 10 May 2020 07:58:45 +0000 (09:58 +0200)]
MC: obey to the rule of 5 to please sonar
Martin Quinson [Sun, 10 May 2020 07:52:22 +0000 (09:52 +0200)]
Fix MC+SMPI builds
Martin Quinson [Sat, 9 May 2020 23:56:20 +0000 (01:56 +0200)]
Ensure that suspending an actor running later in the current scheduling round actually works
Fixes https://framagit.org/simgrid/simgrid/-/issues/50
Martin Quinson [Sat, 9 May 2020 23:26:00 +0000 (01:26 +0200)]
cosmetics
Martin Quinson [Thu, 7 May 2020 17:41:21 +0000 (19:41 +0200)]
MC: Further renamings
Augustin Degomme [Thu, 7 May 2020 08:54:10 +0000 (10:54 +0200)]
try to print pointer correctly on sunos as well
Augustin Degomme [Thu, 7 May 2020 07:20:43 +0000 (09:20 +0200)]
doc: add units for message sizes, and try to make smpi/buffering more understandable
Martin Quinson [Wed, 6 May 2020 23:38:58 +0000 (01:38 +0200)]
MC: actually remove the comm channel from RemoteClientMemory
It is now in remote::CheckerSide. This makes it symmetric with remote::ClientSide
There is still a lot to do to clean things up:
- the actual communication Checker->App is spread all over the place
- the ModelChecker singleton dupplicates the function of the mc::Session
- plus the other ugly things that I fail to see right now given the ambiant mess
Martin Quinson [Wed, 6 May 2020 23:21:19 +0000 (01:21 +0200)]
MC: rename remote/RemoteClient -> remote/RemoteClientMemory and remove networking from its responsability
Martin Quinson [Wed, 6 May 2020 23:13:40 +0000 (01:13 +0200)]
MC: move a function around + cosmetics
Martin Quinson [Wed, 6 May 2020 22:59:21 +0000 (00:59 +0200)]
MC: inline a trivial function
Martin Quinson [Wed, 6 May 2020 22:53:05 +0000 (00:53 +0200)]
MC: rename remote/EventLoop into remote/CheckerSide
Martin Quinson [Wed, 6 May 2020 22:46:50 +0000 (00:46 +0200)]
MC: rename remote/Client into remote/AppSide
Martin Quinson [Wed, 6 May 2020 21:43:05 +0000 (23:43 +0200)]
The return type of the sg_actor_on_exit() callbacks is now 'void'
Martin Quinson [Wed, 6 May 2020 21:24:19 +0000 (23:24 +0200)]
actor-exiting: Align the C test with the C++ one
Martin Quinson [Wed, 6 May 2020 20:27:27 +0000 (22:27 +0200)]
the on_exit() of each actor is also executed when the simulation deadlocks
Martin Quinson [Wed, 6 May 2020 15:39:11 +0000 (17:39 +0200)]
Extra header needed by FreeBSD to know SIGCHILD
Martin Quinson [Wed, 6 May 2020 14:49:06 +0000 (16:49 +0200)]
split a piece of src/mc/ModelChecker.cpp into src/mc/remote/EventLoop.cpp
Martin Quinson [Wed, 6 May 2020 01:19:03 +0000 (03:19 +0200)]
MC: tiny code simplifications
Martin Quinson [Tue, 5 May 2020 22:22:17 +0000 (00:22 +0200)]
further simplify the MC initialization
Martin Quinson [Tue, 5 May 2020 22:13:03 +0000 (00:13 +0200)]
simplify the MC initialization by using only one env variable
Martin Quinson [Tue, 5 May 2020 21:53:15 +0000 (23:53 +0200)]
Remove a useless call in MC initialization
That's a very long time that we don't have two heap regions anymore.
Martin Quinson [Fri, 1 May 2020 13:01:55 +0000 (15:01 +0200)]
Fix doc markup to not break the build process
Martin Quinson [Fri, 1 May 2020 13:01:05 +0000 (15:01 +0200)]
make sure that the doc build failures get detected
Arnaud Giersch [Thu, 30 Apr 2020 09:28:58 +0000 (11:28 +0200)]
Use const reference for std::string parameters.
Arnaud Giersch [Wed, 29 Apr 2020 12:18:54 +0000 (14:18 +0200)]
Also check that the i/o operation didn't fail.
Arnaud Giersch [Wed, 29 Apr 2020 11:56:48 +0000 (13:56 +0200)]
Update ChangeLog.
Yann Duplouy [Mon, 27 Apr 2020 17:09:07 +0000 (19:09 +0200)]
Merge branch 'random_readwritestate' into 'master'
[xbt/random] Read/Write the state of the RNG
See merge request simgrid/simgrid!36
Frederic Suter [Mon, 27 Apr 2020 17:07:40 +0000 (19:07 +0200)]
revalidate tesh files
Frederic Suter [Mon, 27 Apr 2020 11:28:14 +0000 (13:28 +0200)]
use signals for smpi tracing of execs
Frederic Suter [Mon, 27 Apr 2020 10:14:25 +0000 (12:14 +0200)]
refactoring SMPI trace initialization
Yann Duplouy [Mon, 27 Apr 2020 08:02:12 +0000 (10:02 +0200)]
Tests whether the file could be opened and removes the temporary file at the end
Yann Duplouy [Mon, 27 Apr 2020 08:01:40 +0000 (10:01 +0200)]
Now returns true if the file could be opened
Yann Duplouy [Mon, 27 Apr 2020 07:53:58 +0000 (09:53 +0200)]
Tries to handle IO errors
Frederic Suter [Tue, 21 Apr 2020 14:19:40 +0000 (16:19 +0200)]
remove redundant Link Type
Frederic Suter [Tue, 21 Apr 2020 12:42:58 +0000 (14:42 +0200)]
namespacing cosmetics
Frederic Suter [Tue, 21 Apr 2020 12:30:30 +0000 (14:30 +0200)]
more lambdas
Arnaud Giersch [Fri, 24 Apr 2020 22:14:01 +0000 (00:14 +0200)]
Kill obsolete option --cfg=contexts/parallel-threshold.
The associated code was removed 4 years ago by commit
9ed461c11fd10eeea596831f2791e359c05d26bf "kill more old cruft: adaptative threshold".
Arnaud Giersch [Fri, 24 Apr 2020 12:30:58 +0000 (14:30 +0200)]
Update .mailmap.
Arnaud Giersch [Fri, 24 Apr 2020 12:02:37 +0000 (14:02 +0200)]
Merged FG!35.
Arnaud Giersch [Fri, 24 Apr 2020 12:02:20 +0000 (14:02 +0200)]
Merge branch 'doc' into 'master'
Add a modeling hint for parallel links in doc
See merge request simgrid/simgrid!35
Arnaud Giersch [Fri, 24 Apr 2020 08:29:37 +0000 (10:29 +0200)]
Merged GH!339.
Sylvain Lefebvre [Thu, 23 Apr 2020 03:16:02 +0000 (12:16 +0900)]
Added Mailbox::set_receiver to python binding
Julien EMMANUEL [Wed, 4 Mar 2020 09:39:07 +0000 (10:39 +0100)]
Add a modeling hint for parallel links in doc
Explain how to model several parallel links between two routers
(usually useful when modeling fat-tree platforms for example)
Frederic Suter [Tue, 21 Apr 2020 11:40:42 +0000 (13:40 +0200)]
add the capacicity to modify links' latency and bandwidth
Frederic Suter [Fri, 17 Apr 2020 11:15:46 +0000 (13:15 +0200)]
please sonar
Henri Casanova [Mon, 20 Apr 2020 21:43:45 +0000 (11:43 -1000)]
Typo fix
Yann Duplouy [Wed, 15 Apr 2020 10:15:50 +0000 (12:15 +0200)]
Unit test to check if the RNG state is written and read correctly
Yann Duplouy [Wed, 15 Apr 2020 09:56:15 +0000 (11:56 +0200)]
It is now possible to read/write the RNG state in a file.
Frederic Suter [Mon, 6 Apr 2020 10:59:11 +0000 (12:59 +0200)]
use signals on PajeEvent creation/destruction
Frederic Suter [Sun, 5 Apr 2020 16:15:44 +0000 (18:15 +0200)]
still fighting against this code
Frederic Suter [Sun, 5 Apr 2020 09:12:59 +0000 (11:12 +0200)]
useless morning cleanups
Martin Quinson [Thu, 2 Apr 2020 15:02:32 +0000 (17:02 +0200)]
fix that example
Martin Quinson [Thu, 2 Apr 2020 13:41:29 +0000 (15:41 +0200)]
set_maestro example: improve comments
Martin Quinson [Thu, 2 Apr 2020 13:41:02 +0000 (15:41 +0200)]
cmake: code simplification (hope it does not break)
Frederic Suter [Thu, 2 Apr 2020 13:30:30 +0000 (15:30 +0200)]
fix distcheck
Frederic Suter [Thu, 2 Apr 2020 11:14:52 +0000 (13:14 +0200)]
oops MSG_init() does more than simgrid_init()
Frederic Suter [Thu, 2 Apr 2020 11:02:26 +0000 (13:02 +0200)]
revalidate Java tesh files
Frederic Suter [Thu, 2 Apr 2020 10:19:08 +0000 (12:19 +0200)]
add a tesh for bugged2-liveness
Do not test it because it never ends, but at least now if one wants to
do something clever with this test, one can ;)
Frederic Suter [Thu, 2 Apr 2020 09:24:08 +0000 (11:24 +0200)]
reduce dependency on msg.h
Arnaud Giersch [Mon, 30 Mar 2020 20:15:23 +0000 (22:15 +0200)]
Use the object copied as operand for sizeof.
Frederic Suter [Wed, 1 Apr 2020 14:58:48 +0000 (16:58 +0200)]
this was never tested and neither a bug finder
Loic Guegan [Wed, 1 Apr 2020 15:53:09 +0000 (17:53 +0200)]
Add new tests to MANIFEST.in
Loic Guegan [Wed, 1 Apr 2020 14:39:13 +0000 (16:39 +0200)]
Add WIFI decay model along with tesh tests.
Frederic Suter [Wed, 1 Apr 2020 09:41:49 +0000 (11:41 +0200)]
less MSG and less process
Frederic Suter [Wed, 1 Apr 2020 09:28:55 +0000 (11:28 +0200)]
add sg_actor_list() and sg_actor_count()
deprecate stuff for consistency and undynarification
Frederic Suter [Mon, 30 Mar 2020 15:34:52 +0000 (17:34 +0200)]
last call to MSG_hosts_as_dynar -> deprecate !
Frederic Suter [Mon, 30 Mar 2020 15:09:37 +0000 (17:09 +0200)]
do not include msg.h when not needed
Frederic Suter [Mon, 30 Mar 2020 14:18:48 +0000 (16:18 +0200)]
useless stuff: do not use MSG in java bindings when possible
Frederic Suter [Mon, 30 Mar 2020 13:18:55 +0000 (15:18 +0200)]
use listen_from in s4u test and kill the MSG one
Frederic Suter [Mon, 30 Mar 2020 13:18:32 +0000 (15:18 +0200)]
add Mailox_listen_from
Frederic Suter [Mon, 30 Mar 2020 10:41:55 +0000 (12:41 +0200)]
convert get-sender test
Frederic Suter [Mon, 30 Mar 2020 10:39:50 +0000 (12:39 +0200)]
fix Comm::get_sender()
Matching sender and receiving modifies the CommImpl fields used to
store the sending and receiving actors, not those in Comm. Then to
know the sender on the receiving side one have to look at the kernel
level.
Frederic Suter [Sun, 29 Mar 2020 17:20:39 +0000 (19:20 +0200)]
the extraction of the graph is a NetZone method
Frederic Suter [Sun, 29 Mar 2020 12:19:49 +0000 (14:19 +0200)]
cpp-ify and simpifly functions used by graphicator
this actually doesn't not need instr at all. Then we can further
simplify the graphicator itself.
Frederic Suter [Sun, 29 Mar 2020 12:08:42 +0000 (14:08 +0200)]
convert graphicator to C++
also test the output .dot file in tesh
Frederic Suter [Sun, 29 Mar 2020 11:45:07 +0000 (13:45 +0200)]
cosmetics
Augustin Degomme [Sun, 29 Mar 2020 11:37:40 +0000 (13:37 +0200)]
gcov might not be the name of the executable, respect GCOV environment variable in this case
Arnaud Giersch [Sat, 28 Mar 2020 22:02:37 +0000 (23:02 +0100)]
Silly workaround for coverage build with gcc-10.
Error is: internal compiler error: in coverage_begin_function, at coverage.c:655
Frederic Suter [Sat, 28 Mar 2020 13:20:56 +0000 (14:20 +0100)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid
Arnaud Giersch [Sat, 28 Mar 2020 09:50:13 +0000 (10:50 +0100)]
Hide spurious odr violations warnings.