Frederic Suter [Fri, 24 Feb 2017 14:21:18 +0000 (15:21 +0100)]
woops
Frederic Suter [Fri, 24 Feb 2017 13:47:51 +0000 (14:47 +0100)]
WIP stop using const char* in C++ layers
(and ugly bprintf, const_cast and free that sonar doesn't like)
Martin Quinson [Fri, 24 Feb 2017 10:55:21 +0000 (11:55 +0100)]
cosmetics in ChangeLog
Martin Quinson [Fri, 24 Feb 2017 10:43:14 +0000 (11:43 +0100)]
please sonar
- Remove redundent declaration
- mark functions as extern "C" in their declaration, not only prototypes
- also stop having a C function and a C++ function sharing the same
name with differing prototypes, even if sonar did not complain.
Martin Quinson [Fri, 24 Feb 2017 08:42:01 +0000 (09:42 +0100)]
please sonar by moving includes at the top
degomme [Fri, 24 Feb 2017 10:14:54 +0000 (11:14 +0100)]
Update changelog
Martin Quinson [Fri, 24 Feb 2017 07:09:05 +0000 (08:09 +0100)]
plug some other memleaks
Martin Quinson [Fri, 24 Feb 2017 03:19:20 +0000 (04:19 +0100)]
plug a bunch of memleaks
Martin Quinson [Fri, 24 Feb 2017 02:38:21 +0000 (03:38 +0100)]
cosmetics while digging for a memleak
Martin Quinson [Fri, 24 Feb 2017 02:24:58 +0000 (03:24 +0100)]
plug a memleak. I should beter kill that XBT container instead
Martin Quinson [Fri, 24 Feb 2017 02:03:20 +0000 (03:03 +0100)]
plug an obvious memleak
Martin Quinson [Thu, 23 Feb 2017 23:50:16 +0000 (00:50 +0100)]
tesh: better handling of very large sorted output
- truncate the diff at 250 lines (in any cases)
- show the unsorted output if the diff was asked to be sorted
Martin Quinson [Thu, 23 Feb 2017 11:27:10 +0000 (12:27 +0100)]
fix a suppurious failure on sanitizers
Martin Quinson [Thu, 23 Feb 2017 11:21:29 +0000 (12:21 +0100)]
save some useless calls when there is no request to handle
Martin Quinson [Thu, 23 Feb 2017 11:16:26 +0000 (12:16 +0100)]
cosmetics for sonar
degomme [Thu, 23 Feb 2017 11:03:39 +0000 (12:03 +0100)]
Avoid unsafe things
degomme [Thu, 23 Feb 2017 09:34:06 +0000 (10:34 +0100)]
save some more lines
Frederic Suter [Thu, 23 Feb 2017 10:52:26 +0000 (11:52 +0100)]
smells and bugs
Martin Quinson [Thu, 23 Feb 2017 10:40:41 +0000 (11:40 +0100)]
Also hash the first char, and please sonar by splitting increment to its own expr
Martin Quinson [Thu, 23 Feb 2017 09:56:52 +0000 (10:56 +0100)]
change a 'use after free' into a leak. For now
Martin Quinson [Thu, 23 Feb 2017 08:17:16 +0000 (09:17 +0100)]
cosmetics to please sonar
Martin Quinson [Thu, 23 Feb 2017 00:00:23 +0000 (01:00 +0100)]
try to get some coverage info for sonar on travis
Augustin Degomme [Thu, 23 Feb 2017 00:20:55 +0000 (01:20 +0100)]
oops
degomme [Wed, 22 Feb 2017 19:05:47 +0000 (20:05 +0100)]
At this point of the program simgrid values are not to be trusted as we had a segfault.
This broke some tests, sometimes, as this was wrongly evaluated to true.
degomme [Wed, 22 Feb 2017 17:20:12 +0000 (18:20 +0100)]
somehow off_t is not enough there, and ends up being negative on some 32 bits systems
degomme [Wed, 22 Feb 2017 14:24:38 +0000 (15:24 +0100)]
This should be an off_t (breaks some 32 bits systems)
degomme [Wed, 22 Feb 2017 14:05:44 +0000 (15:05 +0100)]
Speedup mpich tests by trying less sizes.
degomme [Wed, 22 Feb 2017 13:19:49 +0000 (14:19 +0100)]
Try to get rid of some old and weird way of doing things for fortran.
This was not working properly on osx...
degomme [Wed, 22 Feb 2017 08:48:00 +0000 (09:48 +0100)]
MacOS mappings were 1 byte off, preventing extension of them after one section
Martin Quinson [Wed, 22 Feb 2017 16:38:37 +0000 (17:38 +0100)]
comment to explain what's going on
Martin Quinson [Wed, 22 Feb 2017 15:26:30 +0000 (16:26 +0100)]
doh, I broke SMPI
Martin Quinson [Sat, 18 Feb 2017 01:34:18 +0000 (02:34 +0100)]
put MsgActorExt in a namespace
degomme [Tue, 21 Feb 2017 22:18:13 +0000 (23:18 +0100)]
Protect access to remote process list of rma requests, to avoid race conditions..
Frederic Suter [Tue, 21 Feb 2017 08:14:16 +0000 (09:14 +0100)]
document changes related to issue #138
Martin Quinson [Fri, 17 Feb 2017 21:40:21 +0000 (22:40 +0100)]
sonar: reinterpret_cast is OK in jMSG
Martin Quinson [Fri, 17 Feb 2017 21:35:34 +0000 (22:35 +0100)]
Revert "Let our examples compile with java 1.6, or almost"
Sonar is actually right to not like that brain overload. Plus, not all
examples were compiling with prehistorical Java anyway.
This reverts commit
848ff1f03de7a300b6314015e5fb4b28348490c4.
Martin Quinson [Fri, 17 Feb 2017 21:33:21 +0000 (22:33 +0100)]
please sonar
- don't use void as parameter
- prefer if to ternary conditional
Martin Quinson [Fri, 17 Feb 2017 21:23:39 +0000 (22:23 +0100)]
mark s4u::Link as public for windows (+cosmetics)
Martin Quinson [Fri, 17 Feb 2017 20:12:05 +0000 (21:12 +0100)]
static inline are the modern macros
Martin Quinson [Fri, 17 Feb 2017 16:50:49 +0000 (17:50 +0100)]
kill some other occurences of the fifo
Martin Quinson [Fri, 17 Feb 2017 16:41:05 +0000 (17:41 +0100)]
use the C++ API from the flatifier (as an example of that API)
Martin Quinson [Thu, 16 Feb 2017 22:26:20 +0000 (23:26 +0100)]
document my last changes
Frederic Suter [Fri, 17 Feb 2017 15:45:24 +0000 (16:45 +0100)]
forgot one include
Frederic Suter [Fri, 17 Feb 2017 15:16:08 +0000 (16:16 +0100)]
xbt_fifo are no longer used, remove the code
Frederic Suter [Fri, 17 Feb 2017 14:08:24 +0000 (15:08 +0100)]
Friday smell chase
Frederic Suter [Fri, 17 Feb 2017 09:12:53 +0000 (10:12 +0100)]
do not test equality on double
modify (and rename macro) to return -1 if the cost array is not defined
then we can test if the cost is 0 (nothing to do) or -1 (doesn't even
exist) and thus use <= instead of ==
Frederic Suter [Fri, 17 Feb 2017 09:05:57 +0000 (10:05 +0100)]
dead store-- + rewrite of hash function
Frederic Suter [Fri, 17 Feb 2017 08:50:37 +0000 (09:50 +0100)]
please sonar there
c'mon we all know how to access elements in 2D arrays, no need for a
macro;)
Augustin Degomme [Thu, 16 Feb 2017 23:21:10 +0000 (00:21 +0100)]
typo --
Augustin Degomme [Thu, 16 Feb 2017 23:15:52 +0000 (00:15 +0100)]
warning --, and ignore map_populate when not implemented (linux only, but just advisory, so let's follow https://gnu.org/software/hurd/glibc/mmap.html)
Martin Quinson [Thu, 16 Feb 2017 21:42:29 +0000 (22:42 +0100)]
Implement a new algorithm for SMPI_SHARED_MALLOC: global
This maps any new block onto a single file in memory.
The results will be awfully disfigured but that is damn efficient in
memory.
Martin Quinson [Thu, 16 Feb 2017 16:11:52 +0000 (17:11 +0100)]
sanitize the option smpi/shared-malloc, and improve its doc
Frederic Suter [Thu, 16 Feb 2017 14:22:40 +0000 (15:22 +0100)]
xbt_fifo -> std::list
Frederic Suter [Thu, 16 Feb 2017 13:03:00 +0000 (14:03 +0100)]
empty statements...
Frederic Suter [Thu, 16 Feb 2017 11:34:57 +0000 (12:34 +0100)]
Merge branch 'master' of git+ssh://scm.gforge.inria.fr//gitroot/simgrid/simgrid
Frederic Suter [Thu, 16 Feb 2017 11:34:48 +0000 (12:34 +0100)]
woops
degomme [Thu, 16 Feb 2017 11:08:44 +0000 (12:08 +0100)]
Avoid doing things when there is nothing to do.
degomme [Thu, 16 Feb 2017 10:58:13 +0000 (11:58 +0100)]
Avoid potential invalid reads
degomme [Thu, 16 Feb 2017 09:33:30 +0000 (10:33 +0100)]
Handle MPI_UNSIGNED_LONG_LONG in this algorithm
degomme [Thu, 16 Feb 2017 09:33:08 +0000 (10:33 +0100)]
Avoid overflowing in the MPI_Prod version by using larger datatype
Frederic Suter [Thu, 16 Feb 2017 10:49:36 +0000 (11:49 +0100)]
sign the parameters
Frederic Suter [Thu, 16 Feb 2017 10:36:21 +0000 (11:36 +0100)]
Merge branch 'master' of git+ssh://scm.gforge.inria.fr//gitroot/simgrid/simgrid
Frederic Suter [Thu, 16 Feb 2017 10:35:43 +0000 (11:35 +0100)]
fifo2dynar
Luka Stanisic [Wed, 8 Feb 2017 17:24:33 +0000 (18:24 +0100)]
Sometimes (most notably in StarPU-MPI case) the issuer of the comm is neither its src nor dst. I dont see how this can jeopardies the correct execution of SimGrid in other use cases, but I may be missing something.
This commit is indispensable for the correct termination of StarPU-MPI+SimGrid execution.
Frederic Suter [Thu, 16 Feb 2017 09:55:02 +0000 (10:55 +0100)]
a bit of cleaning
Frederic Suter [Thu, 16 Feb 2017 09:54:11 +0000 (10:54 +0100)]
cosmetics
Frederic Suter [Thu, 16 Feb 2017 08:59:48 +0000 (09:59 +0100)]
yet another bitwise pickyness + hey that's a foreach
Martin Quinson [Thu, 16 Feb 2017 08:55:44 +0000 (09:55 +0100)]
match new with delete, not with free
Frederic Suter [Thu, 16 Feb 2017 08:14:14 +0000 (09:14 +0100)]
fix newly introduced bugs
Martin Quinson [Thu, 16 Feb 2017 01:53:45 +0000 (02:53 +0100)]
simplify code by using default values for the fields
Martin Quinson [Thu, 16 Feb 2017 01:47:08 +0000 (02:47 +0100)]
reindent
Martin Quinson [Thu, 16 Feb 2017 01:42:18 +0000 (02:42 +0100)]
further untangle the msg_process creation by using a default value for auto_restart
Martin Quinson [Thu, 16 Feb 2017 01:21:51 +0000 (02:21 +0100)]
start to untangle the MSG actor creation mess
Martin Quinson [Thu, 16 Feb 2017 00:54:19 +0000 (01:54 +0100)]
even more C++ style
Martin Quinson [Thu, 16 Feb 2017 00:50:32 +0000 (01:50 +0100)]
actually, there is no need for the MsgActor to remember about its host. Its s4u component already knows it
Martin Quinson [Thu, 16 Feb 2017 00:36:13 +0000 (01:36 +0100)]
obey our coding standards + kill dead code
MSG is tiring nowadays
Martin Quinson [Thu, 16 Feb 2017 00:34:57 +0000 (01:34 +0100)]
kill dead code
Martin Quinson [Thu, 16 Feb 2017 00:27:45 +0000 (01:27 +0100)]
please sonar and cosmetics
- Uppercase the literal suffix.
- Remove the unused declaration of type "smx_host_priv_t".
- Move this "namespace" out of the 'extern "C"' declaration.
Martin Quinson [Thu, 16 Feb 2017 00:18:15 +0000 (01:18 +0100)]
sonar: fix a regex
Martin Quinson [Thu, 16 Feb 2017 00:08:20 +0000 (01:08 +0100)]
rename simdata_process_t into MsgActorExt
Martin Quinson [Wed, 15 Feb 2017 23:43:12 +0000 (00:43 +0100)]
not even for debugging purposes :)
Martin Quinson [Wed, 15 Feb 2017 23:35:50 +0000 (00:35 +0100)]
kill some useless getter simcalls
They were rather misleading since they did not do any simcall,
actually. The code around the getters of data in the actors is still
somehow magical:
smpi_switch_data_segment((static_cast<smpi_process_data_t>((static_cast<simdata_process_t>(comm->dst_proc->data)->data))->index));
I love this one. Once I'm done, it will become:
smpi_switch_data_segment(comm->dst_proc->extension<SmpiActorExt>()->index);
I pretend that it is clearer. Maybe to me only? :-3
Martin Quinson [Wed, 15 Feb 2017 23:17:28 +0000 (00:17 +0100)]
reindent
Martin Quinson [Wed, 15 Feb 2017 23:15:10 +0000 (00:15 +0100)]
don't hide the C++, deal with it
Martin Quinson [Wed, 15 Feb 2017 23:07:44 +0000 (00:07 +0100)]
move two severly misnamed identifiers to make them static
Martin Quinson [Wed, 15 Feb 2017 22:32:34 +0000 (23:32 +0100)]
make MSG use the Host extension mechanism (at least)
Martin Quinson [Wed, 15 Feb 2017 22:03:02 +0000 (23:03 +0100)]
make the Actors extendable (that was easy)
Martin Quinson [Wed, 15 Feb 2017 22:02:32 +0000 (23:02 +0100)]
cosmetics: reinterpret_cast does not mandate any intermediate cast
Martin Quinson [Wed, 15 Feb 2017 18:07:18 +0000 (19:07 +0100)]
sonar: ignore more generated files
Frederic Suter [Wed, 15 Feb 2017 20:34:23 +0000 (21:34 +0100)]
used unsigned long long to have more than 50 bits
Frederic Suter [Wed, 15 Feb 2017 16:33:04 +0000 (17:33 +0100)]
use bitfields as bitfields
Frederic Suter [Wed, 15 Feb 2017 16:32:59 +0000 (17:32 +0100)]
Merge branch 'master' of git+ssh://scm.gforge.inria.fr//gitroot/simgrid/simgrid
Martin Quinson [Wed, 15 Feb 2017 16:27:37 +0000 (17:27 +0100)]
make the C and Fortran interfaces of SMPI as extern C also in the code
This is useless because they are also marked as such in the header
files, but sonar only notices if they are marked in the implementation
too.
Also do some tiny changes to please sonar.
Martin Quinson [Wed, 15 Feb 2017 16:07:20 +0000 (17:07 +0100)]
exclude some more sonar checks on generated files
Martin Quinson [Wed, 15 Feb 2017 15:37:01 +0000 (16:37 +0100)]
make some C functions as such to please sonar
Martin Quinson [Wed, 15 Feb 2017 15:31:53 +0000 (16:31 +0100)]
new callback: s4u::onTimeAdvance
Martin Quinson [Wed, 15 Feb 2017 15:19:28 +0000 (16:19 +0100)]
new signal s4u::Host::onSpeedChange: when pstate is changed (or similar)
Martin Quinson [Wed, 15 Feb 2017 14:51:36 +0000 (15:51 +0100)]
put all of the host_energy plugin in one file only
Martin Quinson [Wed, 15 Feb 2017 14:33:21 +0000 (15:33 +0100)]
Make room for the upcoming network energy plugin
Martin Quinson [Wed, 15 Feb 2017 14:30:53 +0000 (15:30 +0100)]
add NetworkAction::links(), similar to CpuAction::cpus() for Betsegaw