Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
3 years ago[SMPI] Replay: Make error message more verbose
Christian Heinrich [Fri, 30 Mar 2018 09:15:29 +0000 (11:15 +0200)]
[SMPI] Replay: Make error message more verbose

3 years agoUse const references to pass vector as parameters.
Arnaud Giersch [Sun, 8 Apr 2018 21:16:23 +0000 (23:16 +0200)]
Use const references to pass vector as parameters.

3 years agoUpdate copyright headers.
Arnaud Giersch [Sun, 8 Apr 2018 20:45:26 +0000 (22:45 +0200)]
Update copyright headers.

Simplify year ranges; end by 2018.
Starting year was kept as-is. Shall it be changed to 2003?

3 years agoDelete copy assignment operator when copy constructor is already deleted.
Arnaud Giersch [Sun, 8 Apr 2018 20:21:37 +0000 (22:21 +0200)]
Delete copy assignment operator when copy constructor is already deleted.

3 years agoFix old typo: CpuTiTgmr -> CpuTiTmgr.
Arnaud Giersch [Sun, 8 Apr 2018 20:11:28 +0000 (22:11 +0200)]
Fix old typo: CpuTiTgmr -> CpuTiTmgr.

3 years agoDisable unused copy constructors (and please cppcheck).
Arnaud Giersch [Sun, 8 Apr 2018 19:58:31 +0000 (21:58 +0200)]
Disable unused copy constructors (and please cppcheck).

3 years agoAvoid multiple initializations for active_processes.
Arnaud Giersch [Sun, 8 Apr 2018 16:58:13 +0000 (18:58 +0200)]
Avoid multiple initializations for active_processes.

Fixes a memory leak seen with smpi-replay-multiple
(smpi_free_replay_tmp_buffers() was not called).

3 years agoRemove option -o for uname, which is not supported on Darwin.
Arnaud Giersch [Sat, 7 Apr 2018 15:01:18 +0000 (17:01 +0200)]
Remove option -o for uname, which is not supported on Darwin.

3 years agoWe use nowadays standard C++ exceptions. No need to test them.
Arnaud Giersch [Sat, 7 Apr 2018 12:25:52 +0000 (14:25 +0200)]
We use nowadays standard C++ exceptions. No need to test them.

3 years agoFix format string.
Arnaud Giersch [Sat, 7 Apr 2018 12:18:18 +0000 (14:18 +0200)]
Fix format string.

3 years agostart snake_casing s4u::Actor
Martin Quinson [Sun, 8 Apr 2018 20:32:26 +0000 (22:32 +0200)]
start snake_casing s4u::Actor

3 years agosnake_case s4u::Activity
Martin Quinson [Sat, 7 Apr 2018 20:54:44 +0000 (22:54 +0200)]
snake_case s4u::Activity

3 years agoenum class for e_s4u_activity_state_t
Martin Quinson [Sat, 7 Apr 2018 20:29:02 +0000 (22:29 +0200)]
enum class for e_s4u_activity_state_t

3 years agoignore newly generated files
Martin Quinson [Sat, 7 Apr 2018 20:14:04 +0000 (22:14 +0200)]
ignore newly generated files

3 years agoalways use the right type for link sharing policy
Martin Quinson [Sat, 7 Apr 2018 20:09:38 +0000 (22:09 +0200)]
always use the right type for link sharing policy

3 years agocut replay multiple files to make test shorter
Augustin Degomme [Sat, 7 Apr 2018 17:00:20 +0000 (19:00 +0200)]
cut replay multiple files to make test shorter

3 years agochange e_surf_link_sharing_policy_t into a proper enum class
Martin Quinson [Sat, 7 Apr 2018 16:41:35 +0000 (18:41 +0200)]
change e_surf_link_sharing_policy_t into a proper enum class

3 years agovarious useless cosmetics
Martin Quinson [Sat, 7 Apr 2018 15:35:41 +0000 (17:35 +0200)]
various useless cosmetics

3 years agokill ALL trailing whitespace (and deprecate a function in Link)
Martin Quinson [Sat, 7 Apr 2018 15:13:12 +0000 (17:13 +0200)]
kill ALL trailing whitespace (and deprecate a function in Link)

Sorry for the mixup, I forgot to commit between the two change sets.

3 years agocodacy: trailing whitespace
Martin Quinson [Sat, 7 Apr 2018 06:26:48 +0000 (08:26 +0200)]
codacy: trailing whitespace

3 years agomove all network models to the kernel::resource namespace
Martin Quinson [Sat, 7 Apr 2018 06:24:46 +0000 (08:24 +0200)]
move all network models to the kernel::resource namespace

3 years agokill useless C datatypes
Martin Quinson [Fri, 6 Apr 2018 20:06:29 +0000 (22:06 +0200)]
kill useless C datatypes

3 years agocut another bunch of include
Martin Quinson [Fri, 6 Apr 2018 20:00:34 +0000 (22:00 +0200)]
cut another bunch of include

3 years agomove the definition of surf_network_model in a lame attempt to fix windows
Martin Quinson [Fri, 6 Apr 2018 05:54:47 +0000 (07:54 +0200)]
move the definition of surf_network_model in a lame attempt to fix windows

3 years agoforce gnu_source here.
degomme [Thu, 5 Apr 2018 08:54:36 +0000 (10:54 +0200)]
force gnu_source here.
It's needed for unistd.h types, which would be not defined if the user only specifies POSIX_SOURCE

3 years agoUse dladdr(3) to get region filename.
Arnaud Giersch [Thu, 5 Apr 2018 08:21:18 +0000 (10:21 +0200)]
Use dladdr(3) to get region filename.

proc_regionfilename gives bogus results and breaks mmap privatization.

3 years agoUse XBT_DEBUG instead of disabled fprintf(stderr).
Arnaud Giersch [Thu, 5 Apr 2018 07:51:36 +0000 (09:51 +0200)]
Use XBT_DEBUG instead of disabled fprintf(stderr).

3 years agoDon't depend on <stdbool.h>.
Arnaud Giersch [Thu, 5 Apr 2018 07:20:34 +0000 (09:20 +0200)]
Don't depend on <stdbool.h>.

It's inclusion in xbt/base.h breaks existing MPI codesi (e.g. AMG2013).

3 years agoReduce code duplication.
Arnaud Giersch [Wed, 4 Apr 2018 16:34:11 +0000 (18:34 +0200)]
Reduce code duplication.

3 years agoempty a C->C++ wrapper that will soon die
Martin Quinson [Thu, 5 Apr 2018 05:27:26 +0000 (07:27 +0200)]
empty a C->C++ wrapper that will soon die

3 years agoreduce the scope of some #include, and cut useless ones
Martin Quinson [Wed, 4 Apr 2018 23:50:34 +0000 (01:50 +0200)]
reduce the scope of some #include, and cut useless ones

I'm sick of recompiling everything each time I change a line.

3 years agomake option 'network/crosstraffic' clean and nice
Martin Quinson [Wed, 4 Apr 2018 16:15:08 +0000 (18:15 +0200)]
make option 'network/crosstraffic' clean and nice

3 years agoreduce the amount of included headers
Martin Quinson [Wed, 4 Apr 2018 16:13:27 +0000 (18:13 +0200)]
reduce the amount of included headers

3 years agoMake cmd-line option "network/TCP-gamma" neat and clean
Martin Quinson [Wed, 4 Apr 2018 15:52:35 +0000 (17:52 +0200)]
Make cmd-line option "network/TCP-gamma" neat and clean

3 years agodocument last change
Martin Quinson [Tue, 3 Apr 2018 14:28:54 +0000 (16:28 +0200)]
document last change

3 years agotry to get rid of warning by defining calls here
degomme [Wed, 4 Apr 2018 07:54:18 +0000 (09:54 +0200)]
try to get rid of warning by defining calls here
To avoid redefining them, move also the definition from smpi.h to private.hpp

3 years agoprotect against uninitialized/absent smpi
Augustin Degomme [Tue, 3 Apr 2018 23:18:32 +0000 (01:18 +0200)]
protect against uninitialized/absent smpi

3 years agofix tests with timers by properly detecting POSIX_TIMERS
degomme [Tue, 3 Apr 2018 21:23:55 +0000 (23:23 +0200)]
fix tests with timers by properly detecting POSIX_TIMERS

3 years agofix dependency issue to prevent problems with make -jx
degomme [Tue, 3 Apr 2018 21:02:06 +0000 (23:02 +0200)]
fix dependency issue to prevent problems with make -jx

3 years agoavoid undefined NULL
degomme [Tue, 3 Apr 2018 20:33:11 +0000 (22:33 +0200)]
avoid undefined NULL

3 years agoKill unused typedefs from xbt::string.
Arnaud Giersch [Tue, 3 Apr 2018 17:16:47 +0000 (19:16 +0200)]
Kill unused typedefs from xbt::string.

3 years agoPlease sonar: use typedefs s_xbt_log_*_t.
Arnaud Giersch [Tue, 3 Apr 2018 17:02:19 +0000 (19:02 +0200)]
Please sonar: use typedefs s_xbt_log_*_t.

3 years agoKill useless typedef s_xbt_dict_cursor_t.
Arnaud Giersch [Tue, 3 Apr 2018 16:38:21 +0000 (18:38 +0200)]
Kill useless typedef s_xbt_dict_cursor_t.

3 years agosensible error messages when ending the daemons result in a deadlock (fix #258)
Martin Quinson [Tue, 3 Apr 2018 14:19:47 +0000 (16:19 +0200)]
sensible error messages when ending the daemons result in a deadlock (fix #258)

3 years agoRemove useless C linkage.
Arnaud Giersch [Tue, 3 Apr 2018 14:11:20 +0000 (16:11 +0200)]
Remove useless C linkage.

3 years agoKill useless typedef tmgr_Trace.
Arnaud Giersch [Tue, 3 Apr 2018 14:02:34 +0000 (16:02 +0200)]
Kill useless typedef tmgr_Trace.

3 years agoKill useless typedefs const_lmm_element_t and lmm_constraint_light_t.
Arnaud Giersch [Tue, 3 Apr 2018 13:56:50 +0000 (15:56 +0200)]
Kill useless typedefs const_lmm_element_t and lmm_constraint_light_t.

3 years agoKill useless typedefs routing_NetPoint and sg_netpoint_t.
Arnaud Giersch [Tue, 3 Apr 2018 12:58:34 +0000 (14:58 +0200)]
Kill useless typedefs routing_NetPoint and sg_netpoint_t.

3 years agoPlease sonar: use s_xbt_mheap_t.
Arnaud Giersch [Tue, 3 Apr 2018 12:26:56 +0000 (14:26 +0200)]
Please sonar: use s_xbt_mheap_t.

3 years agoKill unused typedef SMPI_Process.
Arnaud Giersch [Tue, 3 Apr 2018 12:20:23 +0000 (14:20 +0200)]
Kill unused typedef SMPI_Process.

3 years agoKill useless typedef s_smx_simcall_t.
Arnaud Giersch [Tue, 3 Apr 2018 11:53:19 +0000 (13:53 +0200)]
Kill useless typedef s_smx_simcall_t.

3 years agoKill useless typedefs surf_Resource and sg_resource_t.
Arnaud Giersch [Tue, 3 Apr 2018 09:19:05 +0000 (11:19 +0200)]
Kill useless typedefs surf_Resource and sg_resource_t.

3 years agoConstify attribute.
Arnaud Giersch [Tue, 3 Apr 2018 08:45:55 +0000 (10:45 +0200)]
Constify attribute.

3 years agoTypo.
Arnaud Giersch [Tue, 3 Apr 2018 07:36:39 +0000 (09:36 +0200)]
Typo.

3 years agoFix compilation warning.
Arnaud Giersch [Sat, 31 Mar 2018 20:32:14 +0000 (22:32 +0200)]
Fix compilation warning.

warning: ‘simgrid::surf::CpuTiAction’ declared with greater visibility than the type of its field ‘simgrid::surf::CpuTiAction::cpu_’ [-Wattributes]

3 years agotry to handle getopt internal global variable
degomme [Tue, 3 Apr 2018 12:53:11 +0000 (14:53 +0200)]
try to handle getopt internal global variable
add a wrapper that will set the value at each call to get the one from the correct process
This will probably not work for BSD implementations (they have optreset as well that might be needed).

3 years agos4u: test what happens when we kill a newborn actor (seems to work)
Martin Quinson [Tue, 3 Apr 2018 11:45:39 +0000 (13:45 +0200)]
s4u: test what happens when we kill a newborn actor (seems to work)

3 years agofix some issues arising when killing new-born actors (see #260)
Martin Quinson [Tue, 3 Apr 2018 11:40:22 +0000 (13:40 +0200)]
fix some issues arising when killing new-born actors (see #260)

3 years agosonar: make inheritance public
Martin Quinson [Tue, 3 Apr 2018 11:17:29 +0000 (13:17 +0200)]
sonar: make inheritance public

3 years agoDragonflyZone: do not save the whole ClusterCreationArgs structure
Martin Quinson [Tue, 3 Apr 2018 08:18:58 +0000 (10:18 +0200)]
DragonflyZone: do not save the whole ClusterCreationArgs structure

3 years agosnake_case routing
Martin Quinson [Tue, 3 Apr 2018 07:22:39 +0000 (09:22 +0200)]
snake_case routing

3 years agofurther snake_case in routing
Martin Quinson [Mon, 2 Apr 2018 21:16:46 +0000 (23:16 +0200)]
further snake_case in routing

3 years agosnake_case routing::NetPoint
Martin Quinson [Mon, 2 Apr 2018 21:10:16 +0000 (23:10 +0200)]
snake_case routing::NetPoint

3 years agosnake_case in resource::Resource
Martin Quinson [Mon, 2 Apr 2018 21:06:30 +0000 (23:06 +0200)]
snake_case in resource::Resource

3 years agoconvert getCname to get_cname
Martin Quinson [Mon, 2 Apr 2018 19:10:21 +0000 (21:10 +0200)]
convert getCname to get_cname

3 years agofinish snake-casing resource::Model
Martin Quinson [Mon, 2 Apr 2018 09:41:50 +0000 (11:41 +0200)]
finish snake-casing resource::Model

3 years agoresource:: extract action_heap into its own class
Martin Quinson [Sun, 1 Apr 2018 20:45:44 +0000 (22:45 +0200)]
resource:: extract action_heap into its own class

3 years agoinline a useless function
Martin Quinson [Sun, 1 Apr 2018 09:07:13 +0000 (11:07 +0200)]
inline a useless function

3 years agoCosmetics and snake_casing in Action and Model
Martin Quinson [Sun, 1 Apr 2018 08:00:04 +0000 (10:00 +0200)]
Cosmetics and snake_casing in Action and Model

3 years agomake Model::update_algo a constant field, set at initialization only
Martin Quinson [Sat, 31 Mar 2018 20:48:24 +0000 (22:48 +0200)]
make Model::update_algo a constant field, set at initialization only

3 years agoreindent to please clang
Martin Quinson [Sat, 31 Mar 2018 18:22:22 +0000 (20:22 +0200)]
reindent to please clang

3 years agoMerge branch 'master' of scm.gforge.inria.fr:/gitroot/simgrid/simgrid
Martin Quinson [Sat, 31 Mar 2018 17:58:00 +0000 (19:58 +0200)]
Merge branch 'master' of scm.gforge.inria.fr:/gitroot/simgrid/simgrid

3 years agofix build ?
Augustin Degomme [Sat, 31 Mar 2018 17:30:30 +0000 (19:30 +0200)]
fix build ?

3 years agoMerge branch 'master' of scm.gforge.inria.fr:/gitroot/simgrid/simgrid
Martin Quinson [Sat, 31 Mar 2018 17:27:07 +0000 (19:27 +0200)]
Merge branch 'master' of scm.gforge.inria.fr:/gitroot/simgrid/simgrid

3 years agodeprecate a function to snake_case it
Martin Quinson [Sat, 31 Mar 2018 17:23:38 +0000 (19:23 +0200)]
deprecate a function to snake_case it

3 years agoCosmetics in HostImpl
Martin Quinson [Sat, 31 Mar 2018 17:17:53 +0000 (19:17 +0200)]
Cosmetics in HostImpl

3 years agoDisable privatization for smpi_replay.
Arnaud Giersch [Fri, 30 Mar 2018 07:56:54 +0000 (09:56 +0200)]
Disable privatization for smpi_replay.

It does't seem to be mandatory, and the tests are broken with mmap privatization
because the global 'previous_send' is not correctly initialized for all processes.

3 years agosmpirun: really disable privatization with -no-privatize.
Arnaud Giersch [Fri, 30 Mar 2018 12:23:32 +0000 (14:23 +0200)]
smpirun: really disable privatization with -no-privatize.

3 years agoMove debug message.
Arnaud Giersch [Sat, 31 Mar 2018 15:17:12 +0000 (17:17 +0200)]
Move debug message.

3 years agoDisable privatization when not run through smpi_main().
Arnaud Giersch [Sat, 31 Mar 2018 15:16:08 +0000 (17:16 +0200)]
Disable privatization when not run through smpi_main().

SMPI_switch_data_segment is not initialized, and mmap privatization
is crashing when trying to call it.

3 years agoUse enum class for smpi privatization strategies.
Arnaud Giersch [Fri, 30 Mar 2018 20:16:44 +0000 (22:16 +0200)]
Use enum class for smpi privatization strategies.

3 years agoAnother fix in regexp.
Arnaud Giersch [Fri, 30 Mar 2018 11:24:50 +0000 (13:24 +0200)]
Another fix in regexp.

An hyphen '-' cannot be escaped in bracket expressions, it should be put first
(or last). Anyway, it is not allowed for Fortan identifier, so simply remove it.

Also unescape underscores.

3 years agocosmetics in cpu_ti
Martin Quinson [Sat, 31 Mar 2018 15:52:26 +0000 (17:52 +0200)]
cosmetics in cpu_ti

3 years agohave the maxmin system create by itself what it needs for selective update
Martin Quinson [Sat, 31 Mar 2018 14:37:23 +0000 (16:37 +0200)]
have the maxmin system create by itself what it needs for selective update

Earlier, the modified_set was created externally by some models (but
not all). This lead to the interesting situation where we were asking
for selective update with the boolean field, but not getting this
because the modified_set was not existing.

Now that we get it when we ask for it, we detect that:
- the lmm_usage tests cannot activate selective_update because they
  don't have real actions, so they cannot track them to see which were
  modified.
- Storage is having selective updates, but with full algorithm (thus
  the change to Action::~Action() so that we deal when selective is on
  but not Lazy). No idea of whether this is the wanted behavior.

3 years agolmm::System: rename some fields, and initialize them at declaration, not in ctor
Martin Quinson [Sat, 31 Mar 2018 07:32:36 +0000 (09:32 +0200)]
lmm::System: rename some fields, and initialize them at declaration, not in ctor

3 years agoCpuCas01: set updateAlgo as initializer
Martin Quinson [Fri, 30 Mar 2018 23:13:57 +0000 (01:13 +0200)]
CpuCas01: set updateAlgo as initializer

My goal here is to make updateAlgo a constant in each Model object.

3 years agocleanup the declaration and handling of the cpu/optim option
Martin Quinson [Fri, 30 Mar 2018 23:00:17 +0000 (01:00 +0200)]
cleanup the declaration and handling of the cpu/optim option

3 years agoconfig::Flag: allow to pass a map of the valid values
Martin Quinson [Fri, 30 Mar 2018 22:56:58 +0000 (00:56 +0200)]
config::Flag: allow to pass a map of the valid values

3 years agoreduce the visibility of xbt/config.hpp file to the cpp that really need it
Martin Quinson [Fri, 30 Mar 2018 22:46:01 +0000 (00:46 +0200)]
reduce the visibility of xbt/config.hpp file to the cpp that really need it

3 years agoMerge branch 'master' of github.com:simgrid/simgrid
Martin Quinson [Fri, 30 Mar 2018 22:15:57 +0000 (00:15 +0200)]
Merge branch 'master' of github.com:simgrid/simgrid

3 years agocosmetics
Martin Quinson [Fri, 30 Mar 2018 22:14:51 +0000 (00:14 +0200)]
cosmetics

3 years agoMerge pull request #259 from simgrid/configfix
Martin Quinson [Fri, 30 Mar 2018 22:13:35 +0000 (00:13 +0200)]
Merge pull request #259 from simgrid/configfix

config: fix declareFlag template

3 years agoconfig: fix declareFlag template
Gabriel Corona [Fri, 30 Mar 2018 21:59:02 +0000 (23:59 +0200)]
config: fix declareFlag template

3 years agochange a fixme into an assert
Martin Quinson [Fri, 30 Mar 2018 18:44:58 +0000 (20:44 +0200)]
change a fixme into an assert

3 years agovarious sonar fixes
Martin Quinson [Fri, 30 Mar 2018 17:47:00 +0000 (19:47 +0200)]
various sonar fixes

- namespaces cannot be uppercased
- classes with a virtual method should have a virtual destructor
- add the missing explicit keyworlds
- each identifier on its line

3 years agofix regexp. again.
degomme [Fri, 30 Mar 2018 11:08:21 +0000 (13:08 +0200)]
fix regexp. again.

3 years agofix regexp
degomme [Fri, 30 Mar 2018 09:45:00 +0000 (11:45 +0200)]
fix regexp

3 years agoMove variable definition in cpp file.
Arnaud Giersch [Thu, 29 Mar 2018 19:38:58 +0000 (21:38 +0200)]
Move variable definition in cpp file.

3 years agoFix comment.
Arnaud Giersch [Thu, 29 Mar 2018 12:04:00 +0000 (14:04 +0200)]
Fix comment.

3 years agoFix memory leak.
Arnaud Giersch [Thu, 29 Mar 2018 10:04:06 +0000 (12:04 +0200)]
Fix memory leak.