Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
13 months agoReplace memset(..., 0, ...) with zero-initialization.
Arnaud Giersch [Wed, 1 Mar 2023 21:00:05 +0000 (22:00 +0100)]
Replace memset(..., 0, ...) with zero-initialization.

13 months agoZero-initialize messages (essentially their padding bits).
Arnaud Giersch [Wed, 1 Mar 2023 20:55:31 +0000 (21:55 +0100)]
Zero-initialize messages (essentially their padding bits).

This is mainly to clear valgrind errors about uninitialised bytes.

13 months agoHelp to identify null values.
Arnaud Giersch [Wed, 1 Mar 2023 10:04:24 +0000 (11:04 +0100)]
Help to identify null values.

13 months agoLookup only once in map.
Arnaud Giersch [Wed, 1 Mar 2023 10:03:20 +0000 (11:03 +0100)]
Lookup only once in map.

13 months agoUseless assignments to local variable.
Arnaud Giersch [Tue, 28 Feb 2023 15:01:44 +0000 (16:01 +0100)]
Useless assignments to local variable.

13 months agoGH action: build out of sources
Martin Quinson [Thu, 2 Mar 2023 10:04:35 +0000 (11:04 +0100)]
GH action: build out of sources

13 months agoInstall python deps on GHaction + better documentation of build dependencies
Martin Quinson [Thu, 2 Mar 2023 09:13:12 +0000 (10:13 +0100)]
Install python deps on GHaction + better documentation of build dependencies

13 months agoMais quel débile, punaise
Martin Quinson [Thu, 2 Mar 2023 08:55:34 +0000 (09:55 +0100)]
Mais quel débile, punaise

13 months agoMC builds have specific dependencies
Martin Quinson [Thu, 2 Mar 2023 08:48:45 +0000 (09:48 +0100)]
MC builds have specific dependencies

13 months agoGH action: ninja is verbose on error anyway
Martin Quinson [Thu, 2 Mar 2023 08:31:52 +0000 (09:31 +0100)]
GH action: ninja is verbose on error anyway

13 months agoGH action: use the correct package name
Martin Quinson [Thu, 2 Mar 2023 08:27:40 +0000 (09:27 +0100)]
GH action: use the correct package name

13 months agogh action: we need 'sudo' here
Martin Quinson [Thu, 2 Mar 2023 08:20:40 +0000 (09:20 +0100)]
gh action: we need 'sudo' here

13 months agoGH action: install deps
Martin Quinson [Thu, 2 Mar 2023 08:16:13 +0000 (09:16 +0100)]
GH action: install deps

13 months agoGH action: use existing runners
Martin Quinson [Thu, 2 Mar 2023 08:04:52 +0000 (09:04 +0100)]
GH action: use existing runners

13 months agomessing with git actions
Martin Quinson [Thu, 2 Mar 2023 07:44:09 +0000 (08:44 +0100)]
messing with git actions

13 months agoFix yaml syntax :(
Martin Quinson [Thu, 2 Mar 2023 07:42:02 +0000 (08:42 +0100)]
Fix yaml syntax :(

13 months agoAdd a github action to test our git on Debian11, regular and MC
Martin Quinson [Thu, 2 Mar 2023 07:37:31 +0000 (08:37 +0100)]
Add a github action to test our git on Debian11, regular and MC

This is triggered manually, when jenkins is off as right now

13 months agoPass on documentation's Design Goals section
Henri Casanova [Thu, 2 Mar 2023 02:38:48 +0000 (16:38 -1000)]
Pass on documentation's Design Goals section

13 months agoMore work on the documentation's Models section
Henri Casanova [Wed, 1 Mar 2023 23:38:37 +0000 (13:38 -1000)]
More work on the documentation's Models section

13 months agoNew function SMPI_app_instance_start() to easily start a MPI instance in your S4U...
Martin Quinson [Wed, 1 Mar 2023 20:44:56 +0000 (21:44 +0100)]
New function SMPI_app_instance_start() to easily start a MPI instance in your S4U simulation

13 months agoTry to fix a fixme blindly, just in case it was easy
Martin Quinson [Wed, 1 Mar 2023 19:56:56 +0000 (20:56 +0100)]
Try to fix a fixme blindly, just in case it was easy

13 months agoPass on the documentation's Introduction page. Minor grammatical fixes,
Henri Casanova [Wed, 1 Mar 2023 19:34:00 +0000 (09:34 -1000)]
Pass on the documentation's Introduction page. Minor grammatical fixes,
some rewrites and word changes, minor content removal due to redundancy.

13 months agoFix make distcheck
Martin Quinson [Tue, 28 Feb 2023 18:12:26 +0000 (19:12 +0100)]
Fix make distcheck

13 months agoMerge branch 'udpor-phase3' into 'master'
Augustin Degomme [Tue, 28 Feb 2023 15:59:29 +0000 (15:59 +0000)]
Merge branch 'udpor-phase3' into 'master'

Phase 2.5 of UDPOR Integration: Add Iterators for Subsets

See merge request simgrid/simgrid!134

13 months agoAdd src/xbt/.../subsets_tests.cpp to manifest file
Maxwell Pirtle [Tue, 28 Feb 2023 15:36:36 +0000 (16:36 +0100)]
Add src/xbt/.../subsets_tests.cpp to manifest file

13 months agoRemove CompatibilityGraph and friends
Maxwell Pirtle [Tue, 28 Feb 2023 14:52:20 +0000 (15:52 +0100)]
Remove CompatibilityGraph and friends

The CompatibilityGraph and friends that were
added in order to compute maximal sets of events
needlessly complicated the algorithm. A much
better approach was suggested which will be
implemented in the next phase.

While perhaps a rebase could also have been
performed, it would have required quite careful
precision. Since the end goal is the same and
there are better uses of our time, I simply opted
to tag on another commit

13 months agoAdd tests for LazyKSubsets and LazyPowerset
Maxwell Pirtle [Tue, 28 Feb 2023 14:31:54 +0000 (15:31 +0100)]
Add tests for LazyKSubsets and LazyPowerset

The LazyKSubsets and LazyPowerset are simply
wrappers around an iterator type which can
enumerate all subsets of a given iteration.

While this won't be used anymore to enumerate
all possible sets of events of the configuration
in the compatibility graph, which will soon be
removed, it will still be used (or a variant
thereof) when computing K-partial alternatives
later on

13 months agoAdd LazyPowerSet and LazyKSubsets
Maxwell Pirtle [Tue, 28 Feb 2023 10:30:28 +0000 (11:30 +0100)]
Add LazyPowerSet and LazyKSubsets

Two new classes were added that act effectively
as convenience methods around creating subset
iterators. The classes themselves act mostly
like iterators but are instead light-weight
"containers" which can be iterated over. Effectively,
they are contains which "contain" the entire
collection of subsets (of size k respectively) of
some collection without actually storing that collection
in memory.

13 months agoAdd more comments to subsets_iterator implementation
Maxwell Pirtle [Tue, 28 Feb 2023 10:14:43 +0000 (11:14 +0100)]
Add more comments to subsets_iterator implementation

13 months agoAdd powerset_iterator to simgrid::xbt
Maxwell Pirtle [Tue, 28 Feb 2023 09:24:35 +0000 (10:24 +0100)]
Add powerset_iterator to simgrid::xbt

The powerset_iterator, as its name suggests,
is an iterator which traverses over all elements
of the power set of the elements traversed by another
iterator. It makes heavy use of the subsets_iterator
from which it derives its functionality (delegation
rather than inheritance)

13 months agoUse boost::iterator_facade for subsets_iterator
Maxwell Pirtle [Tue, 28 Feb 2023 08:37:19 +0000 (09:37 +0100)]
Use boost::iterator_facade for subsets_iterator

The subsets_iterator class is now implemented
in terms of the boost::iterator_facade which simplies
the implementation considerably of the iterator. The
same approach will be used to write the implementation
for powerset_iterator and the history_iterator (the latter
used to traverse the history of a set of events)

13 months agoUpdate .mailmap [ci-skip]
Arnaud Giersch [Mon, 27 Feb 2023 16:13:35 +0000 (17:13 +0100)]
Update .mailmap [ci-skip]

13 months agodoc: Rework the intro pages
Martin Quinson [Mon, 27 Feb 2023 23:17:32 +0000 (00:17 +0100)]
doc: Rework the intro pages

14 months agoRemove subsets.cpp file
Maxwell Pirtle [Mon, 27 Feb 2023 15:40:48 +0000 (16:40 +0100)]
Remove subsets.cpp file

Since the subsets_iterator is defined using
templates, it needs to be defined solely in
the header file. Thus the cpp file is extraneous
and was removed

14 months agoAdd "working" (but untested) implementation of iterative subsets
Maxwell Pirtle [Mon, 27 Feb 2023 15:37:15 +0000 (16:37 +0100)]
Add "working" (but untested) implementation of iterative subsets

The k-subsets higher-order iterator appears to be
working as expected after fixing a couple of issues
while run under GDB. The next phase is to test this
iterator heavily on a number of different examples
to prove that the iteration works as expected.

Future commits will add two important data structures,
viz. the LazyPowerSet and the LazyKSubsets, both of
which will be used when computing cliques in the
compatibility graph later on

14 months agoAdd first "implementation" of k-subsets iterator
Maxwell Pirtle [Mon, 27 Feb 2023 14:47:04 +0000 (15:47 +0100)]
Add first "implementation" of k-subsets iterator

The higher-order iterator `subsets_iterator`
iterates over all subsets of a given iterator.
Eventually, we'll create the LazyPowerSet and
LazyKSubsets classes which will act as convenience
wrappers around the creation of a k-subset iterator

14 months agoAdd iterator files to xbt/utils
Maxwell Pirtle [Mon, 27 Feb 2023 12:46:14 +0000 (13:46 +0100)]
Add iterator files to xbt/utils

14 months agoPlug a memleak + experience that code out of the MC test for coverage
Martin Quinson [Mon, 27 Feb 2023 13:54:13 +0000 (14:54 +0100)]
Plug a memleak + experience that code out of the MC test for coverage

14 months agocosmetics in docs
Martin Quinson [Mon, 27 Feb 2023 10:08:38 +0000 (11:08 +0100)]
cosmetics in docs

14 months agoAsynchronous locks and fluid I/O streams were aded at some point
Martin Quinson [Mon, 27 Feb 2023 09:16:31 +0000 (10:16 +0100)]
Asynchronous locks and fluid I/O streams were aded at some point

14 months agoAdd 3 figures to the design goals + minor rewording
Martin Quinson [Sun, 26 Feb 2023 23:32:48 +0000 (00:32 +0100)]
Add 3 figures to the design goals + minor rewording

14 months agoUpdate release notes
Martin Quinson [Sun, 26 Feb 2023 21:45:53 +0000 (22:45 +0100)]
Update release notes

14 months agoFix most of the remaining code warnings
Maxwell Pirtle [Mon, 27 Feb 2023 08:20:49 +0000 (09:20 +0100)]
Fix most of the remaining code warnings

This commit fixes the majority of the code
warnings pointed out by SonarSource. There
are some others that will disappear with other
phases once e.g. the functions in UdporChecker
are actually implemented

14 months agoAdd default method for constructing full graph
Maxwell Pirtle [Mon, 27 Feb 2023 07:57:23 +0000 (08:57 +0100)]
Add default method for constructing full graph

A convenience method was added which allows the
full compatibility graph to be constructed without
needing to specify that each node should be included.

14 months agoAdd predicate filtering to compatibility graph comp
Maxwell Pirtle [Fri, 24 Feb 2023 14:40:39 +0000 (15:40 +0100)]
Add predicate filtering to compatibility graph comp

Computing the compatibility graph should attempt to
disqualify as many events as possible from the configuration
to minimize the size of the resulting compatibility graph.
This is _esepcially_ important because we will enumerate
all cliques of the graph and subsequently all possible
events contains within each node. This means that removing
even one or two nodes could reduce the time spent in
enumeration dramatically.

For now, the UdporChecker can only prune based on
dependency. Perhaps, though, there are more clever
ways to prune based on whether `a` is enabled e.g.
in knowing some properties about the event structure.
This will be investigated later, but is a secondary
concern to getting an implementation of the algorithm
up-and-running.

14 months agoFix most cosmetics and code warnings
Maxwell Pirtle [Fri, 24 Feb 2023 13:15:12 +0000 (14:15 +0100)]
Fix most cosmetics and code warnings

14 months agoCreate a private struct to hold search data
Maxwell Pirtle [Fri, 24 Feb 2023 12:52:40 +0000 (13:52 +0100)]
Create a private struct to hold search data

This commits replaces the three separate maps
used to keep track of per-event data in favor
of a single map which maps events to a struct with
three fields

14 months agoAdd first go at compatibility graph construction
Maxwell Pirtle [Fri, 24 Feb 2023 12:30:36 +0000 (13:30 +0100)]
Add first go at compatibility graph construction

This commit introduces the first (albeit incomplete)
implementation of the function which will convert
a configuration into a comptability graph which can
be iterated over with k-cliques

14 months agoAdd first steps towards an implementation of ex(C)
Maxwell Pirtle [Thu, 23 Feb 2023 15:46:03 +0000 (16:46 +0100)]
Add first steps towards an implementation of ex(C)

14 months agoAdd CompatibilityGraph and CompatibilityGraphNode
Maxwell Pirtle [Thu, 23 Feb 2023 14:14:03 +0000 (15:14 +0100)]
Add CompatibilityGraph and CompatibilityGraphNode

Two important classes were added as part of the
process to support UDPOR. The classes added will be
used to maintain compatibility between "strands" of
the event structure for determining maximal sets of
events

14 months ago[ci skip] add lstdc++ to bigdft flags as well
Augustin Degomme [Sun, 26 Feb 2023 21:46:50 +0000 (22:46 +0100)]
[ci skip] add lstdc++ to bigdft flags as well

14 months agobigdft - attempt at fixing build error with new C++ file in futile
Augustin Degomme [Sun, 26 Feb 2023 21:04:27 +0000 (21:04 +0000)]
bigdft - attempt at fixing build error with new C++ file in futile

14 months agoAllow to control the problem size from the cmd line, and reduce the instance in MC
Martin Quinson [Sun, 26 Feb 2023 16:17:19 +0000 (17:17 +0100)]
Allow to control the problem size from the cmd line, and reduce the instance in MC

The previous instance size resulted in a timeout now that the DPOR
reduction is less efficient (because it's less buggy)

14 months agoRevalidate a tesh file (result of a merge error)
Martin Quinson [Sun, 26 Feb 2023 16:16:25 +0000 (17:16 +0100)]
Revalidate a tesh file (result of a merge error)

14 months agoUse bool for booleans
Martin Quinson [Sun, 26 Feb 2023 15:07:41 +0000 (16:07 +0100)]
Use bool for booleans

14 months agoKill a now useless field
Martin Quinson [Sun, 26 Feb 2023 13:15:14 +0000 (14:15 +0100)]
Kill a now useless field

14 months agoMerge branch 'master' into 'master'
Martin Quinson [Sun, 26 Feb 2023 15:07:08 +0000 (15:07 +0000)]
Merge branch 'master' into 'master'

Fixes on DPOR algorithm for MC SimGrid and sleep sets addition

See merge request simgrid/simgrid!128

14 months agoAlso detect the disk failures
Martin Quinson [Sun, 26 Feb 2023 11:30:26 +0000 (12:30 +0100)]
Also detect the disk failures

14 months agoFurther simplify the way host failures are detected
Martin Quinson [Sun, 26 Feb 2023 11:11:49 +0000 (12:11 +0100)]
Further simplify the way host failures are detected

Do as it's done in links and communications: when the resource is
turned off, simply mark the actions it hosts as FAILED.

That's much simpler than the convoluted existing code, which relied on
the Host::on_state_change signal. Each activity pushed a callback to
check whether it was its host which failed. Gosh, so convoluted...

The current change is not completely applied to CpuTI model, which
seems to have another way to mark the actions as failing. So I
override CpuTI::turn_off() to not mark the actions as failing to avoid
a segfault. It's a bit lame, but CpuTI is too different, I feel lazy.

14 months agoSimplify the way Execs detect host failures
Martin Quinson [Sat, 25 Feb 2023 17:40:49 +0000 (18:40 +0100)]
Simplify the way Execs detect host failures

Have the ExecImpl install the callback instead of having the s4u::Exec
do so, and then set an internal field of ExecImpl.

14 months agoRevert "Include the output of this test in the tesh file, because it's linked from...
Martin Quinson [Fri, 24 Feb 2023 17:51:13 +0000 (18:51 +0100)]
Revert "Include the output of this test in the tesh file, because it's linked from the doc now"

This reverts commit 0c5a9c80339933853647914ea9f716ef4fc8413c.

The output does not seem to be portable :(

14 months agoBummer :(
Martin Quinson [Fri, 24 Feb 2023 17:39:52 +0000 (18:39 +0100)]
Bummer :(

14 months agoClear timeout detectors on finish().
Arnaud Giersch [Fri, 24 Feb 2023 15:12:19 +0000 (16:12 +0100)]
Clear timeout detectors on finish().

Fixes transient errors seen with s4u-dht-chord-parallel tests.

14 months agoFill cmdline_ for each instance of EngimeImpl.
Arnaud Giersch [Fri, 24 Feb 2023 14:30:34 +0000 (15:30 +0100)]
Fill cmdline_ for each instance of EngimeImpl.

Even if there is only one instance!
Fixes a memory leak occurring when sg_config_init() exits early.

14 months agoUpdate sonar-project.properties [ci-skip]
Arnaud Giersch [Fri, 24 Feb 2023 13:48:59 +0000 (14:48 +0100)]
Update sonar-project.properties [ci-skip]

14 months agoTwo more random hints to contributors (and reindent the existing ones)
Martin Quinson [Fri, 24 Feb 2023 15:39:28 +0000 (16:39 +0100)]
Two more random hints to contributors (and reindent the existing ones)

14 months agoAdd some Noteworthy tests to the Contributor's doc
Martin Quinson [Fri, 24 Feb 2023 15:32:27 +0000 (16:32 +0100)]
Add some Noteworthy tests to the Contributor's doc

14 months agoWhen the chaos monkey is invoked with nothing to do, it tells a usage message and...
Martin Quinson [Fri, 24 Feb 2023 15:07:22 +0000 (16:07 +0100)]
When the chaos monkey is invoked with nothing to do, it tells a usage message and kills everything

14 months agoInclude the output of this test in the tesh file, because it's linked from the doc now
Martin Quinson [Fri, 24 Feb 2023 15:01:41 +0000 (16:01 +0100)]
Include the output of this test in the tesh file, because it's linked from the doc now

14 months agoAllow to specify the parameters on the command line, when the test is not run from...
Martin Quinson [Fri, 24 Feb 2023 15:00:57 +0000 (16:00 +0100)]
Allow to specify the parameters on the command line, when the test is not run from its favorite directory

14 months agoMerge branch 'udpor-phase2' into 'master'
Martin Quinson [Fri, 24 Feb 2023 14:58:44 +0000 (14:58 +0000)]
Merge branch 'udpor-phase2' into 'master'

Phase 2 of UDPOR Integration: Add topological sorting of events in a configuration

See merge request simgrid/simgrid!133

14 months agoMerge branch 'master' of https://framagit.org/simgrid/simgrid
mlaurent [Fri, 24 Feb 2023 14:42:51 +0000 (15:42 +0100)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid

14 months agofix the done marking of multiple times taken transitions
mlaurent [Fri, 24 Feb 2023 13:46:46 +0000 (14:46 +0100)]
fix the done marking of multiple times taken transitions

14 months agoAdd complicated topological sort test
Maxwell Pirtle [Thu, 23 Feb 2023 10:46:10 +0000 (11:46 +0100)]
Add complicated topological sort test

The test added ensures that for each element
in the sequence of events in the topological
sorting:

1. no event in the history of event `i` appears
in the list of events before event `i` (i.e.
events 0, ..., `i - 1`) in the case of the reverse
graph

2. every event in the history of event `i` (except
`e` itself) appears in the list of events before
`i` (i.e. events 0, ..., `i - 1`) in the case of
the event structure ordering

14 months agoAdd first unit tests for topological sorting
Maxwell Pirtle [Thu, 23 Feb 2023 10:17:27 +0000 (11:17 +0100)]
Add first unit tests for topological sorting

A few unit tests were added to support topological
sorting of events in a configuration. In the future,
a more robust test will be added which ensures that each
newly-discovered event in the reverse order has never
been discovered before

14 months agoAdd topological sort of configuration events
Maxwell Pirtle [Wed, 22 Feb 2023 14:36:18 +0000 (15:36 +0100)]
Add topological sort of configuration events

Topological sorting is an important first step
in determining which groups of events in a
configuration need to be tested together when
looking at all possible subsets of maximal events
of a configuration. The idea is that you first
build a compatability graph (soon to come) whose
elements represent "chains" of the event structure
that are mutually exslcusive and whose edges
describe which chains are mutually compatible
with one another. Then, you look for all possible
cliques within the graph to determine all possible
configurations of these chains. Each of the
major components of this process will be added in
subsequent commits

14 months agoDocument more changes, and update the Release Notes
Martin Quinson [Fri, 24 Feb 2023 00:27:35 +0000 (01:27 +0100)]
Document more changes, and update the Release Notes

14 months agoAdd a comment on why we need such a callback
Martin Quinson [Fri, 24 Feb 2023 00:19:09 +0000 (01:19 +0100)]
Add a comment on why we need such a callback

14 months agoMerge ActivityImpl::post() and ::finish()
Martin Quinson [Thu, 23 Feb 2023 22:59:27 +0000 (23:59 +0100)]
Merge ActivityImpl::post() and ::finish()

14 months agoDo not clean twice in Activity::post(), so that even test() can call it
Martin Quinson [Thu, 23 Feb 2023 22:16:03 +0000 (23:16 +0100)]
Do not clean twice in Activity::post(), so that even test() can call it

14 months agouniformization: call post that calls finish
Fred Suter [Thu, 23 Feb 2023 21:14:44 +0000 (16:14 -0500)]
uniformization: call post that calls finish

14 months agoRevert "Get ready for more versions of ns3"
Martin Quinson [Thu, 23 Feb 2023 21:36:16 +0000 (22:36 +0100)]
Revert "Get ready for more versions of ns3"

This reverts commit 1b8e178fc3f8b3339d25692dfb552f79d349f671.

Also, adds a small comment to avoid this trap in the future.

14 months agoSanitize the handling of timeouts in CommImpl, ExecImpl and IoImpl
Martin Quinson [Thu, 23 Feb 2023 21:21:47 +0000 (22:21 +0100)]
Sanitize the handling of timeouts in CommImpl, ExecImpl and IoImpl

There is no need for a timeout detector in ExecImpl and IoImpl, as
wait_for injects a Synchro to that extend on need.

Use a uniq_ptr on the CommImpl timeout detectors, so that the memory
is managed automatically. As it used to be for ExecImpl.

This kills the last occurrence of surf in the code. For real this time.

14 months agoFix distcheck.
Arnaud Giersch [Thu, 23 Feb 2023 20:33:28 +0000 (21:33 +0100)]
Fix distcheck.

14 months agoPrefer ActivityImpl::post() to ::finish() that should die
Martin Quinson [Thu, 23 Feb 2023 20:24:00 +0000 (21:24 +0100)]
Prefer ActivityImpl::post() to ::finish() that should die

14 months agoGet ready for more versions of ns3
Martin Quinson [Wed, 22 Feb 2023 21:58:45 +0000 (22:58 +0100)]
Get ready for more versions of ns3

14 months agoComment out unused private fields (fix compilation error).
Arnaud Giersch [Thu, 23 Feb 2023 20:18:18 +0000 (21:18 +0100)]
Comment out unused private fields (fix compilation error).

14 months agoMerge branch 'simgrid-udpor-integration' into 'master'
Arnaud Giersch [Thu, 23 Feb 2023 17:00:25 +0000 (18:00 +0100)]
Merge branch 'simgrid-udpor-integration' into 'master'

Phase 1 of Integration of UDPOR: Adding UDPOR Constructs

See merge request simgrid/simgrid!132

14 months agoUseless casts to (void*).
Arnaud Giersch [Thu, 23 Feb 2023 16:14:51 +0000 (17:14 +0100)]
Useless casts to (void*).

14 months agoComment is not relevant anymore.
Arnaud Giersch [Thu, 23 Feb 2023 15:48:28 +0000 (16:48 +0100)]
Comment is not relevant anymore.

[ci-skip]

14 months agoUse type aid_t for an actor's PID.
Arnaud Giersch [Thu, 23 Feb 2023 14:58:28 +0000 (15:58 +0100)]
Use type aid_t for an actor's PID.

14 months agoMore Sonar issues.
Arnaud Giersch [Thu, 23 Feb 2023 14:53:26 +0000 (15:53 +0100)]
More Sonar issues.

14 months agoUse normal strings instead of f-strings (Sonar).
Arnaud Giersch [Thu, 23 Feb 2023 14:37:40 +0000 (15:37 +0100)]
Use normal strings instead of f-strings (Sonar).

14 months agoUse C++17's std::scoped_lock where appropriate.
Arnaud Giersch [Thu, 23 Feb 2023 13:00:47 +0000 (14:00 +0100)]
Use C++17's std::scoped_lock where appropriate.

Stick to C++14's std::lock_guard in public headers.

14 months agoDon't access variable ouside of the critical section.
Arnaud Giersch [Thu, 23 Feb 2023 12:53:15 +0000 (13:53 +0100)]
Don't access variable ouside of the critical section.

TSan warned about a data race there.
Also use a std::scoped_lock to handle the mutexi (Sonar).

14 months agoVarious cleanups.
Arnaud Giersch [Tue, 21 Feb 2023 10:59:44 +0000 (11:59 +0100)]
Various cleanups.

Includes:
* prefer simpler overload for channel send/receive
* use direct-initialization for variables
* rename variable and avoid it to be shadowed later
* remove unnecessary casts

14 months agotransitions in the same actor are dependent
mlaurent [Wed, 22 Feb 2023 17:05:37 +0000 (18:05 +0100)]
transitions in the same actor are dependent

14 months agoPartially revert 2ad536e710c5936ff8e525e4bbb5e7046f292aac (Simplify the library initi...
Martin Quinson [Wed, 22 Feb 2023 15:55:44 +0000 (16:55 +0100)]
Partially revert 2ad536e710c5936ff8e525e4bbb5e7046f292aac (Simplify the library initialization) to fix a memleak

14 months agoImplement the semaphore functions in sthread
Martin Quinson [Wed, 22 Feb 2023 15:54:18 +0000 (16:54 +0100)]
Implement the semaphore functions in sthread

14 months agoMerge branch 'master' of https://framagit.org/simgrid/simgrid
mlaurent [Wed, 22 Feb 2023 15:35:29 +0000 (16:35 +0100)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid