Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
9 months agoMerge branch 'master' of https://framagit.org/simgrid/simgrid
Frederic Suter [Thu, 14 Mar 2019 15:57:45 +0000 (16:57 +0100)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid

9 months agorework SleepImpl (and save a cast)
Frederic Suter [Thu, 14 Mar 2019 15:29:28 +0000 (16:29 +0100)]
rework SleepImpl (and save a cast)

9 months agoInline methods of simgrid::kernel::Resource.
Arnaud Giersch [Thu, 14 Mar 2019 14:35:47 +0000 (15:35 +0100)]
Inline methods of simgrid::kernel::Resource.

9 months agoRemove useless function pointer.
Arnaud Giersch [Thu, 14 Mar 2019 13:53:33 +0000 (14:53 +0100)]
Remove useless function pointer.

9 months agoTidying simix::Timer.
Arnaud Giersch [Thu, 14 Mar 2019 13:10:58 +0000 (14:10 +0100)]
Tidying simix::Timer.

9 months agoDefine move-assignment and delete copy-assignment operators for xbt::Task.
Arnaud Giersch [Thu, 14 Mar 2019 12:54:27 +0000 (13:54 +0100)]
Define move-assignment and delete copy-assignment operators for xbt::Task.

9 months ago[sonar] Name parameters differently than request_depend_asymmetric.
Arnaud Giersch [Thu, 14 Mar 2019 10:24:50 +0000 (11:24 +0100)]
[sonar] Name parameters differently than request_depend_asymmetric.

9 months agoTry to make tests succeed with coverage on Jenkins.
Arnaud Giersch [Thu, 14 Mar 2019 09:27:51 +0000 (10:27 +0100)]
Try to make tests succeed with coverage on Jenkins.

Increase timeout, and disallow parallel run.

9 months agoMove test declaration in proper CMakeLists.txt.
Arnaud Giersch [Thu, 14 Mar 2019 09:06:49 +0000 (10:06 +0100)]
Move test declaration in proper CMakeLists.txt.

9 months agolet base class dtor deal with surf action
Frederic Suter [Thu, 14 Mar 2019 13:07:37 +0000 (14:07 +0100)]
let base class dtor deal with surf action

For CommImpl, it seems that unref() is called too late so keep the
current dtor

9 months agoWhat ActivityImpl child should look like IMHO
Frederic Suter [Thu, 14 Mar 2019 11:49:02 +0000 (12:49 +0100)]
What ActivityImpl child should look like IMHO
* ctor does nothing more than create a class instance
* all fields can be set by chainable setters
* start() has no parameter

On the S4U side, we should have the same (with CRTP soon)
* ctor calls the Impl ctor and sets thing at user level
* start() does a simcall in which we call all the Impl setters to
  transfer all field values to the kernel and then call Impl::start()

Maybe we should also replace "new *Impl()" in S4U by a call to a
Impl::create() static method to be written.

9 months agocosmetic cleanups in S4U
Frederic Suter [Thu, 14 Mar 2019 09:57:51 +0000 (10:57 +0100)]
cosmetic cleanups in S4U

9 months agoActivate assert when debug log is active.
Arnaud Giersch [Wed, 13 Mar 2019 14:16:00 +0000 (15:16 +0100)]
Activate assert when debug log is active.

9 months agoUse std::unordered_map + save an indirection.
Arnaud Giersch [Wed, 13 Mar 2019 13:12:10 +0000 (14:12 +0100)]
Use std::unordered_map + save an indirection.

9 months agoDirectly fill vectors at construction.
Arnaud Giersch [Wed, 13 Mar 2019 10:22:29 +0000 (11:22 +0100)]
Directly fill vectors at construction.

9 months agoSimplification.
Arnaud Giersch [Wed, 13 Mar 2019 08:54:18 +0000 (09:54 +0100)]
Simplification.

9 months agoRemove unused type definitions.
Arnaud Giersch [Tue, 12 Mar 2019 21:49:31 +0000 (22:49 +0100)]
Remove unused type definitions.

9 months agodon't kill the fools sourcing this script
Martin Quinson [Wed, 13 Mar 2019 14:28:23 +0000 (15:28 +0100)]
don't kill the fools sourcing this script

9 months agocomestics in src/kernel
Frederic Suter [Wed, 13 Mar 2019 12:15:12 +0000 (13:15 +0100)]
comestics in src/kernel

9 months agocleanups in smpi, mostly cosmetic stuff and indent
Frederic Suter [Wed, 13 Mar 2019 10:56:01 +0000 (11:56 +0100)]
cleanups in smpi, mostly cosmetic stuff and indent

9 months agoComplete Asan suppressions.
Arnaud Giersch [Tue, 12 Mar 2019 21:22:37 +0000 (22:22 +0100)]
Complete Asan suppressions.

9 months agoEnsure field is initialized.
Arnaud Giersch [Tue, 12 Mar 2019 17:39:10 +0000 (18:39 +0100)]
Ensure field is initialized.

9 months agoClang is picky.
Arnaud Giersch [Tue, 12 Mar 2019 16:43:38 +0000 (17:43 +0100)]
Clang is picky.

error: local variable value will be copied despite being returned by name [-Werror,-Wreturn-std-move]

9 months agoSave valgrind_stack_id in a private field.
Arnaud Giersch [Tue, 12 Mar 2019 13:31:16 +0000 (14:31 +0100)]
Save valgrind_stack_id in a private field.

Only register stacks when running on Valgrind to avoid false alarms from Asan.

9 months agoMailboxPtr looks like a smart pointer, but it's not. Kill it.
Arnaud Giersch [Tue, 12 Mar 2019 09:53:17 +0000 (10:53 +0100)]
MailboxPtr looks like a smart pointer, but it's not. Kill it.

9 months agoRemove unnecessary calls to c_str().
Arnaud Giersch [Tue, 12 Mar 2019 09:42:03 +0000 (10:42 +0100)]
Remove unnecessary calls to c_str().

9 months agoIIUC return std::move(...) is discouraged.
Arnaud Giersch [Tue, 12 Mar 2019 15:01:39 +0000 (16:01 +0100)]
IIUC return std::move(...) is discouraged.

9 months agoReferences++.
Arnaud Giersch [Tue, 12 Mar 2019 09:20:14 +0000 (10:20 +0100)]
References++.

9 months agomv ActorImpl where it belongs
Frederic Suter [Tue, 12 Mar 2019 13:53:57 +0000 (14:53 +0100)]
mv ActorImpl where it belongs

9 months agouse consistent namespaces
Frederic Suter [Tue, 12 Mar 2019 13:12:52 +0000 (14:12 +0100)]
use consistent namespaces
Storage is a resource, it goes in simgrid::kernel::resource

9 months agodon't use old fashioned simcall when you don't have to
Frederic Suter [Tue, 12 Mar 2019 12:12:10 +0000 (13:12 +0100)]
don't use old fashioned simcall when you don't have to

9 months agoproperly split task/comm in msg files
Frederic Suter [Tue, 12 Mar 2019 10:43:05 +0000 (11:43 +0100)]
properly split task/comm in msg files

9 months agoobjectify a few msg::Comm functions
Frederic Suter [Tue, 12 Mar 2019 10:36:23 +0000 (11:36 +0100)]
objectify a few msg::Comm functions

9 months agomark old MSG functions as deprecated
Frederic Suter [Tue, 12 Mar 2019 08:19:49 +0000 (09:19 +0100)]
mark old MSG functions as deprecated

9 months agoMerge branch 'master' of https://framagit.org/simgrid/simgrid
Frederic Suter [Mon, 11 Mar 2019 16:22:45 +0000 (17:22 +0100)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid

9 months agoSimplifications
Frederic Suter [Mon, 11 Mar 2019 15:31:17 +0000 (16:31 +0100)]
Simplifications

Do not use an ugly global map when each smpi process can store its own
tracing category.

9 months agoReplace void* when using std::thread.
Arnaud Giersch [Mon, 11 Mar 2019 13:53:11 +0000 (14:53 +0100)]
Replace void* when using std::thread.

9 months agoDeprecated functions are still used by StarPU. Postpone their removal.
Arnaud Giersch [Mon, 11 Mar 2019 12:26:40 +0000 (13:26 +0100)]
Deprecated functions are still used by StarPU. Postpone their removal.

9 months agoPass std::string parameters by reference too.
Arnaud Giersch [Sun, 10 Mar 2019 22:20:43 +0000 (23:20 +0100)]
Pass std::string parameters by reference too.

9 months agoDon't use pass-by-value for large parameters.
Arnaud Giersch [Sun, 10 Mar 2019 17:50:42 +0000 (18:50 +0100)]
Don't use pass-by-value for large parameters.

9 months agoMore references for parameters of type std::function.
Arnaud Giersch [Sun, 10 Mar 2019 17:37:13 +0000 (18:37 +0100)]
More references for parameters of type std::function.

9 months agoConstify.
Arnaud Giersch [Sun, 10 Mar 2019 14:46:37 +0000 (15:46 +0100)]
Constify.

9 months agoBad cast.
Arnaud Giersch [Sun, 10 Mar 2019 14:34:36 +0000 (15:34 +0100)]
Bad cast.

9 months agoMake ActorImpl::context_ a std::unique_ptr.
Arnaud Giersch [Fri, 8 Mar 2019 22:06:26 +0000 (23:06 +0100)]
Make ActorImpl::context_ a std::unique_ptr.

9 months agoMake SwappedContext::parmap_ a std::unique_ptr.
Arnaud Giersch [Fri, 8 Mar 2019 14:47:58 +0000 (15:47 +0100)]
Make SwappedContext::parmap_ a std::unique_ptr.

9 months agoCosmetics around std::unique_ptr.
Arnaud Giersch [Fri, 8 Mar 2019 14:34:00 +0000 (15:34 +0100)]
Cosmetics around std::unique_ptr.

9 months agoFix xbt_assert with side effects.
Arnaud Giersch [Sat, 9 Mar 2019 15:04:32 +0000 (16:04 +0100)]
Fix xbt_assert with side effects.

9 months agoEquality/assignment mismatch.
Arnaud Giersch [Sat, 9 Mar 2019 14:59:11 +0000 (15:59 +0100)]
Equality/assignment mismatch.

9 months agoRelease memory after last use only.
Arnaud Giersch [Fri, 8 Mar 2019 13:19:50 +0000 (14:19 +0100)]
Release memory after last use only.

9 months agoPut XBT_ATTRIB_DEPRECATED at proper place.
Arnaud Giersch [Fri, 8 Mar 2019 13:09:34 +0000 (14:09 +0100)]
Put XBT_ATTRIB_DEPRECATED at proper place.

9 months ago2 fixes in host-energy plugin
Martin Quinson [Fri, 8 Mar 2019 16:52:01 +0000 (17:52 +0100)]
2 fixes in host-energy plugin

- When computing the current watts, consistently use the pstate that
  was set at the beginning of the previous period.
  (the pstate at the end of the period was used to determinate whether
  or not we are in boot/shutdown state, ie, whether speed==0)
- Do not mark as used hosts that are just turned on and off. This is
  to be consistent with the tesh files while fixing the other bug.

9 months agoSpecify bindir while launching tesh
Martin Quinson [Wed, 6 Mar 2019 23:56:19 +0000 (00:56 +0100)]
Specify bindir while launching tesh

9 months agoUse references for callback parameters of on_exit().
Arnaud Giersch [Thu, 7 Mar 2019 16:32:41 +0000 (17:32 +0100)]
Use references for callback parameters of on_exit().

9 months agoUse references for parameters of type std::function.
Arnaud Giersch [Thu, 7 Mar 2019 15:50:38 +0000 (16:50 +0100)]
Use references for parameters of type std::function.

9 months agoUse references for parameters of type std::vector.
Arnaud Giersch [Thu, 7 Mar 2019 15:00:57 +0000 (16:00 +0100)]
Use references for parameters of type std::vector.

9 months agoFix mismatched alloc/free.
Arnaud Giersch [Wed, 6 Mar 2019 22:18:11 +0000 (23:18 +0100)]
Fix mismatched alloc/free.

9 months agoRemove duplicated but unused forward declarations.
Arnaud Giersch [Wed, 6 Mar 2019 22:10:10 +0000 (23:10 +0100)]
Remove duplicated but unused forward declarations.

9 months agoDon't hide class member.
Arnaud Giersch [Fri, 8 Mar 2019 09:12:57 +0000 (10:12 +0100)]
Don't hide class member.

9 months agoFix null pointer dereference.
Arnaud Giersch [Thu, 7 Mar 2019 17:21:39 +0000 (18:21 +0100)]
Fix null pointer dereference.

9 months agoSwitch s4u tuto to pajengr as well.
degomme [Fri, 8 Mar 2019 11:05:11 +0000 (12:05 +0100)]
Switch s4u tuto to pajengr as well.

9 months agohopefully fix most issues. thx agier for spotting the main one
Frederic Suter [Fri, 8 Mar 2019 10:11:13 +0000 (11:11 +0100)]
hopefully fix most issues. thx agier for spotting the main one

9 months agopoor damage control for tonight only
Frederic Suter [Thu, 7 Mar 2019 23:13:08 +0000 (00:13 +0100)]
poor damage control for tonight only

9 months agorevalidate another tesh
Frederic Suter [Thu, 7 Mar 2019 16:46:37 +0000 (17:46 +0100)]
revalidate another tesh

9 months agoMerge branch 'master' of https://framagit.org/simgrid/simgrid
Frederic Suter [Thu, 7 Mar 2019 16:40:12 +0000 (17:40 +0100)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid

9 months agorevalidate tesh
Frederic Suter [Thu, 7 Mar 2019 16:38:51 +0000 (17:38 +0100)]
revalidate tesh

9 months agosimplifications and fixes (forgot properties)
Frederic Suter [Thu, 7 Mar 2019 16:23:54 +0000 (17:23 +0100)]
simplifications and fixes (forgot properties)

9 months agoadapt smpi tuto to use pajengr (+ dockerfile)
degomme [Thu, 7 Mar 2019 16:17:20 +0000 (17:17 +0100)]
adapt smpi tuto to use pajengr (+ dockerfile)

9 months agouse extension for user data in MSG
Frederic Suter [Thu, 7 Mar 2019 15:55:15 +0000 (16:55 +0100)]
use extension for user data in MSG

9 months agoSplit the behavior of ActorImpl::create
Frederic Suter [Thu, 7 Mar 2019 14:10:14 +0000 (15:10 +0100)]
Split the behavior of ActorImpl::create
follow the init->set->start logic

9 months agoSometimes 'free' is not a member of 'std'.
Arnaud Giersch [Wed, 6 Mar 2019 21:06:24 +0000 (22:06 +0100)]
Sometimes 'free' is not a member of 'std'.

9 months agoAdd exception specification for xbt_free_f.
Arnaud Giersch [Wed, 6 Mar 2019 20:49:49 +0000 (21:49 +0100)]
Add exception specification for xbt_free_f.

Take the same exception specification as for std::free. Without that, Intel icc
fails to compile simgrid::xbt::demangle (backtrace.cpp) with:
error \#878: incompatible exception specifications

9 months agoMissing include.
Arnaud Giersch [Wed, 6 Mar 2019 17:52:28 +0000 (18:52 +0100)]
Missing include.

9 months agoUse real pointer type for context wrappers.
Arnaud Giersch [Wed, 6 Mar 2019 16:37:52 +0000 (17:37 +0100)]
Use real pointer type for context wrappers.

9 months ago[sonar] Use unsigned char* for context stacks.
Arnaud Giersch [Wed, 6 Mar 2019 16:51:30 +0000 (17:51 +0100)]
[sonar] Use unsigned char* for context stacks.

9 months ago[sonar] Use std::function.
Arnaud Giersch [Wed, 6 Mar 2019 16:11:02 +0000 (17:11 +0100)]
[sonar] Use std::function.

9 months agoDeprecate some functions.
Arnaud Giersch [Wed, 6 Mar 2019 09:22:01 +0000 (10:22 +0100)]
Deprecate some functions.

9 months agoType consistency.
Arnaud Giersch [Wed, 6 Mar 2019 14:22:32 +0000 (15:22 +0100)]
Type consistency.

9 months agooops
degomme [Wed, 6 Mar 2019 15:20:01 +0000 (16:20 +0100)]
oops

9 months agoWIP - SMPI tuto - add parts about sampling and memory sharing
degomme [Wed, 6 Mar 2019 15:01:02 +0000 (16:01 +0100)]
WIP - SMPI tuto - add parts about sampling and memory sharing

TODO :
- collectives, and more ?

9 months agoTry to help sonar.
degomme [Wed, 6 Mar 2019 14:56:25 +0000 (15:56 +0100)]
Try to help sonar.

9 months agoFix mc liveness examples.
degomme [Wed, 6 Mar 2019 14:56:12 +0000 (15:56 +0100)]
Fix mc liveness examples.

9 months agoObjectify MSG task send
Frederic Suter [Wed, 6 Mar 2019 10:57:40 +0000 (11:57 +0100)]
Objectify MSG task send

9 months agoSimplifications in MSG task execution
Frederic Suter [Wed, 6 Mar 2019 10:14:13 +0000 (11:14 +0100)]
Simplifications in MSG task execution

9 months agoplease sonar
Frederic Suter [Wed, 6 Mar 2019 08:23:10 +0000 (09:23 +0100)]
please sonar

9 months agoremove or deprecate now useless code
Frederic Suter [Wed, 6 Mar 2019 08:08:18 +0000 (09:08 +0100)]
remove or deprecate now useless code

9 months agoplease clang
Frederic Suter [Tue, 5 Mar 2019 23:11:18 +0000 (00:11 +0100)]
please clang

9 months agos4u::Exec now has 2 child classes
Frederic Suter [Tue, 5 Mar 2019 22:43:51 +0000 (23:43 +0100)]
s4u::Exec now has 2 child classes
s4u::ExecSeq and s4u::ExecPar

side effects:
+ no more C-style host list in HostImpl and ptaskLO7
+ Sequential execution can have a timeout
TODO:
+ get rid of ExecImplPtr in MSG
+ check and clean

9 months agoParmap status is simply a boolean.
Arnaud Giersch [Tue, 5 Mar 2019 22:20:38 +0000 (23:20 +0100)]
Parmap status is simply a boolean.

9 months agoUse std::function instead of function pointer.
Arnaud Giersch [Tue, 5 Mar 2019 22:05:02 +0000 (23:05 +0100)]
Use std::function instead of function pointer.

9 months agoUse proper type instead of void*.
Arnaud Giersch [Tue, 5 Mar 2019 21:46:54 +0000 (22:46 +0100)]
Use proper type instead of void*.

9 months agoAssert that the pointer is not null when dereferenced.
Arnaud Giersch [Tue, 5 Mar 2019 12:25:11 +0000 (13:25 +0100)]
Assert that the pointer is not null when dereferenced.

9 months agoField is initialized by constructor.
Arnaud Giersch [Tue, 5 Mar 2019 12:22:08 +0000 (13:22 +0100)]
Field is initialized by constructor.

9 months agothose pimpl are actually never null, stop fooling sonar
Martin Quinson [Tue, 5 Mar 2019 08:29:28 +0000 (09:29 +0100)]
those pimpl are actually never null, stop fooling sonar

9 months agoapply agier fixes for StarPU build
Frederic Suter [Tue, 5 Mar 2019 08:46:35 +0000 (09:46 +0100)]
apply agier fixes for StarPU build

9 months agoMerge branch 'master' of https://framagit.org/simgrid/simgrid
Frederic Suter [Tue, 5 Mar 2019 08:22:35 +0000 (09:22 +0100)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid

9 months agodon't let sonar think that pimpl_ can be null
Martin Quinson [Tue, 5 Mar 2019 07:03:51 +0000 (08:03 +0100)]
don't let sonar think that pimpl_ can be null

9 months agosonar: pass large parameters as const; don't name unused params
Martin Quinson [Tue, 5 Mar 2019 06:29:53 +0000 (07:29 +0100)]
sonar: pass large parameters as const; don't name unused params

9 months agoSanitize the prototype of Actor::on_exit() callbacks
Martin Quinson [Mon, 4 Mar 2019 23:38:28 +0000 (00:38 +0100)]
Sanitize the prototype of Actor::on_exit() callbacks

Changes on_exit(function<void(int failed, void*data)>, data)
into    on_exit(function<void(bool failed)>)

So, we are using bool for boolean values, and we don't force the user
to build a closure on void* data manually. If you want to pass a data
to the callback, just use the C++ formalism: [data](bool failed){...}

Other changes on the way (that excalated quickly)
- Document some recent changes to the internals in ChangeLog
- Document this_actor::on_exit() and Actor::on_exit() in doxygen
- Also sanitize the prototype of MSG_process_on_exit(). Was taking a
  (void*,void*) function; now takes a (int, void*) one. This was too
  weird to use void* to denote integers -- I actually doubt it ever
  worked the way it was written, but the tests are too poor to be
  sure: the only usage of this function ignores the return value.
- Also add a new test in activity-lifetime: test_sleep_restart_end
  Commented for now as it breaks miserably.

9 months agoMove ForcefulKillException to the root namespace, along with the other exceptions
Martin Quinson [Mon, 4 Mar 2019 22:28:38 +0000 (23:28 +0100)]
Move ForcefulKillException to the root namespace, along with the other exceptions

9 months agoRename StopRequest into ForcefulKillException to contribute to #325
Martin Quinson [Mon, 4 Mar 2019 22:01:36 +0000 (23:01 +0100)]
Rename StopRequest into ForcefulKillException to contribute to #325