cosmetics in the wanna be MC's simcall observer

diff --git a/src/mc/Transition.hpp b/src/mc/Transition.hpp
index 39f8a83..a0a2813 100644 (file)
--- a/src/mc/Transition.hpp
+++ b/src/mc/Transition.hpp
@@ -33,7 +33,7 @@ public:
   int argument_ = 0;
 };
 
   int argument_ = 0;
 };
 

-}
-}
+} // namespace mc
+} // namespace simgrid

 
 #endif
 
 #endif

diff --git a/src/mc/checker/SimcallInspector.hpp b/src/mc/checker/SimcallInspector.hpp
index 940578c..525f3a5 100644 (file)
--- a/src/mc/checker/SimcallInspector.hpp
+++ b/src/mc/checker/SimcallInspector.hpp
@@ -13,20 +13,20 @@ namespace mc {
 
 class SimcallInspector {
 public:
 
 class SimcallInspector {
 public:

-  /** whether this transition can currently be taken without blocking.
+  /** Whether this transition can currently be taken without blocking.

    *
    * For example, a mutex_lock is not enabled when the mutex is not free.
    * A comm_receive is not enabled before the corresponding send has been issued.
    */
   virtual bool is_enabled() { return true; }
 
    *
    * For example, a mutex_lock is not enabled when the mutex is not free.
    * A comm_receive is not enabled before the corresponding send has been issued.
    */
   virtual bool is_enabled() { return true; }
 

-  /** Execute the simcall, from the kernel POV.
+  /** Prepare the simcall to be executed

    *
    *

-   * Most of the time, this action is in charge of doing what the perf models would have done if not in MC mode.
-   * For example, if it's a random(), choose the value to explore next. If it's a waitany, choose the terminated
-   * communication to consider now.
+   * Do the choices that the platform would have done in non-MC settings.
+   * For example if it's a waitany, pick the communication that should finish first.
+   * If it's a random(), choose the next value to explore.

    */
    */

-  virtual void fire() = 0;
+  virtual void arm() {}

 
   /** Some simcalls may only be observable under some circomstances.
    * Most simcalls are not visible from the MC because they don't have an inspector at all. */
 
   /** Some simcalls may only be observable under some circomstances.
    * Most simcalls are not visible from the MC because they don't have an inspector at all. */