From 671e12e2cec060c4315c5c8162e6c0ccf0287f7b Mon Sep 17 00:00:00 2001 From: Martin Quinson Date: Mon, 9 Sep 2019 02:18:06 +0200 Subject: [PATCH] cosmetics in the wanna be MC's simcall observer --- src/mc/Transition.hpp | 4 ++-- src/mc/checker/SimcallInspector.hpp | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/mc/Transition.hpp b/src/mc/Transition.hpp index 39f8a83673..a0a2813b08 100644 --- a/src/mc/Transition.hpp +++ b/src/mc/Transition.hpp @@ -33,7 +33,7 @@ public: int argument_ = 0; }; -} -} +} // namespace mc +} // namespace simgrid #endif diff --git a/src/mc/checker/SimcallInspector.hpp b/src/mc/checker/SimcallInspector.hpp index 940578c290..525f3a5ce0 100644 --- a/src/mc/checker/SimcallInspector.hpp +++ b/src/mc/checker/SimcallInspector.hpp @@ -13,20 +13,20 @@ namespace mc { class SimcallInspector { public: - /** whether this transition can currently be taken without blocking. + /** Whether this transition can currently be taken without blocking. * * For example, a mutex_lock is not enabled when the mutex is not free. * A comm_receive is not enabled before the corresponding send has been issued. */ virtual bool is_enabled() { return true; } - /** Execute the simcall, from the kernel POV. + /** Prepare the simcall to be executed * - * Most of the time, this action is in charge of doing what the perf models would have done if not in MC mode. - * For example, if it's a random(), choose the value to explore next. If it's a waitany, choose the terminated - * communication to consider now. + * Do the choices that the platform would have done in non-MC settings. + * For example if it's a waitany, pick the communication that should finish first. + * If it's a random(), choose the next value to explore. */ - virtual void fire() = 0; + virtual void arm() {} /** Some simcalls may only be observable under some circomstances. * Most simcalls are not visible from the MC because they don't have an inspector at all. */ -- 2.20.1