Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
Don't completely short-circuit these loops!
authorArnaud Giersch <arnaud.giersch@iut-bm.univ-fcomte.fr>
Tue, 11 Feb 2014 07:41:26 +0000 (08:41 +0100)
committerArnaud Giersch <arnaud.giersch@iut-bm.univ-fcomte.fr>
Tue, 11 Feb 2014 08:15:39 +0000 (09:15 +0100)
We really need some validated tesh files for cloud/vm examples to detect
such stupid mistakes.

src/surf/vm_workstation_hl13.cpp
src/surf/workstation_interface.cpp

index b5fe764..a788edc 100644 (file)
@@ -113,7 +113,7 @@ double WorkstationVMHL13Model::shareResources(double now)
   /* iterate for all virtual machines */
   for (WorkstationVMModel::vm_list_t::iterator iter =
          WorkstationVMModel::ws_vms.begin();
-       iter !=  WorkstationVMModel::ws_vms.begin(); ++iter) {
+       iter !=  WorkstationVMModel::ws_vms.end(); ++iter) {
 
     WorkstationVMPtr ws_vm = &*iter;
     CpuPtr cpu = static_cast<CpuPtr>(ws_vm->p_cpu);
@@ -158,7 +158,7 @@ double WorkstationVMHL13Model::shareResources(double now)
   /* iterate for all virtual machines */
   for (WorkstationVMModel::vm_list_t::iterator iter =
          WorkstationVMModel::ws_vms.begin();
-       iter !=  WorkstationVMModel::ws_vms.begin(); ++iter) {
+       iter !=  WorkstationVMModel::ws_vms.end(); ++iter) {
 
     {
 #if 0
index cd22204..1b41b0c 100644 (file)
@@ -49,7 +49,7 @@ void WorkstationModel::adjustWeightOfDummyCpuActions()
   /* iterate for all virtual machines */
   for (WorkstationVMModel::vm_list_t::iterator iter =
          WorkstationVMModel::ws_vms.begin();
-       iter !=  WorkstationVMModel::ws_vms.begin(); ++iter) {
+       iter !=  WorkstationVMModel::ws_vms.end(); ++iter) {
 
     WorkstationVMPtr ws_vm = &*iter;
     CpuCas01Ptr cpu_cas01 = static_cast<CpuCas01Ptr>(ws_vm->p_cpu);
@@ -302,7 +302,7 @@ xbt_dynar_t Workstation::getVms()
   /* iterate for all virtual machines */
   for (WorkstationVMModel::vm_list_t::iterator iter =
          WorkstationVMModel::ws_vms.begin();
-       iter !=  WorkstationVMModel::ws_vms.begin(); ++iter) {
+       iter !=  WorkstationVMModel::ws_vms.end(); ++iter) {
 
     WorkstationVMPtr ws_vm = &*iter;
     if (this == ws_vm-> p_subWs)