From: Arnaud Giersch <arnaud.giersch@iut-bm.univ-fcomte.fr>
Date: Tue, 11 Feb 2014 07:41:26 +0000 (+0100)
Subject: Don't completely short-circuit these loops!
X-Git-Tag: v3_11_beta~55
X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/commitdiff_plain/3a0459051e2eea639a475b8267472daee1769693

Don't completely short-circuit these loops!

We really need some validated tesh files for cloud/vm examples to detect
such stupid mistakes.
---

diff --git a/src/surf/vm_workstation_hl13.cpp b/src/surf/vm_workstation_hl13.cpp
index b5fe764dfa..a788edc851 100644
--- a/src/surf/vm_workstation_hl13.cpp
+++ b/src/surf/vm_workstation_hl13.cpp
@@ -113,7 +113,7 @@ double WorkstationVMHL13Model::shareResources(double now)
   /* iterate for all virtual machines */
   for (WorkstationVMModel::vm_list_t::iterator iter =
          WorkstationVMModel::ws_vms.begin();
-       iter !=  WorkstationVMModel::ws_vms.begin(); ++iter) {
+       iter !=  WorkstationVMModel::ws_vms.end(); ++iter) {
 
     WorkstationVMPtr ws_vm = &*iter;
     CpuPtr cpu = static_cast<CpuPtr>(ws_vm->p_cpu);
@@ -158,7 +158,7 @@ double WorkstationVMHL13Model::shareResources(double now)
   /* iterate for all virtual machines */
   for (WorkstationVMModel::vm_list_t::iterator iter =
          WorkstationVMModel::ws_vms.begin();
-       iter !=  WorkstationVMModel::ws_vms.begin(); ++iter) {
+       iter !=  WorkstationVMModel::ws_vms.end(); ++iter) {
 
     {
 #if 0
diff --git a/src/surf/workstation_interface.cpp b/src/surf/workstation_interface.cpp
index cd222049a1..1b41b0cf1a 100644
--- a/src/surf/workstation_interface.cpp
+++ b/src/surf/workstation_interface.cpp
@@ -49,7 +49,7 @@ void WorkstationModel::adjustWeightOfDummyCpuActions()
   /* iterate for all virtual machines */
   for (WorkstationVMModel::vm_list_t::iterator iter =
          WorkstationVMModel::ws_vms.begin();
-       iter !=  WorkstationVMModel::ws_vms.begin(); ++iter) {
+       iter !=  WorkstationVMModel::ws_vms.end(); ++iter) {
 
     WorkstationVMPtr ws_vm = &*iter;
     CpuCas01Ptr cpu_cas01 = static_cast<CpuCas01Ptr>(ws_vm->p_cpu);
@@ -302,7 +302,7 @@ xbt_dynar_t Workstation::getVms()
   /* iterate for all virtual machines */
   for (WorkstationVMModel::vm_list_t::iterator iter =
          WorkstationVMModel::ws_vms.begin();
-       iter !=  WorkstationVMModel::ws_vms.begin(); ++iter) {
+       iter !=  WorkstationVMModel::ws_vms.end(); ++iter) {
 
     WorkstationVMPtr ws_vm = &*iter;
     if (this == ws_vm-> p_subWs)