Add new entry in Release_Notes.

[simgrid.git] / src / smpi / colls / alltoallv / alltoallv-ring.cpp

diff --git a/src/smpi/colls/alltoallv/alltoallv-ring.cpp b/src/smpi/colls/alltoallv/alltoallv-ring.cpp
index 79dadaf8c1d609c665141ab454b301b5e86d888c..24a929da8519491ad0bdf59c984a92e89640e90d 100644 (file)
--- a/src/smpi/colls/alltoallv/alltoallv-ring.cpp
+++ b/src/smpi/colls/alltoallv/alltoallv-ring.cpp
@@ -1,4 +1,4 @@
-/* Copyright (c) 2013-2017. The SimGrid Team.
+/* Copyright (c) 2013-2023. The SimGrid Team.
  * All rights reserved.                                                     */
 
 /* This program is free software; you can redistribute it and/or modify it
@@ -22,14 +22,13 @@
 
  * Descrp: Function works in P - 1 steps. In step i, node j - i -> j -> j + i.
 
- * Auther: Ahmad Faraj
+ * Author: Ahmad Faraj
 
  ****************************************************************************/
-namespace simgrid{
-namespace smpi{
-int Coll_alltoallv_ring::alltoallv(void* send_buff, int* send_counts, int* send_disps, MPI_Datatype send_type,
-                                   void* recv_buff, int* recv_counts, int* recv_disps, MPI_Datatype recv_type,
-                                   MPI_Comm comm)
+namespace simgrid::smpi {
+int alltoallv__ring(const void* send_buff, const int* send_counts, const int* send_disps, MPI_Datatype send_type,
+                    void* recv_buff, const int* recv_counts, const int* recv_disps, MPI_Datatype recv_type,
+                    MPI_Comm comm)
 {
   MPI_Status s;
   MPI_Aint send_chunk, recv_chunk;
@@ -43,10 +42,10 @@ int Coll_alltoallv_ring::alltoallv(void* send_buff, int* send_counts, int* send_
   num_procs = comm->size();
   send_chunk = send_type->get_extent();
   recv_chunk = recv_type->get_extent();
-  int pof2 = ((num_procs != 0) && ((num_procs & (~num_procs + 1)) == num_procs));
+  bool pof2  = ((num_procs != 0) && ((num_procs & (~num_procs + 1)) == num_procs));
   for (i = 0; i < num_procs; i++) {
 
-    if (pof2 == 1) {
+    if (pof2) {
       /* use exclusive-or algorithm */
       src = dst = rank ^ i;
     } else {
@@ -61,5 +60,4 @@ int Coll_alltoallv_ring::alltoallv(void* send_buff, int* send_counts, int* send_
   }
   return MPI_SUCCESS;
 }
-}
-}
+} // namespace simgrid::smpi