Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
[trace] factorizing code so we have just one way to get routes (between ASes, hosts...
[simgrid.git] / src / instr / instr_routing.c
index b501bd7..083910c 100644 (file)
@@ -430,21 +430,25 @@ static xbt_node_t new_xbt_graph_node (xbt_graph_t graph, const char *name, xbt_d
 static xbt_edge_t new_xbt_graph_edge (xbt_graph_t graph, xbt_node_t s, xbt_node_t d, xbt_dict_t edges)
 {
   xbt_edge_t ret;
-  char *name;
 
   const char *sn = instr_node_name (s);
   const char *dn = instr_node_name (d);
+  int len = strlen(sn)+strlen(dn)+1;
+  char *name = (char*)malloc(len * sizeof(char));
 
-  name = bprintf ("%s%s", sn, dn);
-  ret = xbt_dict_get_or_null (edges, name);
-  if (ret) return ret;
-  free (name);
-  name = bprintf ("%s%s", dn, sn);
+
+  snprintf (name, len, "%s%s", sn, dn);
   ret = xbt_dict_get_or_null (edges, name);
-  if (ret) return ret;
+  if (ret == NULL){
+    snprintf (name, len, "%s%s", dn, sn);
+    ret = xbt_dict_get_or_null (edges, name);
+  }
 
-  ret = xbt_graph_new_edge(graph, s, d, NULL);
-  xbt_dict_set (edges, name, ret, NULL);
+  if (ret == NULL){
+    ret = xbt_graph_new_edge(graph, s, d, NULL);
+    xbt_dict_set (edges, name, ret, NULL);
+  }
+  free (name);
   return ret;
 }
 
@@ -467,57 +471,51 @@ static void recursiveXBTGraphExtraction (xbt_graph_t graph, xbt_dict_t nodes, xb
   container_t child1, child2;
   const char *child1_name, *child2_name;
   xbt_dict_foreach(container->children, cursor1, child1_name, child1) {
-    if (child1->kind == INSTR_LINK) continue;
-    xbt_dict_foreach(container->children, cursor2, child2_name, child2) {
-      if (child2->kind == INSTR_LINK) continue;
+    //if child1 is not a link, a smpi node, a msg process or a msg task
+    if (child1->kind == INSTR_LINK || child1->kind == INSTR_SMPI || child1->kind == INSTR_MSG_PROCESS || child1->kind == INSTR_MSG_TASK) continue;
 
-      if ((child1->kind == INSTR_HOST || child1->kind == INSTR_ROUTER) &&
-          (child2->kind == INSTR_HOST  || child2->kind == INSTR_ROUTER) &&
-          strcmp (child1_name, child2_name) != 0){
+    xbt_dict_foreach(container->children, cursor2, child2_name, child2) {
+      //if child2 is not a link, a smpi node, a msg process or a msg task
+      if (child2->kind == INSTR_LINK || child2->kind == INSTR_SMPI || child2->kind == INSTR_MSG_PROCESS || child2->kind == INSTR_MSG_TASK) continue;
+
+      //if child1 is not child2
+      if (strcmp (child1_name, child2_name) == 0) continue;
+
+      //get the route
+      route_t route = xbt_new0(s_route_t,1);
+      route->link_list = xbt_dynar_new(global_routing->size_of_link,NULL);
+      rc->get_route_and_latency (rc,
+          (network_element_t)(child1->net_elm),
+          (network_element_t)(child2->net_elm),route, NULL);
+
+      //user might want to extract a graph using routes with only one link
+      //see --cfg=tracing/onelink_only:1 or --help-tracing for details
+      if (TRACE_onelink_only() && xbt_dynar_length (route->link_list) > 1) continue;
+
+      //traverse the route connecting the containers
+      unsigned int cpt;
+      void *link;
+      xbt_node_t current, previous;
+      if (route->src_gateway){
+        previous = new_xbt_graph_node(graph, route->src_gateway->name, nodes);
+      }else{
+        previous = new_xbt_graph_node(graph, child1_name, nodes);
+      }
 
-        // FIXME factorize route creation with else branch below (once possible)
-        xbt_dynar_t route=NULL;
-        routing_get_route_and_latency ((network_element_t)(child1->net_elm),
-                                       (network_element_t)(child2->net_elm),
-                                       &route,NULL);
-        if (TRACE_onelink_only()){
-          if (xbt_dynar_length (route) > 1) continue;
-        }
-        unsigned int cpt;
-        void *link;
-        xbt_node_t current, previous = new_xbt_graph_node(graph, child1_name, nodes);
-        xbt_dynar_foreach (route, cpt, link) {
-          char *link_name = ((link_CM02_t)link)->lmm_resource.generic_resource.name;
-          current = new_xbt_graph_node(graph, link_name, nodes);
-          new_xbt_graph_edge (graph, previous, current, edges);
-          //previous -> current
-          previous = current;
-        }
-        current = new_xbt_graph_node(graph, child2_name, nodes);
+      xbt_dynar_foreach (route->link_list, cpt, link) {
+        char *link_name = ((link_CM02_t)link)->lmm_resource.generic_resource.name;
+        current = new_xbt_graph_node(graph, link_name, nodes);
         new_xbt_graph_edge (graph, previous, current, edges);
-
-      }else if (child1->kind == INSTR_AS &&
-                child2->kind == INSTR_AS &&
-                strcmp(child1_name, child2_name) != 0){
-
-        route_t route = xbt_new0(s_route_t,1);
-        route->link_list = xbt_dynar_new(global_routing->size_of_link,NULL);
-        rc->get_route_and_latency (rc,
-                                   (network_element_t)(child1->net_elm),
-                                   (network_element_t)(child2->net_elm),route, NULL);
-        unsigned int cpt;
-        void *link;
-        xbt_node_t current, previous = new_xbt_graph_node(graph, route->src_gateway->name, nodes);
-        xbt_dynar_foreach (route->link_list, cpt, link) {
-          char *link_name = ((link_CM02_t)link)->lmm_resource.generic_resource.name;
-          current = new_xbt_graph_node(graph, link_name, nodes);
-          //previous -> current
-          previous = current;
-        }
+        //previous -> current
+        previous = current;
+      }
+      if (route->dst_gateway){
         current = new_xbt_graph_node(graph, route->dst_gateway->name, nodes);
-        new_xbt_graph_edge (graph, previous, current, edges);
-        generic_free_route(route);
+      }else{
+        current = new_xbt_graph_node(graph, child2_name, nodes);
       }
+      new_xbt_graph_edge (graph, previous, current, edges);
+      generic_free_route(route);
     }
   }
 
@@ -529,6 +527,8 @@ xbt_graph_t instr_routing_platform_graph (void)
   xbt_dict_t nodes = xbt_dict_new_homogeneous(NULL);
   xbt_dict_t edges = xbt_dict_new_homogeneous(NULL);
   recursiveXBTGraphExtraction (ret, nodes, edges, global_routing->root, PJ_container_get_root());
+  xbt_dict_free (&nodes);
+  xbt_dict_free (&edges);
   return ret;
 }