Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
2 years agoreduce the differences between the s4u_async examples
Martin Quinson [Sun, 10 Sep 2017 15:57:36 +0000 (17:57 +0200)]
reduce the differences between the s4u_async examples

2 years agofix the s4u_async-waitany example
Martin Quinson [Sun, 10 Sep 2017 15:34:48 +0000 (17:34 +0200)]
fix the s4u_async-waitany example

2 years agomassive cleanups in the s4u-async-waitall example
Martin Quinson [Sun, 10 Sep 2017 14:55:46 +0000 (16:55 +0200)]
massive cleanups in the s4u-async-waitall example

2 years agoMerge pull request #218 from Takishipp/MSG2S4U
Martin Quinson [Sun, 10 Sep 2017 13:20:21 +0000 (15:20 +0200)]
Merge pull request #218 from Takishipp/MSG2S4U

first attempt to convert async-waitany msg version to s4u (doesn't work yet)

2 years agoplease sonar: kill dead code
Martin Quinson [Sun, 10 Sep 2017 13:19:55 +0000 (15:19 +0200)]
please sonar: kill dead code

2 years agoIndentation.
Arnaud Giersch [Sat, 9 Sep 2017 21:20:22 +0000 (23:20 +0200)]
Indentation.

2 years ago'request' cannot be null here (verified before at line 611.
Arnaud Giersch [Sat, 9 Sep 2017 20:37:09 +0000 (22:37 +0200)]
'request' cannot be null here (verified before at line 611.

2 years agoRemove useless assignments.
Arnaud Giersch [Sat, 9 Sep 2017 20:29:19 +0000 (22:29 +0200)]
Remove useless assignments.

2 years agoUse C++ strings instead of char*.
Arnaud Giersch [Sat, 9 Sep 2017 16:23:12 +0000 (18:23 +0200)]
Use C++ strings instead of char*.

2 years agoFix use-ater-free.
Arnaud Giersch [Sat, 9 Sep 2017 14:28:26 +0000 (16:28 +0200)]
Fix use-ater-free.

2 years agoFix unitialized value spotted by scan-build.
Arnaud Giersch [Sat, 9 Sep 2017 14:05:08 +0000 (16:05 +0200)]
Fix unitialized value spotted by scan-build.

34  while (simgrid::s4u::Engine::getClock() < deadline) {
        # (1) Loop condition is true.  Entering loop body
35    void* received;
        # (2) 'received' declared without an initial value
36    if (comm == nullptr)
        # (3) Taking false branch
37      comm = mailbox->get_async(&received);
38    if (comm->test()) {
        # (4) Assuming the condition is true
        # (5) Taking true branch
39      // Retrieve the data sent by the peer.
40      TrackerQuery* tq = static_cast<TrackerQuery*>(received);
        # (6) Assigned value is garbage or undefined

2 years agoFix potential buffer overflows.
Arnaud Giersch [Fri, 8 Sep 2017 22:09:45 +0000 (00:09 +0200)]
Fix potential buffer overflows.

2 years agoStupid scan-build, this is always true.
Arnaud Giersch [Fri, 8 Sep 2017 21:22:10 +0000 (23:22 +0200)]
Stupid scan-build, this is always true.

2 years agoVerify parameters passed to strcmp.
Arnaud Giersch [Fri, 8 Sep 2017 20:30:00 +0000 (22:30 +0200)]
Verify parameters passed to strcmp.

2 years agoFix use-after-free.
Arnaud Giersch [Wed, 6 Sep 2017 13:14:31 +0000 (15:14 +0200)]
Fix use-after-free.

'message' is not mine if I didn't get an answer.

2 years agoAdding integration tests of async-waitall and waitany
Takishipp [Fri, 8 Sep 2017 15:47:44 +0000 (17:47 +0200)]
Adding integration tests of async-waitall and waitany

2 years agoMake some correction to the converted examples
Takishipp [Fri, 8 Sep 2017 12:30:53 +0000 (14:30 +0200)]
Make some correction to the converted examples

2 years agofix async-waitall example
Takishipp [Thu, 7 Sep 2017 14:33:03 +0000 (16:33 +0200)]
fix async-waitall example

2 years agoadd a description to s4u for the treated examples
Takishipp [Wed, 6 Sep 2017 14:06:55 +0000 (16:06 +0200)]
add a description to s4u for the treated examples

2 years agoasyc-waitall is converted
Takishipp [Wed, 6 Sep 2017 10:59:38 +0000 (12:59 +0200)]
asyc-waitall is converted

2 years agoasync-waitall is almost converted - phase 1
Takishipp [Tue, 5 Sep 2017 16:13:38 +0000 (18:13 +0200)]
async-waitall is almost converted - phase 1

2 years agoDon't inline ~xbt_ex.
Arnaud Giersch [Mon, 4 Sep 2017 20:44:04 +0000 (22:44 +0200)]
Don't inline ~xbt_ex.

Otherwise, xbt_ex is also defined in libsimgrid-java and some tests are broken
with clang/libc++/freebsd.

Thanks Gabriel if this works!

2 years agoStart to convert async-waitall to s4u
Takishipp [Mon, 4 Sep 2017 15:27:55 +0000 (17:27 +0200)]
Start to convert async-waitall to s4u

2 years agoAlmost converted phase 2
Takishipp [Mon, 4 Sep 2017 15:09:44 +0000 (17:09 +0200)]
Almost converted phase 2

2 years agostart cleaning up the instr::containers
Martin Quinson [Sun, 3 Sep 2017 23:48:45 +0000 (01:48 +0200)]
start cleaning up the instr::containers

2 years agotry to get rid of some errors seen by scan-build
Augustin Degomme [Sun, 3 Sep 2017 22:55:03 +0000 (00:55 +0200)]
try to get rid of some errors seen by scan-build

2 years agogive a proper constructor/destructor to instr::Container
Martin Quinson [Sun, 3 Sep 2017 20:34:17 +0000 (22:34 +0200)]
give a proper constructor/destructor to instr::Container

2 years agotry to please scan-build
Augustin Degomme [Sat, 2 Sep 2017 23:53:13 +0000 (01:53 +0200)]
try to please scan-build

2 years agocheck we don't allow 0 here
Augustin Degomme [Sat, 2 Sep 2017 21:51:53 +0000 (23:51 +0200)]
check we don't allow 0 here

2 years agosee if that pleases scan-build
Augustin Degomme [Sat, 2 Sep 2017 18:38:24 +0000 (20:38 +0200)]
see if that pleases scan-build

2 years agoavoid potential division by 0... But not sure 0 is right as an answer here
Augustin Degomme [Sat, 2 Sep 2017 15:28:39 +0000 (17:28 +0200)]
avoid potential division by 0... But not sure 0 is right as an answer here

2 years agoRevert "Libsimgrid-java already depends on libsimgrid. There's no need to load it...
Arnaud Giersch [Sat, 2 Sep 2017 06:26:56 +0000 (08:26 +0200)]
Revert "Libsimgrid-java already depends on libsimgrid.  There's no need to load it in advance."

This reverts commit 4e90ee55b9c3170ef7c9ade5d979987ae395cf00.

It breaks when ligsimgrid must be extracted from simgrid.jar.

2 years agoLibsimgrid-java already depends on libsimgrid. There's no need to load it in advance.
Arnaud Giersch [Fri, 1 Sep 2017 21:45:53 +0000 (23:45 +0200)]
Libsimgrid-java already depends on libsimgrid.  There's no need to load it in advance.

2 years agoFix mismatched free() / delete.
Arnaud Giersch [Fri, 1 Sep 2017 19:39:35 +0000 (21:39 +0200)]
Fix mismatched free() / delete.

2 years agoadd --no-compress-output flag to dynamic analysis flags as cmake spits out base64...
Augustin Degomme [Fri, 1 Sep 2017 14:14:20 +0000 (16:14 +0200)]
add --no-compress-output flag to dynamic analysis flags as cmake spits out base64+gzip outputs by default now

2 years agodon't eat the errno of when dlopen fails (but still remove the copied binary)
Martin Quinson [Thu, 31 Aug 2017 21:41:46 +0000 (23:41 +0200)]
don't eat the errno of when dlopen fails (but still remove the copied binary)

2 years agoalmost converted
Takishipp [Thu, 31 Aug 2017 16:24:24 +0000 (18:24 +0200)]
almost converted

2 years agoCompare file prefix only.
Arnaud Giersch [Wed, 30 Aug 2017 21:32:39 +0000 (23:32 +0200)]
Compare file prefix only.

This corrects commit e38b14311d3182de4c7bd3b03dcdde8caa93a941.

2 years agoSecond phase to convert async-waitany msg vertion to s4u (bugs to solve)
Takishipp [Wed, 30 Aug 2017 15:54:09 +0000 (17:54 +0200)]
Second phase to convert async-waitany msg vertion to s4u (bugs to solve)

2 years agoUse std::atomic::fetch_add instead of ++ shortcut (clearer to the reader).
Arnaud Giersch [Wed, 30 Aug 2017 15:27:50 +0000 (17:27 +0200)]
Use std::atomic::fetch_add instead of ++ shortcut (clearer to the reader).

2 years agoUnused typedefs.
Arnaud Giersch [Wed, 30 Aug 2017 14:04:15 +0000 (16:04 +0200)]
Unused typedefs.

2 years agoProtected is useless here (please sonar).
Arnaud Giersch [Wed, 30 Aug 2017 13:27:41 +0000 (15:27 +0200)]
Protected is useless here (please sonar).

2 years agoReduce code duplication in parmap_bench.cpp.
Arnaud Giersch [Wed, 30 Aug 2017 13:21:35 +0000 (15:21 +0200)]
Reduce code duplication in parmap_bench.cpp.

2 years agoUse xbt/log in parmap_bench and please sonar.
Arnaud Giersch [Wed, 30 Aug 2017 13:02:41 +0000 (15:02 +0200)]
Use xbt/log in parmap_bench and please sonar.

2 years agoNo need for timestamps in logs.
Arnaud Giersch [Wed, 30 Aug 2017 12:45:39 +0000 (14:45 +0200)]
No need for timestamps in logs.

2 years agoDon't mess ev->ap (allows multiple %m in layout).
Arnaud Giersch [Wed, 30 Aug 2017 12:41:47 +0000 (14:41 +0200)]
Don't mess ev->ap (allows multiple %m in layout).

2 years agoCosmetics.
Arnaud Giersch [Wed, 30 Aug 2017 12:32:33 +0000 (14:32 +0200)]
Cosmetics.

2 years agoRemove bogus setenv.
Arnaud Giersch [Tue, 29 Aug 2017 20:04:12 +0000 (22:04 +0200)]
Remove bogus setenv.

2 years agoA std::string is ok here.
Arnaud Giersch [Tue, 29 Aug 2017 19:50:44 +0000 (21:50 +0200)]
A std::string is ok here.

2 years agoC++-style casts.
Arnaud Giersch [Tue, 29 Aug 2017 19:44:44 +0000 (21:44 +0200)]
C++-style casts.

2 years agos4u is not that bad anymore
Martin Quinson [Mon, 28 Aug 2017 20:27:04 +0000 (22:27 +0200)]
s4u is not that bad anymore

2 years agouniformize the function names
Martin Quinson [Mon, 28 Aug 2017 20:15:02 +0000 (22:15 +0200)]
uniformize the function names

2 years agoinstr: kill leftover classes
Martin Quinson [Mon, 28 Aug 2017 19:14:12 +0000 (21:14 +0200)]
instr: kill leftover classes

2 years agoinstr: kill an unused field
Martin Quinson [Mon, 28 Aug 2017 18:43:06 +0000 (20:43 +0200)]
instr: kill an unused field

2 years agorename the instr::Container class to its proper name
Martin Quinson [Mon, 28 Aug 2017 18:39:15 +0000 (20:39 +0200)]
rename the instr::Container class to its proper name

2 years agosmpi: don't override the value of network/TCP-gamma with the default value. That...
Martin Quinson [Mon, 28 Aug 2017 15:52:41 +0000 (17:52 +0200)]
smpi: don't override the value of network/TCP-gamma with the default value. That's misleading

2 years agodoc: give the real default value of option network/TCP-gamma
Martin Quinson [Mon, 28 Aug 2017 15:52:13 +0000 (17:52 +0200)]
doc: give the real default value of option network/TCP-gamma

2 years agofirst attempt to convert async-waitany msg version to s4u (doesn't work)
Takishipp [Mon, 28 Aug 2017 15:21:42 +0000 (17:21 +0200)]
first attempt to convert async-waitany msg version to s4u (doesn't work)

2 years agoinstr: please sonar
Martin Quinson [Mon, 28 Aug 2017 10:05:10 +0000 (12:05 +0200)]
instr: please sonar

- Use initialization lists
- Don't have C++ declarations within the extern "C" block

2 years agofollow the naming conventions in Instr
Martin Quinson [Mon, 28 Aug 2017 09:56:13 +0000 (11:56 +0200)]
follow the naming conventions in Instr

2 years agofix clang builds
Martin Quinson [Mon, 28 Aug 2017 09:22:18 +0000 (11:22 +0200)]
fix clang builds

Don't try to have globals linked in the C++ way.
Instead, we should kill all those globals (but not today)

2 years agomove all inst declarations into their namespace
Martin Quinson [Mon, 28 Aug 2017 00:20:57 +0000 (02:20 +0200)]
move all inst declarations into their namespace

2 years agokill a C type now that we have a class
Martin Quinson [Sun, 27 Aug 2017 23:06:17 +0000 (01:06 +0200)]
kill a C type now that we have a class

2 years agoclass names must be in CamelCase
Martin Quinson [Sun, 27 Aug 2017 22:42:55 +0000 (00:42 +0200)]
class names must be in CamelCase

2 years agoa class with no method is not a class
Martin Quinson [Sun, 27 Aug 2017 22:37:30 +0000 (00:37 +0200)]
a class with no method is not a class

2 years agoMerge branch 'master' of github.com:simgrid/simgrid
Martin Quinson [Sun, 27 Aug 2017 22:23:36 +0000 (00:23 +0200)]
Merge branch 'master' of github.com:simgrid/simgrid

2 years agoMerge branch 'master' of scm.gforge.inria.fr:/gitroot/simgrid/simgrid
Martin Quinson [Sun, 27 Aug 2017 22:23:23 +0000 (00:23 +0200)]
Merge branch 'master' of scm.gforge.inria.fr:/gitroot/simgrid/simgrid

2 years agoMerge pull request #215 from Takishipp/s_type_cleanup
Martin Quinson [Sun, 27 Aug 2017 22:22:02 +0000 (00:22 +0200)]
Merge pull request #215 from Takishipp/s_type_cleanup

s_type cleanup

2 years agoCreate dict in NetworkNS3Model constructor.
Arnaud Giersch [Sun, 27 Aug 2017 15:00:52 +0000 (17:00 +0200)]
Create dict in NetworkNS3Model constructor.

It's already destroyed from ~NetworkNS3Model.

2 years agothis has to be ordered as MPI allows access to items with an index
Augustin Degomme [Fri, 25 Aug 2017 23:25:55 +0000 (01:25 +0200)]
this has to be ordered as MPI allows access to items with an index

2 years agoAvoid sending address of local variables.
Arnaud Giersch [Thu, 24 Aug 2017 20:45:17 +0000 (22:45 +0200)]
Avoid sending address of local variables.

This should fix the problem introduced by commit e2334f2600f6d03f43a79f9c3dc43c2fff21e115.

2 years agoTrivial formatting issues.
Arnaud Giersch [Tue, 22 Aug 2017 17:20:06 +0000 (19:20 +0200)]
Trivial formatting issues.

2 years agoUse (const) references with range-based for loops.
Arnaud Giersch [Fri, 4 Aug 2017 07:46:24 +0000 (09:46 +0200)]
Use (const) references with range-based for loops.

This avoids unnecessary copies and saves a few milliseconds.

2 years agoFix ns-3 build.
Arnaud Giersch [Tue, 22 Aug 2017 20:56:53 +0000 (22:56 +0200)]
Fix ns-3 build.

2 years agoMissing "override"s.
Arnaud Giersch [Tue, 22 Aug 2017 20:05:26 +0000 (22:05 +0200)]
Missing "override"s.

2 years agoUse NewGlobalRef since Vm in unref'd by DeleteGlobalRef.
Arnaud Giersch [Mon, 21 Aug 2017 13:49:07 +0000 (15:49 +0200)]
Use NewGlobalRef since Vm in unref'd by DeleteGlobalRef.

2 years agoUsing std::remove_if is overkill here.
Arnaud Giersch [Mon, 21 Aug 2017 13:47:26 +0000 (15:47 +0200)]
Using std::remove_if is overkill here.

2 years agoThis method can be made const.
Arnaud Giersch [Mon, 21 Aug 2017 11:25:22 +0000 (13:25 +0200)]
This method can be made const.

2 years agoEnsure that low is valid before using it.
Arnaud Giersch [Sun, 20 Aug 2017 21:15:09 +0000 (23:15 +0200)]
Ensure that low is valid before using it.

2 years agoRemove useless #undef's.
Arnaud Giersch [Sun, 20 Aug 2017 21:15:09 +0000 (23:15 +0200)]
Remove useless #undef's.

2 years agoWhitespace cleanup.
Arnaud Giersch [Sun, 20 Aug 2017 21:15:09 +0000 (23:15 +0200)]
Whitespace cleanup.

2 years agoUse default destructor.
Arnaud Giersch [Sun, 20 Aug 2017 21:15:09 +0000 (23:15 +0200)]
Use default destructor.

2 years agoThese lines belong to the outer loop.
Arnaud Giersch [Sun, 20 Aug 2017 17:15:49 +0000 (19:15 +0200)]
These lines belong to the outer loop.

2 years agoDeobfuscate expression.
Arnaud Giersch [Sun, 20 Aug 2017 17:07:25 +0000 (19:07 +0200)]
Deobfuscate expression.

2 years agoHandle case when active_peers is empty.
Arnaud Giersch [Sun, 20 Aug 2017 15:52:31 +0000 (17:52 +0200)]
Handle case when active_peers is empty.

2 years agoComment unused field.
Arnaud Giersch [Sun, 20 Aug 2017 15:51:27 +0000 (17:51 +0200)]
Comment unused field.

Unused attribute is not supported by gcc in this case.

2 years agoSort storages before listing.
Arnaud Giersch [Sun, 20 Aug 2017 12:04:50 +0000 (14:04 +0200)]
Sort storages before listing.

2 years agonormalize s_type class part 3
Takishipp [Fri, 18 Aug 2017 15:11:46 +0000 (17:11 +0200)]
normalize s_type class part 3

2 years agonormalize s_type class part 2
Takishipp [Fri, 18 Aug 2017 14:41:12 +0000 (16:41 +0200)]
normalize s_type class part 2

2 years agonormalize s_type class
Takishipp [Fri, 18 Aug 2017 13:30:59 +0000 (15:30 +0200)]
normalize s_type class

2 years agomodernize three simcalls
Frederic Suter [Fri, 18 Aug 2017 08:43:43 +0000 (10:43 +0200)]
modernize three simcalls

2 years agoAdd type_stat_new to s_type class as a method
Takishipp [Wed, 16 Aug 2017 14:50:59 +0000 (16:50 +0200)]
Add type_stat_new to s_type class as a method

2 years agoAdd link_new to s_type class as a method
Takishipp [Wed, 16 Aug 2017 14:44:48 +0000 (16:44 +0200)]
Add link_new to s_type class as a method

2 years agoAdd variable_new to s_type class as method
Takishipp [Wed, 16 Aug 2017 14:28:53 +0000 (16:28 +0200)]
Add variable_new to s_type class as method

2 years agoAdd event_new to s_type class as a method
Takishipp [Wed, 16 Aug 2017 13:45:13 +0000 (15:45 +0200)]
Add event_new to s_type class as a method

2 years agoAdd type_container_new to s_type class as method
Takishipp [Wed, 16 Aug 2017 13:29:49 +0000 (15:29 +0200)]
Add type_container_new to s_type class as method

2 years agoAdd s_type_get_or_null to s_type class as a method
Takishipp [Wed, 16 Aug 2017 11:51:58 +0000 (13:51 +0200)]
Add s_type_get_or_null to s_type class as a method

2 years agoAdd a constructor to s_type class
Takishipp [Wed, 16 Aug 2017 10:06:33 +0000 (12:06 +0200)]
Add a constructor to s_type class

2 years agoMerge branch 'master' of github.com:simgrid/simgrid into s_type_cleanup
Takishipp [Wed, 16 Aug 2017 08:58:48 +0000 (10:58 +0200)]
Merge branch 'master' of github.com:simgrid/simgrid into s_type_cleanup

2 years agoFactorize s_type and value instr class
Takishipp [Wed, 16 Aug 2017 08:58:17 +0000 (10:58 +0200)]
Factorize s_type and value instr class