Augustin Degomme [Mon, 19 Apr 2021 14:06:55 +0000 (16:06 +0200)]
Group buffer leaks by origin as well.
Keep total size and min/max for each if possible, then display by largest total size.
Arnaud Giersch [Mon, 19 Apr 2021 13:55:40 +0000 (15:55 +0200)]
Plug memory leak.
Arnaud Giersch [Mon, 19 Apr 2021 08:16:14 +0000 (10:16 +0200)]
Const, once again.
Martin Quinson [Mon, 19 Apr 2021 10:54:35 +0000 (12:54 +0200)]
Doc improvement [ci-skip]
Martin Quinson [Mon, 19 Apr 2021 10:35:48 +0000 (12:35 +0200)]
Merge branch 'master' of framagit.org:simgrid/simgrid
Arnaud Giersch [Sun, 18 Apr 2021 19:25:37 +0000 (21:25 +0200)]
Finally rename smpi::Group::actor_pid() back to actor().
Arnaud Giersch [Sun, 18 Apr 2021 19:14:49 +0000 (21:14 +0200)]
Kill smpi::Group::rank(s4u::Actor*).
Arnaud Giersch [Sun, 18 Apr 2021 17:01:49 +0000 (19:01 +0200)]
Kill smpi::Group::actor(int).
Arnaud Giersch [Sun, 18 Apr 2021 14:29:22 +0000 (16:29 +0200)]
Change smpi::Group::set_mapping to take a pid.
Arnaud Giersch [Sun, 18 Apr 2021 13:25:41 +0000 (15:25 +0200)]
Add assert's to ensure consistency between the two kinds of mapping.
Arnaud Giersch [Sun, 18 Apr 2021 12:50:09 +0000 (14:50 +0200)]
Define new rank_to_pid_map_.
Arnaud Giersch [Sun, 18 Apr 2021 13:19:44 +0000 (15:19 +0200)]
Lookup for parent process (like in Group::rank(s4u::Actor*).
Arnaud Giersch [Sun, 18 Apr 2021 09:29:36 +0000 (11:29 +0200)]
In smpi::Group, 'index' is in fact a PID. Fix type and rename.
Arnaud Giersch [Sun, 18 Apr 2021 19:19:38 +0000 (21:19 +0200)]
Kill a TODO (-1 is correct for an invalid PID).
Arnaud Giersch [Sun, 18 Apr 2021 09:53:53 +0000 (11:53 +0200)]
MPI_SOURCE is a rank; src_traced should be a PID.
Arnaud Giersch [Sun, 18 Apr 2021 09:38:55 +0000 (11:38 +0200)]
Fix comment.
Arnaud Giersch [Sun, 18 Apr 2021 08:32:08 +0000 (10:32 +0200)]
Pass large parameter by const reference.
Arnaud Giersch [Sat, 17 Apr 2021 19:12:19 +0000 (21:12 +0200)]
Minor cleanups (useless stuff).
Augustin Degomme [Sun, 18 Apr 2021 10:22:44 +0000 (12:22 +0200)]
also requalify mc version of the tesh
Augustin Degomme [Sun, 18 Apr 2021 09:54:44 +0000 (11:54 +0200)]
Group leak reports by type/file/line (for handles, will see for buffer later).
And split reporting.
Arnaud Giersch [Sat, 17 Apr 2021 09:21:27 +0000 (11:21 +0200)]
Sonar polishing.
Arnaud Giersch [Sat, 17 Apr 2021 08:56:54 +0000 (10:56 +0200)]
Pointer-to-const parameters in smpi::Group.
Arnaud Giersch [Sat, 17 Apr 2021 08:52:12 +0000 (10:52 +0200)]
Reduce code duplication (and fix bug in Group::difference).
Arnaud Giersch [Fri, 16 Apr 2021 22:11:41 +0000 (00:11 +0200)]
A for-loop with 'num' modified in the body is too complex according to Sonar.
Arnaud Giersch [Fri, 16 Apr 2021 21:26:14 +0000 (23:26 +0200)]
Fix smpi::Group::intersection().
Using 'size2' for controlling the first loop was a bug (spotted by Sonar).
Arnaud Giersch [Fri, 16 Apr 2021 21:21:02 +0000 (23:21 +0200)]
Fix Group::group_union().
Included ranks from group2 were not good.
Arnaud Giersch [Fri, 16 Apr 2021 21:36:00 +0000 (23:36 +0200)]
Simplify smpi::Group::difference().
Arnaud Giersch [Fri, 16 Apr 2021 19:41:27 +0000 (21:41 +0200)]
Review smpi::Group::*excl() and smpi::Group::*incl().
Mostly cosmetic changes.
Arnaud Giersch [Fri, 16 Apr 2021 20:51:42 +0000 (22:51 +0200)]
Kill redundant member 'size_' from smpi::Group.
Arnaud Giersch [Fri, 16 Apr 2021 16:32:28 +0000 (18:32 +0200)]
Minor changes in smpi::Group.
Arnaud Giersch [Fri, 16 Apr 2021 19:26:02 +0000 (21:26 +0200)]
Remove unused option from example.
Arnaud Giersch [Fri, 16 Apr 2021 14:09:05 +0000 (16:09 +0200)]
Simplify loop searching for a bypass route.
Arnaud Giersch [Fri, 16 Apr 2021 12:59:10 +0000 (14:59 +0200)]
Prefer a do-while in this case, and rewrite without 'break'.
Arnaud Giersch [Fri, 16 Apr 2021 12:29:23 +0000 (14:29 +0200)]
Use std::find_if when looking for a matching comm.
Arnaud Giersch [Fri, 16 Apr 2021 09:29:22 +0000 (11:29 +0200)]
Replace C-style arrays and remove const_cast.
Define local class EngineWrapper to encapsulate common code.
Arnaud Giersch [Fri, 16 Apr 2021 08:59:45 +0000 (10:59 +0200)]
Use const& for std::string parameters.
Arnaud Giersch [Thu, 15 Apr 2021 21:07:15 +0000 (23:07 +0200)]
Pointer-to-const.
Arnaud Giersch [Fri, 16 Apr 2021 13:23:17 +0000 (15:23 +0200)]
Fix build with older clang.
SUTER Frederic [Fri, 16 Apr 2021 12:26:08 +0000 (14:26 +0200)]
please clang take 2
SUTER Frederic [Fri, 16 Apr 2021 12:15:08 +0000 (14:15 +0200)]
please clang
Bruno Donassolo [Fri, 16 Apr 2021 10:33:57 +0000 (12:33 +0200)]
Some code improvements.
Avoid unnecessary map lookups.
Thanks @agiersch for the review
SUTER Frederic [Fri, 16 Apr 2021 10:05:38 +0000 (12:05 +0200)]
add wrappers with scalars on the user side
SUTER Frederic [Thu, 15 Apr 2021 14:03:18 +0000 (16:03 +0200)]
simplification
SUTER Frederic [Thu, 15 Apr 2021 13:55:30 +0000 (15:55 +0200)]
cosmetics
SUTER Frederic [Tue, 13 Apr 2021 18:26:04 +0000 (20:26 +0200)]
cosmetics
Bruno Donassolo [Thu, 15 Apr 2021 13:33:43 +0000 (15:33 +0200)]
s4u::NetZone::create_router.
Export create_router to s4u so we can use in C++ platforms.
Bruno Donassolo [Thu, 15 Apr 2021 08:59:15 +0000 (10:59 +0200)]
Please sonar, just a little
Arnaud Giersch [Thu, 15 Apr 2021 07:43:35 +0000 (09:43 +0200)]
Use rule-of-three, and hope to please sonar without breaking clang13 builds.
Arnaud Giersch [Wed, 14 Apr 2021 21:45:10 +0000 (23:45 +0200)]
Revert "Delete the implicitely defined move constructor."
This reverts commit
c26d236dedf486357690800a0d5527871ef45620.
Clang 13 fails with "The specified type does not meet the requirements of
Cpp17MoveInsertable"
AFAICT, the std::deque makes a noexcept constructor impossible.
Arnaud Giersch [Wed, 14 Apr 2021 21:30:54 +0000 (23:30 +0200)]
Finally provide a noexcept move constructor.
Previous commit (
f7cf88e9b8 Delete the implicitely defined move constructor.)
was causing clang 13 to fail with: "The specified type does not meet the
requirements of Cpp17MoveInsertable".
Arnaud Giersch [Wed, 14 Apr 2021 19:53:21 +0000 (21:53 +0200)]
Use emplace_back to add a new property_set.
Sonar S6003.
Arnaud Giersch [Wed, 14 Apr 2021 19:37:50 +0000 (21:37 +0200)]
Minor Sonar smells (const, etc).
Arnaud Giersch [Wed, 14 Apr 2021 19:21:52 +0000 (21:21 +0200)]
Move a \n.
Arnaud Giersch [Wed, 14 Apr 2021 14:13:59 +0000 (16:13 +0200)]
Delete the implicitely defined move constructor.
Fix for sonar issue S5018: Move and swap operations should be "noexcept"
Arnaud Giersch [Wed, 14 Apr 2021 12:21:14 +0000 (14:21 +0200)]
Disable copy for actor::ProcessArg.
Also fix sonar issue S5018: Move and swap operations should be "noexcept"
Arnaud Giersch [Wed, 14 Apr 2021 11:22:58 +0000 (13:22 +0200)]
Delete the implicitely defined move constructor.
Fix for sonar issue S5018: Move and swap operations should be "noexcept"
Anyway, AFAICT, the implicit move constructor here does nothing more than the copy-constructor.
Arnaud Giersch [Wed, 14 Apr 2021 06:56:37 +0000 (08:56 +0200)]
Sonar requires a comment for empty functions.
Bruno Donassolo [Wed, 14 Apr 2021 15:53:28 +0000 (17:53 +0200)]
Simplify add_route methods.
Leave only one add_route method, as it was initially.
Deprecate old add_route which uses LinkImpl*, s4u is the interface we want
with user.
Bruno Donassolo [Mon, 12 Apr 2021 14:08:26 +0000 (16:08 +0200)]
Vivaldi on top of StarZone
Implement Vivaldi on top of StarZone.
This allows the easy usage of Vivaldi on C++ platforms (no need to
access specific methods from Vivaldi NetZone.
Platform creation from XML is unchanged.
Bruno Donassolo [Tue, 13 Apr 2021 18:36:23 +0000 (20:36 +0200)]
Adjust add_route to accept route between netzones
Bruno Donassolo [Tue, 13 Apr 2021 15:24:11 +0000 (17:24 +0200)]
StarZone: implement get_graph method
Add get_graph for StarZone. A top node named with the zone's name is
created to be the center of the star.
Bruno Donassolo [Fri, 9 Apr 2021 17:46:42 +0000 (19:46 +0200)]
New netzone: Star Zone
Implements a netzone following a star topology.
Components inside the Star topology are connected by default (through no
links), users can add routes using the NetZone::add_route method:
- netpoint -> nullptr(*): links used in all outgoing communications
- nullptr(*) -> netpoint: links used in all incoming communication
- netpoint -> netpoint: loopback
Duplicated links in a route inside the Star Zone are removed.
Added UTs for StarZone, some tests are disabled since they check the
xbt_assert and would stop the test execution.
Arnaud Giersch [Tue, 13 Apr 2021 15:56:08 +0000 (17:56 +0200)]
[ci-skip] Update lua tesh files with deprecation warning.
SUTER Frederic [Tue, 13 Apr 2021 15:31:00 +0000 (17:31 +0200)]
constify
SUTER Frederic [Tue, 13 Apr 2021 15:24:42 +0000 (17:24 +0200)]
this is no useless
SUTER Frederic [Tue, 13 Apr 2021 13:13:41 +0000 (15:13 +0200)]
do not call sg_platf_new_link when creating Cluster-ed Zones
SUTER Frederic [Tue, 13 Apr 2021 09:39:20 +0000 (11:39 +0200)]
improve router creation
Arnaud Giersch [Tue, 13 Apr 2021 07:13:30 +0000 (09:13 +0200)]
Deprecate Lua platform files.
Arnaud Giersch [Tue, 13 Apr 2021 06:58:53 +0000 (08:58 +0200)]
No need to duplicate variables.
Arnaud Giersch [Tue, 13 Apr 2021 06:52:28 +0000 (08:52 +0200)]
Const...
SUTER Frederic [Mon, 12 Apr 2021 21:20:00 +0000 (23:20 +0200)]
change way disks are managed in the XML parsing
Arnaud Giersch [Mon, 12 Apr 2021 21:08:40 +0000 (23:08 +0200)]
Define CommImpl::wait_for().
Arnaud Giersch [Mon, 12 Apr 2021 20:45:19 +0000 (22:45 +0200)]
Print state_ in symbolic form.
Arnaud Giersch [Mon, 12 Apr 2021 20:38:58 +0000 (22:38 +0200)]
More cosmetics around namespaces.
Arnaud Giersch [Mon, 12 Apr 2021 19:41:51 +0000 (21:41 +0200)]
Fix segfault with lua.
Arnaud Giersch [Mon, 12 Apr 2021 14:22:56 +0000 (16:22 +0200)]
Inline function.
Arnaud Giersch [Mon, 12 Apr 2021 14:20:57 +0000 (16:20 +0200)]
Define CommImp::wait_any_for().
Arnaud Giersch [Mon, 12 Apr 2021 12:59:03 +0000 (14:59 +0200)]
Cosmetics.
SUTER Frederic [Mon, 12 Apr 2021 16:23:55 +0000 (18:23 +0200)]
please clang (?) and make properties optional to create an ActorImpl
SUTER Frederic [Mon, 12 Apr 2021 15:32:48 +0000 (17:32 +0200)]
do not allocate/free properties
SUTER Frederic [Mon, 12 Apr 2021 13:54:53 +0000 (15:54 +0200)]
do not allocate/free radicals
SUTER Frederic [Mon, 12 Apr 2021 13:36:23 +0000 (15:36 +0200)]
cosmetics
SUTER Frederic [Mon, 12 Apr 2021 13:10:49 +0000 (15:10 +0200)]
modernize cabinet creation
SUTER Frederic [Mon, 12 Apr 2021 12:24:45 +0000 (14:24 +0200)]
change way vivaldi coordinates are managed internally
Arnaud Giersch [Mon, 12 Apr 2021 10:34:22 +0000 (12:34 +0200)]
Upgrade embedded catch2 (-> v2.13.5).
Arnaud Giersch [Mon, 12 Apr 2021 10:06:14 +0000 (12:06 +0200)]
Minor Sonar smells.
Arnaud Giersch [Mon, 12 Apr 2021 09:57:42 +0000 (11:57 +0200)]
Const ref for std::string parameter.
Arnaud Giersch [Mon, 12 Apr 2021 09:49:33 +0000 (11:49 +0200)]
Return const reference to vector.
Arnaud Giersch [Mon, 12 Apr 2021 09:42:30 +0000 (11:42 +0200)]
Use a reference for ExecImpl::wait_any_for()'s vector.
Arnaud Giersch [Mon, 12 Apr 2021 09:20:40 +0000 (11:20 +0200)]
Define CommImpl::test_any().
Arnaud Giersch [Mon, 12 Apr 2021 09:01:11 +0000 (11:01 +0200)]
Simcall COMM_TESTANY is not blocking either. Simplify.
Arnaud Giersch [Mon, 12 Apr 2021 08:36:00 +0000 (10:36 +0200)]
Define CommImpl::test().
Arnaud Giersch [Mon, 12 Apr 2021 08:32:34 +0000 (10:32 +0200)]
Simcall COMM_TEST is not blocking.
Arnaud Giersch [Sun, 11 Apr 2021 19:44:35 +0000 (21:44 +0200)]
Little simplification.
Arnaud Giersch [Mon, 12 Apr 2021 08:25:12 +0000 (10:25 +0200)]
Finalize current CommImpl only once.
Arnaud Giersch [Mon, 12 Apr 2021 08:18:15 +0000 (10:18 +0200)]
Homogenize debug messages across ActivityImpl's finish() methods.
Arnaud Giersch [Mon, 12 Apr 2021 07:56:48 +0000 (09:56 +0200)]
Ensure there is only one simcall waiting.
Augustin Degomme [Fri, 9 Apr 2021 17:24:33 +0000 (19:24 +0200)]
[ci-skip] we want to order by the largest first ..
Augustin Degomme [Fri, 9 Apr 2021 09:26:22 +0000 (11:26 +0200)]
try to be preemptive about 32 bits complaints
Augustin Degomme [Fri, 9 Apr 2021 01:38:21 +0000 (03:38 +0200)]
this value was actually wrong, and caught by the new buffer overflow check.
this is due to the fact that actual mpich test uses 10 times higher values, so just removing last digit was breaking the BIGDFT=4*NUM_X-1 condition