Use rule-of-three, and hope to please sonar without breaking clang13 builds.

diff --git a/examples/cpp/dht-kademlia/routing_table.hpp b/examples/cpp/dht-kademlia/routing_table.hpp
index dff5954..4746e20 100644 (file)
--- a/examples/cpp/dht-kademlia/routing_table.hpp
+++ b/examples/cpp/dht-kademlia/routing_table.hpp
@@ -19,6 +19,10 @@ public:
   std::deque<unsigned int> nodes_; // Nodes in the bucket.
   unsigned int getId() const { return id_; }
   explicit Bucket(unsigned int id) : id_(id) {}
+  // Use rule-of-three, and implicitely disable the move constructor which cannot be 'noexcept' (as required by C++ Core
+  // Guidelines), due to the std::deque member.
+  Bucket(const Bucket&) = default;
+  ~Bucket()             = default;
 };
 
 /* Node routing table */

diff --git a/src/kernel/lmm/maxmin.hpp b/src/kernel/lmm/maxmin.hpp
index 3a140f2..2ad066c 100644 (file)
--- a/src/kernel/lmm/maxmin.hpp
+++ b/src/kernel/lmm/maxmin.hpp
@@ -143,9 +143,11 @@ namespace lmm {
  */
 class XBT_PUBLIC Element {
 public:
+  // Use rule-of-three, and implicitely disable the move constructor which should be 'noexcept' according to C++ Core
+  // Guidelines.
   Element()               = default;
   Element(const Element&) = default;
-  Element(Element&& that) noexcept : Element(that) {}
+  ~Element()              = default;
 
   int get_concurrency() const;
   void decrease_concurrency();