Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
3 years agoDefine next XBT_ATTRIB_DEPRECATED macro.
Arnaud Giersch [Sun, 28 Mar 2021 15:28:56 +0000 (17:28 +0200)]
Define next XBT_ATTRIB_DEPRECATED macro.

3 years agoRemove deprecated features for next release.
Arnaud Giersch [Sun, 28 Mar 2021 13:50:57 +0000 (15:50 +0200)]
Remove deprecated features for next release.

3 years agoStart the dev of 3.28.
Arnaud Giersch [Sun, 28 Mar 2021 13:44:45 +0000 (15:44 +0200)]
Start the dev of 3.28.

3 years agoRelease SimGrid v3.27 v3.27
Martin Quinson [Mon, 29 Mar 2021 14:44:45 +0000 (16:44 +0200)]
Release SimGrid v3.27

3 years agoAvoid using && in .gitlab-ci.yml.
Arnaud Giersch [Mon, 29 Mar 2021 12:56:19 +0000 (14:56 +0200)]
Avoid using && in .gitlab-ci.yml.

It does not always stop the script as we would expect.
See https://gitlab.com/gitlab-org/gitlab-runner/-/issues/25394 for more info.

3 years agoMove xbt_modinter.h to src/include/xbt/.
Arnaud Giersch [Mon, 29 Mar 2021 11:30:47 +0000 (13:30 +0200)]
Move xbt_modinter.h to src/include/xbt/.

3 years agoTypos [noci]
Martin Quinson [Mon, 29 Mar 2021 10:28:08 +0000 (12:28 +0200)]
Typos [noci]

3 years agoadd some words about new options in smpi tuto
Augustin Degomme [Sun, 28 Mar 2021 23:36:04 +0000 (01:36 +0200)]
add some words about new options in smpi tuto

3 years agotypo [noci]
Augustin Degomme [Sun, 28 Mar 2021 15:55:04 +0000 (17:55 +0200)]
typo [noci]

3 years agocosmetics
Augustin Degomme [Sun, 28 Mar 2021 14:03:30 +0000 (16:03 +0200)]
cosmetics

3 years agoadd message when 0 bytes are allocated
Augustin Degomme [Sun, 28 Mar 2021 14:03:09 +0000 (16:03 +0200)]
add message when 0 bytes are allocated

3 years agoProposition of a NEWS entry
Martin Quinson [Sun, 28 Mar 2021 10:11:44 +0000 (12:11 +0200)]
Proposition of a NEWS entry

3 years agocosmetics
Augustin Degomme [Sun, 28 Mar 2021 01:47:16 +0000 (03:47 +0200)]
cosmetics

3 years agoalso change option name in MC-flavored tesh
Augustin Degomme [Sun, 28 Mar 2021 01:29:20 +0000 (03:29 +0200)]
also change option name in MC-flavored tesh

3 years agotrim changelog
Augustin Degomme [Sun, 28 Mar 2021 00:59:56 +0000 (01:59 +0100)]
trim changelog

3 years agodocument new options
Augustin Degomme [Sun, 28 Mar 2021 00:59:46 +0000 (01:59 +0100)]
document new options

3 years agoadd -analyze to smpirun to activate both smpi/display-timing and smpi/display-allocs...
Augustin Degomme [Sun, 28 Mar 2021 00:57:18 +0000 (01:57 +0100)]
add -analyze to smpirun to activate both smpi/display-timing and smpi/display-allocs at once

3 years agorename option,
Augustin Degomme [Sun, 28 Mar 2021 00:56:39 +0000 (01:56 +0100)]
rename option,
display-analysis was meant to display both timings and allocations, but it's just allocations.

3 years agotypo
Augustin Degomme [Sun, 28 Mar 2021 00:52:49 +0000 (01:52 +0100)]
typo

3 years agoTypos [noci]
Arnaud Giersch [Sat, 27 Mar 2021 22:43:16 +0000 (23:43 +0100)]
Typos [noci]

3 years agoAdd explaining comment.
Arnaud Giersch [Sat, 27 Mar 2021 22:38:19 +0000 (23:38 +0100)]
Add explaining comment.

3 years agoChangelog: this big fat warning is not mandated, as we don't have an example that...
Martin Quinson [Sat, 27 Mar 2021 21:20:53 +0000 (22:20 +0100)]
Changelog: this big fat warning is not mandated, as we don't have an example that fails [noci]

3 years agoReduce scope for variables.
Arnaud Giersch [Sat, 27 Mar 2021 21:01:36 +0000 (22:01 +0100)]
Reduce scope for variables.

3 years agoReplace std::random with xbt::random.
Arnaud Giersch [Sat, 27 Mar 2021 20:57:26 +0000 (21:57 +0100)]
Replace std::random with xbt::random.

3 years agoFix XbtRandom::uniform_int() when used with large range.
Arnaud Giersch [Sat, 27 Mar 2021 20:54:44 +0000 (21:54 +0100)]
Fix XbtRandom::uniform_int() when used with large range.

Add more unit tests.

3 years ago[sonar] Useless parentheses.
Arnaud Giersch [Sat, 27 Mar 2021 13:17:20 +0000 (14:17 +0100)]
[sonar] Useless parentheses.

3 years agoUse std::call_once instead of pthread_once.
Arnaud Giersch [Sat, 27 Mar 2021 09:18:21 +0000 (10:18 +0100)]
Use std::call_once instead of pthread_once.

3 years agoChangelog updates as a preparation to the next release [noci]
Martin Quinson [Sat, 27 Mar 2021 21:06:47 +0000 (22:06 +0100)]
Changelog updates as a preparation to the next release [noci]

It's overdue already.

3 years agochangelog update
Augustin Degomme [Sat, 27 Mar 2021 20:25:18 +0000 (21:25 +0100)]
changelog update

3 years agoRename github action
Augustin Degomme [Sat, 27 Mar 2021 19:04:01 +0000 (19:04 +0000)]
Rename github action
It's the name of the badge, and it was too long

3 years agoMerge branch 'master' into 'master'
Augustin Degomme [Sat, 27 Mar 2021 13:18:44 +0000 (13:18 +0000)]
Merge branch 'master' into 'master'

add ctest output to gitlab ci

See merge request simgrid/simgrid!60

3 years agoadd ctest output to gitlab ci
Augustin Degomme [Sat, 27 Mar 2021 13:18:44 +0000 (13:18 +0000)]
add ctest output to gitlab ci

3 years agocosmetics, somewhat hinted by sonar
Martin Quinson [Fri, 26 Mar 2021 23:02:04 +0000 (00:02 +0100)]
cosmetics, somewhat hinted by sonar

3 years agoMove SimcallObserver from simgrid::mc to simgrid::kernel::actor
Martin Quinson [Fri, 26 Mar 2021 22:43:37 +0000 (23:43 +0100)]
Move SimcallObserver from simgrid::mc to simgrid::kernel::actor

3 years agoMerge branch 'simcall_blocking' into 'master'
Arnaud Giersch [Fri, 26 Mar 2021 22:01:11 +0000 (22:01 +0000)]
Merge branch 'simcall_blocking' into 'master'

Fix simcall_blocking returning a value.

See merge request simgrid/simgrid!59

3 years agoMove PoC blocking_simcall.hpp from public include/ to teshsuite/.
Arnaud Giersch [Fri, 26 Mar 2021 13:55:46 +0000 (14:55 +0100)]
Move PoC blocking_simcall.hpp from public include/ to teshsuite/.

3 years agoFix simcall_blocking returning a value.
Arnaud Giersch [Fri, 26 Mar 2021 13:40:24 +0000 (14:40 +0100)]
Fix simcall_blocking returning a value.

Get the return value from observer->get_result().

3 years agoKill empty file.
Arnaud Giersch [Fri, 26 Mar 2021 14:05:10 +0000 (15:05 +0100)]
Kill empty file.

3 years agosupport MPI_CXX types.
Augustin Degomme [Fri, 26 Mar 2021 00:57:18 +0000 (01:57 +0100)]
support MPI_CXX types.
As SMPI is in C++, that's basically free ..

3 years agoA few more ChangeLog updates.
Arnaud Giersch [Thu, 25 Mar 2021 20:43:17 +0000 (21:43 +0100)]
A few more ChangeLog updates.

Includes fixing trailing whitespaces.

3 years agoChangelog update for SMPI
Augustin Degomme [Thu, 25 Mar 2021 17:06:02 +0000 (18:06 +0100)]
Changelog update for SMPI

3 years agowhy do not implement this?
SUTER Frederic [Thu, 25 Mar 2021 15:37:32 +0000 (16:37 +0100)]
why do not implement this?

3 years agouse simcalls for setters
SUTER Frederic [Thu, 25 Mar 2021 15:37:11 +0000 (16:37 +0100)]
use simcalls for setters

3 years agoUse const& for std::string parameter (sonar, again).
Arnaud Giersch [Thu, 25 Mar 2021 13:19:55 +0000 (14:19 +0100)]
Use const& for std::string parameter (sonar, again).

3 years agoFix test: java-app-bittorrent
Bruno Donassolo [Thu, 25 Mar 2021 13:56:12 +0000 (14:56 +0100)]
Fix test: java-app-bittorrent

Add a warning in Changelog, although no result has changed in our tests,
it's probably possible.

Simplify model management. As models must be added in order in the
engine, the list is already in the correct order respecting the
dependencies.

3 years agomore chaining for CPUs too
SUTER Frederic [Thu, 25 Mar 2021 09:48:51 +0000 (10:48 +0100)]
more chaining for CPUs too

3 years agoas to zone
SUTER Frederic [Thu, 25 Mar 2021 09:07:54 +0000 (10:07 +0100)]
as to zone

3 years agoCleaning and chaining around links
SUTER Frederic [Thu, 25 Mar 2021 08:42:37 +0000 (09:42 +0100)]
Cleaning and chaining around links

3 years agoUse a const reference for parameter.
Arnaud Giersch [Thu, 25 Mar 2021 09:25:14 +0000 (10:25 +0100)]
Use a const reference for parameter.

Sonar warned that std::move is never called on this rvalue reference argument.

3 years agoBetter fix for constness of argv in sg_actor_start/create.
Arnaud Giersch [Thu, 25 Mar 2021 08:56:29 +0000 (09:56 +0100)]
Better fix for constness of argv in sg_actor_start/create.

Define two variants of the functions and allow to write the examples
without cast romving const qualifier.

3 years agoMake model name constant
Martin Quinson [Thu, 25 Mar 2021 01:37:24 +0000 (02:37 +0100)]
Make model name constant

3 years agoUse the models directly, not their names
Martin Quinson [Thu, 25 Mar 2021 00:59:00 +0000 (01:59 +0100)]
Use the models directly, not their names

3 years agouse default value when none better is to be given
Martin Quinson [Thu, 25 Mar 2021 00:41:04 +0000 (01:41 +0100)]
use default value when none better is to be given

3 years agoRemove more obsolete files from the old doc
Martin Quinson [Wed, 24 Mar 2021 22:19:06 +0000 (23:19 +0100)]
Remove more obsolete files from the old doc

Also remove the most obsolete parts of tools/cmake/Documentation.cmake
We should integrate docs/Build.sh into cmake, at some point.

3 years agoMerge branch 'models_type_rework_part2_try2' into 'master'
Martin Quinson [Thu, 25 Mar 2021 00:11:09 +0000 (00:11 +0000)]
Merge branch 'models_type_rework_part2_try2' into 'master'

No more types for models.

See merge request simgrid/simgrid!58

3 years agoRemove a level of constness for argv parameter of sg_actor_start/create.
Arnaud Giersch [Wed, 24 Mar 2021 21:12:47 +0000 (22:12 +0100)]
Remove a level of constness for argv parameter of sg_actor_start/create.

Aligns with the signature of main(), and allows to write without cast:

    int main(int argc, char *argv[]) {
        sg_actor_start(NULL, NULL, argc, argv);
        ...

The main drawback is that we have to add an explicit cast in our constrained
examples.

3 years agoNot sure if these files are still used, but keep them up-to-date.
Arnaud Giersch [Wed, 24 Mar 2021 09:18:27 +0000 (10:18 +0100)]
Not sure if these files are still used, but keep them up-to-date.

3 years agoRestore xbt_dynar_to_array, which is still used by starpu.
Arnaud Giersch [Wed, 24 Mar 2021 08:45:15 +0000 (09:45 +0100)]
Restore xbt_dynar_to_array, which is still used by starpu.

But mark it as deprecated.

3 years agoSuperfluous global variable.
Arnaud Giersch [Tue, 23 Mar 2021 21:56:34 +0000 (22:56 +0100)]
Superfluous global variable.

3 years agoKill now unused xbt_str_split_quoted(), xbt_str_split_quoted_in_place().
Arnaud Giersch [Tue, 23 Mar 2021 15:22:24 +0000 (16:22 +0100)]
Kill now unused xbt_str_split_quoted(), xbt_str_split_quoted_in_place().

3 years agoUse boost::tokenizer.
Arnaud Giersch [Tue, 23 Mar 2021 14:21:22 +0000 (15:21 +0100)]
Use boost::tokenizer.

It's already used in other parts of the code.

3 years agoKill unused dynar functions.
Arnaud Giersch [Tue, 23 Mar 2021 13:31:08 +0000 (14:31 +0100)]
Kill unused dynar functions.

3 years agoUse C++ functions to parse file.
Arnaud Giersch [Tue, 23 Mar 2021 13:11:00 +0000 (14:11 +0100)]
Use C++ functions to parse file.

3 years agoNo more types for models.
Bruno Donassolo [Tue, 23 Mar 2021 18:04:35 +0000 (19:04 +0100)]
No more types for models.

Remove the concept of type for a model (CPU, VM, NETWORK, etc).
Explicitly declare the dependencies between models when adding them to
the engine.

Internally, they are organized in a ordered list, respecting the
dependencies described by the user.

Changes in APIs:
s4u_Engine.hpp:
- Delete get_model_list(simgrid::kernel::resource::Model::Type type)
- Modify add_model(std::shared_ptr<simgrid::kernel::resource::Model> model, std::vector<std::string>&& dep_models = {}): added list of dependencies

Model.hpp:
- set_name(), get_name(): add methods to associate a name to the model

3 years ago[sonar] Pass large object by reference to const.
Arnaud Giersch [Tue, 23 Mar 2021 12:39:05 +0000 (13:39 +0100)]
[sonar] Pass large object by reference to const.

3 years ago[sonar] Make parameter a pointer-to-const.
Arnaud Giersch [Tue, 23 Mar 2021 12:36:57 +0000 (13:36 +0100)]
[sonar] Make parameter a pointer-to-const.

3 years ago[sonar] Inheriting constructors should be used.
Arnaud Giersch [Tue, 23 Mar 2021 12:33:41 +0000 (13:33 +0100)]
[sonar] Inheriting constructors should be used.

3 years agoBlank lines.
Arnaud Giersch [Mon, 22 Mar 2021 19:47:13 +0000 (20:47 +0100)]
Blank lines.

3 years agoKill "FIXME" comment.
Arnaud Giersch [Mon, 22 Mar 2021 19:46:33 +0000 (20:46 +0100)]
Kill "FIXME" comment.

3 years agoHumpf, time to sleep, obviously
Martin Quinson [Tue, 23 Mar 2021 00:47:04 +0000 (01:47 +0100)]
Humpf, time to sleep, obviously

3 years agoForbid to modify a sealed netzone
Martin Quinson [Tue, 23 Mar 2021 00:41:23 +0000 (01:41 +0100)]
Forbid to modify a sealed netzone

3 years agoFix make distcheck
Martin Quinson [Mon, 22 Mar 2021 23:32:56 +0000 (00:32 +0100)]
Fix make distcheck

3 years agoSanitize how tracefiles are handled
Martin Quinson [Mon, 22 Mar 2021 22:48:16 +0000 (23:48 +0100)]
Sanitize how tracefiles are handled

In particular, SMPI was always providing a trace file per actor, even
when only one file was provided, with the content for all actors. That
was a waste of memory and processing.

But the worst was that the same file was opened N times, limiting this
solution to 1024 ranks on linux and 256 on Mac OSX. We could have
asked the users to increase the limit of file descriptors per process
to overcome this limitation.

Hopefuly with this change, the same file will be opened once only,
removing this limit all together.

Fixes https://framagit.org/simgrid/simgrid/-/issues/62

This cleanup also impacts S4U code, that cannot access the
simgrid::xbt::action_fs global anymore to open the shared file itself,
but must use xbt_replay_set_tracefile() for that.

3 years agoNetZone: father to parent and more accessors
SUTER Frederic [Mon, 22 Mar 2021 12:58:24 +0000 (13:58 +0100)]
NetZone: father to parent and more accessors

3 years agotrimming zones
SUTER Frederic [Fri, 19 Mar 2021 10:04:26 +0000 (11:04 +0100)]
trimming zones

3 years agoHandle simcall result through mc::SimcallObserver.
Arnaud Giersch [Mon, 22 Mar 2021 12:29:48 +0000 (13:29 +0100)]
Handle simcall result through mc::SimcallObserver.

Get rid of simix::(un)marshal.

3 years agoReduce scope for variables.
Arnaud Giersch [Mon, 22 Mar 2021 10:08:56 +0000 (11:08 +0100)]
Reduce scope for variables.

3 years agoActivityImpl::register_simcall does not need to be 'virtual'.
Arnaud Giersch [Sat, 20 Mar 2021 20:28:40 +0000 (21:28 +0100)]
ActivityImpl::register_simcall does not need to be 'virtual'.

3 years agoFactor un-registration of simcall.
Arnaud Giersch [Sat, 20 Mar 2021 17:45:38 +0000 (18:45 +0100)]
Factor un-registration of simcall.

3 years agoMake SIMIX_comm_copy_data_callback a member of CommImpl.
Arnaud Giersch [Fri, 19 Mar 2021 23:03:38 +0000 (00:03 +0100)]
Make SIMIX_comm_copy_data_callback a member of CommImpl.

3 years agoMake fields private.
Arnaud Giersch [Fri, 19 Mar 2021 23:00:58 +0000 (00:00 +0100)]
Make fields private.

3 years agoCosmetics (redundant version number).
Arnaud Giersch [Fri, 19 Mar 2021 22:58:27 +0000 (23:58 +0100)]
Cosmetics (redundant version number).

3 years agoThis is the index, we want the rank for the underlying iprobe.
Augustin Degomme [Sun, 21 Mar 2021 00:22:27 +0000 (01:22 +0100)]
This is the index, we want the rank for the underlying iprobe.

3 years agoextraneous chars
Augustin Degomme [Sat, 20 Mar 2021 23:09:01 +0000 (00:09 +0100)]
extraneous chars

3 years agostatus can actually be MPI_STATUS_IGNORE
Augustin Degomme [Sat, 20 Mar 2021 23:08:22 +0000 (00:08 +0100)]
status can actually be MPI_STATUS_IGNORE

3 years agoAdd ModelChecker::finalize_app(), but don't use it as it don't work yet
Martin Quinson [Sat, 20 Mar 2021 21:54:34 +0000 (22:54 +0100)]
Add ModelChecker::finalize_app(), but don't use it as it don't work yet

3 years agosome symbol renamings to make MC easier to understand (to me)
Martin Quinson [Sat, 20 Mar 2021 21:45:14 +0000 (22:45 +0100)]
some symbol renamings to make MC easier to understand (to me)

3 years ago.mailmap
Arnaud Giersch [Fri, 19 Mar 2021 14:48:01 +0000 (15:48 +0100)]
.mailmap

3 years agoMake Time::date const; kill useless getter.
Arnaud Giersch [Fri, 19 Mar 2021 14:03:24 +0000 (15:03 +0100)]
Make Time::date const; kill useless getter.

3 years agoMake fields private; define getters.
Arnaud Giersch [Fri, 19 Mar 2021 13:48:14 +0000 (14:48 +0100)]
Make fields private; define getters.

3 years agoMake Datatype::contents_ a private std::unique_ptr.
Arnaud Giersch [Fri, 19 Mar 2021 13:14:47 +0000 (14:14 +0100)]
Make Datatype::contents_ a private std::unique_ptr.

3 years agoDon't mix public and private fields (sonar).
Arnaud Giersch [Fri, 19 Mar 2021 12:27:31 +0000 (13:27 +0100)]
Don't mix public and private fields (sonar).

3 years agoFactorize handling of asynchronous receives.
Arnaud Giersch [Fri, 19 Mar 2021 10:35:38 +0000 (11:35 +0100)]
Factorize handling of asynchronous receives.

Apply the same changes to both the C and C++ examples.

3 years agoUnnecessary 'else'.
Arnaud Giersch [Fri, 19 Mar 2021 10:08:35 +0000 (11:08 +0100)]
Unnecessary 'else'.

3 years agoMake cast explicit.
Arnaud Giersch [Fri, 19 Mar 2021 09:36:36 +0000 (10:36 +0100)]
Make cast explicit.

3 years agoReduce scope for variables.
Arnaud Giersch [Fri, 19 Mar 2021 09:34:59 +0000 (10:34 +0100)]
Reduce scope for variables.

3 years agoreally set link latency for ns3
SUTER Frederic [Fri, 19 Mar 2021 08:48:27 +0000 (09:48 +0100)]
really set link latency for ns3

3 years agoprivatize fields of ClusterZone + more explicit methods
SUTER Frederic [Thu, 18 Mar 2021 18:26:03 +0000 (19:26 +0100)]
privatize fields of ClusterZone + more explicit methods

3 years agoadd tesh file to dist
Augustin Degomme [Fri, 19 Mar 2021 00:35:36 +0000 (01:35 +0100)]
add tesh file to dist

3 years agoFix clang builds
Martin Quinson [Fri, 19 Mar 2021 00:08:04 +0000 (01:08 +0100)]
Fix clang builds