Use a const reference for parameter.

Sonar warned that std::move is never called on this rvalue reference argument.

diff --git a/include/simgrid/s4u/Engine.hpp b/include/simgrid/s4u/Engine.hpp
index 25f87a0..883aa08 100644 (file)
--- a/include/simgrid/s4u/Engine.hpp
+++ b/include/simgrid/s4u/Engine.hpp
@@ -137,7 +137,7 @@ public:
    * @param list  List of dependencies for this model (optional)
    */
   void add_model(std::shared_ptr<simgrid::kernel::resource::Model> model,
-                 std::vector<kernel::resource::Model*>&& dependencies = {});
+                 const std::vector<kernel::resource::Model*>& dependencies = {});
 
   /** @brief Get list of all models managed by this engine */
   const std::vector<simgrid::kernel::resource::Model*>& get_all_models() const;

diff --git a/src/kernel/EngineImpl.cpp b/src/kernel/EngineImpl.cpp
index 87e4ecc..9fba6da 100644 (file)
--- a/src/kernel/EngineImpl.cpp
+++ b/src/kernel/EngineImpl.cpp
@@ -53,7 +53,7 @@ void EngineImpl::register_default(const actor::ActorCodeFactory& code)
   default_function = code;
 }
 
-void EngineImpl::add_model(std::shared_ptr<resource::Model> model, std::vector<resource::Model*>&& dependencies)
+void EngineImpl::add_model(std::shared_ptr<resource::Model> model, const std::vector<resource::Model*>& dependencies)
 {
   auto model_name = model->get_name();
   xbt_assert(models_prio_.find(model_name) == models_prio_.end(),

diff --git a/src/kernel/EngineImpl.hpp b/src/kernel/EngineImpl.hpp
index 04436a4..0a592de 100644 (file)
--- a/src/kernel/EngineImpl.hpp
+++ b/src/kernel/EngineImpl.hpp
@@ -52,7 +52,7 @@ public:
    * @param list  List of dependencies for this model
    */
   void add_model(std::shared_ptr<simgrid::kernel::resource::Model> model,
-                 std::vector<resource::Model*>&& dep_models = {});
+                 const std::vector<resource::Model*>& dep_models = {});
 
   /** @brief Get list of all models managed by this engine */
   const std::vector<resource::Model*>& get_all_models() const { return models_; }

diff --git a/src/s4u/s4u_Engine.cpp b/src/s4u/s4u_Engine.cpp
index 4c07ea4..ba1b583 100644 (file)
--- a/src/s4u/s4u_Engine.cpp
+++ b/src/s4u/s4u_Engine.cpp
@@ -74,11 +74,9 @@ double Engine::get_clock()
 }
 
 void Engine::add_model(std::shared_ptr<kernel::resource::Model> model,
-                       std::vector<kernel::resource::Model*>&& dependencies)
+                       const std::vector<kernel::resource::Model*>& dependencies)
 {
-  simgrid::kernel::actor::simcall([this, &model, &dependencies] {
-    pimpl->add_model(std::move(model), std::forward<decltype(dependencies)>(dependencies));
-  });
+  simgrid::kernel::actor::simcall([this, &model, &dependencies] { pimpl->add_model(std::move(model), dependencies); });
 }
 
 const std::vector<simgrid::kernel::resource::Model*>& Engine::get_all_models() const