another round for sonar

diff --git a/examples/java/app/pingpong/Main.java b/examples/java/app/pingpong/Main.java
index baa07d8..8e56aed 100644 (file)
--- a/examples/java/app/pingpong/Main.java
+++ b/examples/java/app/pingpong/Main.java
@@ -10,10 +10,11 @@ import org.simgrid.msg.HostNotFoundException;
 import org.simgrid.msg.Msg;
  
 class Main {
 import org.simgrid.msg.Msg;
  
 class Main {

+  protected static final int TASK_COUNT = 3;
+       

   private Main() {
     throw new IllegalAccessError("Utility class");
   }
   private Main() {
     throw new IllegalAccessError("Utility class");
   }

-  protected static final int TASK_COUNT = 3;

 
   public static void main(String[] args) throws HostNotFoundException {
     Msg.init(args);
 
   public static void main(String[] args) throws HostNotFoundException {
     Msg.init(args);

diff --git a/examples/java/cloud/migration/Test.java b/examples/java/cloud/migration/Test.java
index d57582d..df9a19f 100644 (file)
--- a/examples/java/cloud/migration/Test.java
+++ b/examples/java/cloud/migration/Test.java
@@ -78,7 +78,6 @@ public class Test extends Process{
       tmp.setLoad(vmSrcLoad[i-1]);
     }
 
       tmp.setLoad(vmSrcLoad[i-1]);
     }
 

-    int collocatedDst = 6;

     int[] vmDstLoad = {
         0,
         40,
     int[] vmDstLoad = {
         0,
         40,

diff --git a/src/smpi/smpi_process.hpp b/src/smpi/smpi_process.hpp
index 9294546..0d9a73b 100644 (file)
--- a/src/smpi/smpi_process.hpp
+++ b/src/smpi/smpi_process.hpp
@@ -43,7 +43,7 @@ class Process {
     papi_counter_t papi_counter_data_;
 #endif
   public:
     papi_counter_t papi_counter_data_;
 #endif
   public:

-    Process(int index);
+    explicit Process(int index);

     void destroy();
     void set_data(int index, int *argc, char ***argv);
     void finalize();
     void destroy();
     void set_data(int index, int *argc, char ***argv);
     void finalize();


@@ -60,10 +60,10 @@ class Process {
     smx_mailbox_t mailbox();
     smx_mailbox_t mailbox_small();
     xbt_mutex_t mailboxes_mutex();
     smx_mailbox_t mailbox();
     smx_mailbox_t mailbox_small();
     xbt_mutex_t mailboxes_mutex();

-    #if HAVE_PAPI
+#if HAVE_PAPI

     int papi_event_set(void);
     papi_counter_t& papi_counters(void);
     int papi_event_set(void);
     papi_counter_t& papi_counters(void);

-    #endif
+#endif

     xbt_os_timer_t timer();
     void simulated_start();
     double simulated_elapsed();
     xbt_os_timer_t timer();
     void simulated_start();
     double simulated_elapsed();