Please static checkers.

diff --git a/examples/platforms/supernode.py b/examples/platforms/supernode.py
index b18d2a1..7270da8 100755 (executable)
--- a/examples/platforms/supernode.py
+++ b/examples/platforms/supernode.py
@@ -33,7 +33,7 @@ except ImportError:
 def run_command(cmd):
     print(cmd)
     proc = subprocess.Popen(cmd.split(), stdout=subprocess.PIPE, stderr=subprocess.PIPE)
-    stdout, stderr = proc.communicate()
+    _stdout, stderr = proc.communicate()
     if proc.returncode != 0:
         sys.exit(f'Command failed:\n{stderr.decode()}')
 
@@ -52,14 +52,14 @@ def merge_updown(graph):
     '''
     Merge all the UP and DOWN links.
     '''
-    H = graph.copy()
+    graph2 = graph.copy()
     downlinks = [v for v in graph if 'DOWN' in v]
     mapping = {}
     for down in downlinks:
         up = down.replace('DOWN', 'UP')
-        H = nx.contracted_nodes(H, down, up)
+        graph2 = nx.contracted_nodes(graph2, down, up)
         mapping[down] = down.replace('_DOWN', '')
-    return nx.relabel_nodes(H, mapping)
+    return nx.relabel_nodes(graph2, mapping)
 
 
 def contract_links(graph):
@@ -67,7 +67,6 @@ def contract_links(graph):
     Remove all the 'link' vertices from the graph to directly connect the nodes.
     Note: it assumes that link vertices have the "link" string in their name.
     '''
-    H = graph.copy()
     links = [v for v in graph if 'link' in v]
     new_edges = []
     for v in links:
@@ -92,7 +91,9 @@ def load_graph(platform_csv, simplify_graph):
     return graph
 
 
-def plot_graph(graph, label=False, groups=[]):
+def plot_graph(graph, label=False, groups=None):
+    if groups is None:
+        groups = []
     # First, we compute the graph layout, i.e. the position of the nodes.
     # The neato algorithm from graphviz is nicer, but this is an extra-dependency.
     # The spring_layout is also not too bad.
@@ -115,7 +116,7 @@ def plot_graph(graph, label=False, groups=[]):
     nx.draw_networkx_edges(graph, pos, alpha=0.3)
     if label:
         nx.draw_networkx_labels(graph, pos)
-    plt.legend(scatterpoints = 1)
+    plt.legend(scatterpoints=1)
 
 
 def generate_svg(platform_csv, output_file, simplify_graph):
@@ -125,7 +126,7 @@ def generate_svg(platform_csv, output_file, simplify_graph):
     print(f'Generated file {output_file}')
 
 
-if __name__ == '__main__':
+def main():
     parser = argparse.ArgumentParser(description='Visualization of topologies for SimGrid C++ platforms')
     parser.add_argument('input', type=str, help='SimGrid C++ platform file name (input)')
     parser.add_argument('output', type=str, help='File name of the output image')
@@ -145,3 +146,7 @@ if __name__ == '__main__':
         compile_platform(platform_cpp, platform_so)
         dump_csv(platform_so, platform_csv)
         generate_svg(platform_csv, args.output, args.simplify)
+
+
+if __name__ == '__main__':
+    main()

diff --git a/teshsuite/s4u/comm-fault-scenarios/comm-fault-scenarios.cpp b/teshsuite/s4u/comm-fault-scenarios/comm-fault-scenarios.cpp
index 0b896cc..6f674fa 100644 (file)
--- a/teshsuite/s4u/comm-fault-scenarios/comm-fault-scenarios.cpp
+++ b/teshsuite/s4u/comm-fault-scenarios/comm-fault-scenarios.cpp
@@ -117,7 +117,7 @@ class SendAgent {
   const MBoxes& mbox_;
   const ScenarioContext& ctx_;
 
-  sg4::CommPtr do_put(CommType type, double& send_value)
+  sg4::CommPtr do_put(CommType type, double& send_value) const
   {
     switch (type) {
       case CommType::EAGER_SYNC:
@@ -145,7 +145,7 @@ class SendAgent {
     DIE_IMPOSSIBLE;
   }
 
-  void send_message(const Scenario& s)
+  void send_message(const Scenario& s) const
   {
     std::string scenario_string = to_string(s);
     XBT_DEBUG("Will try: %s", scenario_string.c_str());
@@ -220,7 +220,7 @@ public:
   {
   }
 
-  void operator()()
+  void operator()() const
   {
     run_++;
     XBT_DEBUG("Host %i starts run %i and scenario %zu.", id_, run_, scenario_);
@@ -352,7 +352,7 @@ public:
       : id_(id), other_host_(other_host), mbox_(mbox), ctx_(ctx)
   {
   }
-  void operator()()
+  void operator()() const
   {
     run_++;
     XBT_DEBUG("Host %i starts run %i and scenario %zu.", id_, run_, scenario_);