pass large objects by const ref to please sonar

diff --git a/include/simgrid/s4u/Engine.hpp b/include/simgrid/s4u/Engine.hpp
index b1405ca..b4259fd 100644 (file)
--- a/include/simgrid/s4u/Engine.hpp
+++ b/include/simgrid/s4u/Engine.hpp
@@ -165,7 +165,7 @@ public:
   void set_config(const std::string& name, int value);
   void set_config(const std::string& name, bool value);
   void set_config(const std::string& name, double value);
-  void set_config(const std::string& name, std::string value);
+  void set_config(const std::string& name, const std::string& value);
 
   /** Callback fired when the platform is created (ie, the xml file parsed),
    * right before the actual simulation starts. */

diff --git a/src/s4u/s4u_Engine.cpp b/src/s4u/s4u_Engine.cpp
index 2c486a0..f21bdbf 100644 (file)
--- a/src/s4u/s4u_Engine.cpp
+++ b/src/s4u/s4u_Engine.cpp
@@ -421,7 +421,7 @@ void Engine::set_config(const std::string& name, bool value)
 {
   config::set_value(name.c_str(), value);
 }
-void Engine::set_config(const std::string& name, std::string value)
+void Engine::set_config(const std::string& name, const std::string& value)
 {
   config::set_value(name.c_str(), value);
 }