Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
Remove declarations for never used signal slots.
authorArnaud Giersch <arnaud.giersch@univ-fcomte.fr>
Fri, 15 Mar 2019 19:58:53 +0000 (20:58 +0100)
committerArnaud Giersch <arnaud.giersch@univ-fcomte.fr>
Sat, 16 Mar 2019 14:59:15 +0000 (15:59 +0100)
Either not defined, or simply not used.

src/plugins/vm/VirtualMachineImpl.cpp
src/plugins/vm/VirtualMachineImpl.hpp
src/surf/StorageImpl.hpp
src/surf/cpu_interface.hpp

index 3098d59..8179ece 100644 (file)
@@ -25,7 +25,7 @@ namespace vm {
  *************/
 simgrid::xbt::signal<void(VirtualMachineImpl*)> VirtualMachineImpl::on_creation;
 simgrid::xbt::signal<void(VirtualMachineImpl*)> VirtualMachineImpl::on_destruction;
  *************/
 simgrid::xbt::signal<void(VirtualMachineImpl*)> VirtualMachineImpl::on_creation;
 simgrid::xbt::signal<void(VirtualMachineImpl*)> VirtualMachineImpl::on_destruction;
-simgrid::xbt::signal<void(VirtualMachineImpl*)> VirtualMachineImpl::on_state_change;
+
 /*********
  * Model *
  *********/
 /*********
  * Model *
  *********/
index 2e2bce5..e501789 100644 (file)
@@ -35,8 +35,6 @@ public:
   static xbt::signal<void(simgrid::vm::VirtualMachineImpl*)> on_creation;
   /** @brief Callbacks fired after VM destruction. Signature: `void(VirtualMachineImpl*)` */
   static xbt::signal<void(simgrid::vm::VirtualMachineImpl*)> on_destruction;
   static xbt::signal<void(simgrid::vm::VirtualMachineImpl*)> on_creation;
   /** @brief Callbacks fired after VM destruction. Signature: `void(VirtualMachineImpl*)` */
   static xbt::signal<void(simgrid::vm::VirtualMachineImpl*)> on_destruction;
-  /** @brief Callbacks after VM State changes. Signature: `void(VirtualMachineImpl*)` */
-  static xbt::signal<void(simgrid::vm::VirtualMachineImpl*)> on_state_change;
 
   virtual void suspend(kernel::actor::ActorImpl* issuer);
   virtual void resume();
 
   virtual void suspend(kernel::actor::ActorImpl* issuer);
   virtual void resume();
index 70d8e4b..99ef007 100644 (file)
@@ -34,18 +34,6 @@ class StorageAction;
 /** @ingroup SURF_storage_interface
  * @brief The possible type of action for the storage component
  */
 /** @ingroup SURF_storage_interface
  * @brief The possible type of action for the storage component
  */
-/*************
- * Callbacks *
- *************/
-
-/** @ingroup SURF_callbacks
- * @brief Callbacks handler which emit the callbacks after StorageAction State changed *
- * @details Callback functions have the following signature: `void(StorageAction *action,
- * simgrid::kernel::resource::Action::State old, simgrid::kernel::resource::Action::State current)`
- */
-XBT_PUBLIC_DATA
-simgrid::xbt::signal<void(StorageAction*, kernel::resource::Action::State, kernel::resource::Action::State)>
-    on_state_change;
 
 /*********
  * Model *
 
 /*********
  * Model *
@@ -135,6 +123,11 @@ private:
  */
 class StorageAction : public Action {
 public:
  */
 class StorageAction : public Action {
 public:
+  /**
+   * @brief Callbacks handler which emit the callbacks after StorageAction State changed *
+   * @details Callback functions have the following signature: `void(StorageAction& action,
+   * simgrid::kernel::resource::Action::State old, simgrid::kernel::resource::Action::State current)`
+   */
   static xbt::signal<void(StorageAction*, Action::State, Action::State)> on_state_change;
 
   /**
   static xbt::signal<void(StorageAction*, Action::State, Action::State)> on_state_change;
 
   /**
index 93bc683..cdecf0e 100644 (file)
@@ -169,10 +169,6 @@ public:
    *  Signature: `void(CpuAction *action, simgrid::kernel::resource::Action::State previous)`
    */
   static simgrid::xbt::signal<void(simgrid::surf::CpuAction*, simgrid::kernel::resource::Action::State)> on_state_change;
    *  Signature: `void(CpuAction *action, simgrid::kernel::resource::Action::State previous)`
    */
   static simgrid::xbt::signal<void(simgrid::surf::CpuAction*, simgrid::kernel::resource::Action::State)> on_state_change;
-  /** @brief Signal emitted when the action share changes (amount of flops it gets)
-   *  Signature: `void(CpuAction *action)`
-   */
-  static simgrid::xbt::signal<void(simgrid::surf::CpuAction*)> on_share_change;
 
   CpuAction(simgrid::kernel::resource::Model * model, double cost, bool failed) : Action(model, cost, failed) {}
   CpuAction(simgrid::kernel::resource::Model * model, double cost, bool failed, kernel::lmm::Variable* var)
 
   CpuAction(simgrid::kernel::resource::Model * model, double cost, bool failed) : Action(model, cost, failed) {}
   CpuAction(simgrid::kernel::resource::Model * model, double cost, bool failed, kernel::lmm::Variable* var)