Sonar: make overridden methods virtual.

diff --git a/src/smpi/include/smpi_comm.hpp b/src/smpi/include/smpi_comm.hpp
index ed621f1..86f00b2 100644 (file)
--- a/src/smpi/include/smpi_comm.hpp
+++ b/src/smpi/include/smpi_comm.hpp
@@ -58,7 +58,7 @@ class Comm : public F2C, public Keyval{
     static void destroy(MPI_Comm comm);
     void init_smp();
 
     static void destroy(MPI_Comm comm);
     void init_smp();
 

-    int add_f();
+    int add_f() override;

     static void free_f(int id);
     static Comm* f2c(int);
 
     static void free_f(int id);
     static Comm* f2c(int);
 

diff --git a/src/smpi/include/smpi_f2c.hpp b/src/smpi/include/smpi_f2c.hpp
index 207c699..03d8908 100644 (file)
--- a/src/smpi/include/smpi_f2c.hpp
+++ b/src/smpi/include/smpi_f2c.hpp
@@ -33,10 +33,12 @@ class F2C {
     static void delete_lookup();
     static std::unordered_map<std::string, F2C*>* lookup();
 
     static void delete_lookup();
     static std::unordered_map<std::string, F2C*>* lookup();
 

+    virtual ~F2C() = default;
+

     //Override these to handle specific values.
     //Override these to handle specific values.

-    int add_f();
+    virtual int add_f();

     static void free_f(int id);
     static void free_f(int id);

-    int c2f();
+    virtual int c2f();

 
     // This method should be overridden in all subclasses to avoid casting the result when calling it.
     // For the default one, the MPI_*_NULL returned is assumed to be NULL.
 
     // This method should be overridden in all subclasses to avoid casting the result when calling it.
     // For the default one, the MPI_*_NULL returned is assumed to be NULL.

diff --git a/src/smpi/include/smpi_request.hpp b/src/smpi/include/smpi_request.hpp
index 5a11b2d..f6c69ac 100644 (file)
--- a/src/smpi/include/smpi_request.hpp
+++ b/src/smpi/include/smpi_request.hpp
@@ -91,7 +91,7 @@ class Request : public F2C {
     static int match_send(void* a, void* b, simgrid::kernel::activity::CommImpl* ignored);
     static int match_recv(void* a, void* b, simgrid::kernel::activity::CommImpl* ignored);
 
     static int match_send(void* a, void* b, simgrid::kernel::activity::CommImpl* ignored);
     static int match_recv(void* a, void* b, simgrid::kernel::activity::CommImpl* ignored);
 

-    int add_f();
+    int add_f() override;

     static void free_f(int id);
     static Request* f2c(int);
 
     static void free_f(int id);
     static Request* f2c(int);