smpi_bench_end();
if (comm == MPI_COMM_NULL) {
retval = MPI_ERR_COMM;
- } else if (not datatype->is_valid()) {
- retval = MPI_ERR_ARG;
- } else if(request == nullptr){
+ } else if (datatype == MPI_DATATYPE_NULL || not datatype->is_valid()) {
+ retval = MPI_ERR_TYPE;
+ } else if (count < 0){
+ retval = MPI_ERR_COUNT;
+ } else if (root < 0 || root >= comm->size()){
+ retval = MPI_ERR_ROOT;
+ } else if (request == nullptr){
retval = MPI_ERR_ARG;
} else {
int rank = simgrid::s4u::this_actor::get_pid();
retval = MPI_ERR_TYPE;
} else if ((( sendbuf != MPI_IN_PLACE) && (sendcount <0)) || ((comm->rank() == root) && (recvcount <0))){
retval = MPI_ERR_COUNT;
+ } else if (root < 0 || root >= comm->size()){
+ retval = MPI_ERR_ROOT;
} else if (request == nullptr){
retval = MPI_ERR_ARG;
} else {
retval = MPI_ERR_COUNT;
} else if ((comm->rank() == root) && (recvcounts == nullptr || displs == nullptr)) {
retval = MPI_ERR_ARG;
+ } else if (root < 0 || root >= comm->size()){
+ retval = MPI_ERR_ROOT;
} else if (request == nullptr){
retval = MPI_ERR_ARG;
} else {
if (comm == MPI_COMM_NULL) {
retval = MPI_ERR_COMM;
- } else if (((comm->rank() == root) && (not sendtype->is_valid())) ||
- ((recvbuf != MPI_IN_PLACE) && (not recvtype->is_valid()))) {
+ } else if (((comm->rank() == root) && (sendtype == MPI_DATATYPE_NULL || not sendtype->is_valid())) ||
+ ((recvbuf != MPI_IN_PLACE) && (recvtype == MPI_DATATYPE_NULL || not recvtype->is_valid()))) {
retval = MPI_ERR_TYPE;
+ } else if (((comm->rank() == root) && (sendcount < 0)) ||
+ ((recvbuf != MPI_IN_PLACE) && (recvcount < 0))) {
+ retval = MPI_ERR_COUNT;
} else if ((sendbuf == recvbuf) ||
((comm->rank()==root) && sendcount>0 && (sendbuf == nullptr))){
retval = MPI_ERR_BUFFER;
- }else if (request == nullptr){
+ } else if (root < 0 || root >= comm->size()){
+ retval = MPI_ERR_ROOT;
+ } else if (request == nullptr){
retval = MPI_ERR_ARG;
} else {
retval = MPI_ERR_TYPE;
} else if (request == nullptr){
retval = MPI_ERR_ARG;
+ } else if (recvbuf != MPI_IN_PLACE && recvcount < 0){
+ retval = MPI_ERR_COUNT;
+ } else if (root < 0 || root >= comm->size()){
+ retval = MPI_ERR_ROOT;
} else {
if (recvbuf == MPI_IN_PLACE) {
recvtype = sendtype;
+ if(sendcounts[comm->rank()]<0)
+ return MPI_ERR_COUNT;
recvcount = sendcounts[comm->rank()];
}
int rank = simgrid::s4u::this_actor::get_pid();
std::vector<int>* trace_sendcounts = new std::vector<int>;
if (comm->rank() == root) {
- for (int i = 0; i < comm->size(); i++) // copy data to avoid bad free
+ for (int i = 0; i < comm->size(); i++){ // copy data to avoid bad free
trace_sendcounts->push_back(sendcounts[i] * dt_size_send);
+ if(sendcounts[i]<0)
+ return MPI_ERR_COUNT;
+ }
}
TRACE_smpi_comm_in(rank, request==MPI_REQUEST_IGNORED?"PMPI_Scatterv":"PMPI_Iscatterv",
if (comm == MPI_COMM_NULL) {
retval = MPI_ERR_COMM;
- } else if (not datatype->is_valid() || op == MPI_OP_NULL) {
- retval = MPI_ERR_ARG;
+ } else if (datatype == MPI_DATATYPE_NULL || not datatype->is_valid()){
+ retval = MPI_ERR_TYPE;
+ } else if (op == MPI_OP_NULL) {
+ retval = MPI_ERR_OP;
} else if (request == nullptr){
retval = MPI_ERR_ARG;
+ } else if (root < 0 || root >= comm->size()){
+ retval = MPI_ERR_ROOT;
+ } else if (count < 0){
+ retval = MPI_ERR_COUNT;
} else {
int rank = simgrid::s4u::this_actor::get_pid();
int retval = 0;
smpi_bench_end();
- if (not datatype->is_valid() || op == MPI_OP_NULL) {
- retval = MPI_ERR_ARG;
- } else {
+ if (datatype == MPI_DATATYPE_NULL || not datatype->is_valid()){
+ retval = MPI_ERR_TYPE;
+ } else if (op == MPI_OP_NULL) {
+ retval = MPI_ERR_OP;
+ } else if (count < 0){
+ retval = MPI_ERR_COUNT;
+ } else {
op->apply(inbuf, inoutbuf, &count, datatype);
retval = MPI_SUCCESS;
}
if (comm == MPI_COMM_NULL) {
retval = MPI_ERR_COMM;
- } else if (not datatype->is_valid()) {
+ } else if (datatype == MPI_DATATYPE_NULL || not datatype->is_valid()) {
retval = MPI_ERR_TYPE;
+ } else if (count < 0){
+ retval = MPI_ERR_COUNT;
} else if (op == MPI_OP_NULL) {
retval = MPI_ERR_OP;
} else if (request == nullptr){
if (comm == MPI_COMM_NULL) {
retval = MPI_ERR_COMM;
- } else if (not datatype->is_valid()) {
+ } else if (datatype == MPI_DATATYPE_NULL || not datatype->is_valid()){
retval = MPI_ERR_TYPE;
} else if (op == MPI_OP_NULL) {
retval = MPI_ERR_OP;
} else if (request == nullptr){
retval = MPI_ERR_ARG;
+ } else if (count < 0){
+ retval = MPI_ERR_COUNT;
} else {
int rank = simgrid::s4u::this_actor::get_pid();
void* sendtmpbuf = sendbuf;
retval = MPI_ERR_OP;
} else if (request == nullptr){
retval = MPI_ERR_ARG;
+ } else if (count < 0){
+ retval = MPI_ERR_COUNT;
} else {
int rank = simgrid::s4u::this_actor::get_pid();
void* sendtmpbuf = sendbuf;
if (comm == MPI_COMM_NULL) {
retval = MPI_ERR_COMM;
- } else if (not datatype->is_valid()) {
+ } else if (datatype == MPI_DATATYPE_NULL || not datatype->is_valid()){
retval = MPI_ERR_TYPE;
} else if (op == MPI_OP_NULL) {
retval = MPI_ERR_OP;
int totalcount = 0;
for (int i = 0; i < comm->size(); i++) { // copy data to avoid bad free
+ if(recvcounts[i]<0)
+ return MPI_ERR_COUNT;
trace_recvcounts->push_back(recvcounts[i] * dt_send_size);
totalcount += recvcounts[i];
}
retval = MPI_ERR_COMM;
} else if ((sendbuf != MPI_IN_PLACE && sendtype == MPI_DATATYPE_NULL) || recvtype == MPI_DATATYPE_NULL) {
retval = MPI_ERR_TYPE;
+ } else if ((sendbuf != MPI_IN_PLACE && sendcount < 0) || recvcount < 0){
+ retval = MPI_ERR_COUNT;
} else if (request == nullptr){
retval = MPI_ERR_ARG;
} else {
MPI_Datatype sendtmptype = sendtype;
int maxsize = 0;
for (int i = 0; i < size; i++) { // copy data to avoid bad free
+ if (recvcounts[i] <0 || (sendbuf != MPI_IN_PLACE && sendcounts[i]<0))
+ return MPI_ERR_COUNT;
recv_size += recvcounts[i] * dt_size_recv;
trace_recvcounts->push_back(recvcounts[i] * dt_size_recv);
if (((recvdisps[i] + recvcounts[i]) * dt_size_recv) > maxsize)