I said there is no need to copy before strcmp

diff --git a/teshsuite/simdag/platforms/flatifier.cpp b/teshsuite/simdag/platforms/flatifier.cpp
index a3c3cba..581b755 100644 (file)
--- a/teshsuite/simdag/platforms/flatifier.cpp
+++ b/teshsuite/simdag/platforms/flatifier.cpp
@@ -31,20 +31,18 @@ XBT_LOG_NEW_DEFAULT_CATEGORY(flatifier,
 
 static int name_compare_hosts(const void *n1, const void *n2)
 {
 
 static int name_compare_hosts(const void *n1, const void *n2)
 {

-  char name1[80], name2[80];
-  strcpy(name1, sg_host_get_name(*((sg_host_t *) n1)));
-  strcpy(name2, sg_host_get_name(*((sg_host_t *) n2)));
-
-  return strcmp(name1, name2);
+  return strcmp(
+      sg_host_get_name(*(sg_host_t *) n1),
+      sg_host_get_name(*(sg_host_t *) n2)
+  );

 }
 
 static int name_compare_links(const void *n1, const void *n2)
 {
 }
 
 static int name_compare_links(const void *n1, const void *n2)
 {

-  char name1[80], name2[80];
-  strcpy(name1, sg_link_name(*((SD_link_t *) n1)));
-  strcpy(name2, sg_link_name(*((SD_link_t *) n2)));
-
-  return strcmp(name1, name2);
+  return strcmp(
+      sg_link_name(*(SD_link_t *) n1),
+      sg_link_name(*(SD_link_t *) n2)
+  );

 }
 
 static int parse_cmdline(int *timings, int *downgrade, char **platformFile, int argc, char **argv)
 }
 
 static int parse_cmdline(int *timings, int *downgrade, char **platformFile, int argc, char **argv)