codacy

diff --git a/examples/s4u/app-bittorrent/s4u_peer.cpp b/examples/s4u/app-bittorrent/s4u_peer.cpp
index 04bb2e4..659a4aa 100644 (file)
--- a/examples/s4u/app-bittorrent/s4u_peer.cpp
+++ b/examples/s4u/app-bittorrent/s4u_peer.cpp
@@ -657,7 +657,7 @@ bool Peer::hasCompletedPiece(unsigned int piece)
 int Peer::getFirstMissingBlockFrom(int piece)
 {
   for (unsigned int i = 0; i < PIECES_BLOCKS; i++)
-    if (!(bitfield_blocks & 1ULL << (piece * PIECES_BLOCKS + i)))
+    if (not(bitfield_blocks & 1ULL << (piece * PIECES_BLOCKS + i)))
       return i;
   return -1;
 }

diff --git a/examples/s4u/app-bittorrent/s4u_peer.hpp b/examples/s4u/app-bittorrent/s4u_peer.hpp
index c37eca9..6e33e58 100644 (file)
--- a/examples/s4u/app-bittorrent/s4u_peer.hpp
+++ b/examples/s4u/app-bittorrent/s4u_peer.hpp
@@ -61,11 +61,11 @@ public:
   void updateInterestedAfterReceive();
   void updateChokedPeers();
 
-  bool hasNotPiece(unsigned int piece) { return !(bitfield_ & 1U << piece); }
+  bool hasNotPiece(unsigned int piece) { return not(bitfield_ & 1U << piece); }
   bool hasCompletedPiece(unsigned int piece);
   unsigned int countPieces(unsigned int bitfield);
   /** Check that a piece is not currently being download by the peer. */
-  bool isNotDownloadingPiece(unsigned int piece) { return !(current_pieces & 1U << piece); }
+  bool isNotDownloadingPiece(unsigned int piece) { return not(current_pieces & 1U << piece); }
   int partiallyDownloadedPiece(Connection* remote_peer);
   void updatePiecesCountFromBitfield(unsigned int bitfield);
   void removeCurrentPiece(Connection* remote_peer, unsigned int current_piece);

diff --git a/examples/s4u/app-bittorrent/s4u_tracker.hpp b/examples/s4u/app-bittorrent/s4u_tracker.hpp
index b342b7a..1e43850 100644 (file)
--- a/examples/s4u/app-bittorrent/s4u_tracker.hpp
+++ b/examples/s4u/app-bittorrent/s4u_tracker.hpp
@@ -29,6 +29,7 @@ class TrackerAnswer {
   std::set<int>* peers; // the peer list the peer has asked for.
 public:
   explicit TrackerAnswer(int interval) : interval(interval) { peers = new std::set<int>; }
+  TrackerAnswer(const TrackerAnswer&)                               = delete;
   ~TrackerAnswer() { delete peers; };
   void addPeer(int peer) { peers->insert(peer); }
   std::set<int>* getPeers() { return peers; }
@@ -42,7 +43,6 @@ class Tracker {
 
 public:
   explicit Tracker(std::vector<std::string> args);
-  Tracker(const Tracker&) = delete;
   void operator()();
 };