Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
Three new routing schema by Silas De Munck
authormquinson <mquinson@48e7efb5-ca39-0410-a469-dd3cf9ba447f>
Thu, 16 Jul 2009 18:51:53 +0000 (18:51 +0000)
committermquinson <mquinson@48e7efb5-ca39-0410-a469-dd3cf9ba447f>
Thu, 16 Jul 2009 18:51:53 +0000 (18:51 +0000)
git-svn-id: svn+ssh://scm.gforge.inria.fr/svn/simgrid/simgrid/trunk@6521 48e7efb5-ca39-0410-a469-dd3cf9ba447f

ChangeLog
src/surf/network.c
src/surf/surf_config.c
src/surf/surf_private.h
src/surf/surf_routing.c
src/surf/surfxml_parse.c

index 013329c..45bd464 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 SimGrid (3.3.2-svn) unstable; urgency=low
 
+ The "Simplicity does not preceed complexity, but follows it" release.
+
+ The main contributors of this release were (lexical order):
+   Silas De Munck, Stéphane Genaud, Martin Quinson, Cristian Rosa.
+
  SMPI:
   * Implement some more MPI primitives: 
     MPI_Waitany, MPI_Waitall, MPI_Reduce, MPI_Allreduce, MPI_Sendrecv
@@ -14,6 +19,12 @@ SimGrid (3.3.2-svn) unstable; urgency=low
     - Use dynar to represent routes (instead of void** + int*)
     - kill link_set (use surf_network_model->resource_set instead)
     - Add a command-line option to choose the routing schema to use
+    - Add three new models: 
+      * Floyd (shortest path computed at initialization)
+      * Dijikstra (shortest path recomputed all the time)
+      * Cached Dijikstra (shortest path computed on need)
+      All these models where contributed by Silas De Munck, and are
+      described in his ICCS09 paper.
 
   * Simplify model declaration
     (less redirections, less function to write when defining a model)
index e7292f1..767a0c5 100644 (file)
@@ -415,6 +415,10 @@ static surf_action_t communicate(const char *src_name, const char *dst_name,int
   /* LARGE PLATFORMS HACK:
      expand also with src->link and dst->link */
 
+  /* Cleanup route if required */
+  if(used_routing->finalize_route)
+    used_routing->finalize_route(route);
+
   XBT_OUT;
 
   return (surf_action_t) action;
index 52aa6a5..da90a17 100644 (file)
@@ -168,7 +168,7 @@ void surf_config_init(int *argc, char **argv)
     default_value = xbt_strdup("Full");
     xbt_cfg_register(&_surf_cfg_set, "routing",
                      "Model to use to store the routing information",
-                     xbt_cfgelm_string, &default_value, 0, 0, NULL,
+                     xbt_cfgelm_string, &default_value, 1, 1, NULL,
                      NULL);
 
     xbt_cfg_register(&_surf_cfg_set, "TCP_gamma",
index de1a7b6..85ddca0 100644 (file)
@@ -82,6 +82,7 @@ struct s_routing {
   xbt_dict_t host_id; /* char* -> int* */
 
   xbt_dynar_t (*get_route)(int src, int dst);
+  void (*finalize_route)(xbt_dynar_t route);
   void (*finalize)(void);
   int host_count;
 };
index 1ed0b66..742ccd5 100644 (file)
@@ -3,10 +3,13 @@
 /* This program is free software; you can redistribute it and/or modify it
  * under the terms of the license (GNU LGPL) which comes with this package. */
 
+#include <float.h>
 #include "surf_private.h"
 #include "xbt/dynar.h"
 #include "xbt/str.h"
 #include "xbt/config.h"
+#include "xbt/graph.h"
+#include "xbt/set.h"
 
 XBT_LOG_NEW_DEFAULT_SUBCATEGORY(surf_route,surf,"Routing part of surf");// FIXME: connect this under windows
 
@@ -14,6 +17,9 @@ routing_t used_routing = NULL;
 
 /* Prototypes of each model */
 static void routing_model_full_create(size_t size_of_link,void *loopback);
+static void routing_model_floyd_create(size_t size_of_link, void*loopback);
+static void routing_model_dijkstra_create(size_t size_of_link, void*loopback);
+static void routing_model_dijkstracache_create(size_t size_of_link, void*loopback);
 
 /* Definition of each model */
 struct model_type {
@@ -23,7 +29,10 @@ struct model_type {
 };
 struct model_type models[] =
 { {"Full", "Full routing data (fast, large memory requirements, fully expressive)", routing_model_full_create },
-    {NULL,NULL}};
+  {"Floyd", "Floyd routing data (slow initialization, fast lookup, lesser memory requirements, shortest path routing only)", routing_model_floyd_create },
+  {"Dijkstra", "Dijkstra routing data (fast initialization, slow lookup, small memory requirements, shortest path routing only)", routing_model_dijkstra_create },
+  {"DijkstraCache", "Dijkstra routing data (fast initialization, fast lookup, small memory requirements, shortest path routing only)", routing_model_dijkstracache_create },
+    {NULL,NULL,NULL}};
 
 
 void routing_model_create(size_t size_of_links, void* loopback) {
@@ -177,3 +186,555 @@ static void routing_model_full_create(size_t size_of_link,void *loopback) {
       &routing_full_parse_Sroute_set_endpoints);
   surfxml_add_callback(ETag_surfxml_route_cb_list, &routing_full_parse_Eroute);
 }
+
+/* ************************************************************************** */
+/* *************************** FLOYD ROUTING ********************************* */
+typedef struct {
+  s_routing_t generic_routing;
+  double *cost_table;
+  int *predecessor_table;
+  void** link_table;
+  
+  void *loopback;
+  size_t size_of_link;
+} s_routing_floyd_t,*routing_floyd_t;
+
+
+
+#define FLOYD_COST(i,j) ((routing_floyd_t)used_routing)->cost_table[(i)+(j)*(used_routing)->host_count]
+#define FLOYD_PRED(i,j) ((routing_floyd_t)used_routing)->predecessor_table[(i)+(j)*(used_routing)->host_count]
+#define FLOYD_LINK(i,j) ((routing_floyd_t)used_routing)->link_table[(i)+(j)*(used_routing)->host_count]
+
+static void routing_floyd_parse_end(void) {
+
+  routing_floyd_t routing = (routing_floyd_t) used_routing;
+  int nb_link = 0;
+  unsigned int cpt = 0;    
+  void* link_list = NULL;
+  xbt_dict_cursor_t cursor = NULL;
+  char *key,*data, *end;
+  const char *sep = "#";
+  xbt_dynar_t links, keys;
+  char *link_name = NULL;
+
+  unsigned int i,j;
+
+  int host_count = routing->generic_routing.host_count;
+
+  /* Create Cost, Predecessor and Link tables */
+  routing->cost_table = xbt_new0(double, host_count * host_count); //link cost from host to host
+  routing->predecessor_table = xbt_new0(int, host_count*host_count); //predecessor host numbers
+  routing->link_table = xbt_new0(void*,host_count*host_count); //actual link between src and dst
+
+  /* Initialize costs and predecessors*/
+  for(i = 0; i<host_count;i++)
+    for(j = 0; j<host_count;j++) {
+        FLOYD_COST(i,j) = DBL_MAX;
+        FLOYD_PRED(i,j) = -1;
+    }
+
+   /* Put the routes in position */
+  xbt_dict_foreach(route_table, cursor, key, data) {
+    nb_link = 0;
+    links = (xbt_dynar_t)data;
+    keys = xbt_str_split_str(key, sep);
+
+    
+    src_id = strtol(xbt_dynar_get_as(keys, 0, char*), &end, 16);
+    dst_id = strtol(xbt_dynar_get_as(keys, 1, char*), &end, 16);
+    xbt_dynar_free(&keys);
+    DEBUG4("Handle %d %d (from %d hosts): %ld links",
+        src_id,dst_id,routing->generic_routing.host_count,xbt_dynar_length(links));
+    xbt_assert3(xbt_dynar_length(links) == 1, "%ld links in route between host %d and %d, should be 1", xbt_dynar_length(links), src_id, dst_id);
+    
+    xbt_dynar_foreach (links, cpt, link_name) {
+      void* link = xbt_dict_get_or_null(surf_network_model->resource_set, link_name);
+      if (link)
+        link_list = link;
+      else
+        THROW1(mismatch_error,0,"Link %s not found", link_name);
+    
+    }
+
+    FLOYD_LINK(src_id,dst_id) = link_list;
+    FLOYD_PRED(src_id, dst_id) = src_id;
+
+    //link cost
+    FLOYD_COST(src_id, dst_id) = 1; // assume 1 for now
+
+  }
+
+    /* Add the loopback if needed */
+  for (i = 0; i < host_count; i++)
+    if (!FLOYD_PRED(i, i)) {
+      FLOYD_PRED(i, i) = i;
+      FLOYD_COST(i, i) = 1;
+      FLOYD_LINK(i, i) = routing->loopback;
+    }
+
+
+  //Calculate path costs 
+  unsigned int a,b,c;
+  for(c=0;c<host_count;c++) {
+    for(a=0;a<host_count;a++) {
+      for(b=0;b<host_count;b++) {
+        if(FLOYD_COST(a,c) < DBL_MAX && FLOYD_COST(c,b) < DBL_MAX) {
+          if(FLOYD_COST(a,b) == DBL_MAX || (FLOYD_COST(a,c)+FLOYD_COST(c,b) < FLOYD_COST(a,b))) {
+            FLOYD_COST(a,b) = FLOYD_COST(a,c)+FLOYD_COST(c,b);
+            FLOYD_PRED(a,b) = FLOYD_PRED(c,b);
+          }
+        }
+      }
+    }
+  }
+}
+
+/*
+ * Business methods
+ */
+static xbt_dynar_t routing_floyd_get_route(int src_id,int dst_id) {
+
+  routing_floyd_t routing = (routing_floyd_t) used_routing;
+
+  int pred = dst_id;
+  int prev_pred = 0;
+
+  xbt_dynar_t link_list = xbt_dynar_new(routing->size_of_link, NULL);
+
+  do {
+    prev_pred = pred;
+    pred = FLOYD_PRED(src_id, pred);
+
+    if(pred == -1) // if no pred in route -> no route to host
+        break;
+
+    xbt_dynar_unshift(link_list, &FLOYD_LINK(pred,prev_pred));
+
+  } while(pred != src_id);
+
+  xbt_assert2(pred != -1, "no route from host %d to %d", src_id, dst_id);
+
+  return link_list;
+}
+
+static void routing_floyd_finalize_route(xbt_dynar_t route) {
+  xbt_dynar_free(&route);
+}
+
+static void routing_floyd_finalize(void) {
+  routing_floyd_t routing = (routing_floyd_t)used_routing;
+
+  if (routing) {
+    free(routing->link_table);
+    free(routing->cost_table);
+    free(routing->predecessor_table);
+    xbt_dict_free(&used_routing->host_id);
+    free(routing);
+    routing=NULL;
+  }
+}
+
+static void routing_model_floyd_create(size_t size_of_link,void *loopback) {
+  /* initialize our structure */
+  routing_floyd_t routing = xbt_new0(s_routing_floyd_t,1);
+  routing->generic_routing.name = "Floyd";
+  routing->generic_routing.host_count = 0;
+  routing->generic_routing.get_route = routing_floyd_get_route;
+  routing->generic_routing.finalize = routing_floyd_finalize;
+  routing->generic_routing.finalize_route = routing_floyd_finalize_route;
+  routing->size_of_link = size_of_link;
+  routing->loopback = loopback;
+
+  /* Set it in position */
+  used_routing = (routing_t) routing;
+  
+  /* Setup the parsing callbacks we need */
+  routing->generic_routing.host_id = xbt_dict_new();
+  surfxml_add_callback(STag_surfxml_host_cb_list, &routing_full_parse_Shost);
+  surfxml_add_callback(ETag_surfxml_platform_cb_list, &routing_floyd_parse_end);
+  surfxml_add_callback(STag_surfxml_route_cb_list, 
+      &routing_full_parse_Sroute_set_endpoints);
+  surfxml_add_callback(ETag_surfxml_route_cb_list, &routing_full_parse_Eroute);
+  
+}
+
+/* ************************************************************************** */
+/* ********** Dijkstra & Dijkstra Cached ROUTING **************************** */
+typedef struct {
+  s_routing_t generic_routing;
+  xbt_graph_t route_graph;
+  xbt_set_t graph_node_map;
+  xbt_set_t route_cache;
+  int cached;
+  void *loopback;
+  size_t size_of_link;
+} s_routing_dijkstra_t,*routing_dijkstra_t;
+
+
+typedef struct graph_node_data {
+  int id; 
+  int graph_id; //used for caching internal id's
+} s_graph_node_data_t, * graph_node_data_t;
+
+typedef struct graph_node_map_element {
+  XBT_SET_HEADERS;
+
+  xbt_node_t node;
+} s_graph_node_map_element_t, * graph_node_map_element_t;
+
+typedef struct route_cache_element {
+  XBT_SET_HEADERS;
+
+  int * pred_arr;
+  int size;
+} s_route_cache_element_t, * route_cache_element_t;    
+
+/*
+ * Free functions
+ */
+static void route_cache_elem_free(void *e) {
+  route_cache_element_t elm=(route_cache_element_t)e;
+
+  if (elm) {
+    free(elm->name);
+    free(elm->pred_arr);
+    free(elm);
+  }
+}
+
+static void graph_node_map_elem_free(void *e) {
+  graph_node_map_element_t elm = (graph_node_map_element_t)e;
+
+  if(elm) {
+    free(elm->name);
+    free(elm);
+  }
+}
+
+/*
+ * Utility functions
+*/
+static xbt_node_t route_graph_new_node(int id, int graph_id) {
+  routing_dijkstra_t routing = (routing_dijkstra_t) used_routing;
+
+  graph_node_data_t data = xbt_new0(struct graph_node_data, sizeof(struct graph_node_data));
+  data->id = id;
+  data->graph_id = graph_id;
+  xbt_node_t node = xbt_graph_new_node(routing->route_graph, data);
+
+  graph_node_map_element_t elm = xbt_new0(struct graph_node_map_element, sizeof(struct graph_node_map_element));
+  elm->name_len = 0;
+  elm->name = bprintf("%d",id);
+  elm->node = node;
+
+  xbt_set_add(routing->graph_node_map, (xbt_set_elm_t)elm, &graph_node_map_elem_free);
+
+  return node;
+}
+
+static graph_node_map_element_t graph_node_map_search(int id) {
+  routing_dijkstra_t routing = (routing_dijkstra_t) used_routing;
+
+  char * id_str = bprintf("%d",id);
+  graph_node_map_element_t elm = (graph_node_map_element_t)xbt_set_get_by_name_or_null(routing->graph_node_map, id_str);
+  free(id_str);
+
+  return elm;
+}
+
+/*
+ * Parsing
+ */
+static void route_new_dijkstra(int src_id, int dst_id, void* link) {
+  routing_dijkstra_t routing = (routing_dijkstra_t) used_routing;
+
+  xbt_node_t src = NULL;
+  xbt_node_t dst = NULL;
+  char * src_id_str = bprintf("%d",src_id);
+  char * dst_id_str = bprintf("%d",dst_id);
+  graph_node_map_element_t src_elm = (graph_node_map_element_t)xbt_set_get_by_name_or_null(routing->graph_node_map, src_id_str);
+  graph_node_map_element_t dst_elm = (graph_node_map_element_t)xbt_set_get_by_name_or_null(routing->graph_node_map, dst_id_str);
+  free(src_id_str);
+  free(dst_id_str);
+
+  if(src_elm)
+    src = src_elm->node;
+
+  if(dst_elm)
+    dst = dst_elm->node;
+
+  //add nodes if they don't exist in the graph
+  if(src_id == dst_id && src == NULL && dst == NULL) {
+    src = route_graph_new_node(src_id, -1);
+    dst = src;
+  } else {
+    if(src == NULL) {
+      src = route_graph_new_node(src_id, -1);
+    }
+       
+    if(dst == NULL) {
+      dst = route_graph_new_node(dst_id, -1);
+    }
+  }
+
+  //add link as edge to graph
+  xbt_graph_new_edge(routing->route_graph, src, dst, link);
+  
+}
+
+static void add_loopback_dijkstra(void) {
+  routing_dijkstra_t routing = (routing_dijkstra_t) used_routing;
+
+       xbt_dynar_t nodes = xbt_graph_get_nodes(routing->route_graph);
+       
+       xbt_node_t node = NULL;
+       unsigned int cursor2;
+       xbt_dynar_foreach(nodes, cursor2, node) {
+               xbt_dynar_t out_edges = xbt_graph_node_get_outedges(node); 
+               xbt_edge_t edge = NULL;
+               unsigned int cursor;
+       
+               int found = 0;
+               xbt_dynar_foreach(out_edges, cursor, edge) {
+                       xbt_node_t other_node = xbt_graph_edge_get_target(edge);
+                       if(other_node == node) {
+                               found = 1;
+                               break;
+                       }
+               }
+
+               if(!found)
+                       xbt_graph_new_edge(routing->route_graph, node, node, &routing->loopback);
+       }
+}
+
+static void routing_dijkstra_parse_end(void) {
+  routing_dijkstra_t routing = (routing_dijkstra_t) used_routing;
+  int nb_link = 0;
+  unsigned int cpt = 0;
+  xbt_dict_cursor_t cursor = NULL;
+  char *key, *data, *end;
+  const char *sep = "#";
+  xbt_dynar_t links, keys;
+  char *link_name = NULL;
+
+  /* Create the topology graph */
+  routing->route_graph = xbt_graph_new_graph(1, NULL);
+  routing->graph_node_map = xbt_set_new();
+  if(routing->cached)
+    routing->route_cache = xbt_set_new();
+
+
+  /* Put the routes in position */
+  xbt_dict_foreach(route_table, cursor, key, data) {
+    nb_link = 0;
+    links = (xbt_dynar_t) data;
+    keys = xbt_str_split_str(key, sep);
+
+    src_id = strtol(xbt_dynar_get_as(keys, 0, char *), &end, 16);
+    dst_id = strtol(xbt_dynar_get_as(keys, 1, char *), &end, 16);
+    xbt_dynar_free(&keys);
+
+    DEBUG4("Handle %d %d (from %d hosts): %ld links",
+        src_id,dst_id,routing->generic_routing.host_count,xbt_dynar_length(links));
+
+    xbt_assert3(xbt_dynar_length(links) == 1, "%ld links in route between host %d and %d, should be 1", xbt_dynar_length(links), src_id, dst_id);
+
+    xbt_dynar_foreach(links, cpt, link_name) {
+      void* link = xbt_dict_get_or_null(surf_network_model->resource_set, link_name);
+      if (link)
+        route_new_dijkstra(src_id,dst_id,link);
+      else
+        THROW1(mismatch_error,0,"Link %s not found", link_name);
+    }
+    
+  }
+
+  /* Add the loopback if needed */
+  add_loopback_dijkstra();
+
+  /* initialize graph indexes in nodes after graph has been built */
+  xbt_dynar_t nodes = xbt_graph_get_nodes(routing->route_graph);
+
+  xbt_node_t node = NULL;
+  unsigned int cursor2;
+  xbt_dynar_foreach(nodes, cursor2, node) {
+    graph_node_data_t data = xbt_graph_node_get_data(node);
+    data->graph_id = cursor2;
+  }
+
+}
+
+/*
+ * Business methods
+ */
+static xbt_dynar_t routing_dijkstra_get_route(int src_id,int dst_id) {
+
+  routing_dijkstra_t routing = (routing_dijkstra_t) used_routing;
+  int * pred_arr = NULL;
+  
+  xbt_dynar_t nodes = xbt_graph_get_nodes(routing->route_graph);
+
+  /*Use the graph_node id mapping set to quickly find the nodes */
+  graph_node_map_element_t src_elm = graph_node_map_search(src_id);
+  graph_node_map_element_t dst_elm = graph_node_map_search(dst_id);
+  xbt_assert2(src_elm != NULL && dst_elm != NULL, "src %d or dst %d does not exist", src_id, dst_id);
+  int src_node_id = ((graph_node_data_t)xbt_graph_node_get_data(src_elm->node))->graph_id;
+  int dst_node_id = ((graph_node_data_t)xbt_graph_node_get_data(dst_elm->node))->graph_id;
+
+  route_cache_element_t elm = NULL;
+  if(routing->cached) {
+    /*check if there is a cached predecessor list avail */
+    char * src_id_str = bprintf("%d",src_id);
+    elm = (route_cache_element_t)xbt_set_get_by_name_or_null(routing->route_cache, src_id_str);
+    free(src_id_str);
+  }
+
+  if(elm) { //cached mode and cache hit
+    pred_arr = elm->pred_arr;
+  } else { //not cached mode or cache miss
+    double * cost_arr = NULL;
+    xbt_heap_t pqueue = NULL;
+    int i = 0;
+
+    int nr_nodes = xbt_dynar_length(nodes);
+    cost_arr = xbt_new0(double, nr_nodes); //link cost from src to other hosts
+    pred_arr = xbt_new0(int, nr_nodes); //predecessors in path from src
+    pqueue = xbt_heap_new(nr_nodes, free);
+
+    //initialize
+    cost_arr[src_node_id] = 0.0;
+
+    for(i = 0; i < nr_nodes; i++) {
+      if(i != src_node_id) {
+        cost_arr[i] = DBL_MAX;
+      }
+
+      pred_arr[i] = 0;
+
+      //initialize priority queue
+      int * nodeid = xbt_new0(int, 1);
+      *nodeid = i;
+      xbt_heap_push(pqueue, nodeid, cost_arr[i]);
+
+    }
+
+    // apply dijkstra using the indexes from the graph's node array
+    while(xbt_heap_size(pqueue) > 0) {
+      int * v_id = xbt_heap_pop(pqueue);
+      xbt_node_t v_node = xbt_dynar_get_as(nodes, *v_id, xbt_node_t);
+      xbt_dynar_t out_edges = xbt_graph_node_get_outedges(v_node); 
+      xbt_edge_t edge = NULL;
+      unsigned int cursor;
+
+      xbt_dynar_foreach(out_edges, cursor, edge) {
+        xbt_node_t u_node = xbt_graph_edge_get_target(edge);
+        graph_node_data_t data = xbt_graph_node_get_data(u_node);
+        int u_id = data->graph_id;
+        int cost_v_u = 1; //fixed link cost for now
+
+        if(cost_v_u + cost_arr[*v_id] < cost_arr[u_id]) {
+          pred_arr[u_id] = *v_id;
+          cost_arr[u_id] = cost_v_u + cost_arr[*v_id];
+          int * nodeid = xbt_new0(int, 1);
+          *nodeid = u_id;
+          xbt_heap_push(pqueue, nodeid, cost_arr[u_id]);
+        }
+      }
+
+      //free item popped from pqueue
+      free(v_id);
+    }
+
+    free(cost_arr);
+    xbt_heap_free(pqueue);
+
+  }
+
+  //compose route path with links
+  xbt_dynar_t link_list = xbt_dynar_new(routing->size_of_link, NULL);
+
+  int v;
+  int size = 0;
+  for(v = dst_node_id; v != src_node_id; v = pred_arr[v]) {
+    xbt_node_t node_pred_v = xbt_dynar_get_as(nodes, pred_arr[v], xbt_node_t);
+    xbt_node_t node_v = xbt_dynar_get_as(nodes, v, xbt_node_t);
+    xbt_edge_t edge = xbt_graph_get_edge(routing->route_graph, node_pred_v, node_v);
+
+    xbt_assert2(edge != NULL, "no route between host %d and %d", src_id, dst_id);
+
+    void * link = xbt_graph_edge_get_data(edge);
+    xbt_dynar_unshift(link_list, &link);
+    size++;
+  }
+
+
+  if(routing->cached && elm == NULL) {
+    //add to predecessor list of the current src-host to cache
+    elm = xbt_new0(struct route_cache_element, sizeof(struct route_cache_element));
+    elm->name = bprintf("%d",src_id);
+    elm->name_len = 0;
+    elm->pred_arr = pred_arr;
+    elm->size = size;
+    xbt_set_add(routing->route_cache, (xbt_set_elm_t)elm, &route_cache_elem_free);
+  }
+
+  if(!routing->cached)
+    free(pred_arr);
+
+  return link_list;
+}
+
+static void routing_dijkstra_finalize_route(xbt_dynar_t route) {
+  xbt_dynar_free(&route);
+}
+
+static void routing_dijkstra_finalize(void) {
+  routing_dijkstra_t routing = (routing_dijkstra_t)used_routing;
+
+  if (routing) {
+    xbt_graph_free_graph(routing->route_graph, &free, NULL, &free);
+    xbt_set_free(&routing->graph_node_map);
+    if(routing->cached)
+      xbt_set_free(&routing->route_cache);
+    xbt_dict_free(&used_routing->host_id);
+    free(routing);
+    routing=NULL;
+  }
+}
+
+/*
+ *
+ */
+static void routing_model_dijkstraboth_create(size_t size_of_link,void *loopback, int cached) {
+  /* initialize our structure */
+  routing_dijkstra_t routing = xbt_new0(s_routing_dijkstra_t,1);
+  routing->generic_routing.name = "Dijkstra";
+  routing->generic_routing.host_count = 0;
+  routing->generic_routing.get_route = routing_dijkstra_get_route;
+  routing->generic_routing.finalize = routing_dijkstra_finalize;
+  routing->generic_routing.finalize_route = routing_dijkstra_finalize_route;
+  routing->size_of_link = size_of_link;
+  routing->loopback = loopback;
+  routing->cached = cached;
+
+  /* Set it in position */
+  used_routing = (routing_t) routing;
+
+  /* Setup the parsing callbacks we need */
+  routing->generic_routing.host_id = xbt_dict_new();
+  surfxml_add_callback(STag_surfxml_host_cb_list, &routing_full_parse_Shost);
+  surfxml_add_callback(ETag_surfxml_platform_cb_list, &routing_dijkstra_parse_end);
+  surfxml_add_callback(STag_surfxml_route_cb_list,
+      &routing_full_parse_Sroute_set_endpoints);
+  surfxml_add_callback(ETag_surfxml_route_cb_list, &routing_full_parse_Eroute);
+}
+
+static void routing_model_dijkstra_create(size_t size_of_link,void *loopback) {
+  routing_model_dijkstraboth_create(size_of_link, loopback, 0);
+}
+
+static void routing_model_dijkstracache_create(size_t size_of_link,void *loopback) {
+  routing_model_dijkstraboth_create(size_of_link, loopback, 1);
+}
index be1a261..a0b9868 100644 (file)
@@ -12,6 +12,8 @@
 #include "surf/surfxml_parse_private.h"
 #include "surf/surf_private.h"
 
+#define NO_IMPLICIT_ROUTES
+
 XBT_LOG_NEW_DEFAULT_SUBCATEGORY(surf_parse, surf,
                                 "Logging specific to the SURF parsing module");
 #undef CLEANUP
@@ -1111,8 +1113,10 @@ static void parse_cluster(void)
   char *cluster_suffix = A_surfxml_cluster_suffix;
   char *cluster_radical = A_surfxml_cluster_radical;
   char *cluster_power = A_surfxml_cluster_power;
+#if !defined NO_IMPLICIT_ROUTES
   char *cluster_bw = A_surfxml_cluster_bw;
   char *cluster_lat = A_surfxml_cluster_lat;
+#endif
   char *cluster_bb_bw = A_surfxml_cluster_bb_bw;
   char *cluster_bb_lat = A_surfxml_cluster_bb_lat;
   char *backbone_name;
@@ -1139,7 +1143,7 @@ static void parse_cluster(void)
 
   SURFXML_START_TAG(host);
   SURFXML_END_TAG(host);
-
+#ifndef NO_IMPLICIT_ROUTES
   /* Make link for the foreach */
   parse_change_link_data("$1", cluster_bw, "", cluster_lat, "", "");
   A_surfxml_link_state = A_surfxml_link_state_ON;
@@ -1147,7 +1151,7 @@ static void parse_cluster(void)
 
   SURFXML_START_TAG(link);
   SURFXML_END_TAG(link);
-
+#endif
   SURFXML_END_TAG(foreach);
 
   /* Make backbone link */
@@ -1159,7 +1163,7 @@ static void parse_cluster(void)
 
   SURFXML_START_TAG(link);
   SURFXML_END_TAG(link);
-
+#ifndef NO_IMPLICIT_ROUTES
   /* Make route multi with the outside world, i.e. cluster->$* */
   SURFXML_BUFFER_SET(route_c_multi_src, cluster_id);
   SURFXML_BUFFER_SET(route_c_multi_dst, "$*");
@@ -1189,7 +1193,7 @@ static void parse_cluster(void)
   SURFXML_END_TAG(link_c_ctn);
 
   SURFXML_END_TAG(route_c_multi);
-
+#endif
 
   free(backbone_name);