Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
change the dict in which parsed properties are stored from homogeneous
authorsuter <frederic.suter@cc.in2p3.fr>
Fri, 30 May 2014 21:56:02 +0000 (23:56 +0200)
committersuter <frederic.suter@cc.in2p3.fr>
Fri, 30 May 2014 21:56:02 +0000 (23:56 +0200)
to heterogeneous. A leak occured in
teshsuite/msg/storage/storage_basic.c after the addition of a call
MSG_storage_set_property_value that adds a new property to the dict. The
new element doesn't appear to be freed when freeing the resources. After
several tries, the proposed modification solves the issue without
breaking something else.

src/surf/surfxml_parse.c

index dafaab1..ab38ab2 100644 (file)
@@ -420,8 +420,8 @@ void STag_surfxml_prop(void)
   }
   else{
     if (!current_property_set)
-      current_property_set = xbt_dict_new_homogeneous(xbt_free_f); // Maybe, it should raise an error
-    xbt_dict_set(current_property_set, A_surfxml_prop_id, xbt_strdup(A_surfxml_prop_value), NULL);
+       current_property_set = xbt_dict_new(); // Maybe, it should raise an error
+    xbt_dict_set(current_property_set, A_surfxml_prop_id, xbt_strdup(A_surfxml_prop_value), xbt_free);
   }
 }