Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
previous ti-tracing improvement for bcast and reduce was not a good idea.
authorAugustin Degomme <adegomme@users.noreply.github.com>
Fri, 6 Aug 2021 21:30:58 +0000 (23:30 +0200)
committerAugustin Degomme <adegomme@users.noreply.github.com>
Fri, 6 Aug 2021 21:30:58 +0000 (23:30 +0200)
these are already ranks.

src/smpi/internals/smpi_replay.cpp

index 2ed50c2..346fab7 100644 (file)
@@ -589,7 +589,7 @@ void BcastAction::kernel(simgrid::xbt::ReplayAction&)
 {
   const BcastArgParser& args = get_args();
   TRACE_smpi_comm_in(get_pid(), "action_bcast",
-                     new simgrid::instr::CollTIData("bcast", MPI_COMM_WORLD->group()->rank(args.root), -1.0, args.size,
+                     new simgrid::instr::CollTIData("bcast", args.root, -1.0, args.size,
                                                     0, Datatype::encode(args.datatype1), ""));
 
   colls::bcast(send_buffer(args.size * args.datatype1->size()), args.size, args.datatype1, args.root, MPI_COMM_WORLD);
@@ -601,7 +601,7 @@ void ReduceAction::kernel(simgrid::xbt::ReplayAction&)
 {
   const ReduceArgParser& args = get_args();
   TRACE_smpi_comm_in(get_pid(), "action_reduce",
-                     new simgrid::instr::CollTIData("reduce", MPI_COMM_WORLD->group()->rank(args.root), args.comp_size,
+                     new simgrid::instr::CollTIData("reduce", args.root, args.comp_size,
                                                     args.comm_size, 0, Datatype::encode(args.datatype1), ""));
 
   colls::reduce(send_buffer(args.comm_size * args.datatype1->size()),