sonar found these potential issues .. why not.

diff --git a/src/smpi/smpi_global.cpp b/src/smpi/smpi_global.cpp
index b7b181c..47a3374 100644 (file)
--- a/src/smpi/smpi_global.cpp
+++ b/src/smpi/smpi_global.cpp
@@ -790,7 +790,7 @@ int smpi_main(int (*realmain) (int argc, char *argv[]), int argc, char *argv[])
   SIMIX_global_init(&argc, argv);
   MSG_init(&argc,argv);
 
   SIMIX_global_init(&argc, argv);
   MSG_init(&argc,argv);
 

-  SMPI_switch_data_segment = smpi_switch_data_segment;
+  SMPI_switch_data_segment = &smpi_switch_data_segment;

 
   smpi_init_options();
 
 
   smpi_init_options();
 

diff --git a/src/smpi/smpi_mpi_dt.cpp b/src/smpi/smpi_mpi_dt.cpp
index 1268a50..f7d69c5 100644 (file)
--- a/src/smpi/smpi_mpi_dt.cpp
+++ b/src/smpi/smpi_mpi_dt.cpp
@@ -424,8 +424,9 @@ void smpi_datatype_free(MPI_Datatype* type){
 
 void smpi_datatype_use(MPI_Datatype type){
 
 
 void smpi_datatype_use(MPI_Datatype type){
 

-  if(type != MPI_DATATYPE_NULL)
-    type->in_use++;
+  if(type == MPI_DATATYPE_NULL)
+    return;
+  type->in_use++;

 
   if(type->sizeof_substruct!=0){
     static_cast<s_smpi_subtype_t *>((type)->substruct)->subtype_use(&type);  
 
   if(type->sizeof_substruct!=0){
     static_cast<s_smpi_subtype_t *>((type)->substruct)->subtype_use(&type);