please sonar

diff --git a/src/simix/ActorImpl.cpp b/src/simix/ActorImpl.cpp
index 1fd6dc3..935ca1b 100644 (file)
--- a/src/simix/ActorImpl.cpp
+++ b/src/simix/ActorImpl.cpp
@@ -348,7 +348,6 @@ smx_actor_t SIMIX_process_create(const char* name, std::function<void()> code, v
   XBT_DEBUG("Inserting %s(%s) in the to_run list", process->getCname(), host->getCname());
   simix_global->process_to_run.push_back(process);
   intrusive_ptr_add_ref(process);
   XBT_DEBUG("Inserting %s(%s) in the to_run list", process->getCname(), host->getCname());
   simix_global->process_to_run.push_back(process);
   intrusive_ptr_add_ref(process);

-

   /* Tracing the process creation */
   TRACE_msg_process_create(process->getName(), process->pid, process->host);
 
   /* Tracing the process creation */
   TRACE_msg_process_create(process->getName(), process->pid, process->host);
 

diff --git a/src/simix/ActorImpl.hpp b/src/simix/ActorImpl.hpp
index 28409f3..ecc4156 100644 (file)
--- a/src/simix/ActorImpl.hpp
+++ b/src/simix/ActorImpl.hpp
@@ -130,8 +130,6 @@ typedef boost::intrusive::list<ActorImpl, boost::intrusive::member_hook<ActorImp
 }
 }
 
 }
 }
 

-typedef simgrid::simix::ProcessArg *smx_process_arg_t;
-

 typedef simgrid::simix::ActorImpl* smx_actor_t;
 
 extern "C" {
 typedef simgrid::simix::ActorImpl* smx_actor_t;
 
 extern "C" {

diff --git a/src/simix/smx_host.cpp b/src/simix/smx_host.cpp
index da84fe5..1dea2c9 100644 (file)
--- a/src/simix/smx_host.cpp
+++ b/src/simix/smx_host.cpp
@@ -120,6 +120,7 @@ void SIMIX_host_add_auto_restart_process(sg_host_t host, const char* name, std::
     watched_hosts.insert(host->getCname());
     XBT_DEBUG("Push host %s to watched_hosts because state == SURF_RESOURCE_OFF", host->getCname());
   }
     watched_hosts.insert(host->getCname());
     XBT_DEBUG("Push host %s to watched_hosts because state == SURF_RESOURCE_OFF", host->getCname());
   }

+  XBT_DEBUG("Adding Process %s to the auto-restart list of Host %s", arg->name.c_str(), arg->host->getCname());

   host->extension<simgrid::simix::Host>()->auto_restart_processes.push_back(arg);
 }
 
   host->extension<simgrid::simix::Host>()->auto_restart_processes.push_back(arg);
 }
 

diff --git a/src/smpi/internals/smpi_process.cpp b/src/smpi/internals/smpi_process.cpp
index 29ac6f4..90a265e 100644 (file)
--- a/src/smpi/internals/smpi_process.cpp
+++ b/src/smpi/internals/smpi_process.cpp
@@ -23,10 +23,11 @@ using simgrid::s4u::Actor;
 using simgrid::s4u::ActorPtr;
 
 Process::Process(ActorPtr actor, msg_bar_t finalization_barrier)
 using simgrid::s4u::ActorPtr;
 
 Process::Process(ActorPtr actor, msg_bar_t finalization_barrier)

-  : finalization_barrier_(finalization_barrier)
+    : finalization_barrier_(finalization_barrier), process_(actor)

 {
 {

-  std::stringstream mailboxname, mailboxname_small;
-  process_              = actor;
+  std::stringstream mailboxname;
+  std::stringstream mailboxname_small;
+

   mailboxname           << std::string("SMPI-")  << process_->getPid();
   mailboxname_small     << std::string("small-") << process_->getPid();
   mailbox_              = simgrid::s4u::Mailbox::byName(mailboxname.str());
   mailboxname           << std::string("SMPI-")  << process_->getPid();
   mailboxname_small     << std::string("small-") << process_->getPid();
   mailbox_              = simgrid::s4u::Mailbox::byName(mailboxname.str());

diff --git a/teshsuite/s4u/cloud-interrupt-migration/cloud-interrupt-migration.cpp b/teshsuite/s4u/cloud-interrupt-migration/cloud-interrupt-migration.cpp
index afb79fb..df7d015 100644 (file)
--- a/teshsuite/s4u/cloud-interrupt-migration/cloud-interrupt-migration.cpp
+++ b/teshsuite/s4u/cloud-interrupt-migration/cloud-interrupt-migration.cpp
@@ -35,7 +35,7 @@ static void master_main()
   vm0->start();
 
   XBT_INFO("Start the migration of %s from %s to %s", vm0->getCname(), pm0->getCname(), pm1->getCname());
   vm0->start();
 
   XBT_INFO("Start the migration of %s from %s to %s", vm0->getCname(), pm0->getCname(), pm1->getCname());

-  simgrid::s4u::ActorPtr migration = vm_migrate_async(vm0, pm1);
+  vm_migrate_async(vm0, pm1);

 
   simgrid::s4u::this_actor::sleep_for(2);
   XBT_INFO("Wait! change my mind, shutdown %s. This ends the migration", vm0->getCname());
 
   simgrid::s4u::this_actor::sleep_for(2);
   XBT_INFO("Wait! change my mind, shutdown %s. This ends the migration", vm0->getCname());

diff --git a/teshsuite/smpi/macro-sample/macro-sample.c b/teshsuite/smpi/macro-sample/macro-sample.c
index 8e10034..627067e 100644 (file)
--- a/teshsuite/smpi/macro-sample/macro-sample.c
+++ b/teshsuite/smpi/macro-sample/macro-sample.c
@@ -25,7 +25,8 @@ static double compute(double d0)
 
 int main(int argc, char *argv[])
 {
 
 int main(int argc, char *argv[])
 {

-  int n, rank;
+  int n;
+  int rank;

   MPI_Init(&argc, &argv);
   int verbose = argc <= 1;
   MPI_Comm_size(MPI_COMM_WORLD, &n);
   MPI_Init(&argc, &argv);
   int verbose = argc <= 1;
   MPI_Comm_size(MPI_COMM_WORLD, &n);