Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
kill set-signal.tesh, catch-signal.tesh already test the same
authorMartin Quinson <martin.quinson@loria.fr>
Wed, 30 Sep 2015 16:55:01 +0000 (18:55 +0200)
committerMartin Quinson <martin.quinson@loria.fr>
Wed, 30 Sep 2015 16:55:01 +0000 (18:55 +0200)
tools/cmake/AddTests.cmake
tools/tesh/CMakeLists.txt
tools/tesh/catch-signal.tesh
tools/tesh/set-signal.tesh [deleted file]

index ef53354..166aec8 100644 (file)
@@ -80,11 +80,8 @@ IF(NOT enable_memcheck)
   ADD_TESH(tesh-self-catch-wrong-output          --cd "${CMAKE_BINARY_DIR}/bin" ${CMAKE_HOME_DIRECTORY}/tools/tesh/catch-wrong-output.tesh)
   ADD_TESH(tesh-self-bg-basic                    --cd "${CMAKE_BINARY_DIR}/bin" ${CMAKE_HOME_DIRECTORY}/tools/tesh/bg-basic.tesh)
   ADD_TESH(tesh-self-background                  --cd "${CMAKE_BINARY_DIR}/bin" ${CMAKE_HOME_DIRECTORY}/tools/tesh/background.tesh)
-  IF(NOT WIN32)
-    ADD_TESH(tesh-self-set-signal                --cd "${CMAKE_BINARY_DIR}/bin" ${CMAKE_HOME_DIRECTORY}/tools/tesh/set-signal.tesh)
-    ADD_TESH(tesh-self-bg-set-signal             --cd "${CMAKE_BINARY_DIR}/bin" ${CMAKE_HOME_DIRECTORY}/tools/tesh/bg-set-signal.tesh)
-    ADD_TESH(tesh-self-catch-signal              --cd "${CMAKE_BINARY_DIR}/bin" ${CMAKE_HOME_DIRECTORY}/tools/tesh/catch-signal.tesh)
-  ENDIF()
+  ADD_TESH(tesh-self-bg-set-signal               --cd "${CMAKE_BINARY_DIR}/bin" ${CMAKE_HOME_DIRECTORY}/tools/tesh/bg-set-signal.tesh)
+  ADD_TESH(tesh-self-catch-signal                --cd "${CMAKE_BINARY_DIR}/bin" ${CMAKE_HOME_DIRECTORY}/tools/tesh/catch-signal.tesh)
 
   ### GENERIC  ###
   # BEGIN TESH TESTS
index 69c5f7a..c45ae0b 100644 (file)
@@ -15,7 +15,6 @@ set(tesh_files
   ${CMAKE_CURRENT_SOURCE_DIR}/set-output-sort.tesh
   ${CMAKE_CURRENT_SOURCE_DIR}/set-output-sort-1.tesh
   ${CMAKE_CURRENT_SOURCE_DIR}/set-return.tesh
-  ${CMAKE_CURRENT_SOURCE_DIR}/set-signal.tesh
   ${CMAKE_CURRENT_SOURCE_DIR}/set-timeout.tesh
   ${CMAKE_CURRENT_SOURCE_DIR}/background.tesh
   ${CMAKE_CURRENT_SOURCE_DIR}/basic.tesh
index 3a7727f..8229a7a 100644 (file)
@@ -9,9 +9,11 @@ $ cd temp_testdir-catch-signal
 < kill 'SEGV', $$;
 $ mkfile segfault.pl
 
+p Check that we notice when SEGV is raised
 ! expect signal SIGSEGV
 $ perl segfault.pl
 
+p Check that we return the expected return value on SEGV
 ! expect return 15
 < $ perl segfault.pl
 $ ../tesh --enable-coverage
diff --git a/tools/tesh/set-signal.tesh b/tools/tesh/set-signal.tesh
deleted file mode 100644 (file)
index 314b7f0..0000000
+++ /dev/null
@@ -1,20 +0,0 @@
-#! ./tesh
-# This suite builds and uses a program raising a segfault, ie a program dying
-# of SIGSEV. tesh must detect this condition and report the issue.
-
-$ rm -rf temp_testdir-set-signal
-$ mkdir temp_testdir-set-signal
-
-$ cd temp_testdir-set-signal
-< #include <stdlib.h>
-< int main(void) {
-<   char *A=NULL;
-<   *A = 1;
-< }
-$ mkfile segfault.c
-
-$ cc -o segfault segfault.c
-! expect signal SIGSEGV
-$ ./segfault
-$ cd ..
-$ rm -rf temp_testdir-set-signal