Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
Remove std::move.
authorArnaud Giersch <arnaud.giersch@univ-fcomte.fr>
Wed, 28 Mar 2018 15:57:55 +0000 (17:57 +0200)
committerArnaud Giersch <arnaud.giersch@univ-fcomte.fr>
Wed, 28 Mar 2018 15:58:01 +0000 (17:58 +0200)
According to clang:
src/xbt/xbt_replay.cpp:123:38: error: moving a temporary object prevents copy elision
      [-Werror,-Wpessimizing-move]
      simgrid::xbt::ReplayAction evt(std::move(simgrid::xbt::get_action(argv[0])));
                                     ^
src/xbt/xbt_replay.cpp:123:38: note: remove std::move call here
      simgrid::xbt::ReplayAction evt(std::move(simgrid::xbt::get_action(argv[0])));
                                     ^~~~~~~~~~                                 ~
1 error generated.

src/xbt/xbt_replay.cpp

index b022e52..23be2f5 100644 (file)
@@ -120,7 +120,7 @@ int replay_runner(int argc, char* argv[])
 {
   if (simgrid::xbt::action_fs) { // A unique trace file
     while (true) {
-      simgrid::xbt::ReplayAction evt(std::move(simgrid::xbt::get_action(argv[0])));
+      simgrid::xbt::ReplayAction evt(simgrid::xbt::get_action(argv[0]));
       if (evt.empty())
         break;
       simgrid::xbt::handle_action(evt);