Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
Survive with old cmakes
authorMartin Quinson <martin.quinson@ens-rennes.fr>
Sun, 10 Jul 2022 22:33:55 +0000 (00:33 +0200)
committerMartin Quinson <martin.quinson@ens-rennes.fr>
Sun, 10 Jul 2022 22:33:55 +0000 (00:33 +0200)
CMakeLists.txt
examples/sthread/CMakeLists.txt

index b03c595..d39d92a 100644 (file)
@@ -23,6 +23,7 @@ cmake_minimum_required(VERSION 3.5)
 if(NOT CMAKE_VERSION VERSION_LESS "3.9")
   cmake_policy(SET CMP0069 NEW)
 endif()
+# once we move >= 3.13, we should use target_link_option in examples/sthread
 message(STATUS "Cmake version ${CMAKE_MAJOR_VERSION}.${CMAKE_MINOR_VERSION}.${CMAKE_PATCH_VERSION}")
 set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${CMAKE_HOME_DIRECTORY}/tools/cmake/Modules)
 
index 6a91932..81d4ef1 100644 (file)
@@ -11,7 +11,7 @@ foreach(x
     add_executable       (pthread-${x} EXCLUDE_FROM_ALL pthread-${x}.c)
     set_target_properties(pthread-${x} PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR})
     target_link_libraries(pthread-${x} PRIVATE Threads::Threads)
-    target_link_options(pthread-${x} PUBLIC "-Wl,-znorelro -Wl,-znoseparate-code")
+    target_link_libraries(pthread-${x} PUBLIC "-Wl,-znorelro -Wl,-znoseparate-code") # TODO: convert to target_link_option once cmake is >3.13
 
     add_dependencies(tests pthread-${x})
     ADD_TESH_FACTORIES(pthread-${x} "^thread" --setenv libdir=${CMAKE_BINARY_DIR}/lib --cd ${CMAKE_BINARY_DIR}/examples/sthread ${CMAKE_CURRENT_SOURCE_DIR}/pthread-${x}.tesh)