Please the checkers (sonar, codacy)

- reduce the scope of a variable
- Mark a constructor as explicit
- Blindly obey the given hints about javascript that I don't really master

diff --git a/docs/source/_ext/showfile.js b/docs/source/_ext/showfile.js
index fd8ae6c..200bbdb 100644 (file)
--- a/docs/source/_ext/showfile.js
+++ b/docs/source/_ext/showfile.js
@@ -3,10 +3,10 @@ $(function() {
     /**
      * Toggle logic
      */
-    $('.hidden-content').hide()
-    $('.toggle-header').click(function () {
+    $(".hidden-content").hide();
+    $(".toggle-header").click(function () {
         $(this).toggleClass("open");
-        $(this).next('.toggle-content').toggle('400');
-    })
+        $(this).next(".toggle-content").toggle('400');
+    });
 });
 

diff --git a/examples/c/dht-kademlia/answer.c b/examples/c/dht-kademlia/answer.c
index c50d506..3d71da1 100644 (file)
--- a/examples/c/dht-kademlia/answer.c
+++ b/examples/c/dht-kademlia/answer.c
@@ -23,11 +23,9 @@ answer_t answer_init(unsigned int destination_id)
 /** Destroys a node answer object. */
 void answer_free(answer_t answer)
 {
-  unsigned int i;
   if (answer) {
-    for (i = 0; i < answer->size; i++) {
+    for (unsigned int i = 0; i < answer->size; i++)
       node_contact_free(*(void**)xbt_dynar_get_ptr(answer->nodes, i));
-    }
     xbt_dynar_free(&answer->nodes);
   }
   xbt_free(answer);

diff --git a/src/mc/remote/RemoteSimulation.hpp b/src/mc/remote/RemoteSimulation.hpp
index 4d2ce16..55f3f97 100644 (file)
--- a/src/mc/remote/RemoteSimulation.hpp
+++ b/src/mc/remote/RemoteSimulation.hpp
@@ -73,7 +73,7 @@ private:
   static constexpr int cache_simix_processes = 4;
 
 public:
-  RemoteSimulation(pid_t pid);
+  explicit RemoteSimulation(pid_t pid);
   ~RemoteSimulation();
   void init();