-/* Copyright (c) 2006-2019. The SimGrid Team. All rights reserved. */
+/* Copyright (c) 2006-2020. The SimGrid Team. All rights reserved. */
/* This program is free software; you can redistribute it and/or modify it
* under the terms of the license (GNU LGPL) which comes with this package. */
class XBT_PRIVATE compare_hosts {
public:
- bool operator()(simgrid::s4u::Host* const a, simgrid::s4u::Host* const b) const;
+ bool operator()(s4u::Host* const a, s4u::Host* const b) const;
};
-typedef boost::heap::fibonacci_heap<simgrid::s4u::Host*, boost::heap::compare<compare_hosts>>::handle_type heap_handle;
+using heap_handle = boost::heap::fibonacci_heap<s4u::Host*, boost::heap::compare<compare_hosts>>::handle_type;
-/**
- * Structure that imitates a std::pair, but it allows us
- * to use meaningful names instead of .first and .second
- */
+/** Structure that imitates a std::pair, but it allows us to use meaningful names instead of .first and .second */
struct XBT_PRIVATE pair_handle_load
{
heap_handle update_handle;
double load;
};
-static std::map<simgrid::s4u::Host* const, pair_handle_load> additional_load;
+static std::map<s4u::Host* const, pair_handle_load> additional_load;
-bool compare_hosts::operator()(simgrid::s4u::Host* const a, simgrid::s4u::Host* const b) const {
+bool compare_hosts::operator()(s4u::Host* const a, s4u::Host* const b) const
+{
return additional_load[a].load > additional_load[b].load;
}
-
void LoadBalancer::run()
{
- simgrid::s4u::Engine* engine = simgrid::s4u::Engine::get_instance();
- std::vector<simgrid::s4u::Host*> available_hosts =
- engine->get_filtered_hosts([](simgrid::s4u::Host* host) { return host->is_on(); });
+ const s4u::Engine* engine = s4u::Engine::get_instance();
+ std::vector<s4u::Host*> available_hosts =
+ engine->get_filtered_hosts([](const s4u::Host* host) { return host->is_on(); });
xbt_assert(available_hosts.size() > 0, "No hosts available; are they all switched off?");
// TODO: Account for daemon background load (-> use especially the availability file)
- std::vector<simgrid::s4u::ActorPtr> all_actors =
- engine->get_filtered_actors([](simgrid::s4u::ActorPtr actor) { return not actor->is_daemon(); });
+ std::vector<s4u::ActorPtr> all_actors =
+ engine->get_filtered_actors([](s4u::ActorPtr actor) { return not actor->is_daemon(); });
- for (auto& actor : all_actors) {
+ for (auto const& actor : all_actors) {
new_mapping.assign(actor, actor->get_host());
}
// Sort the actors, from highest to lowest load; we then just iterate over these actors
- std::sort(all_actors.begin(), all_actors.end(), [this](simgrid::s4u::ActorPtr a, simgrid::s4u::ActorPtr b) {
+ std::sort(all_actors.begin(), all_actors.end(), [this](s4u::ActorPtr a, s4u::ActorPtr b) {
return actor_computation[a->get_pid()] > actor_computation[b->get_pid()];
});
// after a host got another actor assigned (or moved from).
// We can't use std::priorityQueue here because we modify *two* elements: The top element, which
// we can access and which has the lowest load, gets a new actor assigned.
- // However, the host loosing that actor must be updated as well.
+ // However, the host losing that actor must be updated as well.
// std::priorityQueue is immutable and hence doesn't work for us.
//
// This heap contains the least loaded host at the top
- boost::heap::fibonacci_heap<simgrid::s4u::Host*, boost::heap::compare<compare_hosts>> usable_hosts;
+ boost::heap::fibonacci_heap<s4u::Host*, boost::heap::compare<compare_hosts>> usable_hosts;
for (auto& host : available_hosts) {
- std::vector<simgrid::s4u::ActorPtr> actors = host->get_all_actors();
- heap_handle update_handle = usable_hosts.push(host); // Required to update elements in the heap
- additional_load[host] = {update_handle, 0}; // Save the handle for later
- const double total_flops_computed = sg_host_get_computed_flops(host);
- for (auto& actor : actors) {
+ std::vector<s4u::ActorPtr> actors = host->get_all_actors();
+ heap_handle update_handle = usable_hosts.push(host); // Required to update elements in the heap
+ additional_load[host] = {update_handle, 0}; // Save the handle for later
+ const double total_flops_computed = sg_host_get_computed_flops(host);
+ for (auto const& actor : actors) {
additional_load[host].load += actor_computation[actor->get_pid()] / total_flops_computed; // Normalize load - this allows comparison
// even between hosts with different frequencies
XBT_DEBUG("Actor %li -> %f", actor->get_pid(), actor_computation[actor->get_pid()]);
}
// Implementation of the Greedy algorithm
- for (auto& actor : all_actors) {
- simgrid::s4u::Host* target_host = usable_hosts.top(); // This is the host with the lowest load
+ for (auto const& actor : all_actors) {
+ s4u::Host* target_host = usable_hosts.top(); // This is the host with the lowest load
- simgrid::s4u::Host* cur_mapped_host = new_mapping.get_host(actor);
+ s4u::Host* cur_mapped_host = new_mapping.get_host(actor);
if (target_host != cur_mapped_host
&& additional_load[target_host].load + actor_computation[actor->get_pid()] < additional_load[cur_mapped_host].load
&& new_mapping.count_actors(cur_mapped_host) > 1) {
}
while (!usable_hosts.empty()) {
- simgrid::s4u::Host* host = usable_hosts.top();
+ s4u::Host* host = usable_hosts.top();
usable_hosts.pop();
sg_host_load_reset(host); // Reset host load for next iterations
/* Debug messages that allow us to verify the load for each host */
XBT_DEBUG("Host: %s, load total: %f", host->get_cname(), additional_load[host].load);
double load_verif = 0.0;
- new_mapping.for_each_actor(host,
- [this, &load_verif](simgrid::s4u::ActorPtr actor) {
- load_verif += actor_computation[actor->get_pid()];
- XBT_DEBUG(" %li (load: %f)", actor->get_pid(), actor_computation[actor->get_pid()]);
+ new_mapping.for_each_actor(host, [this, &load_verif](s4u::ActorPtr actor) {
+ load_verif += actor_computation[actor->get_pid()];
+ XBT_DEBUG(" %li (load: %f)", actor->get_pid(), actor_computation[actor->get_pid()]);
});
XBT_DEBUG("Host load verification: %f", load_verif);
}
}
}
-simgrid::s4u::Host* LoadBalancer::get_mapping(simgrid::s4u::ActorPtr actor)
+s4u::Host* LoadBalancer::get_mapping(s4u::ActorPtr actor)
{
return new_mapping.get_host(actor);
}
-void LoadBalancer::record_actor_computation(simgrid::s4u::ActorPtr actor, double load)
+void LoadBalancer::record_actor_computation(s4u::Actor const& actor, double load)
{
- actor_computation[actor->get_pid()] += load;
-}
-}
-}
+ actor_computation[actor.get_pid()] += load;
}
+} // namespace loadbalancer
+} // namespace plugin
+} // namespace simgrid