A
lgorithmique
N
umérique
D
istribuée
Public GIT Repository
projects
/
simgrid.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
fix dist
[simgrid.git]
/
src
/
kernel
/
routing
/
DragonflyZone.cpp
diff --git
a/src/kernel/routing/DragonflyZone.cpp
b/src/kernel/routing/DragonflyZone.cpp
index
12dd63c
..
827aa98
100644
(file)
--- a/
src/kernel/routing/DragonflyZone.cpp
+++ b/
src/kernel/routing/DragonflyZone.cpp
@@
-30,18
+30,15
@@
DragonflyZone::~DragonflyZone()
}
}
}
}
-
unsigned int* DragonflyZone::rankId_to_coords(int rankId
)
+
void DragonflyZone::rankId_to_coords(int rankId, unsigned int (*coords)[4]
)
{
// coords : group, chassis, blade, node
{
// coords : group, chassis, blade, node
- unsigned int* coords = (unsigned int*)malloc(4 * sizeof(unsigned int));
- coords[0] = rankId / (numChassisPerGroup_ * numBladesPerChassis_ * numNodesPerBlade_);
+ (*coords)[0] = rankId / (numChassisPerGroup_ * numBladesPerChassis_ * numNodesPerBlade_);
rankId = rankId % (numChassisPerGroup_ * numBladesPerChassis_ * numNodesPerBlade_);
rankId = rankId % (numChassisPerGroup_ * numBladesPerChassis_ * numNodesPerBlade_);
-
coords[1]
= rankId / (numBladesPerChassis_ * numNodesPerBlade_);
+
(*coords)[1]
= rankId / (numBladesPerChassis_ * numNodesPerBlade_);
rankId = rankId % (numBladesPerChassis_ * numNodesPerBlade_);
rankId = rankId % (numBladesPerChassis_ * numNodesPerBlade_);
- coords[2] = rankId / numNodesPerBlade_;
- coords[3] = rankId % numNodesPerBlade_;
-
- return coords;
+ (*coords)[2] = rankId / numNodesPerBlade_;
+ (*coords)[3] = rankId % numNodesPerBlade_;
}
void DragonflyZone::parse_specific_arguments(sg_platf_cluster_cbarg_t cluster)
}
void DragonflyZone::parse_specific_arguments(sg_platf_cluster_cbarg_t cluster)
@@
-134,7
+131,7
@@
void DragonflyZone::generateRouters()
}
}
}
}
-void DragonflyZone::createLink(
char*
id, int numlinks, surf::LinkImpl** linkup, surf::LinkImpl** linkdown)
+void DragonflyZone::createLink(
std::string
id, int numlinks, surf::LinkImpl** linkup, surf::LinkImpl** linkdown)
{
*linkup = nullptr;
*linkdown = nullptr;
{
*linkup = nullptr;
*linkdown = nullptr;
@@
-142,16
+139,16
@@
void DragonflyZone::createLink(char* id, int numlinks, surf::LinkImpl** linkup,
linkTemplate.bandwidth = this->cluster_->bw * numlinks;
linkTemplate.latency = this->cluster_->lat;
linkTemplate.policy = this->cluster_->sharing_policy; // sthg to do with that ?
linkTemplate.bandwidth = this->cluster_->bw * numlinks;
linkTemplate.latency = this->cluster_->lat;
linkTemplate.policy = this->cluster_->sharing_policy; // sthg to do with that ?
- linkTemplate.id =
std::string(id)
;
+ linkTemplate.id =
id
;
sg_platf_new_link(&linkTemplate);
sg_platf_new_link(&linkTemplate);
- XBT_DEBUG("Generating link %s", id);
+ XBT_DEBUG("Generating link %s", id
.c_str()
);
surf::LinkImpl* link;
std::string tmpID;
if (this->cluster_->sharing_policy == SURF_LINK_FULLDUPLEX) {
surf::LinkImpl* link;
std::string tmpID;
if (this->cluster_->sharing_policy == SURF_LINK_FULLDUPLEX) {
- tmpID =
std::string(linkTemplate.id)
+ "_UP";
+ tmpID =
linkTemplate.id
+ "_UP";
link = surf::LinkImpl::byName(tmpID.c_str());
*linkup = link; // check link?
link = surf::LinkImpl::byName(tmpID.c_str());
*linkup = link; // check link?
- tmpID =
std::string(linkTemplate.id)
+ "_DOWN";
+ tmpID =
linkTemplate.id
+ "_DOWN";
link = surf::LinkImpl::byName(tmpID.c_str());
*linkdown = link; // check link ?
} else {
link = surf::LinkImpl::byName(tmpID.c_str());
*linkdown = link; // check link ?
} else {
@@
-164,7
+161,6
@@
void DragonflyZone::createLink(char* id, int numlinks, surf::LinkImpl** linkup,
void DragonflyZone::generateLinks()
{
static int uniqueId = 0;
void DragonflyZone::generateLinks()
{
static int uniqueId = 0;
- char* id = nullptr;
surf::LinkImpl* linkup;
surf::LinkImpl* linkdown;
surf::LinkImpl* linkup;
surf::LinkImpl* linkdown;
@@
-184,8
+180,10
@@
void DragonflyZone::generateLinks()
static_cast<surf::LinkImpl**>(xbt_malloc0(this->numChassisPerGroup_ * sizeof(surf::LinkImpl*)));
for (unsigned int j = 0; j < numLinksperLink_ * this->numNodesPerBlade_; j += numLinksperLink_) {
static_cast<surf::LinkImpl**>(xbt_malloc0(this->numChassisPerGroup_ * sizeof(surf::LinkImpl*)));
for (unsigned int j = 0; j < numLinksperLink_ * this->numNodesPerBlade_; j += numLinksperLink_) {
- id = bprintf("local_link_from_router_%d_to_node_%d_%d", i, j / numLinksperLink_, uniqueId);
+ std::string id = "local_link_from_router_"+ std::to_string(i) + "_to_node_" +
+ std::to_string(j / numLinksperLink_) + "_" + std::to_string(uniqueId);
this->createLink(id, 1, &linkup, &linkdown);
this->createLink(id, 1, &linkup, &linkdown);
+
if (this->cluster_->sharing_policy == SURF_LINK_FULLDUPLEX) {
this->routers_[i]->myNodes_[j] = linkup;
this->routers_[i]->myNodes_[j + 1] = linkdown;
if (this->cluster_->sharing_policy == SURF_LINK_FULLDUPLEX) {
this->routers_[i]->myNodes_[j] = linkup;
this->routers_[i]->myNodes_[j + 1] = linkdown;
@@
-200,8
+198,10
@@
void DragonflyZone::generateLinks()
for (unsigned int i = 0; i < this->numGroups_ * this->numChassisPerGroup_; i++) {
for (unsigned int j = 0; j < this->numBladesPerChassis_; j++) {
for (unsigned int k = j + 1; k < this->numBladesPerChassis_; k++) {
for (unsigned int i = 0; i < this->numGroups_ * this->numChassisPerGroup_; i++) {
for (unsigned int j = 0; j < this->numBladesPerChassis_; j++) {
for (unsigned int k = j + 1; k < this->numBladesPerChassis_; k++) {
- id = bprintf("green_link_in_chassis_%d_between_routers_%d_and_%d_%d", i % numChassisPerGroup_, j, k, uniqueId);
+ std::string id = "green_link_in_chassis_" + std::to_string(i % numChassisPerGroup_) +"_between_routers_" +
+ std::to_string(j) + "_and_" + std::to_string(k) + "_" + std::to_string(uniqueId);
this->createLink(id, this->numLinksGreen_, &linkup, &linkdown);
this->createLink(id, this->numLinksGreen_, &linkup, &linkdown);
+
this->routers_[i * numBladesPerChassis_ + j]->greenLinks_[k] = linkup;
this->routers_[i * numBladesPerChassis_ + k]->greenLinks_[j] = linkdown;
uniqueId++;
this->routers_[i * numBladesPerChassis_ + j]->greenLinks_[k] = linkup;
this->routers_[i * numBladesPerChassis_ + k]->greenLinks_[j] = linkdown;
uniqueId++;
@@
-214,8
+214,10
@@
void DragonflyZone::generateLinks()
for (unsigned int j = 0; j < this->numChassisPerGroup_; j++) {
for (unsigned int k = j + 1; k < this->numChassisPerGroup_; k++) {
for (unsigned int l = 0; l < this->numBladesPerChassis_; l++) {
for (unsigned int j = 0; j < this->numChassisPerGroup_; j++) {
for (unsigned int k = j + 1; k < this->numChassisPerGroup_; k++) {
for (unsigned int l = 0; l < this->numBladesPerChassis_; l++) {
- id = bprintf("black_link_in_group_%d_between_chassis_%d_and_%d_blade_%d_%d", i, j, k, l, uniqueId);
+ std::string id = "black_link_in_group_" + std::to_string(i) + "_between_chassis_" + std::to_string(j) +
+ "_and_" + std::to_string(k) +"_blade_" + std::to_string(l) + "_" + std::to_string(uniqueId);
this->createLink(id, this->numLinksBlack_, &linkup, &linkdown);
this->createLink(id, this->numLinksBlack_, &linkup, &linkdown);
+
this->routers_[i * numBladesPerChassis_ * numChassisPerGroup_ + j * numBladesPerChassis_ + l]
->blackLinks_[k] = linkup;
this->routers_[i * numBladesPerChassis_ * numChassisPerGroup_ + k * numBladesPerChassis_ + l]
this->routers_[i * numBladesPerChassis_ * numChassisPerGroup_ + j * numBladesPerChassis_ + l]
->blackLinks_[k] = linkup;
this->routers_[i * numBladesPerChassis_ * numChassisPerGroup_ + k * numBladesPerChassis_ + l]
@@
-235,8
+237,10
@@
void DragonflyZone::generateLinks()
unsigned int routernumj = j * numBladesPerChassis_ * numChassisPerGroup_ + i;
this->routers_[routernumi]->blueLinks_ = static_cast<surf::LinkImpl**>(xbt_malloc0(sizeof(surf::LinkImpl*)));
this->routers_[routernumj]->blueLinks_ = static_cast<surf::LinkImpl**>(xbt_malloc0(sizeof(surf::LinkImpl*)));
unsigned int routernumj = j * numBladesPerChassis_ * numChassisPerGroup_ + i;
this->routers_[routernumi]->blueLinks_ = static_cast<surf::LinkImpl**>(xbt_malloc0(sizeof(surf::LinkImpl*)));
this->routers_[routernumj]->blueLinks_ = static_cast<surf::LinkImpl**>(xbt_malloc0(sizeof(surf::LinkImpl*)));
- id = bprintf("blue_link_between_group_%d_and_%d_routers_%d_and_%d_%d", i, j, routernumi, routernumj, uniqueId);
+ std::string id = "blue_link_between_group_"+ std::to_string(i) +"_and_" + std::to_string(j) +"_routers_" +
+ std::to_string(routernumi) + "_and_" + std::to_string(routernumj) + "_" + std::to_string(uniqueId);
this->createLink(id, this->numLinksBlue_, &linkup, &linkdown);
this->createLink(id, this->numLinksBlue_, &linkup, &linkdown);
+
this->routers_[routernumi]->blueLinks_[0] = linkup;
this->routers_[routernumj]->blueLinks_[0] = linkdown;
uniqueId++;
this->routers_[routernumi]->blueLinks_[0] = linkup;
this->routers_[routernumj]->blueLinks_[0] = linkdown;
uniqueId++;
@@
-264,8
+268,10
@@
void DragonflyZone::getLocalRoute(NetPoint* src, NetPoint* dst, sg_platf_route_c
return;
}
return;
}
- unsigned int* myCoords = rankId_to_coords(src->id());
- unsigned int* targetCoords = rankId_to_coords(dst->id());
+ unsigned int myCoords[4];
+ rankId_to_coords(src->id(), &myCoords);
+ unsigned int targetCoords[4];
+ rankId_to_coords(dst->id(), &targetCoords);
XBT_DEBUG("src : %u group, %u chassis, %u blade, %u node", myCoords[0], myCoords[1], myCoords[2], myCoords[3]);
XBT_DEBUG("dst : %u group, %u chassis, %u blade, %u node", targetCoords[0], targetCoords[1], targetCoords[2],
targetCoords[3]);
XBT_DEBUG("src : %u group, %u chassis, %u blade, %u node", myCoords[0], myCoords[1], myCoords[2], myCoords[3]);
XBT_DEBUG("dst : %u group, %u chassis, %u blade, %u node", targetCoords[0], targetCoords[1], targetCoords[2],
targetCoords[3]);
@@
-342,9
+348,6
@@
void DragonflyZone::getLocalRoute(NetPoint* src, NetPoint* dst, sg_platf_route_c
route->link_list->push_back(targetRouter->myNodes_[targetCoords[3] * numLinksperLink_ + numLinksperLink_ - 1]);
if (latency)
*latency += targetRouter->myNodes_[targetCoords[3] * numLinksperLink_ + numLinksperLink_ - 1]->latency();
route->link_list->push_back(targetRouter->myNodes_[targetCoords[3] * numLinksperLink_ + numLinksperLink_ - 1]);
if (latency)
*latency += targetRouter->myNodes_[targetCoords[3] * numLinksperLink_ + numLinksperLink_ - 1]->latency();
-
- xbt_free(myCoords);
- xbt_free(targetCoords);
}
}
}
}
}
}